From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2AFD0A0093; Fri, 29 Apr 2022 08:26:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F34C4410E3; Fri, 29 Apr 2022 08:26:04 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 5FEAC40E50 for ; Fri, 29 Apr 2022 08:26:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651213563; x=1682749563; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=qY+U9w3IAcZJFvomOVSFJVE3Jfpb5XzibFvHvjQQFdc=; b=RIebdSQTmONwPKeREcyks903Tp5wYpSJExErFsifS0C8hgkIIAAWHcYg dM+/N6zSey+aESpSCFoc2BF/wjLA/OZWfGStG4wOYpAp/1rPe4voUCsQy UN5QOoKTjrBw35bbak+46uLOrClh69JZHWWdg1281+mJSnco6QAxWPVSQ D71YQU47bvDr5siQZ6f0+6qVbpHxrJKmnB77soylu7oiQi0LRuOD8Z+Iq rauuu7+AJHeHE+0nhFUJAD66COzwV6tGTcw5TA11k0Wx+bgSFzwH0sN9L 4OkYclXKMCRDipf824stiB3jBzeEDL+5RpXlgb8s2fyeF68te3Cs4SH1I g==; X-IronPort-AV: E=McAfee;i="6400,9594,10331"; a="248477545" X-IronPort-AV: E=Sophos;i="5.91,297,1647327600"; d="scan'208";a="248477545" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2022 23:26:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,297,1647327600"; d="scan'208";a="565994896" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga007.fm.intel.com with ESMTP; 28 Apr 2022 23:26:01 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 28 Apr 2022 23:26:01 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 28 Apr 2022 23:26:00 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 28 Apr 2022 23:26:00 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 28 Apr 2022 23:26:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jjp7ueJdK7vnc+JLQM00UnQDqzCCm0dVMuTElkcUCrykQaBlKIxD23aqhQ6QD+SKWyX/y4UV4i0zE1+7jaN3On6DuXGQ/WmoG7wzYouRDzCkl36H4paiaj/N9LzEtbt28Z1tcN2Ks97G+pK9EZ9kgb94H9Fh6G47IrBiqtu2oyxz8aN5mdAu9jnKPpJQzGihmlY3QeQWpoo/gi+ucWIairXy62JqjSigWs2Ec/9wQ78il3RXeUDTy+bEwvj9XEanpSdpP00lPiOUC6OBnWfUXWI44HYIlOqhMd8oDlMU5BwjGxq49v1TtF0gk9WX8sgwrH+ymV9m6lPJvFfruus1xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+dQT85dXxVtM0LXcaKoOeasRb6yUCbvvhqzu0KxYhww=; b=RkjxowioCKTWRekAAF13+wu7wlMSJjuWgeOy/kgqK40qUmdqJnth6kx2mD2AaCVocNVOz4SKNrQuM8xhw+qOoRTXslNNT0QhRi9KHLhhODf20oWRSXS/rEoQ8kAwu6UgkF12aLVezO7B++qasbbVz342nXPqIF0/SaqXvNLl67YioXsrOoBW/lMQvDM628vEHwHMe1jplohWqKvFmN2LOncpCsXckBXbl2RN7+XF3ls+dSmxb+/5pmymf7PXqjmWnqX/MB+zaBoYXGiXOmS4ad+MAg3VOL+8MLQtWRlWtO/aYjitqHYWfLbFtskR/txD8eBO33pDhONjhhs5smr9Dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by MN2PR11MB4351.namprd11.prod.outlook.com (2603:10b6:208:193::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 29 Apr 2022 06:25:59 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::fc0f:1644:98b5:be1]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::fc0f:1644:98b5:be1%5]) with mapi id 15.20.5206.014; Fri, 29 Apr 2022 06:25:59 +0000 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , "dev@dpdk.org" CC: "Zhang, Roy Fan" Subject: RE: [EXT] [PATCH v4 0/3] cryptodev: move dh type from xform to dh op Thread-Topic: [EXT] [PATCH v4 0/3] cryptodev: move dh type from xform to dh op Thread-Index: AQHYWgqZw0b+PZ1W/0yjhl483f3Ty60D6uoAgAKB3yA= Date: Fri, 29 Apr 2022 06:25:58 +0000 Message-ID: References: <20220427074400.2091-1-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7da87634-b745-4bbd-af15-08da29a92011 x-ms-traffictypediagnostic: MN2PR11MB4351:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fne0ndviunH+A0ZuzCMC0hICG9rHWwhWo2uhkIFhhSXrQe/0XdDTE6ofZ3nonMveaX1o8Tm0nqianE9QD6djP1hmI0tQCz7hgj2LZtftVXkO+AJb30iSDZLeyR0GokmJC740hgCeBCCwlkhpM5l81mrQLXmealbB13JDFBQX2xpvUG2ExIvRNazQ2eMG0El5kAJ/eu4Yvx9P7tlPvOmdOReULsbwmHvDf6cOuW5K2qO04NbU6Vnk7poLVLt4/MdQB+DUiWB5l96CASPHnh9t168i4RpsHi7iTSFoZCvlxfQOa3YBVDHIPNIqaKS9PzugOd7dYUkt/QeGtXmaJ/2Dnlawjb1u2cB1Hjny+KmgVJVnz5vgbPkeFv1cCEJNQU2zqLRSJdbDbEgXQS4mIFWjSMoS5bwwd1anfaa9/NTR9WSEQaen/E+t8HGVnmkElNVMlXW2/thtK/TTATBuEhxMESPyDB1QVxJKnIole77ChbsU86m+38v8DSB5MVPnQiLrSbVt5AfMsPSheMAf9dvO1t3ku6yaE9TV1iBIrb11Dfpn3L65IlsZExXR4FWjqFtss6Ph0pkx/XpE/u9iyQDVCcOhQuovsHg18F3RGtbSoXvdN8tG/EedEsC9igSdtnpglmqE4mDv6luv/WIttPooruoCqNUZ+nyBN0mCNfUU9MKtrQlCuCBhBDnqQKA6Ad2nlCLraWNx+NtXIUxGytyA4FVcx2W2ImxamtQEzp3wgCyapW+9Wt8DwilkOY9cNJzyfh+Ai6Aps4UOKLl6ReGjOjeConYqCtCLjrVBvRLF4qA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2906002)(966005)(55016003)(38100700002)(38070700005)(122000001)(86362001)(5660300002)(26005)(83380400001)(9686003)(33656002)(53546011)(71200400001)(8936002)(52536014)(508600001)(82960400001)(7696005)(6506007)(76116006)(316002)(186003)(66446008)(66946007)(4326008)(66556008)(66476007)(8676002)(64756008)(110136005)(107886003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?en8RoRVJsDdNy78yWXQcpViVkdVJpIKHZpHI7XsE3RRG8QO5B5wc68vXLT+L?= =?us-ascii?Q?TTSJLss1W5yAs2w0RQjNYDJuijdMbiciMMAx8j/ibLT3KokGsTv6Nk2+BhAp?= =?us-ascii?Q?hQrFKPOfH/2cpjM5L8Io6Ope6ej6Sa2EmPh57Ji7aDzCbuWkRvsSA4VqsUjW?= =?us-ascii?Q?Qt1yknS1zZudcVvV+/q4DP3fF4TuAmQeNJqgjgO3g+TQX1AdS8qEgPxF/ckv?= =?us-ascii?Q?K61I/gFamC2VglHY/0Qqb8iHuqNf8EpM3fzlk9XQfj/IMbfg1V4SePl5Isc0?= =?us-ascii?Q?c9gnedAWDfu2hTStUi1mvT/OQ0yYOnKp9n9NtCjH16ncc8gTvMIJtJhGsYYv?= =?us-ascii?Q?gJuqmitlWAR/kQoApNaL9YSJfJW1UQnzamXGMeZxfeZYGyJxcH/5p8SpaGzF?= =?us-ascii?Q?dXcVzWyJ8e+nTlkSIb75RRDx1+llpxk1VHv5qumGk8KXd4+mXK0jIY5f0b/z?= =?us-ascii?Q?6RnCtzjSkflU4qk2qdUmHeA1bNbfkN4LlvXotxYmomv6gflo1zFsuPuVJJ+3?= =?us-ascii?Q?ZA2jgKbqnJK9lhiErfcfhy4b5WgjqeiocVaT9qu8g3W2yRoYBZ/3mzcIYaLq?= =?us-ascii?Q?e/XU8yW/h2vbeQmFc1kQeHqgV7+iCp51Iz2TNa1fJsDOIYOzmoA8hyWo62aG?= =?us-ascii?Q?SOqlYIUz5248xgkcEzoN8Mnjh98XzNWUtTr4aVvlzoDIwDimNTZ74cMSKnLD?= =?us-ascii?Q?BNPCSKtEwlGKN5jjYWifBuMaK2OyBqf5XpaKeUJOPis6n65DMEyfTCBrROsZ?= =?us-ascii?Q?+pf+DX7Xb4MaRgT0FfJBlvHAMbFL1u+Gcz2HyyFToy8hHqHp+1PK0L0vTWhL?= =?us-ascii?Q?sr7zzMMSCuXIx8i3Ho/LuDOMBo2PigWhBYsPwxR4tJC3fxucgdRg7bHP/aHJ?= =?us-ascii?Q?wxiJZ8smlCjVOuTuSvPw+9parLuOn7I8HV+udNe9GhM2MaSxi1ks5zpijuxi?= =?us-ascii?Q?FzPgkguCi0mcbtvaKOR4vI0LWkIAxSMxRsP2LMQX6gzH812XuU3ZYUoJwlwa?= =?us-ascii?Q?gqaPGsWyoWuMeaVBqF6GuWW1r/YZu9cNyLU2RoQQnV4cZ/b4q5iK9LXxxdAA?= =?us-ascii?Q?UrCzYUKmHjFzI67MNeQPR6qVTrKj/tKS2tJqVjxSmyzjy14IQu0pJcnDcRLq?= =?us-ascii?Q?MEL21Ez9rRylA5VIyVcu82Z87ZMIhGXOoQERL+2tr8P7yFVPvsn57jUCFheh?= =?us-ascii?Q?nVz97Km9L/3aO8i2P6NJzZ361EOtWfRVofesLRQEVEglr+KlSBSr8uo5UonY?= =?us-ascii?Q?RHTfqEiRh63YSDCJiZVoe/SaoXnaSrSbxp3/uL+XJKFFkfzCmpX57+GA78is?= =?us-ascii?Q?gxlRINsbpa7AjkUFx0of8knNYLd6BY+5ws9xMgsxcqF8Eq/Az+Df7aLHje/G?= =?us-ascii?Q?kba8w0NEOpnVgzVMBNOO4h+zK0VDLEuk1zhDJzU03zffQprsT4RFYXLxeVjv?= =?us-ascii?Q?ZPUuIHN8V1r4tebuQTs54EyK3tNd1Oqv4J9QKwfJJiLk2IXkfO8V1o1VJhmt?= =?us-ascii?Q?69x72FZAqeA1zTciTR7IMANQQcozui4h0aevQtJU5c21UmnvpiBjdgttDnA9?= =?us-ascii?Q?oB4/ine4oQU8xmp9GuNs/f9SstY0j6mW2uQ+cjDxvF02Rx4/Yj38/UnwGZBP?= =?us-ascii?Q?wr2ccH8KdLk61P5aqjOy7eWiPzUA5AeKaecDtUMyPN75BsHgrXU+qTBxEOgq?= =?us-ascii?Q?g+f6XkoahGBivMmh6RmDt1b/9cA7MsPiJwuZ8UMqMNj27aV/o6SHub/GwHV/?= =?us-ascii?Q?E93MlTXufXiw0Q+tid4NUJpCynj13PQ=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7da87634-b745-4bbd-af15-08da29a92011 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2022 06:25:58.9963 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: k/eWVCA/K0rGINCI+yGCDQpKqJB4ExPKan54MaI83U6j3F0KAyME21oXxf5Azjh3Y5C4u9qdFRHhvSd4PdLw921PChNSK8Qv+BHd00/NzdY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4351 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Akhil Goyal > Sent: Wednesday, April 27, 2022 5:58 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v4 0/3] cryptodev: move dh type from xform to d= h op >=20 > Hi Arek, > > Operation type (PUBLIC_KEY_GENERATION, SHARED_SECRET) should be free > > to choose for any operation. One xform/session should be enough to > > perform both DH operations, if op_type would be xform member, session > > would have to be to be created twice for the same group. Similar > > problem would be observed in sessionless case. > > Additionally, it will help extend DH to support Elliptic Curves. > > > rte_crypto_asym_op_type is moved to rte_crypto_dh_op_param. > But why not move to rte_crypto_asym_op? I see that in other ops also, Op_= type > is there, we can move that out. Right? >=20 Yes, we could. Although some of the operations do not use op type=20 (POINT_MULT, MODEX) so we would have to extend asym_op_type to contain RTE_CRYPTO_ASYM_OP_DEFAULT /**< Default operation */. Another proposal was to split op type to: CRYPTO and KEY_EXCHANGE_OP like I described in here: https://patchwork.dpdk.org/project/dpdk/patch/20220407134248.20178-1-arkadi= uszx.kusztal@intel.com/ then op stays in algorithm_op. > Also, I see one more potential issue. > There is a union of various ops in rte_crypto_asym_op, but how will User > identify which one to use. There should be a union to identify which Stru= ct to > choose from. Could you show how this union would look like? Normally PMD will reject operations that are incorrectly setup, for example= DH_op + ECDSA_xform or incorrect op type like ENCRYPT. >=20 >=20 > > v4: > > - changed op_type coment > > - added openssl fix > > > > Arek Kusztal (3): > > cryptodev: move dh type from xform to dh op > > crypto/openssl: move dh type from xform to dh op > > test/crypto: move dh type from xform to dh op > > > > app/test/test_cryptodev_asym.c | 11 +++--- > > drivers/crypto/openssl/rte_openssl_pmd.c | 54 ++------------------= -------- > > drivers/crypto/openssl/rte_openssl_pmd_ops.c | 26 -------------- > > lib/cryptodev/rte_crypto_asym.h | 14 ++++---- > > 4 files changed, 16 insertions(+), 89 deletions(-) > > > > -- > > 2.13.6