From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADE42A050A; Sat, 7 May 2022 09:29:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5598D4068A; Sat, 7 May 2022 09:29:24 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id D3BB640395; Sat, 7 May 2022 09:29:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651908563; x=1683444563; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=O1bnaAO5foYJFEEpQKAGNibH0We7hjEsfh+ErJQRKBM=; b=fPsMsm/Et335aisHOpbCYNXmg8ILDYHhUttkZTScgkG+pjJVXE4bxX84 Y2icXKIVUK0P0VMW2EICz63V4NHRWoWWXBEbvkJRfLtTafCFKnSpNYRQd yPMbnpIcbb+147Mf1WLSl/cK+VcZdun+y/rgQUgBtl4F50dfVHGMfQwhj 0JbHP6bORdp80qVrVC2YQ3XFIOe14YrlYppvQgE3EI9+FRdWbjKu01ESH H/88B2YtOyAEpQ6V7jWn9vlFBetp3OvyXMxrdGmnhDc3T6oBOElQmHgVU P2iF2YEBTpHfULfAiz0dIEmOtG6fEn7Der6gXw4vaGDGGRZfjn83wBbTe w==; X-IronPort-AV: E=McAfee;i="6400,9594,10339"; a="248578202" X-IronPort-AV: E=Sophos;i="5.91,206,1647327600"; d="scan'208";a="248578202" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2022 00:29:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,206,1647327600"; d="scan'208";a="665822155" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga002.fm.intel.com with ESMTP; 07 May 2022 00:29:21 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sat, 7 May 2022 00:29:21 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sat, 7 May 2022 00:29:21 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sat, 7 May 2022 00:29:20 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sat, 7 May 2022 00:29:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CII3XKDQpgbJh/IfnGELsjU6mcnNZfU3Eb5AMJlvatN91wF3bjttsvZ28U6bfwx/Hx0vkuV2Oy0fhRR6XCniZsjXqsq0LKx61SE/It2rst/+SpdWlJAmFhvhYlo/kgw48tFOpS94O252hyJUvNCfRnFXzM0/zVl+7rwiEJ689RX3sFgBuwR13PU9gpirkczk2yEzGEGiEBQNt6wFJXnUMBWcHJGgAiQBVUnYnm0EJx//rJYsJEU++rumal7qg3DExwpgZ7o3S8ojtFIe6bTKNkEWkQQzOrJU8yOP7pC6VIkczZBcRwekw2tb9nRS9QoqCbYgYUB8voAXEYmHR0R/sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j5xRhKtjo9oJWDUyqiHz4WKB/5x8BPNF+oOgu10lvmU=; b=T65AxUOske2kqgogx0qgrN610PepwGpeEeZdc78R9LEeI0TMev8lpeeMvAmZYUDbXFNy7KxWhMDs4YAqBhG7vm0iWFEGNr1ftOlAr6ezV3cggYZ9qsTi0+MxeHKiCY7hJHsE1PG7rZzBGDLJW4N6lIx1xC8REO8kCwqDa8wTwMhUB3j3KhthBo9Ma1oqYIg+dGhGZaM/RgIhJpx+caVi4QcWjBAkkXWm1wuNq5sZI8sl+mnuXEwlLgWLxagPRamSu2MRgYDi/9HJFZsT1RmyuBqqGwDZfOhMssuxRU8Y6MSAN27h5QOxxIXvxlV+hbOyBR8v7Orvs6K3vg5DcEjr5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5109.namprd11.prod.outlook.com (2603:10b6:510:3e::11) by DS7PR11MB6200.namprd11.prod.outlook.com (2603:10b6:8:98::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Sat, 7 May 2022 07:29:19 +0000 Received: from PH0PR11MB5109.namprd11.prod.outlook.com ([fe80::e8d0:1b87:aa9d:339e]) by PH0PR11MB5109.namprd11.prod.outlook.com ([fe80::e8d0:1b87:aa9d:339e%7]) with mapi id 15.20.5206.027; Sat, 7 May 2022 07:29:19 +0000 From: "Zhang, Peng1X" To: "Zhang, Qi Z" , "Yang, Qiming" , "Zhou, YidingX" , "dev@dpdk.org" CC: "stable@dpdk.org" Subject: RE: [PATCH] net/ice: Modify DCF state checking mechanism and error code Thread-Topic: [PATCH] net/ice: Modify DCF state checking mechanism and error code Thread-Index: AQHYYFQnQPcXwZiQ6U6D30twly0QCa0TAmiAgAABy2A= Date: Sat, 7 May 2022 07:29:19 +0000 Message-ID: References: <20220505153932.401749-1-peng1x.zhang@intel.com> <81e3dc069d384b63bb4a05c843ae1675@intel.com> In-Reply-To: <81e3dc069d384b63bb4a05c843ae1675@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 73955bff-7724-4aeb-c964-08da2ffb4c65 x-ms-traffictypediagnostic: DS7PR11MB6200:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UK+YAv0e+jnxpdAyrbATjQwtr2eFGmcKBgcOfFNinQT+FRfudAUdyxSpLG/44mmL5yTxnvpnnKzFbshpG2sB2v5i1oe8ZYChU3vyM7EB9uZSrV/hidA/GWLeV6OI5GGJfc1gmH/iQWgoprGArZE6b1wrGvz+UmlhMCi3Gk80YLN/RbGyKuRRegWfy/T86oqwL4ibYqt4ny1W+ATaomkPEYHinnyQz/Z8DC4wO4jJFXa5ymNHIUD91hzy9MTC3WlXTF8ec13arKt41BeL0hC6TtWhOp8kFu3ol+/2SMlyZNIlTjUdemDydktr93u0UqGjfhNLgEm67gTR17/3/m0nuGBuO5DTTbATT8/GS/I7c/Qu1V8hTFifiDj7Llf2fpl7I26oAU8joFq5/xMqBOxTiGc1aMHxTpakZg5xO65bVr03Wxt3L9VmVFp157q7m21Wk9vQCjpyghojoF2Sm8JO4GGAVxAt+h0MDXoVoy6AJZKiRvgoTWb9534lOccDMassTVeqOH2aAAHN5MSwSaNo+IYJTwcdIs7JmSSr/p6xbFe+8f3ZjjjthdrXgTWdXoAkOxV2Oo1E97sPaSXgZqWWde4ikJBKhc7qvjTlC/772ytA0EO4EIAjm5ok9J8tCLT8KpHnUWM/qLzrsZIdyhkds21rg7yFKV8g2+lznx6fRYhQ8F+WvWmao1Eo/iLVAUrGIKeR3UyPjEF39x7SnXRkyg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5109.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(450100002)(76116006)(186003)(66946007)(66476007)(66446008)(8936002)(66556008)(64756008)(33656002)(52536014)(4326008)(5660300002)(9686003)(83380400001)(26005)(8676002)(38100700002)(508600001)(86362001)(6506007)(110136005)(53546011)(71200400001)(55016003)(7696005)(38070700005)(2906002)(82960400001)(122000001)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lrVYJ9MdoYQk2nDucFkhXuX7g1IDlUMroT4xy/rldGu8BAW/KEt110tU0iL4?= =?us-ascii?Q?f5PTtRI3v4uRALu51vCBFFQsxg3mZZbyLNSHl7F3xq5nymaar+//B5ptgZBA?= =?us-ascii?Q?e51JAMqLCjXnaB+CFGCFl2L4nQDlcM2J6R6+4YNe/gazr4fs/8NWZ2pWTqtA?= =?us-ascii?Q?aw8kRCQBGKQ3fGQbxKRHKHZK3CheEwscmvr8jkx/FRfM6G8j2YGMftZcNNqL?= =?us-ascii?Q?kIcI4enMbQsmYmviFenPpRefxdccQ5G4lMTgfUCNxpOJ+JRYH9Wli5a+5CSs?= =?us-ascii?Q?2pm6pQeJdYIZyElxHy8rOpMdbcrZqCe6ni34c7bDleP79MDyvdqWxqTjX6B2?= =?us-ascii?Q?ARNkF/EZScmZDAQWg6XIeiAVMHcwT9pI9H7u94slubLSyhrOhrW4ACrY4XbE?= =?us-ascii?Q?EumwJSqAWx14CrKFofZo3jim5BBiWQjFhoC2uaHJo0JqfBRzoKFNm9VvmbJQ?= =?us-ascii?Q?w7AFEs5KJqbusBh4R2Xj3KWImMoCm/5ybHQmpHK+gqa82rbvZ9ghJUnbm3sP?= =?us-ascii?Q?5eQNS7o6Np+N2lOheCxV9VtsKVk33/jXrA1hQmkxstvEc8SqtykoQaxc2y8B?= =?us-ascii?Q?201zM838PvAnInqK8THyEyIeCJnWtHRkFRdFQsRgEZOXO0+xptA9XdE2kFlY?= =?us-ascii?Q?GmM/kXPYlclp0rDvs4J+RHlfhBCoswmuuZQYzfINgWBveg9oT7hwJoK1QDrm?= =?us-ascii?Q?oKqfIPBQkE170G4oqA8hrqQEhkO4gaem0OhJMXAwGoISq1mTWoVI1VcGwReA?= =?us-ascii?Q?BeJLGeDHmpsU+3fVWZHRQeBEy4Ju5W38dgGZ5XSV7JstbYXdOwB9YS7AKEao?= =?us-ascii?Q?TiY+ClFtM7kKA5DvO1PsY4kUgZqc4VwDS1dnLaPHfyDMW2vZhcP/XAgrl73o?= =?us-ascii?Q?TZmhlFE58v2dfOjUIPgOW5l814QF1t+Por/PDeLJt8t6C1F5zLuZobicM5Ib?= =?us-ascii?Q?Tnp+RISzck7gx6k2A7iHRW7Nx7M7BUbNhR04NiYSDAJS+hvNCrlNuVrGEWym?= =?us-ascii?Q?ydABNG5kLiyvOirKdZ0AQcDqkGvWYdkXC0i9ldncf5eQzBX0ikjCa60p3jqq?= =?us-ascii?Q?4MLDYezdGXfeacLuV7zMlb4FnF/EEWd3FsChsibNQDagZOokVh6VZMkFTkhX?= =?us-ascii?Q?9iLA2fphis8RFq4sce4PIVI7CS0FcCB6un2OWzJQXLonRfqEr1FxgYPSgbaF?= =?us-ascii?Q?/xGMehivWzXdBtU+fLogzNZQgPADX9euLFJ316EgaZ19oMv+D5vg1ylYBxxN?= =?us-ascii?Q?ptx/1HcN8Rczn+k6lo8g6sFOFHXmt9KJ/iEMp4/WGgD/ni0Qz5lyDw296O42?= =?us-ascii?Q?2910OnbFM14dEuZhyIl2swCDiUWKAEaNV9H5bkzsuwQLcpAKLQryM0AXzXX2?= =?us-ascii?Q?x8SFglsNwLUe9Wnwp4KwGGf90Zcunt89W+FTP5pz+OStX55L9yPD+ZipqKvL?= =?us-ascii?Q?15rbKUuR3ImktBfyn3EoSZ6fRJQh2bWGBpxuu4/YhDWfxZf0UYPlfaNLe122?= =?us-ascii?Q?rqcnjcexfknAo7smLJzHmfs3+bt1+eh0utDyEF7MKVuGXdi5GN54RTrAy/y8?= =?us-ascii?Q?/D7iK7oqjGXqxF/QDgdOyl0dnaMmgbsMUjDB2+t6u9zk1tbgaJHFnMwu9wBu?= =?us-ascii?Q?GZtQfFG/x/1+pWGqrLqtJJyNVafkUgYoYFgnBqjPSecRYaV7BXNmzP+U3kSK?= =?us-ascii?Q?rVLxgLifgLZYb5fVBWZ5lXouC0UssfOL+okUe4aY1LUwAA6CB2SOZ4P1RiZM?= =?us-ascii?Q?qxq4kMflbg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5109.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73955bff-7724-4aeb-c964-08da2ffb4c65 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2022 07:29:19.0757 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SmWR0MRMleVhfZUl002K8WZshOLL8behRoLTEZPhTJ05KqT7Q8thCH2qf/NPtkQ94mH4D6Aq8s1fk15fbo+KXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6200 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Qi, The Aim of change error code from EAGAIN to EBUSY is to mention user as = reporter wished ' something more along the lines of device being busy '.=20 Br, Peng > -----Original Message----- > From: Zhang, Qi Z > Sent: Saturday, May 7, 2022 3:10 PM > To: Zhang, Peng1X ; Yang, Qiming > ; Zhou, YidingX ; > dev@dpdk.org > Cc: stable@dpdk.org > Subject: RE: [PATCH] net/ice: Modify DCF state checking mechanism and err= or > code >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Peng1X > > Sent: Thursday, May 5, 2022 11:40 PM > > To: Yang, Qiming ; Zhang, Qi Z > > ; Zhou, YidingX ; > > dev@dpdk.org > > Cc: Zhang, Peng1X ; stable@dpdk.org > > Subject: [PATCH] net/ice: Modify DCF state checking mechanism and > > error code > > > > From: Peng Zhang > > > > Add DCF state checking mechanism which will conduct whether reset is > > done.And modify error code to avoid misleading. > > > > Fixes: b71573ec2fc2 ("net/ice: retry getting VF VSI map after > > failure") > > Cc: stable@dpdk.org > > > > Signed-off-by: Peng Zhang > > --- > > drivers/net/ice/ice_dcf.c | 3 ++- > > drivers/net/ice/ice_switch_filter.c | 2 +- > > 2 files changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c > > index > > 7f0c074b01..3808272ea3 100644 > > --- a/drivers/net/ice/ice_dcf.c > > +++ b/drivers/net/ice/ice_dcf.c > > @@ -544,7 +544,8 @@ ice_dcf_handle_vsi_update_event(struct ice_dcf_hw > > *hw) > > > > for (;;) { > > if (ice_dcf_get_vf_resource(hw) =3D=3D 0 && > > - ice_dcf_get_vf_vsi_map(hw) >=3D 0) { > > + ice_dcf_get_vf_vsi_map(hw) >=3D 0 && > > + ice_dcf_check_reset_done(hw) =3D=3D 0) { > > err =3D 0; > > break; > > } > > diff --git a/drivers/net/ice/ice_switch_filter.c > > b/drivers/net/ice/ice_switch_filter.c > > index 36c9bffb73..199a981018 100644 > > --- a/drivers/net/ice/ice_switch_filter.c > > +++ b/drivers/net/ice/ice_switch_filter.c > > @@ -434,7 +434,7 @@ ice_switch_create(struct ice_adapter *ad, > > flow->rule =3D filter_conf_ptr; } else { if > > (ice_dcf_adminq_need_retry(ad)) -ret =3D -EAGAIN; > > +ret =3D -EBUSY; >=20 > what's wrong with -EAGAIN? Is it necessary? >=20 > > else > > ret =3D -EINVAL; > > > > -- > > 2.25.1 >=20