From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EA44A00C4; Sun, 10 Jul 2022 08:32:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8FEDA410EA; Sun, 10 Jul 2022 08:32:13 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 8B87A406B4 for ; Fri, 8 Jul 2022 10:56:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657270607; x=1688806607; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=aBOZeXmhto4oY2FA+XD+F2XfXOQQTsrcm6t/maOLx1A=; b=iVgFJ7gW6XEoGL+HQ1yDARM5PeVk38FHe37fbzNVZfQQ+qt59auwSikq 7nCrWOAX+Cef2MJyjKYttfuJgMLDowYV6xwre1I1h4mHfOd6NUjoRZUiM F+1T+k2zzMajE2vlTBnXE//quqh1PRgsqVdBu1iVKZkNsbmVeLfX9DtBM UHp9kzSwLwJZUI0QtCJYhgvdcxu5+SHi71E2xX4FWQFpQUG/rFX4jjJ8q 4i08NmRnshZIYZXPgXCEbJ7Hvh7dYoY0Lgebj2Le09ENVxzQFdeftn/VG 7QxN4hN2Op6n62vqwm+5LPqxdN8UrSyyVSov4fkTVZ9Q2Y+uYf5ypN8bw w==; X-IronPort-AV: E=McAfee;i="6400,9594,10401"; a="309801147" X-IronPort-AV: E=Sophos;i="5.92,255,1650956400"; d="scan'208";a="309801147" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2022 01:56:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,255,1650956400"; d="scan'208";a="920928922" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga005.fm.intel.com with ESMTP; 08 Jul 2022 01:56:46 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 8 Jul 2022 01:56:46 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 8 Jul 2022 01:56:45 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 8 Jul 2022 01:56:45 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 8 Jul 2022 01:56:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JIP3bbrzSdRAp6TMNbu3J+gEvUVs970pOoFmcitPRbCporqisxJK/S9EWFpNdy9ki0Mu9WCe+7WqGClQH3WTQo2DVBnvbvmiMuRU638NQosC6f7+d7gnfibsHDUy/1IHBa5zMlBIMgZNajbVqw5trR5jH1LsB2IuXgx8NVhHhC2AY36X4qWkAjcRK9hkatGK0FPPrMLxB4eCiV4dJFqv1wh+Mks7UVSulMdQUllAFRjd75RKTpIswZNFPC+v9IpxM9coItGEJZt34mHA3YCERa1593G9NCtVGbi/lV5B7Z1kpADmZMTJBoFMlGBz0+5SsL78rdAHK/bUSdmC9u7n5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LXW2DKCwYqP8hQfInNf7Wa0nMa9HyxMVSE9cSf0xq/Q=; b=YYYzshWYvb3Rpb78cDjuUEtdkrOVUyWQH9eLKVmNeNokFWJa6zoT9Ym3qFjUCaBUh/xsorNyNfla+ay5QR2fkunc/P+xxvtuIMmQw3HYetIeD9eyvkYGMhY9Y0WNkflTIOUpHnpz9aQxD+jweAurDYYS00jYJUsVgGZB5xHzCJ1zC6F0aHwuf3BE2Ib63DOlv/aZJn/VaSRYPVNwMXf1z9QwkKPQBhryKb5O1ZmtUoXNthKq4ZHNRJ4nOkCPVbBeQKXkDTP+pDeU7JW1URhFXHGOuQlAkVUR9h9Qg5/RVt3O7ow8sJxwDEZFGr5t8QQHFQQvKiweRJR2kZt3XmbaPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5159.namprd11.prod.outlook.com (2603:10b6:510:3c::20) by DM4PR11MB6190.namprd11.prod.outlook.com (2603:10b6:8:ad::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Fri, 8 Jul 2022 08:56:39 +0000 Received: from PH0PR11MB5159.namprd11.prod.outlook.com ([fe80::c8ca:b1a3:b892:8681]) by PH0PR11MB5159.namprd11.prod.outlook.com ([fe80::c8ca:b1a3:b892:8681%8]) with mapi id 15.20.5395.021; Fri, 8 Jul 2022 08:56:39 +0000 From: "Khan, Hamza" To: Thomas Monjalon CC: "dev@dpdk.org" Subject: RE: [PATCH 1/2] common: add safe version of foreach-list to Linux Thread-Topic: [PATCH 1/2] common: add safe version of foreach-list to Linux Thread-Index: AQHYdaYX98CgyyMAyEuMMYzlJjf6lK1wKdEAgAMfCgCAADYkgIAA5ftw Date: Fri, 8 Jul 2022 08:56:39 +0000 Message-ID: References: <20220601105455.166505-1-hamza.khan@intel.com> <14252746.lhuNh5TYOU@thomas> <3580418.ZkOooBPedc@thomas> In-Reply-To: <3580418.ZkOooBPedc@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4737cbb6-f3e5-4e89-728c-08da60bfc547 x-ms-traffictypediagnostic: DM4PR11MB6190:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8wOXzwI3l9HMhGC07vIjyHTrKQIq+UIhvR03Lbt5AE8jYkSf8skfnCdQ+3rUfY+jWN2ak6IyufSgHiIzri1+nHcT2zJpU15YV1RelQUfWHrbL4PcEvFq8b7y+5+qoKJCid0tJsf+2LWyCu5QHS8SA0HMiYaFNJso31InUg2051sYxyLAE4Pd5FGaT8Qbq0q1771rMce2/4byWXHCLfp9/Tz/Fre7N3r3or3gCoDxb1oCH0AlhDay2bpCOV6zW1cD0PmQXjAKhsdN7MjFwMIyUs8q10PqH2/pdpmQC8MnjQBZQr+fBKhOk+J1fp9nrF6xFy9OiHf7F7ybmEf42aCqhoZfjBnvQeGQ43F9peWOEO3cY8EUNxneHAAd9Q2Ebdt8gpwmu7cr4NrnJY4wEjDhFqf9UGiJtB/jXWymKQQ1R9SsULEso9YJRJ94nhIKWKMe2Nm+Sshl/BFRtva8R3lhf2Ba5zGcbQwJIWcmE8u/wYGr9cjVoZKU7FIDZagTc2zeY9rGMguMm7fMOtBNz0XPiIYb573Re9t9bFWwecOzdV0LwZGNZrqqCmFY5amFefeHE93zkIzlHbn72WoT2gXqM98H84MBhQRWTY/mW5GTcs4pZUlRh/+fs/nyNQn4//nCCC/1tDOyMHZp8s1MaDVgxR+7epjpYc9wZ+KYdrtxT+12rdiF8eJyzs6ExedAXQ3vNhwG56zVaxRa7bzpKrFgv2uy+oyCbEdv53DDVHT56q7wcWUHiSzaWSVS0MsWo0GlKaJnXxATx/IhOeCcLYIMqpmISxLUbTeIcE3aBnuOhLiPsQWatw2R1bfuQ2krwTRc x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5159.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(396003)(376002)(136003)(346002)(366004)(53546011)(66476007)(478600001)(71200400001)(2906002)(52536014)(55016003)(86362001)(6916009)(33656002)(41300700001)(6506007)(66946007)(66556008)(76116006)(26005)(7696005)(316002)(9686003)(64756008)(8676002)(66446008)(4326008)(38100700002)(122000001)(38070700005)(186003)(83380400001)(5660300002)(8936002)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TPyIQtJwyq/8JLVgZsnV2nnI47xRaOSQ413rs0uzkY59tUZk6SDlkr0E/mvr?= =?us-ascii?Q?xKZOKNahp63Rv9PWMMCz/Q7GSPzKmFwwhXRBjKm8R6NFnKFMtrt9hJuVWeB2?= =?us-ascii?Q?mcDVi/u1u8NFgHBOG7vxA7vdaIDVH+MMe8qqSHb1/gOTyVsaREr/O/bwacPo?= =?us-ascii?Q?Ul+nFcbFuuXQYBeHF76kPuqssO9B4JC2dbZ6BxiGgwJgjdGPZInBIMpodtC2?= =?us-ascii?Q?gierJzJT+NfAbbA96OI8g9Vkw+9V0HcZMb6geGbCwfGR7kFRXvfLxmSv52dm?= =?us-ascii?Q?jQVyV5ypDDMeEa1bhlkpp+g1Ao+dG76CnHbWzyO4w4Hui2/HLGxQYyiQW7p3?= =?us-ascii?Q?E2wq2ZEmsk4F8rUTWLN1FHkFqVmQtEhovMksEM7wu89JcO3EoPJZmUcYxwLv?= =?us-ascii?Q?F5d3abgCEhsVmL3T9HhiVkFlPnLQOA1c35oQs95uvSqRpgBu/01z7LrC2bfN?= =?us-ascii?Q?kkTXxF2ljaZlb/npn5IrNKCJLvwqP12ifTLzVN+dv4TCVUSgQYEYuk5sJmMI?= =?us-ascii?Q?XObSg+jqkzyzEmk5+D5tVbV/jHquukTyQBOAwkdeNM2L0QdPD/7cm4dEvNCe?= =?us-ascii?Q?YjYlVxM46V3p635HztHpsZEfQuB/EIcJdzimaHK2Nrc9sytI3Qk6Wy4qT3fA?= =?us-ascii?Q?TNN0YdxS2KiuBRKy7dKkHDT7rzEnYzAfx2h1t8VFzCy+q6q74XPI/+m1pRtI?= =?us-ascii?Q?Hv2ygI0UVO2yQi4+DKrt+543TJ4qi6GxucCu5pXc+x98ylLdvaVOjRNBE9A5?= =?us-ascii?Q?KKbEatHDXiGlZCgPiAGcFRqXD2LxRN95s8Nqa81Mrcat0f9GFzbxeoqYwhzU?= =?us-ascii?Q?kP3+Y61EyVvCyuvUcK5L2QGO3erXA7+2XrKcISFRQoGzguyxNJt7XIlqhtoZ?= =?us-ascii?Q?xWAxG32d09e6xw7D+CR3wkcL9dd7UxRDnB/aRqeT3ywuTpMIwTTkgqLST5I6?= =?us-ascii?Q?kuXc6Wvy3mJPgrTR+qcHQf8JQ7PHWdM+7fZa0UGpxB8AyWVOFz6kbvpyXbhq?= =?us-ascii?Q?Tk9D1LABWG285lJEZGicDeVnXAMjM2vjy3iRygpGadTstnr/Y55NS+BZj03t?= =?us-ascii?Q?1NgdETybqvm29CSMII4VvWAMpa/XPXstxOxcJDg9f7NHJ0pMKpClslElbD0y?= =?us-ascii?Q?UA1DzuQjZPZ1JWjIwmrFDVgo3Qlj9Gf4fs5OHCk9DAFJXw9Ua2ncpPABR9Pj?= =?us-ascii?Q?0mmKH234lwMMn6qHO/GpNHFT7Ia/j1t8H26z9JmBPHpY5D1ehFIIVAzYlypB?= =?us-ascii?Q?0nWvFFhLxbebn2Ta2BeQOCtP3yzCNGWh+PZkscJINuefhk6uu2R91w/WUbDv?= =?us-ascii?Q?4H+GZ9q0NJOnr00nc35xFo4D920TrTQoCav0n/crb3T6Ds5YqFLQBIaJZfs/?= =?us-ascii?Q?/fUQX/c9JBcH9b2b2rh5qLb1NrjduFd/oxnWJjO7zZ58qgprChTJG0RD2d9m?= =?us-ascii?Q?HWlCrSyKVRz66Xf9RmQTHLfRsIBRIC7oSPZnAH0zDZtTrkrESoIjleNSrlVG?= =?us-ascii?Q?zXVcCZ7FjvlRIooI+szBHvdhb6MbgbEwxYviw9uyJzAnNNAp2sTNaVPOiKp1?= =?us-ascii?Q?129pGJt4gTcXgYbtqa4RMJZoGQGiLFW45P8eUOFd?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5159.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4737cbb6-f3e5-4e89-728c-08da60bfc547 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2022 08:56:39.0536 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EaADQqDBwOrf6ZwH0/sNx/+8AEKTDCMkU5TWIP62Rej+lfgcVXCAbmKLXTT/NiLiEpIFtYmWY20qINx9mft6Mw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6190 X-OriginatorOrg: intel.com X-Mailman-Approved-At: Sun, 10 Jul 2022 08:32:11 +0200 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday 7 July 2022 20:10 > To: Khan, Hamza > Cc: dev@dpdk.org > Subject: Re: [PATCH 1/2] common: add safe version of foreach-list to Linu= x >=20 > 07/07/2022 17:59, Khan, Hamza: > > > > > -----Original Message----- > > > From: Thomas Monjalon > > > Sent: Tuesday 5 July 2022 17:16 > > > To: Khan, Hamza > > > Cc: dev@dpdk.org > > > Subject: Re: [PATCH 1/2] common: add safe version of foreach-list to > > > Linux > > > > > > 01/06/2022 12:54, Hamza Khan: > > > > Linux EAL does not have the LIST_FOREACH_SAFE version of the > > > > iterator macros. Add it. > > > > > > > > Signed-off-by: Hamza Khan > > > > --- > > > > lib/eal/linux/include/rte_os.h | 7 +++++++ > > > > 1 file changed, 7 insertions(+) > > > > > > > > diff --git a/lib/eal/linux/include/rte_os.h > > > > b/lib/eal/linux/include/rte_os.h index c72bf5b7e6..00d7714181 > > > > 100644 > > > > --- a/lib/eal/linux/include/rte_os.h > > > > +++ b/lib/eal/linux/include/rte_os.h > > > > @@ -26,6 +26,13 @@ extern "C" { > > > > #define RTE_STAILQ_HEAD(name, type) STAILQ_HEAD(name, type) > > > #define > > > > RTE_STAILQ_ENTRY(type) STAILQ_ENTRY(type) > > > > > > > > +#ifndef LIST_FOREACH_SAFE > > > > +#define LIST_FOREACH_SAFE(var, head, field, tvar) > > > \ > > > > + for ((var) =3D LIST_FIRST((head)); \ > > > > + (var) && ((tvar) =3D LIST_NEXT((var), field), 1); \ > > > > + (var) =3D (tvar)) > > > > +#endif > > > > > > I'm not sure we want to add such thing without a RTE_ prefix. > > > And we should not need LIST_*, we have RTE_TAILQ_*. > > > > > > > > I have sent v2 patch with the aforementioned fix. > > However Is being held until the list moderator can review it for > > approval >=20 > I've unblocked it. > This is blocked because you are not registered in the mailing list, so it= is > considered as spam. >=20 The maintainers will only accept fixes into RC4 if they can be confident in= the patch. So I have edited the Commit Message and created a V3 I registered with the mailing list yesterday but it seems that it is being = held again. Do you have any suggestions on how to avoid this for future patches ? Thanks Hamza