From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE426A0501; Wed, 4 May 2022 04:19:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58AF540694; Wed, 4 May 2022 04:19:23 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 5595F40691 for ; Wed, 4 May 2022 04:19:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651630761; x=1683166761; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=sPpAsYr1Ha+H0/8BRqc62aGN/ujzkwxSd2NCtW0C0Es=; b=Vil+xKS6XlpENnmxAxb/lqNg6qr/MiSRGTuSMinEyUwpd5fQTsaPsdtc t1URLxkAxYeGlgOFTUcZbDofF/AlXjcoKcU1qT883F5U8IFar7lqbmwx+ lUtrQa8M7Ont2+IqjNreld24Z9bRDmnnuydhL3qRYSARNDTFXfFpclyC+ pjkds5+j1COhHoJRLZkqPOH5zbKn6RhXcDZooJ7cEGPF/yG8cxl8eQH6k 0gK1Rwd8/43aaSwS0jSVBqauwMJyrYfDe+qS44sjx2Ku8xbgM0YR3vx2d GW6bZNKlJuyHszmPjS7EXNZxfOaGUNmTwzvu5ChVPPFGIe1/MlApScoq1 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10336"; a="328184408" X-IronPort-AV: E=Sophos;i="5.91,196,1647327600"; d="scan'208";a="328184408" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2022 19:19:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,196,1647327600"; d="scan'208";a="562505089" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga007.jf.intel.com with ESMTP; 03 May 2022 19:19:19 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 3 May 2022 19:19:19 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 3 May 2022 19:19:18 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 3 May 2022 19:19:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TFPMHRXe9CVXHm/oVQEClyBIxdM7eSW6tJz1tHRpyEXJDjP94mu3jHuVzBnXQEVH69EhWXBBDIc7n/9vhz89x0xzBHk1i5dVRgs/nF474ZiotLKpGJ5PyWmqfJgkCharmoWsg+lXNJ8InqMPt33TuVrs/Po32wVzG5eaPvxyh7wd9pURtWsnru7aR5MXTQtrfN8nFHqDgj5+dS1k1CKFAELDd9S+Q2xMPbYrjMWI89iwwTmOpxvOL8HsDdU8S3Rrqd0h9SjVXpLV7KakVPpZK+lGtlJSSJffttVjMHi4y6tCPK0bIVpFEgM1IgIyYogamtZgFV2fK8tcYKrQvRgPUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ljtcMRcQakv6DORzunVhy/WVl6Dcq4zlyXmT+0MTFrY=; b=LVCwL8H/1jUErBymQ/wMRbKiCZscAPFF4SA5Sizuc4KqxOoofNPWU3vsE1/lLCOPnKBToVHpO4+5b0tGhT3yydyeeJjO8AGUidZNgPIw/lvdfUD3GpcqTzbUl3NHXHYdKxlYgmfEMYv2RNdCpFaIDXA60A/+VzJ3HYATpTngJVSrJaMeY95AyICm8xZaN3I7PhQD+PO25l+9ExcjuzRVzzgc5Jv/37d7bj7APJayEqSuJ+WO8qbEtAUcCf76b9IPKu7P+1ymrumRpjo+DSrV5o2i3E2G6GXfsTQjLDypa7/swI6aBkyx8cshDhnUKbnhOIzVUBXqWprb4YK6ZVq7XA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5173.namprd11.prod.outlook.com (2603:10b6:510:39::12) by MWHPR1101MB2080.namprd11.prod.outlook.com (2603:10b6:301:56::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Wed, 4 May 2022 02:19:17 +0000 Received: from PH0PR11MB5173.namprd11.prod.outlook.com ([fe80::b19d:4f53:9171:696]) by PH0PR11MB5173.namprd11.prod.outlook.com ([fe80::b19d:4f53:9171:696%5]) with mapi id 15.20.5206.025; Wed, 4 May 2022 02:19:17 +0000 From: "Wang, Yipeng1" To: Pavan Nikhilesh , "ruifeng.wang@arm.com" , "Gobriel, Sameh" , "Richardson, Bruce" , "Medvedkin, Vladimir" CC: "jerinj@marvell.com" , "dev@dpdk.org" Subject: RE: [PATCH v8 1/2] hash: split x86 and SW hash CRC intrinsics Thread-Topic: [PATCH v8 1/2] hash: split x86 and SW hash CRC intrinsics Thread-Index: AQHYW+SjmwQhw3aXhkmVIWbH5+lypa0OALnw Date: Wed, 4 May 2022 02:19:17 +0000 Message-ID: References: <20220427152232.19223-1-pbhagavatula@marvell.com> <20220429161700.2145-1-pbhagavatula@marvell.com> In-Reply-To: <20220429161700.2145-1-pbhagavatula@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ff0c19ca-dcff-473a-56eb-08da2d747d78 x-ms-traffictypediagnostic: MWHPR1101MB2080:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zL8SZPoWGppt6XMd0BFNNBxT3BaDO9Z5eXcQl2/fD9hm4DA8v4OEdpmkx6TCU4QzWebxt7LSbBmdbo+yCsTYBirPCsd2rbPvuddp86JPoUZbPREaWQRl8GvmOYRo6cSMghSXjCJp3D7F8qUpkIaBsLjxPMw39VpUkBYUE0IfN/xxa8e4Okx0ToQ3pJ+V7YikGkv5KHuBNyStVPw72AyBtUahpjIZrEPRT6wvbHZz5u/uuqQeuTStm4HHCodnQ+d1u8FnsbjNDuTfQM8a/jduB1qfgbXZkMK17b/sNi+nTXYU819aJ2pYIcVRNmSweo+xaY+cUtAHSUT350EVjTSsPDzT0R/V2xCBTQfQC+wqa+uPJVBwcM1o62OeYw1eDHv+VZ+uIXv/TnfQRAG6H/E6je8BJ5dXqkcwYkew/3nDr0MwmL41+qyQYyS8rNipSZCh91LWjoS60Q8I2JzUoAay0PxkwoFeAwJ+4hE1F2GaFciHM+GQCFzdqb6+YS1F9mpieQRC5xVzYT/OQ3YQZp0SX405clNOL1zrqTqZS59GJejitN8zMkSVKYwL6Xf9BHqKk/CnyUEjJb8GOzooaV2q7erQoUXwAYewYm/fZWR+z1ESU4PWS2XDIHjjvOnbDgK69zMJPsKwluvQUnlHr1z0msoe/Qvz6KnpTVmgq3MoMtNCBNnFJkcUw3+Tf7duPUV/0zxtU4ovI8wL9ksnj4tyHA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5173.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(33656002)(508600001)(5660300002)(86362001)(52536014)(8936002)(7696005)(6506007)(53546011)(2906002)(26005)(9686003)(82960400001)(38100700002)(38070700005)(55016003)(122000001)(66446008)(71200400001)(186003)(66476007)(64756008)(83380400001)(6636002)(66946007)(8676002)(316002)(66556008)(54906003)(110136005)(4326008)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hq3LGt8Db7Pj8ue3a1O3D4CNTl513cFug94FvtV1aQL951ntY6p3YWg36SRp?= =?us-ascii?Q?OymJJIPzTIXrMyJE3CI7vFSjQ+QhzUMxNk83HuAgjfsd7462FaYalu51T+L7?= =?us-ascii?Q?ticLNOy7iUw3lHo81vcfs0O0AQ0iRE9tKe0KoqBhTPzCS96hvvoD6HEHJ8zE?= =?us-ascii?Q?P2z9AnI8TfKo8xWYKC4W3YVN6yZz6lWOXgHwTGsAxUAf8811A0pu82lZAVp+?= =?us-ascii?Q?rrHGs/5YZu3BzzuorHxKs/sDmd77KC4zH4mfEYqBNyJWuiLyy/jUZwNjN989?= =?us-ascii?Q?tBP0iUBWxiZCUnNDrjAVAPrtd0IEPI2oJHjxlOnJKUDXTd3DXKXye3FqXE66?= =?us-ascii?Q?b4lpQSOnlhTgg43Fj2akuDvbFlW4jk/WTUFh6Ui6egJYuQUAOkadFb8YGTA7?= =?us-ascii?Q?oKAnVZhZoIltx/CpiyRxCjSp7nBNLS5MSqNaTovBHmgqamt0SfdbrMKj95Ip?= =?us-ascii?Q?9C66DLT3xvnm6SBj0dZK0HbAiZaLioK5v9nFPaGhjP6NOVZ6I1W+9AicE/eG?= =?us-ascii?Q?AwS6k3Igoh6u85w7Y4GKykgpO7prGR2ru+rKTIVP/zHhJI5pVjwF8q/ovo6I?= =?us-ascii?Q?dKncyecKBGawrrM5W1qV+Sz5p/nggtNiyteJ4Ghl72MiKAbiwEITFL9HYdtP?= =?us-ascii?Q?5V2nmFE3VXwNInhYghfrct6G8VcedDcxrirtvne+4EF287c81ZIXH9P62ZrF?= =?us-ascii?Q?OsEg0U+nDvT4WwrC4h35S5O/trUWZL+N6OrWEY2CeHsIF8WRFE5OiSJbRdKF?= =?us-ascii?Q?R1sNOzZAiP4+krdv8vFmHK2+GfabpqzWpjgWtBcj4exP2GH5UxH5ufvW1rke?= =?us-ascii?Q?V29yzXRS1fBUSPJOsKwywdznpkyuVHCZjb2v+9QWB96hUN/wga8VpfIlM6e1?= =?us-ascii?Q?E7YDy9FZY4I+dWnaFhO6tOWMPlgAff99Nb+JzQpXUjBg+9Y2nqZsFGLeZfsX?= =?us-ascii?Q?e2+OgqaQISjcqlThwn0BMEJQcz73vlD8gUVVckclcKx5dajZQP8/d2xFAFOp?= =?us-ascii?Q?20G2Gn+dg5swvjP9eKuOgC2uQGFHLTudMTtnXx8VgMDJprESTdVFZWdqPT0p?= =?us-ascii?Q?YR2y1DH9z3XohcB2kcnMzm8FayddaxnjmZjvm2Y1S6ojL9wd4H4TU4KmdCKI?= =?us-ascii?Q?ioRN4DBK88rw8uWZNnychAZ2liPPYgWl1Gpv9bzXq18lSVc1An4l6qhc6o3e?= =?us-ascii?Q?0cvhtd0Ajw07kb9bUCEs/pltyWUmcrL7eDerzRssX79esvwfKJkXK2o0piuG?= =?us-ascii?Q?HTmvgQNveYBesDzfDBWp8nIjSHYWQGTUsQLb43rmh32kW4BCIokIGo1cPZaP?= =?us-ascii?Q?2EoxmOXTU9/kT/CSlOge0NwRWmOzo1ACCSy+FZn4c+a3HqH/6gzyWD1wVFDg?= =?us-ascii?Q?dmiPGO4MWWFmd29LH6/mIEn58y6ZtHHTjHkLOQiV3EJKkVVRlRumk5q/zvkN?= =?us-ascii?Q?HiY07trClQ6rEDSrDdHifV1tm0IhBEFMwtMM1vd38LhEZT8tN60KiPk4Z4Jt?= =?us-ascii?Q?40QVF2T/vH4gszEO5p2eY8XskgcJ2dOveNxv6//IedfA4uZIr/Dy8rTTPCse?= =?us-ascii?Q?BNpQhu3JvsozMp6PRcnBq91JVCYHNY1QmMIKy60CAW7QN0ZqWFdSu5TX8oOl?= =?us-ascii?Q?Q5xdqBgKuziAIs4EWdzQPifQjz73DZsZne8qqM9gz2+oHhIqG0lg3RMRelLc?= =?us-ascii?Q?gFx+kj+4Icjm7zLvJf1akPPPIq2PBvdPkuz47gJ5vZDqrQ25NBCbGqQQY6XX?= =?us-ascii?Q?om68c1thOA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5173.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff0c19ca-dcff-473a-56eb-08da2d747d78 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2022 02:19:17.0528 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UphrK02LgjCbSB3/uyxCEnjM8qPMLY1OyHSCU9hg5dgcg+1PjhLUliERMDvNwP/MSE7bbq6EE0HLI6lh/7DNmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2080 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Pavan Nikhilesh > Sent: Friday, April 29, 2022 9:17 AM > To: ruifeng.wang@arm.com; Wang, Yipeng1 ; > Gobriel, Sameh ; Richardson, Bruce > ; Medvedkin, Vladimir > > Cc: jerinj@marvell.com; dev@dpdk.org; Pavan Nikhilesh > > Subject: [PATCH v8 1/2] hash: split x86 and SW hash CRC intrinsics >=20 > Split x86 and SW hash crc intrinsics into a separate files. >=20 > Signed-off-by: Pavan Nikhilesh > Reviewed-by: Ruifeng Wang > --- > v8 Changes: > - Install arch specific headers as indirect headers. > - Retain `rte` prefix for arch specific headers. > v7 Changes: > - Fix build with ppc and other arch. > v6 Changes: > - Simplify rte_hash_crc_set_alg function. (Ruifeng) > v5 Changes: > - Move CRC functions to implementation specific files to remove > ifdef clutter. (Ruifeng) >=20 [Wang, Yipeng] Looks good to me and I believe it is more organized now than before. Thanks= for the patch! I did not fully test on x86 though, will rely on the CI or any other review= er's input. A little bit grammar issue in commit message: "into separate files" =20 Acked-by: Yipeng Wang