From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0904EA034F; Fri, 12 Nov 2021 17:49:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2A54410E3; Fri, 12 Nov 2021 17:49:39 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 7938640692 for ; Fri, 12 Nov 2021 17:49:38 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10166"; a="230622609" X-IronPort-AV: E=Sophos;i="5.87,229,1631602800"; d="scan'208";a="230622609" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2021 08:46:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,229,1631602800"; d="scan'208";a="584034036" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by FMSMGA003.fm.intel.com with ESMTP; 12 Nov 2021 08:46:07 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 12 Nov 2021 08:46:07 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 12 Nov 2021 08:46:06 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 12 Nov 2021 08:46:06 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 12 Nov 2021 08:46:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZDiEwWv6cSjPC/MJjBlPECKm4Mjq47S+E9dRQINcas1AIwd5ZV/rj1DQA9Nistq0q85izXDC188nB1jEhQrQpEGKe1onMI9FsHB+J7oG5i7bOAHT4HPL7T2mY02+2xh5KboaM87WB05dmXtIxy5F28zWC9SH1kr8sVF/LkvwqvaPkJN3qKz2Zej7pDic0fMAjcv9cHmSdATJKP4fwI/ejWmfsBtPm/ERYliDhfFWUeVcqjfRrqk4DsRJCF62VfLQm9c6EO48iXYRqUe2qQVwUmgIed1u6HCEuEZHnskXXzuZLwn+pz+UBz0qFmh0Aefl2DBZRis8x5bcytMI8Tj2GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GZ8th7/e4rP+FNveUGQjF62qywzzHaeGJrqubK8mBDY=; b=BdezW+NYCiiaDTasSGCoDIARTZJyP2+yZASR2p7AfL1mWBFZoLsU9F7d9DbhTqg3NfT8gACOMfLZteCIgkOjew8KMWj6ugwQmMOpgB85a0hSSevkZ1C8c4mLiVpZOMsFeSI8HseYJc4hon6CtVjpsPi7RCfcEZh09ZEP1HcReoFQHS0SH9qmJlaVYCS6s62LRW1VaNAQBiMYzN87BCGUmOaQhAZJ0HBW9R5MtGDkslFbKLXVQAV8+I25rsaytgu85aOzplEcX4nbZO2Q4NPJf0nHzrTdpmNqCl5ixdVnLyutFbgXzBD3mYzPKEGrVHKoMoO4Ybb0dzGl+ulRhpXp9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GZ8th7/e4rP+FNveUGQjF62qywzzHaeGJrqubK8mBDY=; b=Z7BWd2K73Rt+/P1KSd0u3/MJy+Qxfe7e6RMx/7MvDPDx409Q7DaJB68bkQtlXqZYI8vkuPCWGEmjyv8OvdReHUxTYV3SZYWc6WixUnVG/OkfckkJW/GbNS+W25oJb56DhuMppxh2hiXANMXBN4MvY4heTXVQOinP4vhNuGaOLk4= Received: from PH0PR11MB5207.namprd11.prod.outlook.com (2603:10b6:510:32::15) by PH0PR11MB4999.namprd11.prod.outlook.com (2603:10b6:510:37::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.17; Fri, 12 Nov 2021 16:46:05 +0000 Received: from PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::f076:f51c:9101:b0ff]) by PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::f076:f51c:9101:b0ff%8]) with mapi id 15.20.4690.016; Fri, 12 Nov 2021 16:46:05 +0000 From: "Walsh, Conor" To: Stephen Hemminger CC: David Marchand , "Yigit, Ferruh" , "Liang, LongfengX" , dev , "Hunt, David" , "Wang, Yipeng1" , "Gobriel, Sameh" , "Richardson, Bruce" , "Medvedkin, Vladimir" , Hemant Agrawal , Sachin Saxena , "Trahe, Fiona" , "Griffin, John" , "Jain, Deepak K" , "Van Haaren, Harry" , Ajit Khaparde , Somnath Kotur , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Shijith Thotton , Srisivasubramanian Srinivasan , "heinrich.kuhn@corigine.com" , Harman Kalra , Rasesh Mody , Devendra Singh Rawat , "Jiawen Wu" , "Wang, Yong" , "Mcnamara, John" , Shreyansh Jain , "santosh.shukla@caviumnetworks.com" , Akhil Goyal , "Zhang, Roy Fan" , "Kusztal, ArkadiuszX" , "michael.baucom@broadcom.com" , Venkat Duvvuru , Lance Richardson , "kishore.padmanabha@broadcom.com" , Jerin Jacob , "derek.chickles@caviumnetworks.com" , "ssrinivasan@caviumnetworks.com" , "mjatharakonda@oneconvergence.com" , "simon.horman@corigine.com" , "david.george@sophos.com" , "sony.chacko@qlogic.com" , "harish.patil@qlogic.com" , Tomasz Kulasek , "ian.betts@intel.com" , Liang Ma , "lei.a.yao@intel.com" Subject: RE: [PATCH 5/7] drivers/net: fix unused but set variables Thread-Topic: [PATCH 5/7] drivers/net: fix unused but set variables Thread-Index: AQHX183ubn5jnLlQ20iaORLFjFgAKqwAEgkAgAACwgCAAAKOQIAAAXCAgAAA9tA= Date: Fri, 12 Nov 2021 16:46:05 +0000 Message-ID: References: <20211112140111.922171-1-conor.walsh@intel.com> <20211112140111.922171-6-conor.walsh@intel.com> <20211112084153.1931b484@hermes.local> In-Reply-To: <20211112084153.1931b484@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 37fb8fb6-a240-4096-6db0-08d9a5fbeb4b x-ms-traffictypediagnostic: PH0PR11MB4999: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K8XGahTPH0XUbpSpT9+/tKIvGqNoda5HP0rmtpabeOqNrLa7f40mjIprQdUtbesiBKRxbwW20/UuFGKpaf1cpgycID9m39DUrSjBYwyPENj6QVqCblTgyfj7chyAx6Db+BMe2mdo2iBRJtQ6dJRBMIdgpI/ivzKR4m50M1ZkyvJnD2Wn9QxkM1/0kjA0IpcNBxIGV9CQ6En449e9H1qGA5+5CaZ08cQBm3cqU+63N0Kjryzlrlq/faDOr97pp9gYZ7s1DY/Ka/+Ch3K0th8lRADD0ij3lyrK+r9vwuEEyquADc2BlF6KNGd9zMz4vGHYnB0YhTE74gAZKxWvmuOgMmUImGWvjdhoMrx22lx51cjc+XTdciYBxh7oeZBr2FMx1EymDL/URFYFV3p+p0h8QQzNlBJf+uya8v+A/NlS8Y/Zp5Pt9aVzb6rXv5tojaKPDZDslCtmHiVXZ3tHZ8Wf9jf0GHCv1ECrhTr3rSyMhOfyWxvMYdHePHYpoCK93OC7171+oz4VeTJGtYHgtlxwJLESn/90RloBPEiICNmRuIKDLJPMg6mclsIv0/mG28RaTeS5Mt5iBPhM/lKG+u1FFUHHW+Tczd8PXVITWuzK/LyzvsKUCAeO6WGMQtrlA5TVvuUOm33Ecgnov6rg9c2+5aGzRSUf2LqSMsnV9ZYpN2V/+N8YpZafD8dyB2DhFntaRDyEF/7vL+iIDOYNmhQrjA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5207.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(7406005)(7416002)(38100700002)(54906003)(33656002)(66476007)(107886003)(76116006)(122000001)(4744005)(316002)(9686003)(8936002)(82960400001)(2906002)(6916009)(26005)(71200400001)(55016002)(7696005)(186003)(508600001)(86362001)(4326008)(66946007)(52536014)(38070700005)(8676002)(6506007)(5660300002)(66556008)(64756008)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tvVe0Qh5d7hnENCODCK8pCIANgudYhhvLS7rfm5/SW+lCuMWZ4CMP6BL3N2a?= =?us-ascii?Q?Z9BFdxPtxxIcEs7JvnbgsrCPDke8VAJIf5kmA12OJZmuk5BeIeX7oZoEGXYv?= =?us-ascii?Q?ZPIt5R3n/lxox+K0SbIbTa4WBZzMAWJJ913krHFQt3/teFhQuvy967fxPvNZ?= =?us-ascii?Q?NFg0a4U/tml+Xg2AgU8m6NjL0L1u9vS20l9qv/4TDxyXS65pHuhdMT5zU9q1?= =?us-ascii?Q?0n8LHZbJbUBlP4o6GNYzBUyZfA0Kdl/UgNfPWhAfU73ycAoIabCZo1GM9MgV?= =?us-ascii?Q?yt2FHwW5Fw2pP1C0W/6Pil4yWtx8Px2SHOmEkkz9WuJBKJE2Os7XVLHJdCQ3?= =?us-ascii?Q?+Mo0LBHWkA2GG7C4DrGXISoXtd5rGDGsLr75h3zsp4pv+TDdWxsiwpL4RvHD?= =?us-ascii?Q?Wy+a3oZLX/PQeIRgqz3vUIoWQ1cyUSJnntXIuSLyGo1s799XkrBzBosikjVN?= =?us-ascii?Q?0xc2X3LcbQOSb7+S5hshcSs/vGevpWTnpc/ByjMH2tk5ZRaAkmIOnsI1A8oY?= =?us-ascii?Q?k9E3humqnuxUj+zHfjji69Kdq2gKppjGZzvnY+5Z6umzSXABH05xCYZU38Ud?= =?us-ascii?Q?WgzLcjwKcrSyMB9aiaItpgdufKB9yseuouLJfa8vwBe7Kzq2GObSbjQwLALc?= =?us-ascii?Q?TQCMlCgB9TnH6oPU8sg9OsekAwvufh3UE1QW+Usky3WLOgbMtLwz4tzl+ZoS?= =?us-ascii?Q?uM1GKNxjNrFXVY7bh+MKgIuR2XZKTLeS7vdSz3DKCpun/5o4zbpR5/hI4OW6?= =?us-ascii?Q?oFk9eWAnyhUjGTRvPY5/TR/hRv4F9cDxzmCEsgMAK/gWvrn1nU0SyJnLcVKR?= =?us-ascii?Q?2JAWPF7dRuUBViE1j8cpmQBFF0SUlf0OsKvkliGw5zyNZcmMt+hOqCFLFooy?= =?us-ascii?Q?RB0u0wOfdTOb1ksa1SBgAHOefOmyhbVdLfQOHMH1Phwg9mpeQNVHQDBRihYy?= =?us-ascii?Q?MnWzfAE43xWgB+YJqrbp/eYvEtuu/kpVOJO9INtB1HQOgPn8v0RaucvZuQFE?= =?us-ascii?Q?Hh6K620S8VWh2UDzTiMubD7rDlNzsS+4HtgJBpEthRD8dvUzT/WqH1d8q6Z/?= =?us-ascii?Q?0fOFuUX14wgr/fP4tofqa3fwmg3kJXpBx1OrsWGPnEPzC334w0rpYVSdPl3c?= =?us-ascii?Q?tzRYrlFzxjqq4lI3XzWVrfchobrAm1eTwPDj9D0XYhZlkZchl2o6TicK/gnb?= =?us-ascii?Q?yfPznCXP6P3Bliz+s+6ozsQbm1EKXPQAjDM8S1oXzKB0M9eqNphgcQnhmmvx?= =?us-ascii?Q?5glc0JFmOjjfDzLbGyx6TTGYMS7uNKylXW7yaejt0xQNkfDZRIA7hpNHcc4M?= =?us-ascii?Q?B+Jv0fqB3OLy9XQBPgEw0Cm67knO0S6l1mnJPfMS037OV7DppSeRI67tF863?= =?us-ascii?Q?BxWvfPqgMneC67quxfLgRrsiA6zPyRpYJSqNfHE3zHJoS2RJUzJ8TBDb9Fub?= =?us-ascii?Q?gNmx3mugISW1hBeBIMCWuN/MIxZtt8PNhHcwoQbLy3Z6LJkmtXRcIa/m7Bsz?= =?us-ascii?Q?b6NftexXqvZ+dYvWY+1hYCqF7MiGHagYnYu4UwEUfkuUPimdKUWR22cUBksX?= =?us-ascii?Q?aCLc2cAnZmnEqunhqM7UWvN045X0mMw+5BslN97P6YOQ1P/4m55E6yMh+bGd?= =?us-ascii?Q?hw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5207.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37fb8fb6-a240-4096-6db0-08d9a5fbeb4b X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Nov 2021 16:46:05.0836 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7GdTluhrRYWLTHz7V8w/2l3JoVyyTFbv8LVbA8u4peK5UX8s3m5/Ec7dW4hnk3psgDjWAdijxs+Zh05SUz2Bkw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4999 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > On Fri, 12 Nov 2021 16:38:37 +0000 > "Walsh, Conor" wrote: >=20 > > Would something along the lines of this make more sense? > > > > #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX > > completed +=3D vmxnet3_unmap_pkt(tcd->txdIdx, txq); > > #else > > vmxnet3_unmap_pkt(tcd->txdIdx, txq); > > #endif > > > > Thanks, > > Conor. >=20 > Why not just > RTE_USED(completed); >=20 > #ifdef's introduce more testing issues. That makes more sense, I'll change it to that in v2. Thanks, Conor.