From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCD2DA0C55; Wed, 3 Nov 2021 10:38:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C19C41149; Wed, 3 Nov 2021 10:38:54 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 6EF9B41134; Wed, 3 Nov 2021 10:38:52 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10156"; a="317665975" X-IronPort-AV: E=Sophos;i="5.87,205,1631602800"; d="scan'208";a="317665975" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 02:38:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,205,1631602800"; d="scan'208";a="489474836" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga007.jf.intel.com with ESMTP; 03 Nov 2021 02:38:51 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 3 Nov 2021 02:38:50 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 3 Nov 2021 02:38:50 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 3 Nov 2021 02:38:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LpqOgZLQ5/+CRKRvBolNNbuUJBuiGb7toR/MfpRSiiQYIDUjzBhqN7VUKUP7tTB6OnDfPdcTuY/wzoJlvSNJrnu5nVZrLTNp30l7I7hHRerFM5NyvQPRxZPDTYLqtA+Tc5qZe5x21sltuY9Gyq7zguyQDxNiZVJd2PO2/5r938QR900oO52Co7BB2d0ygfavrxF9aVtZ9oaMe2fsO1H9g4lgkKWq50PAN2nWhXEi6l9XT27jouA0raHXVTVTs55o8A45XE6RQKRufDfv+vzLk2kir9DKaZMcLFnAV55zcxlkKFXuY/VPSC4nR+utMIyYyUOu1Es7xZ5BFOgntM0AAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JfpQ6kUWo3gDIEf78a8g6JORaocHfLu6+Hj0GXswKR8=; b=ZY9rV31IExrtqAQmS3rKsY0s95h27BjrrO97n6XZgcUgXcRyk4u8adrtn6zS7IBcfQWbjcL/pKFVmbdqgtkoQsIvxoMJWYI6HCldBK14oObFVdhahXmN6KYUkjG4mNIk8pbFUj3HK/orGFfTIXid19BXUjenC2uVE5velfp4vyBsbdoAg5J3DuZr8clYomzcHB6yKBau6IsOUSpPXO5gtMUvf9nhk5r3Gd/xDWDbATy8+VDbX/OXtycrikPIaFvPsqcQsDmlbhUsBjSZJkKo3HdRu95lPwQZHcVFFJgZf0S8nXrKft3cXUMNzqtYFyx86CrB3kEjSuje3lQhqUKiUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JfpQ6kUWo3gDIEf78a8g6JORaocHfLu6+Hj0GXswKR8=; b=vwJZKnQl5z14kLPSSN/Ru2WKEklbOkKrMbt1okFgQO4fzK8Ckt8iOEOHKnJ1M2p0h2HanU10hV9+dSIGOcYc3qnRrhZ+wsyuFaL5EwB2+id3dIkGYgql073J+KE7bJCgd5YawkpkGFEDObOa8F0g9LRF5FKw3/nZBsqTDqPRo1Y= Received: from PH0PR11MB5207.namprd11.prod.outlook.com (2603:10b6:510:32::15) by PH0PR11MB5926.namprd11.prod.outlook.com (2603:10b6:510:14d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Wed, 3 Nov 2021 09:38:48 +0000 Received: from PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::f076:f51c:9101:b0ff]) by PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::f076:f51c:9101:b0ff%8]) with mapi id 15.20.4669.011; Wed, 3 Nov 2021 09:38:48 +0000 From: "Walsh, Conor" To: Joyce Kong , Ori Kam , "Mcnamara, John" , Conor Fogarty CC: "dev@dpdk.org" , "nd@arm.com" , "stable@dpdk.org" Thread-Topic: [PATCH v1] examples/flow_filtering: fix wrong comment Thread-Index: AQHX0FxNU6e5Hhh5cU+D5F+MT8+YqqvxilGw Date: Wed, 3 Nov 2021 09:38:48 +0000 Message-ID: References: <20211103024103.2420-1-joyce.kong@arm.com> In-Reply-To: <20211103024103.2420-1-joyce.kong@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2cdd4afd-0336-4d74-6c50-08d99eadbd08 x-ms-traffictypediagnostic: PH0PR11MB5926: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3nLBBkqNhf9AyK7WznrHiXXay1neDKaLWKGPyrsG19k3wfTKxBc68IH3U3Hzsh8wzlUkhAMr/9CffBakzhJ6xY6kwPmLnUp+AoOxCqQJL+G556LoUnDRjZs9MwmC1aOjGZrHv2xr9k7vCEnpYKsxlMD4eMP5yYSFW3Aen5+64Mxz88GaZr7+3e9h5TSP2UzfNRe1Xp4t4w8YhOYYyH5/RYdqbAp93EYSSAK6zgkYyTPV5kiiqps3dFzl8zNIyBmAym1rmB4OAL5yO8cuSvNOn6BEAP+79nYsTBIlScPTIfCAyDPf1y6sgPWOdXKamFk+lp9pNnqrefFHF0kAI///npyAFNRq4zem/bhFNBPkAhOFaEKpQFG0/etsmCAIsGTNiLl5HuA0/PQoDSTvS/KVfo5XNHWHdLbB2pwNyY8NFM2aL6JpVTRnW+GblK0Zyi+ddNfckXx3WkP6cUUlvoiHx1LiOfmx7Bd/BAI/HZWTBlretaijV7gWbpfjQ4tgh1jvfadM7XyUwan5V4FEaG1ah9bBpYW6tK/g/QezmqSBCM/R2/onQluMWsbuV8YA+vP9Nz1hCOWEzkG/J8GFM2ZncT52pqHOhCQk8VW1SvCavFMIPgqt/gARWTae3QBeAzfLDn2MRh7EeGCfCzXWpm5ZI3FzQG+UCRtY1cLETSdtlyAY9b4TRlzYP/mdKI14ydoNMZykGcmNPzt6QoPhD7F32w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5207.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66476007)(8676002)(2906002)(66446008)(83380400001)(9686003)(33656002)(38100700002)(122000001)(64756008)(66556008)(54906003)(508600001)(7696005)(55016002)(4326008)(186003)(52536014)(5660300002)(110136005)(316002)(6506007)(6636002)(8936002)(86362001)(82960400001)(38070700005)(26005)(71200400001)(76116006)(66946007)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1ncX5mQEH9lkCZfjW1ZkGshwXjq4BzfhKfFxA8mbz9DPN92CD1TSveVfV1L7?= =?us-ascii?Q?/XarFs1KG6AVPdXYHzGw/w0PwC550oDl4pA1RKb1oI5ZQi35uEgUzJI7hwPg?= =?us-ascii?Q?+Zk4bj5bWw4rjfk5KLJO5TswDhMIR3KsTuVlYb2SEEqbHUqbgJhu7nKOeHj5?= =?us-ascii?Q?JHmJLuI1A8StRKVSSU5QuB4tkSzFv185GvX8ez7f8mfXAt8wju4Hm0QJyLGk?= =?us-ascii?Q?GeoZUUjTzgXkwdq14UGYC/HT6WIaOe/dS7UxG+GZgyv3bQMmVAYzARxDi65R?= =?us-ascii?Q?H3ypddZigp0aJhyxdKUhbKRN4uO1i2Elv3iqKqWyeasHcPAhVz0pCNMAWI3a?= =?us-ascii?Q?KVQKHGwOhK/wLLYYHYHjq99YD1S1iGofkhD3nIap9gp8FsVrueyO5m9IgDB/?= =?us-ascii?Q?xibzdixSgwU1lUubo5fec9AAPouNc5Wzz5Qa9B1cbS8sBeDooQkC0h9ROujN?= =?us-ascii?Q?7z/sbp4+L3ktq6R6tVF2jKMAzELsS+ej6D/bsLp/A279u+z06desccTqDxqW?= =?us-ascii?Q?lJ45lvb1fDMCf6mhsxQo/6mbkEDfucm4WZ54MQpTDtmW2WizHJiiYnWymply?= =?us-ascii?Q?VglyNO0eeJVSDMd/xagIKbZ2Km/0hnLo1Qqrdbk8nLQdp+txC3BTog3gB8tJ?= =?us-ascii?Q?T1LPxj+ycAH4/T/KkFsvZT4tiFjn93o5Uuq6Ie7JlG/Nsl3l7WC845dEpbmc?= =?us-ascii?Q?7UIj6CrZtWnW/po33HB6Bksyh1N4mfxn1idqhVbal2/WT2ci4HDsC+r/Q/Cn?= =?us-ascii?Q?eL3mwAcKEpQlyQRkpe09+eKhdETw7n/LBC6pWFnR4a7MMDiawvoY8YbNTKF9?= =?us-ascii?Q?V3Zgmhi5PLURrw5n+tD6Vjl2USU6pehYowElux1c9JxLqgNHlt20bF6jMfXm?= =?us-ascii?Q?3iv8niV1k4cyZLdlECjVGNe27qwzja/uQRT0UzhqEiZZxKwXP9u7j455Qdit?= =?us-ascii?Q?rPMpfUOMkt0yckRebakqQkkpKmgneq9O7XXzi2s7/ftB1zxbAoJ1wz7zsMLS?= =?us-ascii?Q?KP2xsMjS5x56TuSwr8mNZIjWkcW7hukrRfhjoeUI5g+6M6CVnmtDi4usMZKy?= =?us-ascii?Q?cU7/26yDmm0sgYdVupodH+sYvts7sCzRPQiKVCUSR7/7u9ffBgaSYMNVe/eU?= =?us-ascii?Q?Okn54fJQ3QREnla7tsAlw23483/+s/LtzvVv0kN83f1ZwcwGzBRBFeVdgq/K?= =?us-ascii?Q?mdFO9VoXDPbDXm1+Sc/sHJn5rxZsWoLlXfz9PMxLk3q9FaoX6KjoiPcLUOKR?= =?us-ascii?Q?Q2tLKfYqjGdJi/bIpHJjsy3JCOfBr7CEfoCU1cIVydjn4Xhj6Wsh/hbTGnI7?= =?us-ascii?Q?yjvILk7qpheZ9/RnwUBPGaC5HZxfh/FUtbJbeGk5tMBDDhminmEdSzjJCzlH?= =?us-ascii?Q?PDuc16ag0rmJuwEr3rKfETzwgNSjn9KYBGut1NuhqnP+iEsPT0kDm2rMPSMC?= =?us-ascii?Q?d75pi7mTkz+Nh0Hu/1X8fpSyyqSPPaIx6eDpftQnMdzWqUy/Sry9Fknv/PCM?= =?us-ascii?Q?sL8+7kWs9Vle4ZdYKYOfEARDGew1AAFRiTQIBmIRPqYUBn+5M2b8TOmy8YJN?= =?us-ascii?Q?eXbUzyipj6SJjEIOhrgRyrhgXxY0iWIoINFVuNQVnIGBxd+EcYB79kPnT1wF?= =?us-ascii?Q?DQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5207.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2cdd4afd-0336-4d74-6c50-08d99eadbd08 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2021 09:38:48.6467 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GRdj8PDHeGTkD11OTBkM892H3t6WPMetRSFyvlEZalqSO8TTJoiFhuhy8PeAbugK5FhrOYmD5A2tSRyc44eXLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5926 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1] examples/flow_filtering: fix wrong comment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Joyce Kong > Sent: Wednesday 3 November 2021 02:41 > To: Ori Kam ; Mcnamara, John > ; Walsh, Conor ; > Conor Fogarty > Cc: dev@dpdk.org; nd@arm.com; stable@dpdk.org > Subject: [PATCH v1] examples/flow_filtering: fix wrong comment >=20 > Change the 'IPV4' level to 'ETH' level in the comment > as it was previously misdescribed. >=20 > Fixes: 9a212dc06c7a ("doc: use code snippets in sample app guides") > Cc: stable@dpdk.org >=20 > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang > --- > examples/flow_filtering/flow_blocks.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/examples/flow_filtering/flow_blocks.c > b/examples/flow_filtering/flow_blocks.c > index 3251ed9f8f..b168dc6e71 100644 > --- a/examples/flow_filtering/flow_blocks.c > +++ b/examples/flow_filtering/flow_blocks.c > @@ -75,7 +75,7 @@ generate_ipv4_flow(uint16_t port_id, uint16_t rx_q, > * ipv4 we set this level to allow all. > */ >=20 > - /* IPv4 we set this level to allow all. 8< */ > + /* ETH we set this level to allow all. 8< */ > pattern[0].type =3D RTE_FLOW_ITEM_TYPE_ETH; > /* >8 End of setting the first level of the pattern. */ Hi Joyce, This can't be applied as is, it will break the docs build as follows: doc/guides/sample_app_ug/flow_filtering.rst:225: WARNING: start-after patte= rn not found: IPv4 we set this level to allow all. 8< The comment is a tag used by the docs to locate a snippet within the code s= o the corresponding tag must be changed in the docs. The following must be added to this patch: diff --git a/doc/guides/sample_app_ug/flow_filtering.rst b/doc/guides/sampl= e_app_ug/flow_filtering.rst index 11da9148ca..e8605f36f2 100644 --- a/doc/guides/sample_app_ug/flow_filtering.rst +++ b/doc/guides/sample_app_ug/flow_filtering.rst @@ -224,7 +224,7 @@ Setting the first level of the pattern ETH: .. literalinclude:: ../../../examples/flow_filtering/flow_blocks.c :language: c - :start-after: IPv4 we set this level to allow all. 8< + :start-after: ETH we set this level to allow all. 8< :end-before: >8 End of setting the first level of the pattern. :dedent: 1 Thanks, Conor.