From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7A59A034F; Fri, 8 Oct 2021 10:20:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4923040140; Fri, 8 Oct 2021 10:20:52 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id EE6EF40042 for ; Fri, 8 Oct 2021 10:20:50 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10130"; a="226413215" X-IronPort-AV: E=Sophos;i="5.85,357,1624345200"; d="scan'208";a="226413215" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2021 01:20:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,357,1624345200"; d="scan'208";a="439856094" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 08 Oct 2021 01:20:49 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 8 Oct 2021 01:20:49 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 8 Oct 2021 01:20:48 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 8 Oct 2021 01:20:48 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.45) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 8 Oct 2021 01:20:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nUleBkVwjhClU4V40JAM1jTUC4ubm72NI2b1NslZAFMxrzVSjmGuC8qleF7ODiE8sgXszf/mishHMQjPecxilXjtrKOkCLgWnnMETIujCtf+MPKk2Ae7gONrTjgWqRq08uN/0q40Dzcm43SU8+zgddhxtuUVRtvdozcy7jf1jCofzZyAQTmDEgZ+1ipq0BNclnl5x4KyUM4p+r9nB0B+mKBE6cAcWQiYdWJIFYR4rL+/MX+KXklYWx96qMCwb6eEtczPSUU6EmpC6QxRBMUGu0+g4HTir1ssR8EgqFRBBNEno7QG14paAV91BTotldQoEhvW/GtpGTyGce6YV05zYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EWdUX41q5zwS5oC4ScVhFCEyFXG1ZHcbpugJ0uyQTeU=; b=n8zZRTKJrZreBMNM2qJgJwuIVz7zta8ZGxHG8280J0YpZ6e+VCvvV69n9PoEv4WX/HZV3oE/tMOidsIitQ9AzdjHSSJ+/IwxZcMbBd4IZZ8vcHFB64473AT1i/nBGA/tTZ0CZGJcOImAhIgn4fR3rVZfrXgtLLIA3lJZPpyRpk6llLpWvD2WKEDwsoa79ZCf5UVpj2W0rOTSSx7Qr8AGLggfIHzYbBYm1gQjvHLnLad1KdgNXVjHJaAY6B4vixIKXqf4PIU5U7vc5ZEV2et4S6Zhk/c5gJBVJ7TUiiZgrTS4PtPKhCsrSoEEH1O6M/1ahzaWnhqw3sjiQnySLw77Og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EWdUX41q5zwS5oC4ScVhFCEyFXG1ZHcbpugJ0uyQTeU=; b=pIh91RP277ZwmVFgoYRrMyAJ3af0nLLYI9rFHsHiXfT5k9AFrh5uXfC8IB5HKG9P6tq6H9XYpZDAcnZu4vvmTxsXq5H1ORKGriurVL38/TOFCyk5uhyfOryOYFWgEvqhGv06g444rVZB5nMKxvPU2D1JwClY8OK6PE2a8UuKuP4= Received: from PH0PR11MB5207.namprd11.prod.outlook.com (2603:10b6:510:32::15) by PH0PR11MB5174.namprd11.prod.outlook.com (2603:10b6:510:3b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Fri, 8 Oct 2021 08:20:46 +0000 Received: from PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::f076:f51c:9101:b0ff]) by PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::f076:f51c:9101:b0ff%6]) with mapi id 15.20.4587.022; Fri, 8 Oct 2021 08:20:46 +0000 From: "Walsh, Conor" To: "Power, Ciara" , "Richardson, Bruce" CC: "dev@dpdk.org" Thread-Topic: [PATCH] usertools/telemetry: add listing of available file prefixes Thread-Index: AQHXufnOYlJkvYujtUyftSmtH0bn36vHsUMAgAEVHtA= Date: Fri, 8 Oct 2021 08:20:46 +0000 Message-ID: References: <20211005150017.2779845-1-conor.walsh@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a3379a06-12a5-42cb-57b9-08d98a34873c x-ms-traffictypediagnostic: PH0PR11MB5174: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: siCvWZqRjqvy+ZcLC+3QwZSOQCaefT5cCdivGK13xcPWQZ0A0ULgFLKa3nlI1Ad8Cl/WQRQFDPWBZgeeUCclm+sAW/dr9+uU121TeQbxfLoxijJZ7VZTovqSTil1sscrtHHhft+aR4ssXpAJCxu/g03uS4V+EYGXhi3b9bpagOD8Yamfx0yGf+nVMsbUONbBeS/qGh7m5PR6V/53VkKziO9uE+IhC2GFE09wAXRZYgAHhCIVqkH9pC00DOYg9aCeocpJe4Tu7eoPqp5PVG8G4g3EYFKDRhq9p6e00b0cqf/ckSIaitRm0Vs979PfSFUMYgLkTeBurDutNXPRSzWto6wKWYLmK6QyP1Ao2kc7RXg+8JuBFsCy1U/4Ep0HBbwEvN9zMvOz7yyswaJ8vohujXzJJ1kxRn3PQMN2qrkr5ZpF64v8Yq9U+1kxkc/G9wL+kzDhRaGGSsaTLgR936e+cMZ3Rab8+q5gOvxRuVCUZypRqS19JyqKgE8iG0g8VO500yTSni5BxDjDGMNa8YUgTKqk81Zsr/tCfbNXRkvgCyHrO7TjcY2Q4Zk+rWW+fYu/hhvEVjpZ3vOC7NYJDfwF76JpITUm94jmKk1s+X8EtgaCduY/+rXYZl0W/IyOoQRAbXuELQlY4klqUTOg56xJLK1XHmWayHj9PFycDTMshLWABhXkdHlKe1C2AYjiKy4I41Tc7B40UIX2uxB/tMlCfw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5207.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(5660300002)(2906002)(4326008)(38100700002)(66476007)(33656002)(26005)(66946007)(66556008)(6636002)(186003)(64756008)(86362001)(66446008)(8936002)(38070700005)(122000001)(316002)(110136005)(7696005)(6506007)(71200400001)(9686003)(508600001)(8676002)(55016002)(76116006)(4744005)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+WjQJ4f2hs51emFdr4tISvl/+pSxQSLFid6nKzR1rxcU574iAQkE5U1LQGQl?= =?us-ascii?Q?SBu7pgIvyyD/Q2L4rXvxm4PhsXR0A3dh8kSMorGeiyhwCzI7EYV3AFI855VA?= =?us-ascii?Q?3uEVaLCQP0tl6XSMBlYcpwHAyAwf1jPQbJBLRmfEL2RMM9Fh2EU03w+GGpvZ?= =?us-ascii?Q?THKa4iM6I+mdBs5cz3uwjN9rzQAzcx3hgu8BeJXHMd3RhIyy7J8hO1MIGjrF?= =?us-ascii?Q?7bdHTE45XQ8BfdOahSpUy5wvC68gww1aILKU+Tp+M6eIPvaHjXTDMo/EFyfF?= =?us-ascii?Q?bCmEqnRIwaxWkV5l5lvEynS19T2ngHp76x1RUAWBKfwepJn268G4BybAFiOd?= =?us-ascii?Q?bUmDmhb8dZ1J3abibzG1SUjVA2vraV/DbcpudjlafKLGGA+pCAhAz4naR1S+?= =?us-ascii?Q?ZrdjOni+/z07mJLHIEirSaWqTCru32qUI86waAQxic1Xq+la9pBdQLkm3zip?= =?us-ascii?Q?59I/1+Reie/w55ntp3wtZkWBYCziR/XjAEUM8fBU0KbvGobKc3eSzW130MUP?= =?us-ascii?Q?TbpVTLqwhNVNfM93y6mIEmge0xDKPhimaK00wYcZBVYdC8MuLk6G32YMsSfs?= =?us-ascii?Q?2Mxh2mNg3m1NGGSkO7puKp4nI2kv5y0Auhh16QDm4Gt9VouOoW6Hc+Gjw3aN?= =?us-ascii?Q?rn4o1SwHXEjZ5DwO5z8UvjpFBc2cWnv5QPEhle9Fe+cZCYi62/PKm7vF3tEm?= =?us-ascii?Q?Mtk7IAqm7g59bif6nKiiJARQM4m/wY/i7Mt3qkKoF/tNRoWDlfRXsvYs1B8C?= =?us-ascii?Q?Xs5632NQHxZAiAv51ZQSO99TbH5nS8Fa1PpLvvZe/4s0RKk36n/PlMrvbs+z?= =?us-ascii?Q?klkHmTjdjnGOIEP32lLizX5bquEWH4RAJQ1FC+sasP43Z3Ft/c8/P+MdaJQS?= =?us-ascii?Q?YKOcdlYIZSjs+TN+VwFEBbhk9ewGlROf+bOAUzf7Y02zMGhT/0kcCbtG1Tor?= =?us-ascii?Q?xu88RMzOJdwrCwK1GYGm6G0Zs6tqtaIDTmghW1cfOQUau65i3PLKMfWzgFjl?= =?us-ascii?Q?RQA0wbgzZ5DOjAfvtYS2zYvLpe4iDIDdE7/IPFQWZ97tJx83PMr/tmL1iLrk?= =?us-ascii?Q?InCxSOh9rWIvKkWWgXxc/6UmLKnOpXu+orFGb6Wi6fwpy8rk6idEHOjMOppt?= =?us-ascii?Q?kSS5DXiH8HQ9tSWhBkAWksFO1C+8Czrn1tgfXnSypim/o5LNNUQ9xOVY3d5t?= =?us-ascii?Q?gXiILOaGR3wP9ViuRLpWmRcbnGQmDNgHZGNFHuHxCri78lgTuD8YN7UiI2qh?= =?us-ascii?Q?3Dydx9AIhJL68sXBSJStxG4fApMhPQ7diHK5d10WXOWSK+QUzjnJET+UvuWy?= =?us-ascii?Q?o7QU9pnqLpb/JLpqoLpyhuxz?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5207.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3379a06-12a5-42cb-57b9-08d98a34873c X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2021 08:20:46.0282 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ie/Cs3p+Pnnvil3Id+Fbzs22H1V3vXKnzebTAoCv8cXj01VCz6Fo+aQ/adO6dz0R5C92ZGfEFZO6l46HNV0THw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5174 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] usertools/telemetry: add listing of available file prefixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > >+ > >+def list_fp(): > >+ """ List all available file-prefixes to user """ > >+ print("Valid file-prefixes:\n") >=20 > Nit: I think it might be cleaner to move this down to just before the fil= e > prefixes print out, so it doesn't print out when no apps are available. >=20 > >+ path =3D get_dpdk_runtime_dir('') > >+ > >+ sockets =3D glob.glob(os.path.join(path, "*", SOCKET_NAME + "*")) > >+ prefixes =3D [] > >+ if not sockets: > >+ print("\tNo DPDK apps with telemetry enabled available") > >+ for s in sockets: > >+ prefixes.append(os.path.relpath(os.path.dirname(s), start=3Dpat= h)) > >+ for p in sorted(set(prefixes)): > >+ print(p) > >+ print_socket_options(p, glob.glob(os.path.join(path, p, > >+ SOCKET_NAME + > >+ "*"))) > >=20 > Asides from that one small comment, >=20 > Acked-by: Ciara Power >=20 > Thanks! Hi Ciara, Thanks for the ack, I will address your comment in v2. /Conor.