From: "Walsh, Conor" <conor.walsh@intel.com>
To: "Laatz, Kevin" <kevin.laatz@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
"Laatz, Kevin" <kevin.laatz@intel.com>
Subject: Re: [dpdk-dev] [PATCH] dma/idxd: fix truncated error code in status check
Date: Wed, 27 Oct 2021 13:12:59 +0000 [thread overview]
Message-ID: <PH0PR11MB5207D0A93BD87F37768D5369FF859@PH0PR11MB5207.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211026142045.2996949-1-kevin.laatz@intel.com>
> From: dev <dev-bounces@dpdk.org> On Behalf Of Kevin Laatz
> Sent: Tuesday 26 October 2021 15:21
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Laatz, Kevin
> <kevin.laatz@intel.com>
> Subject: [dpdk-dev] [PATCH] dma/idxd: fix truncated error code in status
> check
>
> When checking if the DMA device is active, the result of the operand will
> always be zero since the err_code is truncated to 8 bits which makes
> checking the 31st bit impossible.
>
> This is fixed by changing the type of err_code to uint32_t so that it is
> not truncated.
>
> Coverity issue: 373657
> Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe")
>
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> ---
Reviewed-by: Conor Walsh <conor.walsh@intel.com>
prev parent reply other threads:[~2021-10-27 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 14:20 Kevin Laatz
2021-10-27 13:08 ` Bruce Richardson
2021-10-27 15:00 ` Thomas Monjalon
2021-10-27 13:12 ` Walsh, Conor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB5207D0A93BD87F37768D5369FF859@PH0PR11MB5207.namprd11.prod.outlook.com \
--to=conor.walsh@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).