From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A46DCA0548; Thu, 4 Nov 2021 10:49:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E34740E5A; Thu, 4 Nov 2021 10:49:34 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 7CD5E40DFD; Thu, 4 Nov 2021 10:49:32 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10157"; a="229131886" X-IronPort-AV: E=Sophos;i="5.87,208,1631602800"; d="scan'208";a="229131886" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2021 02:49:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,208,1631602800"; d="scan'208";a="501461304" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga008.jf.intel.com with ESMTP; 04 Nov 2021 02:49:30 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 4 Nov 2021 02:49:30 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 4 Nov 2021 02:49:30 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 4 Nov 2021 02:49:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=apaQ9hJS/fxv2d7h4BkcMEd/v4K8yxEo+7Hv/P53hhAFlZydPTckdBCTaUP+YzzVs9n2TwX7SLyfpuGQKEqhPjnPxgHiI01V8pqD+E5GI3spLLpHwwBvvl5/b+91M8h5mZ0nlVpQVdJXgehreYm0+bCAXtyCOdKBIfakFAP4ha68zad1GOXCHs01wqK0N6dUKwxrjBZ85dR7kzr6kXZJQjzRJYHS3WLOEXmNUYYoIMtk4HMnG1AvfTVHfyMBMsDOPxD1wO7N+O+vMAXOJyeAwMhJ4/pOoiNv/4iaVCadwkDoni5v8wCGCSDa1KuIiBjTdu1gu+w96o7PYQAm4UcDGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DO8/TTA9KEE2AXV5LhMNhjcM7VJm6a/w4u9gcGcmbN0=; b=PhqUv1Rad06Z6E0xEyhkdbq/mKzQgiUrOw+lD+s1obRHzUpjHrh6m7lJRTetk44/mWjO131ikP2kAE8VQGVnKijrrgIMs5IVg8Avi4QO48w1Bwfc2Pu9617vb+lGcQfSXA/htiPrWl/EI74l0TfwFFp4yA0980+eYzyOFXhVFPbKJosRGT70sotztqkdIxVRHSBVSvy23pNgts9EvSgOURn3SvW+SIYQKWUb+WVetm7NlZHUBzM42r1jraEU+GZPGMuKmjXsxXCG0XdK7txY+5dv7z8gSgAoOZdL2udlg02UqX9/3XhegNmH0jZl1d06zm3wzLnXfWbyhpeMPQySrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DO8/TTA9KEE2AXV5LhMNhjcM7VJm6a/w4u9gcGcmbN0=; b=CETWvWTd7INFLCHMsxLe/GBmIsJdQpj4aOo/WbwfEq54EJI4448O439AdnTuD9LYVU3f6uHrhyxscZdt4K0zst8hNZ+b3xVhLHDYr3b46ch5hTgg+jfPd5WQSMizTLODJ8n5aT6ucobXqbgvo7zjQCmVt9tUSwL2ADYl2L43Dyk= Received: from PH0PR11MB5207.namprd11.prod.outlook.com (2603:10b6:510:32::15) by PH0PR11MB5061.namprd11.prod.outlook.com (2603:10b6:510:3c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Thu, 4 Nov 2021 09:49:28 +0000 Received: from PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::f076:f51c:9101:b0ff]) by PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::f076:f51c:9101:b0ff%8]) with mapi id 15.20.4669.013; Thu, 4 Nov 2021 09:49:28 +0000 From: "Walsh, Conor" To: Joyce Kong , Ori Kam , "Mcnamara, John" , Conor Fogarty CC: "dev@dpdk.org" , nd , "stable@dpdk.org" Thread-Topic: [PATCH v1] examples/flow_filtering: fix wrong comment Thread-Index: AQHX0FxNU6e5Hhh5cU+D5F+MT8+YqqvxilGwgAFxroCAACV20A== Date: Thu, 4 Nov 2021 09:49:28 +0000 Message-ID: References: <20211103024103.2420-1-joyce.kong@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f0f342f4-8bb3-45c2-8778-08d99f7864e6 x-ms-traffictypediagnostic: PH0PR11MB5061: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lGKdMf5BItBOZdSP73SHtTmuTUWeJKAIp3aKY3j1pg6Mh5TrzzqNrfiDl7faOj0vDlsmwqUHeceCfopqM5q7J/UPDAWCmUkdIlf3zYHhl44qPcRH/m2BR5K9IRX7s1/cleY72ToWvTsYZT7tftalXL+1zhhcM0x24ZFcXqU8JrPOB9swwooSfww6I2EALpVgp5FFeu/bfILhnswaDNEumM8Ln+WEJD+5TS3M5OPPvyItbyoX1ZgfZEvdze8Al6H4+KZftS5ueUWSq2tCEeLmWbFr31P5QqLbxt2bT4JzpWfYQCw2zni38CvmRBHkQmqt1ZlKfLapfeNhtXzZ4RNW3lKESu7iuks1w5Z/0un3jenPzz8rXstXaPZEycpt+MP31rvRXVPyzZx7Urq9pYPKitwCtRwf7kE627/EjAhFjcPKOdz3oF2FOH5iYP7oBxAdGef1XDA3UECrrOlVZAkLDdO8q+9EZi7L7Suup8uEqHj+7WHnHlqf5E3r0gP4DJMZtZ5lD35wkUt00aLlkqCHqheYZo364k5Tm/Sz/JGlNkDgB3Zr5/hlyUYpDpGYE4uEx1Z1aIiLgvJDgbrIVCUE0tIAVt4qvz3gvtvqoxlKBNVOtmbOBCLx7JJ+i9d771dUP7tKDzHh0cAVClZSDn4oy+FHTaoqTpSwGcFMdKxMPQuj/0/MrvxiUEinqLSQo3SgwjjuQmENBMU1XVsRL/LRpA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5207.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8676002)(110136005)(66446008)(64756008)(54906003)(66556008)(2906002)(66476007)(66946007)(83380400001)(6636002)(86362001)(186003)(82960400001)(8936002)(76116006)(316002)(122000001)(71200400001)(53546011)(33656002)(9686003)(38100700002)(7696005)(55016002)(52536014)(26005)(508600001)(5660300002)(6506007)(38070700005)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?joObT/GAVcqp7PiWCoVZ+9qmYV9tzYd3GFWt/M9l/6DN1G+2RzaiyMc4RMB7?= =?us-ascii?Q?Za8wP8VYFGzPRNl95YN4c/WPQQpm92zokwWUY5xG0+15w91+cc50lOjIEWfG?= =?us-ascii?Q?qe2XgXxOiIyGVsixedk6IPzwKwow+IkbMVUSRED1xc7OO6nP1HcemYcHiM0x?= =?us-ascii?Q?uGp9R2apnVdSa3PU7mJsnr2Qwm4cCiFbY66flpsMtYbw+Z6R+jq5v9H3wg7C?= =?us-ascii?Q?HLWoPeU+aC592FNf7f9x4aEfN+px5P/UXhyk91FfVMXgLIV22ZGhC/jgEnzP?= =?us-ascii?Q?L7i9pWa+5T6vPmpnqI0c+di50oYFbMRpfxM1w8X04eT0s7rRNUk693FodU7q?= =?us-ascii?Q?KVw1oLCIXjqi4fh+ycoqOc09l1uKoghE6/RYn/fOeJHWU3LI4jyQv59LbMAb?= =?us-ascii?Q?M5uFRsf6NarxWnQYSgJ+ZvsZy2JpIxD578gI2VNzPxmg7SJd02Kz2DuIffJ6?= =?us-ascii?Q?BNpYe3CmZ6A4FN0Iy7T779HxwP0xVB9IKu1DuROoanLc8Wg28yHsyeFoT5Zz?= =?us-ascii?Q?yIZns7CFZ7zHnpFU7NKFQDBsIfwTUFbyPK3MECGJy7/B0JTDSrRyCa8dCCEC?= =?us-ascii?Q?OOcjuAf/E2l0Odeq8Vk5wnY/X6nJmyn44/zF4OUbldv44dfW8Yj08goZSbpZ?= =?us-ascii?Q?jHlCBoPl7XxqIsAPo4lOYfkeD77QunqVbVrto8uGF2Ai0Stb4Bmujvay48gD?= =?us-ascii?Q?iYsi1YEwavF/mnkB8lzHSwHPY0ReQBA4uEnL/QASRBFGCC5An8SzbDQzbwfS?= =?us-ascii?Q?TNV02eI+LtjmP+BvUj7ThytssjHTqT5PDWpfnp2PKUcVd53juXGU+Z4zfXKe?= =?us-ascii?Q?yxcPPbFVv1J6aszbO4WP3s+g4qTo6kk4BSWoKaLiDvffXgtj2FT9uFFFUQWv?= =?us-ascii?Q?S11VxAKImYYMyya3dV4ZZTyigxYNTO6j8l0T+bpO0JTosUA4umJZhOWiQ8Os?= =?us-ascii?Q?fyhXfOnfsAkaYeV6ise5A97LKdJhRdl4EQtwWGsP2mSybwbVaJUmKblKe1eN?= =?us-ascii?Q?JIbP0NOMGtMB3AkEl+EM8Gz5ZbRYycqgpgZaHZIfsDmqBs8FRUShTeH+Qg+2?= =?us-ascii?Q?udxz+bh5c7YMewSYwJKq4cQs/pb9drl/JQegz9e2G6cj9dyUpcj9NM3NU9Fr?= =?us-ascii?Q?mVNCCCPY8Yoq4LjMkeGVJi2cwwq8HpydYNoiXGL5NNJFYLX6iE56wMrtDjGH?= =?us-ascii?Q?GRsZ0AK7jSzlrxrjnyfvhA2hdZSWrp0SSGDENzfC7EiFGPEM26t0G1QsH9MJ?= =?us-ascii?Q?Ffv6bUL4nxpef0jmvG3nnDDIFxS/UMHJbN/kQF7TQ6ryIya9BYZkZly532ys?= =?us-ascii?Q?ERIy980K+RqKFzox5oVKf1gAecYa6NkuHYPboTqh0oQ5vqJVNbcUwonphLxI?= =?us-ascii?Q?4Z0jjDEM0RBfPl4To9LyX0nfRDTaM+gjJR//O0IV2H2gI3G+3PH/pfjyj0tV?= =?us-ascii?Q?1bODaIb9jYXXztyPDfh/S9C5TM3zX3hK5MyRmU4fuYVtZWJ1Y1sWCXheSXt9?= =?us-ascii?Q?qlt9vgtW52XuO3symU1xKmge9C169sPA+49g/h057M0L8PyMWNvQ2QZbfaIT?= =?us-ascii?Q?Dn3ndVPRnTzQJaJujnN2RC6npTTi8AKkVU2FiVFT1uY2B+e5AMICcYlUynkl?= =?us-ascii?Q?BdvyoEkFpAaIO8RH4MFkcwQ=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5207.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0f342f4-8bb3-45c2-8778-08d99f7864e6 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2021 09:49:28.6421 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZgdtnaZRxpS+ugH6CtHApKHA5JFkCMXU6FQLnoAvge35ZWLAziKRgbl9Oe/3y+Lop+2MA46S2zywKg2zgboSZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5061 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1] examples/flow_filtering: fix wrong comment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Joyce Kong > Sent: Thursday 4 November 2021 07:34 > To: Walsh, Conor ; Ori Kam ; > Mcnamara, John ; Conor Fogarty > > Cc: dev@dpdk.org; nd ; stable@dpdk.org > Subject: RE: [PATCH v1] examples/flow_filtering: fix wrong comment >=20 > >=20 > > > --- > > > examples/flow_filtering/flow_blocks.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/examples/flow_filtering/flow_blocks.c > > > b/examples/flow_filtering/flow_blocks.c > > > index 3251ed9f8f..b168dc6e71 100644 > > > --- a/examples/flow_filtering/flow_blocks.c > > > +++ b/examples/flow_filtering/flow_blocks.c > > > @@ -75,7 +75,7 @@ generate_ipv4_flow(uint16_t port_id, uint16_t rx_q, > > > * ipv4 we set this level to allow all. > > > */ > > > > > > - /* IPv4 we set this level to allow all. 8< */ > > > + /* ETH we set this level to allow all. 8< */ > > > pattern[0].type =3D RTE_FLOW_ITEM_TYPE_ETH; > > > /* >8 End of setting the first level of the pattern. */ > > > > Hi Joyce, > > > > This can't be applied as is, it will break the docs build as follows: > > doc/guides/sample_app_ug/flow_filtering.rst:225: WARNING: start-after > > pattern not found: IPv4 we set this level to allow all. 8< > > > > The comment is a tag used by the docs to locate a snippet within the co= de > so > > the corresponding tag must be changed in the docs. > > The following must be added to this patch: > > > > diff --git a/doc/guides/sample_app_ug/flow_filtering.rst > > b/doc/guides/sample_app_ug/flow_filtering.rst > > index 11da9148ca..e8605f36f2 100644 > > --- a/doc/guides/sample_app_ug/flow_filtering.rst > > +++ b/doc/guides/sample_app_ug/flow_filtering.rst > > @@ -224,7 +224,7 @@ Setting the first level of the pattern ETH: > > > > .. literalinclude:: ../../../examples/flow_filtering/flow_blocks.c > > :language: c > > - :start-after: IPv4 we set this level to allow all. 8< > > + :start-after: ETH we set this level to allow all. 8< > > :end-before: >8 End of setting the first level of the pattern. > > :dedent: 1 > > > > Thanks, > > Conor. >=20 > Hi Conor, please see V2. >=20 > Thanks, Joyce Hi Joyce, v2 looks correct to me, I will apply my tag to v2 now. Thanks, Conor.