RE: [PATCH v7] sched: enable traffic class oversubscription conditionally

["Danilewicz, MarcinX" <marcinx.danilewicz@intel.com>]

Hi Cristian,

Please find inline answers:

> > History:
> > - v1 - TC OV disabled by default
> > - v2 - throughput improvements
> > - v3, v4, v5 - changes from comments
> > - v6 - removed rte_sched_subport_tc_ov_config declaration and map
> > - v7 - changes from comments on v6
> 
> I see you moved the history a bit below, but still this is not the proper place
> for it.
> 
> > ---
> 
> This is the place for the history log. Please note the "---" line above.
I see. 


> 
> Still only changes in rte_sched.c and no change in rte_sched.h for the API to
> configure this feature?

Yes, because you said to remove whole 
rte_sched_subport_tc_ov_config(struct rte_sched_port *port,
	uint32_t subport_id,
	bool tc_ov_enable)
here as comment to v4:
> >
> > This function should not exist, please remove it and keep the initial code that
> > computes the tc_ov related variable regardless of whether tc_ov is enabled
> or
> > not.

And by the latest other changes the TC OV is enabled by default. All other init for this feature is done with sched init as per yours other explanations. In turn any can change this new flag, but apparently in code without proper API for that?

Isnt that what you wanted?


BR,
/Marcin

Ps meanwhile I am pushing v8 with --- at the right place.

--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.