From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38126A0543; Mon, 30 May 2022 15:34:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F1EB40694; Mon, 30 May 2022 15:34:28 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 9B976400D6 for ; Mon, 30 May 2022 15:34:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653917666; x=1685453666; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=Mf/CQMbM70OIv/0eKX1CdyHZduCqziVC9c1sf9DF98g=; b=RzpPCqP0FQOj2/n/6RwOUMHjxDbGkK9g6S8OhIMaulZw5MILLhXJY5B7 xlUhhq8Tj8N492rrvDBzszd1JIMmWxG29Ua2NgWRVhYZhMqCR1qSEuzDK BOtPnwY6QH3cJW3KJecWpzXLNHdJcO4jTqCre9YAG/Mx64G395tGtEEtX Ol+pNJZXq6mjmuZzGZrGVB3B29Nxgzoa7uYMa2FF5elRmD7dcA9vMu/yk 9G1Yuv/hT9EDywDJ+LnvRhCM7zr+xbeAOT3GRZnRiqFMIha3haETi8MuY yURzrbj8W3c1vW7rAFn1M7cIlbEUaT60irHKjud8xwxO++TbmlR86S32Y w==; X-IronPort-AV: E=McAfee;i="6400,9594,10362"; a="272573100" X-IronPort-AV: E=Sophos;i="5.91,263,1647327600"; d="scan'208";a="272573100" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2022 06:34:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,263,1647327600"; d="scan'208";a="529176775" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 30 May 2022 06:34:25 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 30 May 2022 06:34:25 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 30 May 2022 06:34:24 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 30 May 2022 06:34:24 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 30 May 2022 06:34:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D+DzycfheWOgolLaxmAd1UhSUWPlzC4mi1QviGq0Amsw4zSY4sRJYD2GV9XHsT7Db1aP7ukpuNUPttflO6au5OozDHBj2c8xA1GiFC4iidAEOrcuD4MCu5O+9wC0VtvBbuxQNWZLufoItgKUh7W849zucDodO1pcUp5FkRiPojaBOg1BIcHomMfqe7O9TI+d2n7K9Od2gTZsMC2lELmIMJ08rAYkjRrgUFS8u645YFdugoGZxGdMTQPloCsPBJgaxQFhEybtvKPHDawle6ver4kTPtp1b7r6mEQvdkZdo3MqUYoBMmjEmES/eRQmalt7V7C62qa+DQm8+qmiJ9WykQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=neCCCWVFza5YzQ9+LGIZcgJoKDTkxDxMf43J3Y8FDOE=; b=arsEc7+01ZSnB15GV8fhHo5M4+4eWcF5i1FWnGWP2nLSSxWXZfDIzt25GOOFCTppw8HaIs6oRIL/hBTnjawdwIiAFGgIfiIQRxwguIK+LMF5ld3jhiUygU0Kk0xDZbnkshE8datgVZLbcUkj2GLSRDKkNuzf2qwwHLA6sd9E9UTPL8bVn6lacL8hurQBp2KSmq+b8yB7ky0KaGMKNMwBpS9yGwmJbccZWOK30MAq9UVr1kZ81zY8FyMBDSg74l8THWYO49E+1jYlQGdoTAQRdg7qu81bcww6ipuPag5+j43REQ2kXLWVU0vMOiVn3LiD149vsdwU2beCG9jd85NyTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5784.namprd11.prod.outlook.com (2603:10b6:510:129::22) by BN6PR1101MB2225.namprd11.prod.outlook.com (2603:10b6:405:58::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Mon, 30 May 2022 13:34:22 +0000 Received: from PH0PR11MB5784.namprd11.prod.outlook.com ([fe80::2de4:72f5:cf30:ba97]) by PH0PR11MB5784.namprd11.prod.outlook.com ([fe80::2de4:72f5:cf30:ba97%9]) with mapi id 15.20.5273.023; Mon, 30 May 2022 13:34:22 +0000 From: "Danilewicz, MarcinX" To: "Dumitrescu, Cristian" , "dev@dpdk.org" , "Singh, Jasvinder" CC: "Ajmera, Megha" , "Liu, Yu Y" Subject: RE: [PATCH v7] sched: enable traffic class oversubscription conditionally Thread-Topic: [PATCH v7] sched: enable traffic class oversubscription conditionally Thread-Index: AQHYdBwgzxwMSqXjFEatRQ8L+0zZQq03VKhQgAAVSnA= Date: Mon, 30 May 2022 13:34:22 +0000 Message-ID: References: <20220530084520.827724-1-marcinx.danilewicz@intel.com> <20220530115500.829250-1-marcinx.danilewicz@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bda5ec59-b94f-4bf9-db59-08da42411b21 x-ms-traffictypediagnostic: BN6PR1101MB2225:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DV/CUiYfVr0pTZj1meT7YFUFMfJ6bgDtuKtHMt6680QkgyfYP7zGja4/BHuVr8INvotICs16wDtT0IVlic2Wq31xgfs1yStbfSKugdIRn48h/j75bY1dEwAb670wIXmvODZaNKSKuFSFYRjisEehnnBDQSmUT8MY1J5Yj1cbqHwjjdVIT3Yh4N+EvFEWDf1sJZQs1ZIXUX5p5rx/wr4K5PRO8GXB3J2CA/13mtCiorVJI06VEgllzkggE1XDmL5jYVV4+YKMfcGf/bp+Yf72eMlotuq/W+hAf2eeGv7hx4/eKecmwRM39Mn2uBdVui6IPYRB9k3IIAcm7PVAqtoT7hU/bOFJs3speuz5RxyP+I3I9EJoytTzPCEO81k0Wd6Ufw56tVAL0Lzp0whmqedsta3l6Vbm52w7C4YN6mg76hLsqheNXFOoqJayzcaFL9DSUmwyS9SqOdn8XLFcnXxWMKJ/9TrQpo59FlT9gScD3CMYralCSHhlkQ2RatT0V05GxcUBx7PTY1qBHUR+oCGwMqANyrqhzx1z/9osk3EfHuYcyvWt0wAjSNAPtd3x22ZObuZ2K7+tEsHqWqL0/p9hqXgFOubEuTZVV5WesqG33zkoCUX4mqjLxPr9WTyPvFDAM1BPsL/Lxvj/R7svvTBJyn+6MIIR543rkiDVJMgUr9ASzZCBZpYuE1TKSnqP4yXORyraKsz8by6zp/MC77+6XQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5784.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(8936002)(4326008)(33656002)(52536014)(64756008)(66446008)(66476007)(66556008)(110136005)(54906003)(66946007)(122000001)(8676002)(82960400001)(76116006)(26005)(316002)(6506007)(2906002)(6636002)(9686003)(83380400001)(86362001)(107886003)(5660300002)(55016003)(71200400001)(508600001)(38100700002)(186003)(38070700005)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?V4kiqaaOVSDwuBcQPw2XoYRXrIBaU07FFzEsIad+q7+9lo2sKTJB1wJNpQGk?= =?us-ascii?Q?AkW3SxIIc80RY7LvC6/6doezREcO3nJb3atQ79UrYdd3EHZq65nkCX8UMpvl?= =?us-ascii?Q?LEzgsiDG0/Sn0ghzzmgkmzuc4lhwOie1r+K6GfnHjB+Rs6upVITSKUEO71X2?= =?us-ascii?Q?+4xP3zSDzgJMnI1O8AYjUpGizWdyf/5KAYWDhon5aIlmBc6D7yfyx3912aQE?= =?us-ascii?Q?jUU2NAwrkACtT2fYtgr8l33Ic2sTZoxz8HZLmGOsTMRu30dDPtuYopXUujDA?= =?us-ascii?Q?bQgG8TkzUh5NxFZ6xF5KKJKE0Re80+oVOZKwERRDR0VuiZYpmtcaGaAn6otT?= =?us-ascii?Q?++sZPzcpxWfVwtjT97sv/2WE0XhawpGGcnQxBCKYwCnPxuB1lm/JHvGUp/Vq?= =?us-ascii?Q?c91ABwlQERWBMx8nvygpX75ystdkzCVE/zuwaMOrVQEyb4svdECKo1i8jzmI?= =?us-ascii?Q?J9g1OjI0veZ+PmxP/zFUCbo+05TiPOMZgZ94iInXD/TGPpuoE4z1P6YlTwHo?= =?us-ascii?Q?LzzZmCjiivV16CHULu0lJOytLOrLsu9iFH9qISaE3Cd0cxszVPFCb382V/9K?= =?us-ascii?Q?5rPhm6SfEInu23CBQSE8yXL0pTwJ/5IpOl6mCQwA0StnF5+MQ5UHWRrVmClA?= =?us-ascii?Q?RnMQyz3SUN2WQqWxq4NTiPiV7YSPn/tkgmaecctdGNk+vQxuoaKXRXX1h89K?= =?us-ascii?Q?0HBKgSViInTmGt6FTntf1Bl9Tj3QSi4o+xK5lAsfDG+KGVI1Nx/jVLQ8kRqG?= =?us-ascii?Q?ih6aeKptikpYFVzIcGXgYKvxFD5VYIJD9299j5p0JsM4fEmK7tJo3uoZ6ACI?= =?us-ascii?Q?DXRzW8zoTpqEBwvValBAqccqvo1vqCUxC/mgPqWp4byO+JhEkB/sUhll0Hit?= =?us-ascii?Q?oSBs2arJrHcYZmFbrZ/nwQr4ZugAuga7bc4y3RFMKK8zcAvUCSgMAcWaE8Ns?= =?us-ascii?Q?LykTt13UowzZYD6Xf9rR9HPj4QUa02vowQsByuBAytyUNd4LniXGuedkrIIs?= =?us-ascii?Q?WmZBvo7hgKCHLFvP/thnezoo4ykEKlByZZg9fn0jDV6pkgc5kClbUgb4Jh0u?= =?us-ascii?Q?O4Z8M23o2C2nAELBJrE3smd5GiasS0ufI7kALhSPcafSoJCwytLJaRGRZUbt?= =?us-ascii?Q?jV2Wy1+cGqzIVryuw6cS/PjFTf3G9Heejn2BqHaEolxykLsgzsAYeuo6Ks+0?= =?us-ascii?Q?i2DpMsEGHTDHpl6OT+oVVM6yRQ9hj83bctlqa1kIw/aRlwilxj2ftDLrWyYB?= =?us-ascii?Q?uZUaDEEFnuns72bcjb+4IZCxfyL6lKpiiEE4QmR8ToEm5qgpmbbqzHWEa1kW?= =?us-ascii?Q?1Gt11sQrXd2KluOqZdI3whEWejXmipP1tdOE9m2Q3wClG4hYLrsDqPl0q8Qh?= =?us-ascii?Q?CUSf8is2wiCRkNDcAeq0iDDQ9YIGgzGb8HUi136Sn2nDfqxX/I+yVi23Bbyr?= =?us-ascii?Q?1r4fMFc8Gshx1A8rfMj/EHjv/jU7GTUhXSGhkZCUum0jbbXrVeztceiEEVys?= =?us-ascii?Q?hZNFindbtYHgT5jzcMND589rBfMTB5R4PJWCr+ODhG/XRCsG2Q2hhjHV3gu0?= =?us-ascii?Q?JSB9Rfp4EUIzaLx/T+FHGoDLpXP/AV665FsEEbC8jVJ0+wm1ydPYVxp36XSj?= =?us-ascii?Q?KZkSum2G+8yYyfSuSeUkmtR/BbgGGiHvgtc6AHKVSX0w7l1fts4w7mUfUTYO?= =?us-ascii?Q?iZ1tql/lk7NmVUmr9Tl2cFItJqAE43Pqy+mq6gGEQ66tLkq5pSRPuEvrutMv?= =?us-ascii?Q?8gvDMWthrlUWT2S+8y84x2C63lqnGj4=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5784.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bda5ec59-b94f-4bf9-db59-08da42411b21 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2022 13:34:22.1544 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +mRxSiygUuCemo24q56T2y+BWmntSwLb/hKp3FhBNeuLwl2oitcMHJIjMsIZ6m9U7EK9i1AFZMRqZdQaEnoCxzHFf0fhIE+taT/2wfrh8LA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2225 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Cristian, Please find inline answers: > > History: > > - v1 - TC OV disabled by default > > - v2 - throughput improvements > > - v3, v4, v5 - changes from comments > > - v6 - removed rte_sched_subport_tc_ov_config declaration and map > > - v7 - changes from comments on v6 > = > I see you moved the history a bit below, but still this is not the proper= place > for it. > = > > --- > = > This is the place for the history log. Please note the "---" line above. I see. = > = > Still only changes in rte_sched.c and no change in rte_sched.h for the AP= I to > configure this feature? Yes, because you said to remove whole = rte_sched_subport_tc_ov_config(struct rte_sched_port *port, uint32_t subport_id, bool tc_ov_enable) here as comment to v4: > > > > This function should not exist, please remove it and keep the initial c= ode that > > computes the tc_ov related variable regardless of whether tc_ov is enab= led > or > > not. And by the latest other changes the TC OV is enabled by default. All other = init for this feature is done with sched init as per yours other explanatio= ns. In turn any can change this new flag, but apparently in code without pr= oper API for that? Isnt that what you wanted? BR, /Marcin Ps meanwhile I am pushing v8 with --- at the right place. -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact = the sender and delete all copies.