DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Hu, Zhigang" <zhigang.hu@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "Dong, Yao" <yao.dong@intel.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: The question for the modification against (lib/cryptodev/rte_cryptodev.h) in commit 719834a6
Date: Thu, 19 Dec 2024 10:41:13 +0000	[thread overview]
Message-ID: <PH0PR11MB57845FF3ACDF02982A05C0A588062@PH0PR11MB5784.namprd11.prod.outlook.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 740 bytes --]

Hi, experts,

My C++ program calls some functions defined in lib/cryptodev/rte_cryptodev.h. After upgrading dpdk from 23.11 to 24.11, my C++ program failed to be complied.  It looks like that the cimmit 719834a6 caused my issue.

It seems that the commit 719834a6 intends to exclude all head files from the
#ifdef __cplusplus
extern "C" {
#endif
......
#ifdef __cplusplus
}
#endif
Unfortunately some function declarations are also excluded wrongly since these declarations are before the last head file. Below picture is an example. The function in the red circle can't be linked by C++ complier. Would you please help to check this issue?

Best regards!
Hu Zhigang
    
[cid:bbf5bf01-e72e-42b0-8b1a-fc627fbb1dc5]

[-- Attachment #1.2: Type: text/html, Size: 4833 bytes --]

[-- Attachment #2: image.png --]
[-- Type: image/png, Size: 90739 bytes --]

             reply	other threads:[~2024-12-19 11:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-19 10:41 Hu, Zhigang [this message]
2024-12-19 11:45 ` [PATCH] cryptodev: fix C++ include Thomas Monjalon
2024-12-19 12:24   ` [EXTERNAL] " Akhil Goyal
2024-12-19 12:36     ` Thomas Monjalon
2024-12-19 11:48 ` The question for the modification against (lib/cryptodev/rte_cryptodev.h) in commit 719834a6 Thomas Monjalon
2024-12-19 13:30 ` [PATCH v2] cryptodev: fix C++ include Thomas Monjalon
2024-12-19 15:37   ` David Marchand
2024-12-19 16:36     ` Mattias Rönnblom
2024-12-19 16:34   ` Mattias Rönnblom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR11MB57845FF3ACDF02982A05C0A588062@PH0PR11MB5784.namprd11.prod.outlook.com \
    --to=zhigang.hu@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=yao.dong@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).