From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B06AA0558; Wed, 25 May 2022 16:19:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 445D740151; Wed, 25 May 2022 16:19:07 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 45C83400EF for ; Wed, 25 May 2022 16:19:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653488345; x=1685024345; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=TWk7opx/erp+t70OsCQVx7vJoVaWJ8dyT0gki42sHKE=; b=JaeRLD0f59ohvODugKphVoX8RBVBY4CoHawDq1vGiHS/jhrDvRDMv+AX jbi25YDci2rAHE/rrC0bovJ2t6I/UTcCjvuHWBcnHOMUcCeopa0CfZefz 9wg1n7dK3woeUbFOo9tsnPueFhM5eDVATkrkP637JJtULQp5AnqnSKrpg zMl2jPUUq2ZGOVW17ykAA5E7ryQxjaEBsnT19SvgPz8g32mwXnpR55D3g E3jO2G7YZDD22TLDdqCOebsxsjn5f9DWixYxE2mglfuqPCbhkYS3eWi1n VkHS3SWk9Jg5OUeBicnd75GZmrWk68we3wLljseiiu1ouIb9+8ynFGdMq A==; X-IronPort-AV: E=McAfee;i="6400,9594,10358"; a="273934496" X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="273934496" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2022 07:19:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="549040559" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga006.jf.intel.com with ESMTP; 25 May 2022 07:19:03 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 25 May 2022 07:19:03 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 25 May 2022 07:19:03 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 25 May 2022 07:19:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ksy10aPLwFFAZVVDJez0U3c2qWyGZrD7DkvOwXUBzX0J62fa8yJYQ4XWO+RJ/J4vZbXYQbeFJwWjnAqSAgRGXA8+DdAhM/546CwSautgxtB4TEbYKW1NCU0Fs5CnEaM95d7FRmAEWf2NEjeirvGsYGzrM0TX7LBO0h51IssU4iPxsI61RQLK7cDqOW10tC3WfSl9NnMFFEVfgVB4RUuHuVJf+tQ9pQ9dUNK4Ej8MMkt/nn0fvd1jbDjlizFBXXSEd23hnlCkiseYJTzhxS8PDR7HtnOj+iwIQdVL+1cg2UlHPaF8U3Ue4y91qZ4vproCXJwnpPo7V4vhRAm8Kb+FKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5pZDRXS7kHOfeJ2FiluHvsSbOGokKq69GswosRFg5Wk=; b=djDAni7ZEGgbJY2xUhV6PonEQ85t+nAjZ5mDNmrk6+jcUYwukYn5/kb6uLnD2Uh4LsjJufJydkhM5fOiohgw9W9W+LzJ1LFiAr+qzeo4+uqNcFNmX7omnsL4CMdXxcKpcq/dIa132lHhVkyNbGhDicRL3jGh3RR3hSc7x+QumM25qOdE09jlCUzbthb9+C8E1Xl3A3I8RnMbOAi9dYg4TWAyJtBKfn7TDo/OYIvBvzwyMsc0qQhCyYvDRlywjbPLbHeK5KxM0hoUUxS2ojj3uZ4oNANYLIu13zkAouX+WPWhOmQfMrJHeNEitu0XXxwBQqUNPaCN9I0Y+U3wrY1j5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5784.namprd11.prod.outlook.com (2603:10b6:510:129::22) by BN6PR11MB1923.namprd11.prod.outlook.com (2603:10b6:404:107::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 14:19:00 +0000 Received: from PH0PR11MB5784.namprd11.prod.outlook.com ([fe80::2de4:72f5:cf30:ba97]) by PH0PR11MB5784.namprd11.prod.outlook.com ([fe80::2de4:72f5:cf30:ba97%9]) with mapi id 15.20.5273.023; Wed, 25 May 2022 14:18:59 +0000 From: "Danilewicz, MarcinX" To: "Dumitrescu, Cristian" , "dev@dpdk.org" , "Singh, Jasvinder" CC: "Ajmera, Megha" , "Thakur, Sham Singh" , "Mcnamara, John" , "Devlin, Michelle" Subject: RE: [PATCH v4] sched: enable traffic class oversubscription conditionally Thread-Topic: [PATCH v4] sched: enable traffic class oversubscription conditionally Thread-Index: AQHYb3RJxdA3zlkcaE2KUjxJlDmO1q0uFS9QgAGPYYA= Date: Wed, 25 May 2022 14:18:59 +0000 Message-ID: References: <20220427092357.491720-1-marcinx.danilewicz@intel.com> <20220524134332.644318-1-marcinx.danilewicz@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 88f91803-1b2e-46bd-152e-08da3e5982e1 x-ms-traffictypediagnostic: BN6PR11MB1923:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yFTdcSD7GhFCBIwadJJiaxDd8rVEu00R2740yXBW2jtNoEJQSUDI/W+wKLw20tKqv/zXA5vgVKWIRn25+yeh7wCg5Y2ZGNYx/zHRZxDBCG+bNXOpND8f7dFAjTrR159dUjZjBSToUB0f+g/sBGDHGYb/teOHtStcc+1LRfWjWyIqeCvZ7YOpco9PVBB4u/ggvEd8AfNC+geuvS16TGLBuRGSgwesJUpgtjJLUGkXOYW8cez1EpDy+C/xm7/GtD0AO2M2ss9QzCbOWLgVEC/MMvqB29QIUMUb52SDhAICncUVluL11rWKcxnGxc6/xMi7hCoAT5sOb4Ghc4uxI72tpC0StKP0IEougt60vzalVOXrXsOi7x6N5IcBw8EDHWcz8X+t1Hafw7muZ4btPZ6g0pLNRkINDvwYRrdV5VNP0U3kRuuHF74vxq9TiLAD/OtCkcwhj/GWujS0nEgZ5DiX/PehIoiT59EfHNNo19T2QWv1MoPb5ZhP61nWIVmPOX1zCrWlpYWACrcoliGw7T1z9l23lXyZFmFrqNNQs9pSf/1wnSTg+IgO5wFzMsb+XHD/xx398lCGlQq6/FQpWYqhUMjY7Z7jMHap/3NDkOdqc4t+gdyh3U9BLCmptvVS3Mk3y9R9UUMEDmsFsGlEHXXkR8b2bjzOxj4lG5dTGYUB9zYAu8rey2L3EWOEE7h+s34rJZonCX73/ELsvnNqpA8VpQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5784.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(86362001)(8936002)(71200400001)(186003)(66946007)(33656002)(83380400001)(53546011)(2906002)(5660300002)(508600001)(38070700005)(7696005)(6506007)(38100700002)(9686003)(4326008)(82960400001)(76116006)(6636002)(52536014)(64756008)(8676002)(66556008)(55016003)(66476007)(66446008)(316002)(107886003)(122000001)(110136005)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?peJF9IyyqBJmdf9cc3MzgoCTE9yBkZ53ll7pyw59GCmc6/+jj7TEmfZx+Qn2?= =?us-ascii?Q?HdnBX3P0F/2GK92oCZQFg4m0ax8TIH9dKaEBylx1e9pjaRhzljPnGf2H0abS?= =?us-ascii?Q?SDSoctcxh+uPu3CCEjr+aimXH03YD6YdB9jJb35OEI8iWMbQwfQwWFhOzPCY?= =?us-ascii?Q?i5bKblWO/O6q9uH2S7tittRf2KT8sA3+ZsD9OiNh+HGDsy66IH9ba2a9lbKp?= =?us-ascii?Q?JqOS91PMgWHRZSC8vaIAAmn+kBVr+XomTbQdI0ZWAJu7KQx4UJaRCV4IF+mx?= =?us-ascii?Q?8KsAFGR+AgZ7CPy0eyfFuYGT2sZUuzCrvxKdAPsKL1iD0owiZ7wEhTOOHHoM?= =?us-ascii?Q?c8nfFJkWOj2MzSETf+xAUj0VQQlBlXCAPAuPQdiGKDdHl1QGeU1tsViAhLpB?= =?us-ascii?Q?k9gtlM6CHUB1Vncqy10RfePolFYQhf09vqnpjqEsO3R6qQNlrUt9ExYpT8az?= =?us-ascii?Q?oIIFDESnS9BYpE5X4h2F3Fw0wTtR0BlisHkzidWGkztxocm7syh2GJ3eT75S?= =?us-ascii?Q?MTRblxD+XQBYATHFSPJNDtbg42O1eG4hodbtv4zAIa+xUDLuFPMPGvzfBWqM?= =?us-ascii?Q?jDtiT/1WBImXw4K1CE304Nwlf5+J53C6bkCtmAps25txVY7OE5k/zx1FtSjs?= =?us-ascii?Q?smW76WHkSJgQbDLllmMuE7nssOQ1OlT3MWgZdlLM0HCuJXaJ1zX12urQy2/r?= =?us-ascii?Q?wZvK9D0Qi3VH3beUANBimAVEZ8pxIR1Hfhw2rFnO5vG0gWW7Ro3KQf4kss6F?= =?us-ascii?Q?fGJatu8W5sgnTB0hFEGNTHpGR2SZ4ufwEI1vmS33EmKAiBhfNZfheLmD9qNd?= =?us-ascii?Q?ji0DAhRR29Ih6w9W47anyKr4cCr2/Nw3tQsAMYO7zH+zhtX07oqEkpvANu+/?= =?us-ascii?Q?9aFb2nCMDcSP/m73Kl8pSR3ru0Xfdt5TpSuiHnufhh2PzbBQRkbAoSRJDn5t?= =?us-ascii?Q?Q8CJDY4RkoDN06JPlFnSIo26X+MgnVc2/PUfjap7L1ELqlUWy7Cia/N2qt9K?= =?us-ascii?Q?HfZXAlzC//KSO1ofi61gmnwwUYqo6EAMk+c3iYT1yE+stJMOwiM6ObtTnQg5?= =?us-ascii?Q?//h7sVY7Q3fNsoZlFSZy6rb545qmtNSyw8xMIP0YMRMzmzSZ/fkcV6bJ6MTM?= =?us-ascii?Q?nyW4Cn3dqlwWFVmbzNsI4q2Bc1jWDOc+QjipjMUyOtXCzOUgOQebmms6CF1g?= =?us-ascii?Q?GAT6izAufWStlYzxX9O4vlDMGZvhorYJGqEokswqxeb5sqh+DitwvdfPcQNb?= =?us-ascii?Q?RWVCKaUmxtCvUln43Q/WnDP1kJGYysydVqMi1sUdx09FbDAyDeNpD10J5Bl6?= =?us-ascii?Q?ZXUf8GohITsppjjNeYIi01r5sA29qEJzaH/mmiVjQdYXPLvLLJ3EeMXjUJ7d?= =?us-ascii?Q?1mkinIXEv+ey5UH4+Z17cVTvl/bgH+audcCLBjWXfpvNAU8M88G8nbWTJMhc?= =?us-ascii?Q?ls4mn/qPKRCYxjnOyI9TO/A2EieF4SKopwVrBm8LAbpeNeAss/LobEREzxHT?= =?us-ascii?Q?VSpY871xZ/jqn1UnoZJQEy1PC8+Wt9T5Wk1T73Ll4LIStuX4R/TAqlGZZ5K0?= =?us-ascii?Q?wPIL+JCkI9UcWgnZNStmUHH4syow0tUQ1fQuttwMkcX0UMZWp6wwuVikSFYk?= =?us-ascii?Q?e5pykOVXwkANBIwbwCQAG/OpRmzxiKmtltcEdGs6zZu9o69ZBOTpO1CMI4b2?= =?us-ascii?Q?n2jixCCBPhrtaGh2Jb7Jcj/SgS9nwBs9Ar6mOH4nqc3ohanlQTFGqcz4ti0I?= =?us-ascii?Q?ip+E+0QjzxFniZxSlCkGRMspIWi+dQwWsw/zwGXoun6fORr0bXUj5G7vQVTi?= x-ms-exchange-antispam-messagedata-1: IN2uAMw8c3KpC7m/dIxXsSr3ysUNYMLgnyg= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5784.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88f91803-1b2e-46bd-152e-08da3e5982e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2022 14:18:59.4677 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7+tbSeN/TqCfPiHWbc5hItwu4CwFX1p/zDu70QGlMSfWX9YTsLaU2GhqBMYXfEJwkzpYS3piiX5jNI57k271JBskZ3sw3TwJ/XWF9LQYznU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1923 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Cristian, Oh .. you absolutely right. I did not found them all .. I've missed them i= n all unneeded lines when you reply to full source code in message. I'll ad= d changes from rest of the comments asap. BR, /Marcin -----Original Message----- From: Dumitrescu, Cristian = Sent: Tuesday, May 24, 2022 4:30 PM To: Danilewicz, MarcinX ; dev@dpdk.org; Singh= , Jasvinder Cc: Ajmera, Megha ; Thakur, Sham Singh ; Mcnamara, John ; Devlin, Michel= le Subject: RE: [PATCH v4] sched: enable traffic class oversubscription condit= ionally > -----Original Message----- > From: Danilewicz, MarcinX > Sent: Tuesday, May 24, 2022 2:44 PM > To: dev@dpdk.org; Singh, Jasvinder ; = > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v4] sched: enable traffic class oversubscription = > conditionally > = > Added new API to enable or disable TC over subscription for best = > effort traffic class at subport level. > Added changes after review and increased throughput. > = > By default TC OV is disabled. > History: > - v1 - TC OV disabled by default > - v2 - throughput improvements > - v3, v4 - changes from comments > = > Signed-off-by: Marcin Danilewicz > --- > lib/sched/rte_sched.c | 189 +++++++++++++++++++++++++++++++++++------ Marcin, I don't see any of my comments on the previous V3 version addressed. You me= ntion in the change log that you addressed comments, but I see that all my = comments were silently disregarded. Jasvinder also noted the same for his c= omments in a previous version. Please address the comments and do not keep = sending the same code over and over. This change was supposed to be straightforward, but for some reason the pro= gress is extremely slow on your side. I think at this point we are at risk = of missing the RC1 deadline for this feature. Regards, Cristian -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact = the sender and delete all copies.