From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 597C0A0544; Tue, 7 Jun 2022 12:40:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 408BC4021D; Tue, 7 Jun 2022 12:40:48 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id B335840156 for ; Tue, 7 Jun 2022 12:40:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654598446; x=1686134446; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=M8Hn68hcU+IMxh2cAX9UG0kVMYSue++aV+zo5Te+XAI=; b=TA92937dOSvBKlp1LuxWebhDqmPI/otNkzeCRALq0j1jrjpr0W1uzUz+ pMTFK8YpQPIrP/aauJtkQtbRV0a4GiOI8OxvgoQQT9e02GIA3ancz4Q11 EDQZ2IhmVdVlRFQkJJV4Gctj/P0ED7O8/z8PVSQP4Q6mOipFdoLLgu9CF IfRg3Z9RTVqp2u0WrJ+bzn0UvwIbFMfM+w9U9Xv45oAhHLc7m16vlWTtt 3MPI1/LNdCGZFEFy73ZWHEqTEPMma1gKpjJIbkJ3N7oSuxHZIRhDXeLqu QmGWGwoO2nkMxRYAKNvhPesxNySooUzXc+ohSwcnnOj2ut1oEYZYO0dwo w==; X-IronPort-AV: E=McAfee;i="6400,9594,10370"; a="302078712" X-IronPort-AV: E=Sophos;i="5.91,283,1647327600"; d="scan'208";a="302078712" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 03:40:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,283,1647327600"; d="scan'208";a="584145146" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga007.fm.intel.com with ESMTP; 07 Jun 2022 03:40:45 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 7 Jun 2022 03:40:44 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 7 Jun 2022 03:40:44 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 7 Jun 2022 03:40:44 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 7 Jun 2022 03:40:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MpHehI2Te+a7RFbXbXJddCuO69vXqeR4HvQTFlv8CC2zqS/l9anGWtBunZwqP2DS/GZAdG43EJXkCgry2h1WXnd6Plbx9TAb3WvSNxPHYp2uaAMIzzAoZZXE2VY+ap7U14taXOT9NKEznJq3TFLXnrKZNRrhRb9FCL1XTKThU9s0fmXarwg5EM+OkbibKi6XwPwJ/l7vEAkaP7NzC8k70k2hbU/Hw3CXyiMtQtlTz3VI8zRIxdbCqHjnIKEOKDzoTqAkzyvmzt2VYs0X2MlwWP6T/AeeWgXpPHZ+1ZJeFI0Kny02GSqV8Mu90xaZJtm4owqqXyNcYrfiWVr1JUUG3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tmjfx2+jvvAUDwXDxKyZ3YXy3MsI4YkY6rqrj56iEH0=; b=aYIicVqkRmOTLXZIVCVWlZJ9ssyQIaHUkL1w3RBJbZPcKsnl1YKmOc8/kUd/Hq1gQAeCCesPy1t1fUb0FSDP66bSH1MtktaFw30czFFHmmeC5U4oAydVSQSyAmRWzvAlqeJmXr9in/k+HmGDJTDiBqnNebK5GFNmFZxaA05IjiykSq/fz74if3hUgwPlQ7WeRT4QcqocrPKB6ghC8vRCeuubVaohSpMPoOUwMPAazIQHkOOQwmxJ9dUNLmn4YPT8VCneEMmtZZoGMdb/YZ2HUXLHd1qTo25RhBs4RtFPts4bfzqTNFkzhoxBRThNHypj4ZrsSfwOdt5Fwjo078DpvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5784.namprd11.prod.outlook.com (2603:10b6:510:129::22) by DM6PR11MB2636.namprd11.prod.outlook.com (2603:10b6:5:c8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.17; Tue, 7 Jun 2022 10:40:43 +0000 Received: from PH0PR11MB5784.namprd11.prod.outlook.com ([fe80::2de4:72f5:cf30:ba97]) by PH0PR11MB5784.namprd11.prod.outlook.com ([fe80::2de4:72f5:cf30:ba97%9]) with mapi id 15.20.5273.023; Tue, 7 Jun 2022 10:40:43 +0000 From: "Danilewicz, MarcinX" To: "Dumitrescu, Cristian" , "dev@dpdk.org" , "Singh, Jasvinder" CC: "Ajmera, Megha" , "Liu, Yu Y" Subject: RE: [PATCH v2] sched: enable CMAN at runtime Thread-Topic: [PATCH v2] sched: enable CMAN at runtime Thread-Index: AQHYZgGyjgFuks/050iPI+ktClNfX603YlpQgAyEYEA= Date: Tue, 7 Jun 2022 10:40:42 +0000 Message-ID: References: <20220511135304.258809-1-marcinx.danilewicz@intel.com> <20220512131036.507178-1-marcinx.danilewicz@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 315b7624-32d4-4549-9518-08da48722c1b x-ms-traffictypediagnostic: DM6PR11MB2636:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JE0Q4g8rxCS1wmSwAd2Lv6tnckT8rlcWrfAHZPUMMFwhLPvm1sgNM/nRfsgaOyeTknAaQzLfZtyIQguJXDLxtavZ/TILY4z48QGch3dGUG6dzRDIkPaPKRKN3PVAXBe4U6Ek7PYzCIHM1I4DqLQgGmdJQ0PoTJbadYW9vBeWaio1oJVbuyy3w4Y/1N1llnTEKXSGqor8SFdNJntyu+6bIdZsDU6E2Mi824OfelQKYCDGj69WDlBTEeTkEUoKtBfso3yxw3DY9Hace4TmtQFazY4wwTX99JwHrqpGGA5JaHG3WGl1y9bxDJdxurnFPlyZSPmeywrpc5our9UG14/1d98GRhHYcrm1qvo+mDNRVA44oDT+A7bcWEBfHMOwl4Q/47bvrE1TRD48tFBYcvGCHyzE76lfwoslACQJAO9rcMVUOQ4Cg4GPtIiN1U/p+bn7U5M2W3K8uWF+ixg9fIUzZH+3RC1vHZ25Io5CoOnnZTGypAilAdwefEHaqiSboVwUe2J1sx7Hu/Lj575dDEkifDUNBURt/wQ/blZeNToAIh8sQAGc7ItJijMYFJYQXzk0bWH0UTlIkV6c8mrqcK+qyJvieb+/ReU+hYp4sNasOv58BzrjEEOI0BgN7kS5QlGfAJGIKWam9iZejXubuT2klBOMqxVaPVsu9x9recnXjW1khAJrtskQOJR1F1Di9KhPh7v/UPk2CUcVlqVTvRJTrg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5784.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(508600001)(55016003)(33656002)(8936002)(5660300002)(6636002)(52536014)(38100700002)(54906003)(110136005)(7696005)(71200400001)(86362001)(122000001)(64756008)(2906002)(9686003)(6506007)(82960400001)(186003)(316002)(66446008)(38070700005)(66946007)(107886003)(8676002)(4326008)(76116006)(66556008)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Nl7A8orIoA8sVodgmhiO/60ccbzUrA+Qr/orIgBQz9dJ1Iq/+rn0vITpNWq6?= =?us-ascii?Q?51pfqZOLdOkCAtMoenuRIIPT5+bMrvaeEdikpZr+8xhUzOmoJWR1PzuDeama?= =?us-ascii?Q?RftP1yEuGiJmpgscYfL3aE0EZejxQyHPo8ANNcFT3WpEf56/tsAjJajy6bfF?= =?us-ascii?Q?qgC3dVCEmrlJZvP48bFk/MDR5IGKucFTN8KloLagxX+LY1UGsPIsTufP8LC/?= =?us-ascii?Q?AIqPj64M63Z/XoSrMII0Dvnfhy1xo2+m4n0ySLrUnqZlgzMBrS2DWEFSiOvm?= =?us-ascii?Q?IAYO7GysEOaj7znIB7Yiw4CVq6jeCinawSSQeruk68X/uOQI5oM0ORBG7zao?= =?us-ascii?Q?A4eBQn3KuLoGs7wCEWyNTpbKHRzVehjyJ+ER/apCldHQc7O/ZGz7dSkzo18R?= =?us-ascii?Q?haqwnK6CgoFNZ8oVli0QcTeKV7iREdT7x9mfKvg8KzKwRr9m91gNpKx21nVk?= =?us-ascii?Q?bpcCqePDawOolaodjjV2/b/w7hbfTiW9k9I6AWc+K2A5Oaejhq2AU8lwOC62?= =?us-ascii?Q?sQ2B7tk3tiMoYxU0B6VEqdsZ8MjOBGgCLUWj2mSusJ2o8Fh+wMI2qEAijQti?= =?us-ascii?Q?6/yr+UVeTI7hNvs8XR8ceCXOBPrTXy7geYpWOOtj6JN2NTE7NTVAV2uazsah?= =?us-ascii?Q?tpbGFWvBi7knpQsM62+tcY9Ez7nn/ZZHhstZJl/fdFB4ZJwI90Ed3E0ZYgg3?= =?us-ascii?Q?FAZB1v59XCfr18GWv5kyXHAN4qh9UR+7brk5Kma2fxKikhGbdXnvaf7oS6o9?= =?us-ascii?Q?ChhigxikvApXNd4bTLr2I6WuP1fUky80i9whtFPi/sY94STPHZ3gE+zrciUg?= =?us-ascii?Q?ISdpyrkZ7a0D6Ix80xvODx98exsBk/7rElhdJizzh7b/oJArIKpaqegGaneV?= =?us-ascii?Q?z5It3LH72KzB196RVWt5aX2yXTcpwGnua3fPGCRdBqNv8KLbk0tz/CJaNmrJ?= =?us-ascii?Q?MUcqXc+79+gbJ+WizoErVxOQPz8xs/TWJXdVDAIxgeoNIGbyJ74NFzOUf9jY?= =?us-ascii?Q?ec0C4cJTeGm3mYlVwiYIaoo5zCkx1So1xlNMkuLVNyOfyHOnfI7Q6q4ZJ1Of?= =?us-ascii?Q?TVW+S/NVyBEinz6vZrPy914UgOQzJYCzAYATl+TWT6+SNRiDGin9FcIjY0tb?= =?us-ascii?Q?X44MfAfb/YRb6W0AL4+3QlaswDdnV4YlxQGgAbblq5YBoh1zhHLQxNhPJqNA?= =?us-ascii?Q?Enivd1PvlBqS+fYui5EwluQ0fQW9Iddwg9rhvLmbsKicg2yWk5bNjrxs3iiZ?= =?us-ascii?Q?l5jEDJUDYXajvAw3KVUojl0RuNbaZ8YVoBMFFk5YpuDGJ1L3LrwnZK4Hillg?= =?us-ascii?Q?Bqi7M8cTRG20LKz/xUDFo7IMU/Fb3XE+alYPtjrSD4ih7qgRtBB2nXYoAwmm?= =?us-ascii?Q?UtlgBdfzcS2sk0dEkPJWx76wW2c20ZGYQfz31xv/N+WY5fabAATmFuYiYj8r?= =?us-ascii?Q?vUdop6jKGUsQhEcrCODhTdtcCUDOBrOG/M89n5Km4XcM8bXEDosWP/nTfezS?= =?us-ascii?Q?ziTwKPauEk/0buS4UZVw9yWibKOIiaco0tUg2JxOQXc1lazb/IGerCJPbbNK?= =?us-ascii?Q?zgBRZK4tox0jav46akl17SMkmKjYyc5sKeO9qNpbD702Wp32pV8HWDsvkZb+?= =?us-ascii?Q?ONcX270gE5BNrv4VirCU6eZMdEmcb8ftosF0HhNOSI8UQypgihd0tvmTTTZ0?= =?us-ascii?Q?KBq1kpj+JdpJhLfrWq4a9Pp7qbHSnbIC3G1t9DZEyTMe7nKxj+f78PjPRKdT?= =?us-ascii?Q?RLGBqY51Saw6ULnfcg8zIMLwjZCsgtCVMX8NOa88qozHqVSOzMtLaQLHucVj?= x-ms-exchange-antispam-messagedata-1: CP5NO55bdxapDxBQWdU1tUnhY/YoXhHlZ+0= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5784.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 315b7624-32d4-4549-9518-08da48722c1b X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2022 10:40:42.9666 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FxjwKxLqiZnKz8YukO0qqDQtQ/7wdXK3cqhGS0VTRJ+KVxrzHr8UjHUR2xolYFG2JLMeb26vSbTc6yNyeFklhThZD/Dzkpnf5o8BOTu1Csk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2636 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Cristian, Please find answers inline. > > Log: v2 change in rte_sched.h to avoid ABI breakage. Lessons learned, so I have fixed also positioning of this above. =20 > > diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index > > ec74bee939..db14934832 100644 > > --- a/lib/sched/rte_sched.c > > +++ b/lib/sched/rte_sched.c >=20 =20 > Same comment here: yes, remove the #ifdef ... #endif, but no need to > change this code fragment, as it sets correctly the s->cman_enabled flag, > which is then the only flag used by the rest of the code. Again, no need = to > have a CMAN_NONE in the enumeration, as the same is achieved by setting > params->cman_params to NULL. Yes, with that approach this is better. > > qe->stats.n_pkts_dropped +=3D 1; > > qe->stats.n_bytes_dropped +=3D pkt_len; -#ifdef RTE_SCHED_CMAN > > if (subport->cman_enabled) > > qe->stats.n_pkts_cman_dropped +=3D n_pkts_cman_dropped; > -#endif } >=20 > Please don't forget to remove the __rte_unused attribute for the > n_pkts_cman_dropped in the function parameters, right? Nice spot. Looks like this was there for some time. Regards, Marcin