From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5AD3FA034C; Thu, 28 Apr 2022 16:24:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0697B42819; Thu, 28 Apr 2022 16:24:30 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 4E37340E50 for ; Thu, 28 Apr 2022 16:24:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651155868; x=1682691868; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=XYjTo1uSoHFMDXDKoGJJWbVKRXDxgtzg3U8fUj8qDZU=; b=lgLhuA8SoL95Zah3FHNyU9IaQPsr3nzvluOvOzQ7idHrftEoQwuGfvBQ N454wtSgMeUn67keOxMTp137DexwRSS5uHGCjNs3hU/mS/hlKSor+mAl2 cyTzCj2NtvbiGUGlhyxYAwTsbdil1ePqTKe5iOi+oGc3bNwIUOQwYO+oE aDjV0HFB/7FxDWZE1A+pWOrCH5JGGO3Mh3OXA7hKPzoPsrWb/3elDFwnX q4Of1d3dL52wTRpIPDaH4y/SXqwQXbh0jNxo/tByuvdMOg9rIq601Ucf0 I8Jae5lcjOn3PGC8w1nsDRJ63/jDniKyQqkgth/xeRo3FCXLc16JzWS5u w==; X-IronPort-AV: E=McAfee;i="6400,9594,10330"; a="266118982" X-IronPort-AV: E=Sophos;i="5.91,295,1647327600"; d="scan'208";a="266118982" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2022 07:24:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,295,1647327600"; d="scan'208";a="629583208" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga004.fm.intel.com with ESMTP; 28 Apr 2022 07:24:24 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 28 Apr 2022 07:24:22 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 28 Apr 2022 07:24:22 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 28 Apr 2022 07:24:22 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 28 Apr 2022 07:24:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ehZMW+dIHzmJBgjmY7pPJ0I59eJ6HAR9v5EESzPWZROxU5aoYl+REJQYp89eY3RR/mgf6W83Y90i/cVYSXa/jj+bihf1w8YyinawBYuberjoWMIqfE3m24nlsYw4ke9ii2V7SE1C7tOSDz/UkaHJ9T2K3QbVkHrRkHlfzllGY9Z7GNimfsBAXbj4qxw8f4Hm3Fykw8KONTTS0SI9OsbYZHI7VcRS1/WtPxyPfRiN9nQwwm49nLQ1pAJh+uo0aqJTxCUn7XWo86wrYAaalMavh1uaTL7xa2sTyuWwK1t7vmiC3jdwz4XdvLNhHN9kQxE1ebkj7rfeYlh2bSUt05HrwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2d1b+mK0R2k6Y543l5Z9tyMVHEbnh8mmPSzV50LliwU=; b=HKSMllFBO+1byq+0SYTuMWDqHBLEkDDtbStDdNXMYt1U9YcECs8qFi5PMZydB/G++jNcpaXxd9AZn0RE95+wGPdI0698cq/svD7KumSqA4SaInl3dDH2dZ0vA3OeLC3yZlDxbXcmP3zUZOKp764AoJHDh7Q1F292/BP9W7C3Eb0RNGDKAamp2Z4aQPzcf35cRQDGxMD/DbGJF6dlqK2fGAWXufO9TPxEoqesb4fKH68ghU2Pk6C7o2txIoCMACoSAioSZGfc2aSYGWnDNkhQaIh9VqBhfMlQVI6NiIo6IfM15Rrbk5JeWx/1NHm/CSGN+1XHcckbW5JpukacgqTPNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5832.namprd11.prod.outlook.com (2603:10b6:510:141::7) by CY4PR11MB1686.namprd11.prod.outlook.com (2603:10b6:903:30::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Thu, 28 Apr 2022 14:24:18 +0000 Received: from PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::ad86:86fe:a02b:174f]) by PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::ad86:86fe:a02b:174f%5]) with mapi id 15.20.5186.021; Thu, 28 Apr 2022 14:24:17 +0000 From: "Gujjar, Abhinandan S" To: Akhil Goyal , "dev@dpdk.org" CC: "anoobj@marvell.com" , "jerinj@marvell.com" , "Jayatheerthan, Jay" , "Vangati, Narender" , "vfialko@marvell.com" Subject: RE: [PATCH v3 0/7] Add new cryptodev op for event metadata Thread-Topic: [PATCH v3 0/7] Add new cryptodev op for event metadata Thread-Index: AQHYVY1a1pIzXSPQnEWhVoHDc6vAda0FbCJA Date: Thu, 28 Apr 2022 14:24:17 +0000 Message-ID: References: <20220418193325.368313-1-gakhil@marvell.com> <20220421143720.1583062-1-gakhil@marvell.com> In-Reply-To: <20220421143720.1583062-1-gakhil@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.15 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f07ae568-17bb-42b9-3486-08da2922c784 x-ms-traffictypediagnostic: CY4PR11MB1686:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: efN5Qx1T0UGXCDBTUmgvwj//1DxC2ew3jBXeNBj9ORqNv6WfvikGqgFdcl3R/n0W7RYPbYZoYD9bedmTfuwd4iITgbQ+i7v+5tlG2y7fQ4dB6P1Qqa4bejixVBVhld8TJr8C0xi+Ewy22Fvy5SI78++NmdDej+hnDvdKGMJCWbHv+8V2hEBTSC6+6TfJXafL6ZGGtZuXuW5dQfjpqJ2+m1J1YbOOSNYWEQUju4HcWOEGzHNE7FXDBBo5nmC1QeuYoIzBvHJlZ7CUICE58bVdMcGkrzqqXX2EcVkoNhsyOdPuFF4Yy7M+IXE1wQSQX4cMSsjMJSWqJ4QOdOk4aHytNupFTwBQGzUJQKLr3ZdhOI8oIs+5qBp87wjbu63V2E+W+9W4WtXH0dA7vSxAfI+walNWDetQTRV4k6SuaNCdntBSPPQHbMEyUDZSKp6Z6TNXUWhQa+srxf+sKt04KVAsFh1zhAHoWa/g7cvE501Ax/PMjUo2lz8ECTalpaQsikLUXSpW6I5/q6RDdgSVhquyqfSm2d7iywVITymNgofG0M83gXSsOFYezAgO2TV6N4KeBe4LMlfuP+gpw1rkUYf3W4tW/ZnSrMT/2fFZ9nnkfy1my9YvsaxUbHIaUsQcTcjrpajWUHXjSR43bCQ3U9eukks30jZq7qML9845rqra1bzPjVCdirBw194t8jBRbd2rQcvhCeFZv+K3hLddVQTCzg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5832.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(186003)(83380400001)(2906002)(53546011)(33656002)(6506007)(9686003)(7696005)(316002)(86362001)(54906003)(110136005)(508600001)(82960400001)(55236004)(76116006)(5660300002)(52536014)(71200400001)(26005)(4326008)(122000001)(8936002)(38100700002)(38070700005)(66556008)(8676002)(66946007)(66476007)(66446008)(64756008)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SWNOoVbApw+6M6CA0GBQ3gmmSs6GLe/ZIg+wWdSSkghmRA5dQwOuvn3K9kfV?= =?us-ascii?Q?Eyv+j8vkdBX/5bSuN+UIdybhRyD2LrF8fT6UDDsfBTXQJNXfCKVJVZVSV/P5?= =?us-ascii?Q?oUf+tV9xt13owqKz0mOyFVVTGstJsxO99B9YbeiFdpD7VPluCzuHa/7kd42n?= =?us-ascii?Q?LczssBl2YqrY+pLjub7dpUrHDy1Kejn77698gCufw7ayO216vpY8bVM0GKNO?= =?us-ascii?Q?s4WvKhMK+4NrJlG6D+7naNM2gPNimFU+rrz6ZjK9XI0rLz85T0/cRv8Qj3XE?= =?us-ascii?Q?La3IzuydlArb7Gxj3c1BgV23tSOxu6vaj78GRyItOhBL4G0TW98IMk1r+PNb?= =?us-ascii?Q?Ppxr7ZrCVkHh5p4K7/Ln0cB9IPD6LC4gJeg67aNQ3XdWBp/3Jq+NRiynFdNQ?= =?us-ascii?Q?KEI59qFpw+2jII2OT5k+UD6U35tcHDQsC/Q4JfqMgRHRTlEliL7WV73QZxvO?= =?us-ascii?Q?1DBNS2op8mIOGHH0TOyZcdosB83Lb+/21QfAZn/Clrqor8A0ojP0CfbOreTt?= =?us-ascii?Q?mCmXCz8sKdbcF1CCUfl6g5/N2gi0OXjEOJqFkwOrKBdoyTzdY94WS9JWM8k8?= =?us-ascii?Q?myiCv9nkVS+00VtrIdjfPEpDru2IonwsZRKf37xVO9XgV/qGCKD0j6F2rv98?= =?us-ascii?Q?O1rDagshEOaoXheoStf/VHDlfVSkdCK+HVplW5NdWcaiZEsLPIPSCrn3LfLf?= =?us-ascii?Q?Y390ZPEpF99Zlq8V/ev+hIWZp2bqQyaRygRLMBokaxq/gpE7KhpbRA8HmGO2?= =?us-ascii?Q?jeDn9WhoPlmnA+SEHNlpWiY/3L9Ybz55ZilN73XauyHTIYV9JVq4mZYQtOmc?= =?us-ascii?Q?sV7kQP+PFeg+S3ONU/EYtXGrPagJlF/9gqnrgqWd5MYGBOOopkPEjJAyEtj6?= =?us-ascii?Q?S2nUSzusvxQjdZnyzDkAdsnyGv3ADmiiV3dseMInbosyKEBfI4AyEY5Kbrln?= =?us-ascii?Q?OBpQT7QhPJY3ttV+M43SekxjApY0LDVImIVJ3dobeNfDpGA7kOVkTN9xVKyP?= =?us-ascii?Q?PNMvotfcwQlo9WlrKVML9P+XH7BM3vYb8QjWB11w3k5fBJlTc32cUkSRx5YY?= =?us-ascii?Q?vUoKNkU5sp/zwFfMswJXqeOwX6DqzB11jd1gr23FpjMt+1C/YSkt1VstZ3dj?= =?us-ascii?Q?75ygvv/o5qXpO3ykoexh/8kQysPY7dn5jQ8gPX1X6bymofv+EMHCkcvhRqYb?= =?us-ascii?Q?vYR0AAwxxdnCQth5cAccIgs1ZPi6Ux6cJqHLrslaQT2nOTcNHVBqqK9GV4wh?= =?us-ascii?Q?YvwkrOpo4WxJy25iMN4iaTrTd1L2l4OZaTG1rz396SYHtqozvM588Ih0baj9?= =?us-ascii?Q?4UJFHswCws/6tQGcubmQXpNF5BPA1P8BGwsKlXZYskJNYyqjVaybQ3sr/Ua+?= =?us-ascii?Q?Flfk5WBz1KHyxhb/4FcwthTC3XMvneeANdEVK3PWPJ66sz7vK8TRUH44RBLT?= =?us-ascii?Q?i7wLNuoK0qX6h3GEWcco+A8R9yxDsOBAXInbfvzXBPJN8wSi99xqKsP9f2w5?= =?us-ascii?Q?FKs/b3eL+duilHMyDUGo6/CSGZ4vEayToivTlqAOG242VcWFSgvBp6+4G2wx?= =?us-ascii?Q?6PYFc1SqGGFAp7JvqNLFGvHkzOj4jQrGMKEgh607zB87ZIXZcIkzMyV52L3T?= =?us-ascii?Q?Eshb8kgiSfj5KJa2Esb7wUcOMZetOKz12mEkjhtL14qPB4JeHqZLj2I6CTpH?= =?us-ascii?Q?ogGSX0HTbK6rYIXYQyWllquEgcazUscm+fqt9PO6SBral14a+KpYb5KtQ1IF?= =?us-ascii?Q?XX4xwdTJWaQw8hdI6xKIlIuhn12F+/Q=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5832.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f07ae568-17bb-42b9-3486-08da2922c784 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2022 14:24:17.8977 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xPqlqoK+JIfBCPJ+uSQyI1DeDG0C85TPCtwsghavqyboZgTFhgawZ7jklDTxboi53eFsdliaFfQ3tGkUyFDf3Cnboh4DwitpxDd1/TCJ0iI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1686 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Abhinandan Gujjar > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, April 21, 2022 8:07 PM > To: dev@dpdk.org > Cc: anoobj@marvell.com; jerinj@marvell.com; Gujjar, Abhinandan S > ; Jayatheerthan, Jay > ; Vangati, Narender > ; vfialko@marvell.com; Akhil Goyal > > Subject: [PATCH v3 0/7] Add new cryptodev op for event metadata >=20 > For using event crypto metadata, event metadata need to be set in session= . For > this session user data was used for symmetric crypto sessions and no supp= ort > was present for asymmetric and security sessions. > The use of userdata to store event metadata (which is dereferenced in PMD= ) is > not correct as it is meant for the application to use it. > Hence, a new API is created to set and get event crypto metadata which is > scalable to all sessions supported by the crypto PMD. > The application can use the set API to set event metadata and the PMD may > store that inside the session private data and PMD need not use the get A= PI as > it would be internal to the PMD. > For the software event crypto adapter implementation, the eventdev librar= y > can use the get API to get the event metadata stored inside the session > structure. > For Asymmetric sessions, a new field is added inside the session struct w= hich is > internal to library. > For symmetric and security sessions, new field cannot be added as it woul= d be > ABI break. Hence, session userdata is being used to store that as it was = used > earlier. In next ABI break release this would be fixed similar to asymmet= ric > crypto case. >=20 > The patchset also add support for asymmetric crypto adapter in the test > applications and the crypto/cnxk implementation of the new cryptodev op a= nd > corresponding changes in the eventdev lib. >=20 > Changes in v3: > - fix SW adapter case of memory allocation/free of mdata. mdata is alloca= ted in > set API and freed in session clear/destroy. > - mark rte_cryptodev_session_event_mdata_get as internal API as it is onl= y > needed for the app or the PMD. >=20 > changes in v2: > - v1 patchset only fixed security sessions and also caused ABI breakage. > This is fixed in v2. > - added new API for setting event metadata. > - added new cryptodev op which can handle all sessions >=20 >=20 > Akhil Goyal (5): > crypto/octeontx: use new API for event metadata > test/event: use new API to set event crypto metadata > eventdev: use new API to get event crypto metadata > test/event: add asymmetric cases for crypto adapter > test-eventdev: support asym ops for crypto adapter >=20 > Volodymyr Fialko (2): > cryptodev: add APIs to get/set event metadata > crypto/cnxk: add event metadata set operation >=20 > app/test-eventdev/evt_common.h | 2 + > app/test-eventdev/evt_options.c | 17 + > app/test-eventdev/evt_options.h | 4 + > app/test-eventdev/test_perf_atq.c | 12 +- > app/test-eventdev/test_perf_common.c | 254 ++++++++-- > app/test-eventdev/test_perf_common.h | 45 +- > app/test-eventdev/test_perf_queue.c | 12 +- > app/test/test_event_crypto_adapter.c | 503 +++++++++++++++++++- > doc/guides/tools/testeventdev.rst | 5 + > drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 144 +++++- > drivers/crypto/cnxk/cn10k_ipsec.h | 2 + > drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 138 +++++- > drivers/crypto/cnxk/cn9k_ipsec.h | 2 + > drivers/crypto/cnxk/cnxk_ae.h | 2 + > drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 18 - > drivers/crypto/cnxk/cnxk_se.h | 2 + > drivers/crypto/octeontx/otx_cryptodev_ops.c | 20 +- > lib/cryptodev/cryptodev_pmd.c | 16 + > lib/cryptodev/cryptodev_pmd.h | 36 ++ > lib/cryptodev/rte_cryptodev.c | 41 ++ > lib/cryptodev/rte_cryptodev.h | 22 + > lib/cryptodev/version.map | 4 + > lib/eventdev/rte_event_crypto_adapter.c | 55 +-- > 23 files changed, 1168 insertions(+), 188 deletions(-) >=20 > -- > 2.25.1