From: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
To: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"Carrillo, Erik G" <erik.g.carrillo@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>
Subject: RE: [PATCH v3 2/4] eventdev/eth_tx: change eventdev reconfig logic
Date: Mon, 19 Dec 2022 05:49:10 +0000 [thread overview]
Message-ID: <PH0PR11MB58321886222CD8D00161EF8FE8E59@PH0PR11MB5832.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221219053315.2538180-2-s.v.naga.harish.k@intel.com>
Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> -----Original Message-----
> From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Sent: Monday, December 19, 2022 11:03 AM
> To: jerinj@marvell.com; Carrillo, Erik G <erik.g.carrillo@intel.com>; Gujjar,
> Abhinandan S <abhinandan.gujjar@intel.com>
> Cc: dev@dpdk.org; Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> Subject: [PATCH v3 2/4] eventdev/eth_tx: change eventdev reconfig logic
>
> When rte_event_eth_tx_adapter_create() is used for creating adapter
> instance, eventdev is reconfigured with additional
> ``rte_event_dev_config::nb_event_ports`` parameter.
>
> This eventdev reconfig logic is enhanced to increment the
> ``rte_event_dev_config::nb_single_link_event_port_queues``
> parameter if the adapter event port config is of type
> ``RTE_EVENT_PORT_CFG_SINGLE_LINK``.
>
> With this change the application is no longer need to configure the eventdev
> with ``rte_event_dev_config::nb_single_link_event_port_queues``
> parameter required for eth_tx adapter when the adapter is created using
> above mentioned api.
>
> Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> ---
> v2:
> * fix build error in doc/prog_guide
> v3:
> * update doxygen
> ---
> ---
> .../prog_guide/event_ethernet_tx_adapter.rst | 17 +++++++++++++++++
> lib/eventdev/rte_event_eth_tx_adapter.c | 2 ++
> lib/eventdev/rte_event_eth_tx_adapter.h | 13 +++++++++++++
> 3 files changed, 32 insertions(+)
>
> diff --git a/doc/guides/prog_guide/event_ethernet_tx_adapter.rst
> b/doc/guides/prog_guide/event_ethernet_tx_adapter.rst
> index 905cb445e0..8e6cc87b04 100644
> --- a/doc/guides/prog_guide/event_ethernet_tx_adapter.rst
> +++ b/doc/guides/prog_guide/event_ethernet_tx_adapter.rst
> @@ -56,6 +56,23 @@ and needs to create an event port for it. The callback is
> expected to fill the
>
> err = rte_event_eth_tx_adapter_create(id, dev_id, &tx_p_conf);
>
> +Event device configuration for service based adapter
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +
> +When rte_event_eth_tx_adapter_create() is used for creating adapter
> +instance, eventdev is reconfigured with additional
> +``rte_event_dev_config::nb_event_ports`` parameter.
> +This eventdev reconfig logic also increment the
> +``rte_event_dev_config::nb_single_link_event_port_queues``
> +parameter if the adapter event port config is of type
> +``RTE_EVENT_PORT_CFG_SINGLE_LINK``.
> +
> +So the application is no longer need to configure the event device with
> +``rte_event_dev_config::nb_event_ports`` and
> +``rte_event_dev_config::nb_single_link_event_port_queues``
> +parameters required for eth_tx adapter when the adapter is created
> +using above mentioned api.
> +
> Adding Tx Queues to the Adapter Instance
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c
> b/lib/eventdev/rte_event_eth_tx_adapter.c
> index 88309d2aaa..c780ee1264 100644
> --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> @@ -316,6 +316,8 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t
> dev_id,
>
> port_id = dev_conf.nb_event_ports;
> dev_conf.nb_event_ports += 1;
> + if (pc->event_port_cfg & RTE_EVENT_PORT_CFG_SINGLE_LINK)
> + dev_conf.nb_single_link_event_port_queues += 1;
>
> ret = rte_event_dev_configure(dev_id, &dev_conf);
> if (ret) {
> diff --git a/lib/eventdev/rte_event_eth_tx_adapter.h
> b/lib/eventdev/rte_event_eth_tx_adapter.h
> index 645b87b78a..889e09981e 100644
> --- a/lib/eventdev/rte_event_eth_tx_adapter.h
> +++ b/lib/eventdev/rte_event_eth_tx_adapter.h
> @@ -142,6 +142,19 @@ struct rte_event_eth_tx_adapter_stats {
> /**
> * Create a new ethernet Tx adapter with the specified identifier.
> *
> + * When this API is used for creating adapter instance, eventdev is
> + * reconfigured with additional
> + ``rte_event_dev_config::nb_event_ports``
> + * parameter during service initialization. This eventdev reconfig
> + logic also
> + * increment the
> + ``rte_event_dev_config::nb_single_link_event_port_queues``
> + * parameter if the adapter event port config is of type
> + * ``RTE_EVENT_PORT_CFG_SINGLE_LINK``.
> + *
> + * So the application is no longer need to account for
> + * ``rte_event_dev_config::nb_event_ports`` and
> + * ``rte_event_dev_config::nb_single_link_event_port_queues``
> + * parameters required for eth Tx adapter in eventdev configure when
> + * the adapter is created with this api.
> + *
> * @param id
> * The identifier of the ethernet Tx adapter.
> * @param dev_id
> --
> 2.25.1
next prev parent reply other threads:[~2022-12-19 5:49 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 5:55 [PATCH 1/4] eventdev/eth_rx: " Naga Harish K S V
2022-12-14 5:55 ` [PATCH 2/4] eventdev/eth_tx: " Naga Harish K S V
2022-12-14 5:55 ` [PATCH 3/4] eventdev/crypto: " Naga Harish K S V
2022-12-14 5:55 ` [PATCH 4/4] eventdev/timer: " Naga Harish K S V
2022-12-14 7:04 ` [PATCH v2 1/4] eventdev/eth_rx: " Naga Harish K S V
2022-12-14 7:04 ` [PATCH v2 2/4] eventdev/eth_tx: " Naga Harish K S V
2022-12-14 7:04 ` [PATCH v2 3/4] eventdev/crypto: " Naga Harish K S V
2022-12-19 3:51 ` Gujjar, Abhinandan S
2022-12-19 5:45 ` Naga Harish K, S V
2022-12-14 7:04 ` [PATCH v2 4/4] eventdev/timer: " Naga Harish K S V
2022-12-14 7:31 ` [PATCH v2 1/4] eventdev/eth_rx: " Jayatheerthan, Jay
2022-12-14 9:50 ` Naga Harish K, S V
2022-12-19 5:33 ` [PATCH v3 " Naga Harish K S V
2022-12-19 5:33 ` [PATCH v3 2/4] eventdev/eth_tx: " Naga Harish K S V
2022-12-19 5:49 ` Gujjar, Abhinandan S [this message]
2022-12-19 5:33 ` [PATCH v3 3/4] eventdev/crypto: " Naga Harish K S V
2022-12-19 5:49 ` Gujjar, Abhinandan S
2022-12-19 5:33 ` [PATCH v3 4/4] eventdev/timer: " Naga Harish K S V
2022-12-19 5:56 ` Gujjar, Abhinandan S
2022-12-19 6:20 ` [PATCH v4] " Naga Harish K S V
2022-12-19 5:48 ` [PATCH v3 1/4] eventdev/eth_rx: " Gujjar, Abhinandan S
2022-12-19 6:28 ` [PATCH v4 " Naga Harish K S V
2022-12-19 6:28 ` [PATCH v4 2/4] eventdev/eth_tx: " Naga Harish K S V
2022-12-19 6:28 ` [PATCH v4 3/4] eventdev/crypto: " Naga Harish K S V
2022-12-19 6:28 ` [PATCH v4 4/4] eventdev/timer: " Naga Harish K S V
2022-12-19 17:18 ` Carrillo, Erik G
2022-12-20 9:14 ` Naga Harish K, S V
2022-12-20 8:12 ` [PATCH v5 1/4] eventdev/eth_rx: " Naga Harish K S V
2022-12-20 8:12 ` [PATCH v5 2/4] eventdev/eth_tx: " Naga Harish K S V
2022-12-20 8:12 ` [PATCH v5 3/4] eventdev/crypto: " Naga Harish K S V
2022-12-20 8:12 ` [PATCH v5 4/4] eventdev/timer: " Naga Harish K S V
2022-12-20 9:11 ` [PATCH v5 1/4] eventdev/eth_rx: " Naga Harish K S V
2022-12-20 9:11 ` [PATCH v5 2/4] eventdev/eth_tx: " Naga Harish K S V
2022-12-20 9:11 ` [PATCH v5 3/4] eventdev/crypto: " Naga Harish K S V
2022-12-20 9:11 ` [PATCH v5 4/4] eventdev/timer: " Naga Harish K S V
2022-12-21 6:03 ` [PATCH v5 1/4] eventdev/eth_rx: " Naga Harish K, S V
2023-01-02 5:14 ` Naga Harish K S V
2023-01-02 5:14 ` [PATCH v5 2/4] eventdev/eth_tx: " Naga Harish K S V
2023-01-02 5:14 ` [PATCH v5 3/4] eventdev/crypto: " Naga Harish K S V
2023-01-02 5:14 ` [PATCH v5 4/4] eventdev/timer: " Naga Harish K S V
2023-01-04 6:41 ` [PATCH v6 1/4] eventdev/eth_rx: " Naga Harish K S V
2023-01-04 6:41 ` [PATCH v6 2/4] eventdev/eth_tx: " Naga Harish K S V
2023-01-04 6:41 ` [PATCH v6 3/4] eventdev/crypto: " Naga Harish K S V
2023-01-04 6:41 ` [PATCH v6 4/4] eventdev/timer: " Naga Harish K S V
2023-01-12 7:06 ` Jerin Jacob
2023-01-12 16:32 ` Naga Harish K, S V
2023-01-12 16:30 ` [PATCH v7 1/4] eventdev/eth_rx: " Naga Harish K S V
2023-01-12 16:30 ` [PATCH v7 2/4] eventdev/eth_tx: " Naga Harish K S V
2023-01-12 16:30 ` [PATCH v7 3/4] eventdev/crypto: " Naga Harish K S V
2023-01-12 16:30 ` [PATCH v7 4/4] eventdev/timer: " Naga Harish K S V
2023-01-13 13:51 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB58321886222CD8D00161EF8FE8E59@PH0PR11MB5832.namprd11.prod.outlook.com \
--to=abhinandan.gujjar@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinj@marvell.com \
--cc=s.v.naga.harish.k@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).