From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B95EBA00C5; Mon, 19 Dec 2022 06:49:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5182840698; Mon, 19 Dec 2022 06:49:04 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 5459840695 for ; Mon, 19 Dec 2022 06:49:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671428942; x=1702964942; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=bKld1FKqwVXX019zuvPY30e7aj0ckBT0Cq+CohISywY=; b=CQuL0zR6MHtQeEs9riqgGsEWHtjIpC3r0WuscsmQCT6vu/DDtyHoYZFb gy+1+8znUHQGIEj1YsbcrzPTgQ/kMo5ZF7Ia0YesLl1+AkEJMtMn41ID0 MO9YfOJQ+DqDdGHSJTZt5C0YJAMyQCAsmGupD2EH6Ojb10xxlmP9t/Eyq OKE8zFnj4qA0osIvcBIjF+G5JYlP+pbr66b4O1dCcBCX7GgQhOMc/k6Xy 5m3WYYVbReVQOZCVX3mMMSeDsuAWtO/N4Ipgx7Ay9XTQz5CR21hNFFqkU nvCFISvkNcrVmXWJE4fMU6Nr2NtEipqsTRKRsOebIHJnf9LBnJjAe7Nw4 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="383620546" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="383620546" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2022 21:49:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="757494821" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="757494821" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 18 Dec 2022 21:49:01 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 18 Dec 2022 21:49:00 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 18 Dec 2022 21:49:00 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 18 Dec 2022 21:49:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fhbyLdexHEEGyK8VYgJC809ejgiBMn+HPSUoFo9uerNdGCrHQJbA97XWDPWr78fLyY9Xiw3qdLbrI0QkltatnmE5QtCiH2VTO6Av0FFR6dR4LhW+7eyd9QOWgrl1IQvQP6spfsNr1uw/wmxUdBISG1H/IKBb7D3sZNwKrJNvsYY62cbfs5KFILpmVpj5X3D0MFAKlZYq3ZBKm9KzsHWt245DND/PvtOf3HKIHj2UDhj32+7dKZT4lXe+q9tFRjwTwnkrY+QnviNWIKxqB1fb1Pr8Je2OxGhdHrOVVrqUkY6qJo4YERDccYu45nMDcum2h6IMG7v8/qs8fu6IRC6VcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YQgSzuI8Z5gSg0Rgr02b95S6uuiMa9t/BEzmVfEbcnc=; b=AULlWKjWyPnyHuZbjMPPJ5QsTSiJomALz/Oya9j9uAIpPcbLmVUAzkmsZnJxoTHctMjq3xdaSLHHiFBuR1/fc6puyysBuFoNfKh+cGLz2vhTCg69zdd3VZxnEBEfs83Mda31NqWmx8lU+QFkrpKUfGL8jetsBEppL1HrrRc54AAC/Iha8xAbZjkeTilM4YGJfiW7fFw4anOOCXk6Ent3f3rw6Y4vauexQv7WAvPH+qD1UMLMY5HIznGwxg03oMGsDGUmS192BM9OXXBlmIMI9zZpUX40er8azKrtTYe9MjLb30apXqWWeiDlcrJVlO2gBbqYpdoO+suLNWY3QZDydA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5832.namprd11.prod.outlook.com (2603:10b6:510:141::7) by MN2PR11MB4533.namprd11.prod.outlook.com (2603:10b6:208:264::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Mon, 19 Dec 2022 05:48:58 +0000 Received: from PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::ef44:2061:3d86:6b21]) by PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::ef44:2061:3d86:6b21%9]) with mapi id 15.20.5924.016; Mon, 19 Dec 2022 05:48:58 +0000 From: "Gujjar, Abhinandan S" To: "Naga Harish K, S V" , "jerinj@marvell.com" , "Carrillo, Erik G" CC: "dev@dpdk.org" , "Jayatheerthan, Jay" Subject: RE: [PATCH v3 1/4] eventdev/eth_rx: change eventdev reconfig logic Thread-Topic: [PATCH v3 1/4] eventdev/eth_rx: change eventdev reconfig logic Thread-Index: AQHZE2tsVLBSN5RFU06cNaJTJmV7K650tDnA Date: Mon, 19 Dec 2022 05:48:58 +0000 Message-ID: References: <20221214070440.921488-1-s.v.naga.harish.k@intel.com> <20221219053315.2538180-1-s.v.naga.harish.k@intel.com> In-Reply-To: <20221219053315.2538180-1-s.v.naga.harish.k@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5832:EE_|MN2PR11MB4533:EE_ x-ms-office365-filtering-correlation-id: 1da4944b-cdfa-4df5-8315-08dae184b910 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: as2w2xpDLgjYmaED9k64xyGfi3026QPuvIp4ME/mi/qBnjnTzQCjwVYiYtsK8aAp0/PvEumLHFRMwnauLLIFkETP3ZvaDgkwoa8qZ6om1YaGMpzu+KTkDJ/3Gs6uNSd4vK8se8HXUh83op1ZSNbNLqa/uvFeuItgcBDU3/1/KUydX1xT8eIuje5EI46riU5si1tvN+o3ZPgHHzviy6rItG70caH/1ztQMgMsbY6VZWuwzosNtx24XMEDx6lgrDNaSZyI4KC2Hq6G7r3BaeOfdgJzRuKPgpm2XO2vm14QuzMusOn1Xjui89W44UL4r0Txt68M5WrzXhy1Px237LXawOwKtZBBOcHVLnjD0mVDnpZXER5pYxUCaOUOvg5xUzTkSKBf+EjQc0/6wgjHMY2Jit7jnLpbW4dmrgfj1EWfbScdBkpQq2aEiLwtmDNW4tw+KZMQ74YLerJgEaD/FQAGbBVk0lyRTCU62WgdxTRE2+BwobopnngzZP/A7o4cIJCUXKDTQnLJ66DCNPeGoPEv+RS0Ki3iAKEPOGYvr1FuBvWFakmQ538BjlslZjGaHPktst0inWaIL58YoL7a42uNpzcAnOJQDTn/32zsG/9Ln0xJET2vxaD4XCLAsZo5OG6j25YIShSok3OKuaT8587N4+f1Krm2zG3XO4ztVDsEDGP/j+E+TLdWnGotHiCAKPo5PZYNIjJmwcqM/l+lfTPiqQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5832.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(366004)(136003)(346002)(376002)(39860400002)(451199015)(107886003)(478600001)(33656002)(71200400001)(7696005)(6506007)(55016003)(86362001)(186003)(9686003)(6636002)(66556008)(26005)(316002)(66476007)(66946007)(66446008)(64756008)(54906003)(76116006)(110136005)(38100700002)(41300700001)(8676002)(4326008)(83380400001)(2906002)(82960400001)(52536014)(55236004)(53546011)(122000001)(8936002)(38070700005)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bsNkcmCgStsQd4JWpQMoaxUp+nbnHVa9MgM2Ifo2Wkf+e7oylSeK/hQ/SKZ1?= =?us-ascii?Q?+oMO5BKFv9efEtt53VyVmQHgMii3QGHBWNaiiyTTPfW1o0DbGpPk9Iyp7+P5?= =?us-ascii?Q?mHZnP1CiMqGWntnoqGfO0piUWjfAHPf2JAq5WOpi+Op5mOkEhYbuNN4KStnt?= =?us-ascii?Q?+3EXd1ksn3SgDTinJGee6R8ZoDZjRrjE1bOSZn0+Sk7wIgDEG58FJ0ojCYTS?= =?us-ascii?Q?ZlNXZrM/DjN7NZUS5eec8EYBkBf6j/YvdMynxUJqDjmCM+7AEq2T+kG+d4gv?= =?us-ascii?Q?pd/HIXgZFEwzVlUs3cXokqY4aDEOhfR8fUam9rR5lYJ9oCV+l4bHCAYvduhL?= =?us-ascii?Q?djt+dBu32oafr3tiPjgl30Ltdj4VYGQ8sr4cxp+lVq1T6YBdtsccp4GLc9jd?= =?us-ascii?Q?I3s3XIXoOwdJzPgpq7SeyPFXwdrhoXi211Tb1nvTJl+4ouap/qtPi56JIkxq?= =?us-ascii?Q?nKFGMdjWURn6PengGqw7rjTh6hZF1X23qY+TGpxLsccs6BjdOis8SNTVXu1J?= =?us-ascii?Q?uLjLgdCJyqiqMoY9QeojCGuaurExDI+vMQCCHnFXfCeM1M/y9ZYTklZCkbHZ?= =?us-ascii?Q?0RuDKEYgJtUApqbXBkdykOv+J5HYFAJuG0I23ErtloFNuUchnj8sHeWHoJyo?= =?us-ascii?Q?Tmfer/kovKDw1GsnlSyTkoIDU1RN+XUvIR044cv/6CWMJbDhO5augEvqomdH?= =?us-ascii?Q?8PZnJEUQTTyE17hjNCJuEjm/zfAt9RGczFHyJbgBTqj5i9aHn/VrJEhD7Ntm?= =?us-ascii?Q?4E9AB3+1o7Y7YtJfFpxAKbe3W149toiVFgUKtKqAe5rGq5sLybuWPQ3E4o5R?= =?us-ascii?Q?x3bye/wJicHx3JHPTk3GxgLzoJfN8wmls3zS5uDB7L8TvzV/17E67EzqAdRB?= =?us-ascii?Q?ipavMfwWy11zUGOOtUo1ktgK87bfU4gD+OravoZXacSYT1v50/w3YhBg1gok?= =?us-ascii?Q?V4oTdAr3YhUubek+Ni9HkS5b4U6NlpY8hy6+KMh8753CEWs4qmx4KbFOuxZ8?= =?us-ascii?Q?hJ7gGp5evwiceM1WLS4FVEnUOgOd2YAbN4gKiJQpE4FWUDv4Z9bvoiA898wp?= =?us-ascii?Q?l4AyyvZ4Tcak3WoHB2g9prPNPodszX/6c28CQ+eVD2OJGh6JxGL3enF7RzPf?= =?us-ascii?Q?f+dUqsNtaHZeMgcpEwW5buB3c07w4b745mdfsxEGMtjv+YVY21mEaSk82f4E?= =?us-ascii?Q?u+24Gr/8BxEHXjjHJrlB5NKApnadHuUVrvsIYdVWF+tXnRF0MmekcCRntmKx?= =?us-ascii?Q?Gtx64q14blz1W6FD63Zj+XSAq8Hjl97HkNBtOM0xkI4i99QkgMt407D/YCCa?= =?us-ascii?Q?xnHMpxgTnmE1Uv8scwlaDmPAKp7PDisV7Br6nwzG7VktZNV8yNusk+b2umEe?= =?us-ascii?Q?FkmPAY+h530LI+/TljYCm+LcZOQ/hNYvPOEQFxlp50LK284bsPTEg1CW90Pc?= =?us-ascii?Q?XssWrsjTtwSrHUJd+Tz0XzUlambWR7xXxOnBK6xgnMh/2l0wnktk5y3M8bfF?= =?us-ascii?Q?f63BM3A0PSLXSdfIwN1zA0hpwahu4K/h8lLo/XZQauTW5T6Jm62/N/3llqJd?= =?us-ascii?Q?c4PtfOYL1c+fTazdVKuWcktlGVsvXIDdAd84+/uIZnKR8OClNo4vr9g/ji8E?= =?us-ascii?Q?/Q=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5832.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1da4944b-cdfa-4df5-8315-08dae184b910 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2022 05:48:58.2989 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Dk0GWMCfiZp5aBmPT3xKKjGxPVoHTIrILEvRgzIg2B8D3/yZSUDFSjOLC4QgugYhWfwqB16wTh+O7d2EeYa4ajeZXcon334r9qHyU1iYrkI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4533 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Abhinandan Gujjar > -----Original Message----- > From: Naga Harish K, S V > Sent: Monday, December 19, 2022 11:03 AM > To: jerinj@marvell.com; Carrillo, Erik G ; Guj= jar, > Abhinandan S > Cc: dev@dpdk.org; Jayatheerthan, Jay > Subject: [PATCH v3 1/4] eventdev/eth_rx: change eventdev reconfig logic >=20 > When rte_event_eth_rx_adapter_create() or > rte_event_eth_rx_adapter_create_with_params() is used for creating adapte= r > instance, eventdev is reconfigured with additional > ``rte_event_dev_config::nb_event_ports`` parameter. >=20 > This eventdev reconfig logic is enhanced to increment the > ``rte_event_dev_config::nb_single_link_event_port_queues`` > parameter if the adapter event port config is of type > ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. >=20 > With this change the application no longer need to configure the eventdev > with ``rte_event_dev_config::nb_single_link_event_port_queues`` > parameter required for eth_rx adapter when the adapter is created using > above mentioned apis. >=20 > Signed-off-by: Naga Harish K S V > --- > v2: > * Fix build error > v3: > * update doxygen > --- > --- > .../prog_guide/event_ethernet_rx_adapter.rst | 18 ++++++++++++++++++ > lib/eventdev/rte_event_eth_rx_adapter.c | 3 +++ > lib/eventdev/rte_event_eth_rx_adapter.h | 13 +++++++++++++ > 3 files changed, 34 insertions(+) >=20 > diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > index 116c0a27c6..8fc9be0a9d 100644 > --- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > +++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > @@ -71,6 +71,24 @@ set to true. The function is passed the event device t= o > be associated with the adapter and port configuration for the adapter to > setup an event port if the adapter needs to use a service function. >=20 > +Event device configuration for service based adapter > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + > +When rte_event_eth_rx_adapter_create() or > +rte_event_eth_rx_adapter_create_with_params() is used for creating > +adapter instance, eventdev is reconfigured with additional > +``rte_event_dev_config::nb_event_ports`` parameter. > +This eventdev reconfig logic also increment the > +``rte_event_dev_config::nb_single_link_event_port_queues`` > +parameter if the adapter event port config is of type > +``RTE_EVENT_PORT_CFG_SINGLE_LINK``. > + > +So the application is no longer need to configure the event device with > +``rte_event_dev_config::nb_event_ports`` and > +``rte_event_dev_config::nb_single_link_event_port_queues`` > +parameters required for eth_rx adapter when the adapter is created > +using above mentioned apis. > + > Adding Rx Queues to the Adapter Instance > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >=20 > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c > b/lib/eventdev/rte_event_eth_rx_adapter.c > index cf7bbd4d69..34aa87379e 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -1532,6 +1532,9 @@ rxa_default_conf_cb(uint8_t id, uint8_t dev_id, > rte_event_dev_stop(dev_id); > port_id =3D dev_conf.nb_event_ports; > dev_conf.nb_event_ports +=3D 1; > + if (port_conf->event_port_cfg & > RTE_EVENT_PORT_CFG_SINGLE_LINK) > + dev_conf.nb_single_link_event_port_queues +=3D 1; > + > ret =3D rte_event_dev_configure(dev_id, &dev_conf); > if (ret) { > RTE_EDEV_LOG_ERR("failed to configure event dev %u\n", diff > --git a/lib/eventdev/rte_event_eth_rx_adapter.h > b/lib/eventdev/rte_event_eth_rx_adapter.h > index d0e7d0092c..b7e75ff646 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.h > +++ b/lib/eventdev/rte_event_eth_rx_adapter.h > @@ -382,6 +382,19 @@ int rte_event_eth_rx_adapter_create_ext(uint8_t id, > uint8_t dev_id, > * control in configuration of the service, it should use the > * rte_event_eth_rx_adapter_create_ext() version. > * > + * When this API is used for creating adapter instance, eventdev is > + * reconfigured with additional > + ``rte_event_dev_config::nb_event_ports`` > + * parameter during service initialization. This eventdev reconfig > + logic also > + * increment the > + ``rte_event_dev_config::nb_single_link_event_port_queues`` > + * parameter if the adapter event port config is of type > + * ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. > + * > + * So the application is no longer need to account for > + * ``rte_event_dev_config::nb_event_ports`` and > + * ``rte_event_dev_config::nb_single_link_event_port_queues`` > + * parameters required for eth Rx adapter in eventdev configure when > + * the adapter is created with this api. > + * > * @param id > * The identifier of the ethernet Rx event adapter. > * > -- > 2.25.1