From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E487AA00C5; Mon, 19 Dec 2022 06:49:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D76144114B; Mon, 19 Dec 2022 06:49:26 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id E1A4B40695 for ; Mon, 19 Dec 2022 06:49:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671428965; x=1702964965; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=E9gKYtusoEVnI2j84o2pzEZADTla/i5N7CRhxTGAAtw=; b=SQCujO0yTocvKhp0al3xwVHqWXJ6bXrzC1MEAaMFLc/nBg1lGeaKwPuw QlUlvpjxWrTdEFBDsW5RtEkis2GDNofcfRe0eF7FJE+o/LncfEIPWTWrn PyfC/Ok2AkZWAI6tCNJ3kxuX8XALZDH0mRb3yv9KCpRaevoeIWhdP39N7 BPfYIw/omiLPcbwC7rtv5+YG8aYAUWi3pIlI7lfPg7XCxUdLbzcUdXT4n HaWsibyKvVbo6wtyHS7EBe6qNWoolYNnhOuOSHDXuqjR/yoBggiBbKk0i sxXgzvq5pNlk5vyX+5T05m0ReUbjPdgWVpeJDsuKeu1ScJg+gfN9A7USF w==; X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="405525418" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="405525418" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2022 21:49:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="713894242" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="713894242" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga008.fm.intel.com with ESMTP; 18 Dec 2022 21:49:24 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 18 Dec 2022 21:49:23 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 18 Dec 2022 21:49:23 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.47) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 18 Dec 2022 21:49:23 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XN2xTAzXlkEs/VUvoyx3I1oz8GnbZhC2MhpgKz/h+E7z3VIw8jyDcz1mNNK05ihvAxPWR8px8aeNNOWbjUfyDT3QrF+E6fK7yquxsk28tj4VVVeq01vtHqiwdw9dlx7UJiV83STTdWQpyQt/Awihe/XMRwZm9MTYAeS2J5OXkNQoPmRF6M5kcdB2N55Y5zcPGftat98dx5tsfblfbM+nycEb5t+8kUCMCLsvaswsm1S3wTcX/bTSjesodhTOsDz7o1YaH3WozN6X486KJbrER2XVPVjOSWiWwCRuF7yezhYfnv4IhEnUAqzmdxhjU32tzLE+BE7qHwUKXcqqwC2dRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VMYd8hrzvI9X/9f7PeQQXpef35OZsgUdnhTLA12ibSI=; b=Kf3PhFWphyNHIFTw6RNYwKWjy1yRVOAq7YWSDFgpmGZR0P1Rl3v8b+2JBuF/CWQno8YTBjAnK8tT59Au8KjU1D+zGPxnUNc5gktqKKRf/ShfyBKr0ZQut76O5QrBk1AAzAHmSt6+d0Qe/hzuuitJnciBsJpn+mveBOfRfMQSxBlr/0m0aKPpw0CZoo7tVOJ+lQZeA8E5wlQ4l6R1PZ97BXUUthezRUe5g/deBQGu4GAZ/6bWhn5iCXE45vi4Ncx1zncBR7Y8GygvvV2cZoUhHlNuus8N1sRjkb4kA1lYn/IKbeuaGVRE0TCSh44rYc4/qeOBtU689Kg4cdLSU+oXTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5832.namprd11.prod.outlook.com (2603:10b6:510:141::7) by MN2PR11MB4533.namprd11.prod.outlook.com (2603:10b6:208:264::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Mon, 19 Dec 2022 05:49:21 +0000 Received: from PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::ef44:2061:3d86:6b21]) by PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::ef44:2061:3d86:6b21%9]) with mapi id 15.20.5924.016; Mon, 19 Dec 2022 05:49:21 +0000 From: "Gujjar, Abhinandan S" To: "Naga Harish K, S V" , "jerinj@marvell.com" , "Carrillo, Erik G" CC: "dev@dpdk.org" , "Jayatheerthan, Jay" Subject: RE: [PATCH v3 3/4] eventdev/crypto: change eventdev reconfig logic Thread-Topic: [PATCH v3 3/4] eventdev/crypto: change eventdev reconfig logic Thread-Index: AQHZE2tt/xJKa8qgl021a3dqL7R6qK50tGuQ Date: Mon, 19 Dec 2022 05:49:21 +0000 Message-ID: References: <20221214070440.921488-1-s.v.naga.harish.k@intel.com> <20221219053315.2538180-1-s.v.naga.harish.k@intel.com> <20221219053315.2538180-3-s.v.naga.harish.k@intel.com> In-Reply-To: <20221219053315.2538180-3-s.v.naga.harish.k@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5832:EE_|MN2PR11MB4533:EE_ x-ms-office365-filtering-correlation-id: de26b2af-9a08-4633-d318-08dae184c6de x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tIYpD4NOPlIKQpofQvPhaHQUnjkHAsSD/7QMrXCkQjyIlRErG34VPaZ1/9GWwykfAy0qQAsOMZWyB9rlhRZgBbhqFL2DrTt7YLscKKBXV1xTCCb9YY8mRC5Se26rtp4yAKl09co6TJ03CqMJoaGSCWgo/UEHSPSl2PLVoJMAsyDFdGdSAuaUi/SqJipFx9U9JZM2JNGXsyuf8PNKbXUIsR4gULEgYTrB6gaHHPPR5SitsjBzwo3a4lpqSwwAj+xdpTS6ac66my/zquBNtx26sklg1zy4rQSz+TuidQzf+zKy6A5oVRwARjOijEMLWeYnFbO8S2AYbapRIrp8fH6eTGPRH2viXKhpBQI1AxksqyRDBOsnkAoPEKWVE/20lWRUWVvSFqq9spJf8tG6FA4s9IOCXimyJy+O4TSQlSOeaUPfQ/aOBDuGqDCx5Wy7e+5lj8mXz2C/NYYwCbrzg26rWYFqyNPDCsz8aAKQxOOOhqGxrj5c87AyL2uMa4tjrMH2isP8/C2Jvo2skxjEzNuN4MnIyOQH/fIttMVn0fdYQKD+Hvm0o/mDjJ+9UpvAsRlHZXUqk8AuqAydQ26gK1zsM+CfeYnFdMG8q9o65+mOtSYoEAWLjupTTguNPRFXQmnTGe5KuXUh2meCGA456lJmgmMfSmrJpr7/hhpvi5RoHc/7FZCOokXGKFZ7WxVdb/ng4dcKWiv84bC66vtgaW2BRQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5832.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(366004)(136003)(346002)(376002)(39860400002)(451199015)(107886003)(478600001)(33656002)(71200400001)(7696005)(6506007)(55016003)(86362001)(186003)(9686003)(6636002)(66556008)(26005)(316002)(66476007)(66946007)(66446008)(64756008)(54906003)(76116006)(110136005)(38100700002)(41300700001)(8676002)(4326008)(83380400001)(2906002)(82960400001)(52536014)(55236004)(53546011)(122000001)(8936002)(38070700005)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?T46Y4qgoj1aFjcWE2uMUEBXz5J9SJR5ewkih1JLs7IPPO73ckG6Ftb4YXlUV?= =?us-ascii?Q?NIiTsr5Wh95xBlYAIRdL/GqTRaSyoeuKRbt+2xZMac2a1likO4NFurRvLN15?= =?us-ascii?Q?Y44VFNd0O5ZnMaLzln1312yfW5d/4NqoLVCwqyHfyJ0xdxhYETU/jjsEJldg?= =?us-ascii?Q?LGIaevotizEvBzYv5xyUbJiKhtjan1jfTdZw/j7jn5x//Csu25oPpKVnSFfm?= =?us-ascii?Q?Wu7MRUYyoh8p4y9HEfVzhwiFcm39sdPSU1eVLPa+7PpnO/X1PvX1ybg42cVa?= =?us-ascii?Q?BFFF83P39aqxZinqmIiuSqfxRZssU1yc2EULpFfG/NThyaj7sj5TXvulJPno?= =?us-ascii?Q?lDOglkLGrrRvmMylijXNDGC8/T+iRE8rqIWw2l/m4lEWVb8Gi7gTnil0+q11?= =?us-ascii?Q?xcTWMXKSfRV88JP2fCVwMZdXBd30pjxYBOasUMev5AlvVzG3tpSUfIUeljYv?= =?us-ascii?Q?72voKxlHCUuvZBarqBDVbZCFd+i5Fim07q3fjKzhehwY3IMvf6sDlIblRZZs?= =?us-ascii?Q?6cqu/Ipm9gY74pvB2iWsZzWRpLdE0xd/DdYIfwoeM5s5V0RSfH50U1kcQcul?= =?us-ascii?Q?TGYgAyXi5ulhVcjPVXRuIJReYpAw3M/XfnrBl0qKPpRERN8UkEfYvx4ocxb2?= =?us-ascii?Q?FcTImubWZfyKrpduVpgUwimysrnYgwOnO44TONL/K4AP5zBHGgkgHOSFQeaA?= =?us-ascii?Q?oTs7YKwm+41JQYfmJQWtG340oNw2nlEjWSDigp7EIqVSeIeODXLWgtvMTsY0?= =?us-ascii?Q?exKSf4AI27JeNMwGKCzGlsO4UNStZeRYJ6kP7LPI8acvWBImIC4A7JUN+Fz4?= =?us-ascii?Q?VqrsF/EfsUK8JoihGHkoIWF9vIs4EStBlwyVOAuTsV9HszhkdF6cGMpctk9v?= =?us-ascii?Q?2RTHB/QcPXCX8jW/EE8c1lGtluUGz71udXC1inBpMPWlGLQp4Za0tPOmhkzh?= =?us-ascii?Q?T7p9HAyfQzBL0RHkeVq+qoywqdmCbPd7hM++jX537RqQcIfFoEpfRiFVI/Cy?= =?us-ascii?Q?Ew67EFnigvdtHDT4nwNf349sv9Ie1WpnQwlCOKQs4BQZjhZrNFAOmcvDFoan?= =?us-ascii?Q?iZYrvphqRpHU+fVbwgIkosRPeEl14O8oov6KrdIl/s3xwV5LOhmiqoCY6Y5V?= =?us-ascii?Q?N8e0GO+i/LQXtTrnN/tmg7UwzvFIYf0xXb7kc5R14AfkO4u+f0Aqu7tzPKHQ?= =?us-ascii?Q?CaQyMYr1U+zPSRgn5zzmkVbAWUJW+oAsU8CP8ex8GBDB6XRAxmnkBpxTP2W1?= =?us-ascii?Q?5+dBfC05CyudohjzjC3QaEGNS/3eRH2II/0U8chWgf8b/Bhv+QLRrdyMqyzM?= =?us-ascii?Q?uRtyew0g97NdoIQ8k7LLGQ4zKhD9iPK7SRk1wfNUOZxAjIoIKAy0PkDnSPhT?= =?us-ascii?Q?EPXJatP0EHJ4s/ZI88yF0uKBF2ZWdPl9U3tLKycrX/xcGFiA3AuqULQqUlPw?= =?us-ascii?Q?vF7KH8Cf4ZhIAin+eAQaLjwLFHcdgkOaWt7DuGUNDq3psu4s7nAQ0BHj6ED9?= =?us-ascii?Q?gNuzzryHB52v4UkgmpjnrM7pkIFlFynpWRBg/dFWHoCPVy25DGOT38RzDo9D?= =?us-ascii?Q?CEPURbe9VFGRJKSZ2y+q6CZlCU8Icwt6UGAEGk49+mwM8iL3BLJ3aHekYZMo?= =?us-ascii?Q?rA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5832.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: de26b2af-9a08-4633-d318-08dae184c6de X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2022 05:49:21.4146 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0LmLUxeuZyFiQb4MGV/qG9jmsHzfLBkyYOnBZ7qDsP8wz0fGv/3NVaUQY1ng+obYjHRQVb/+6nlLT85hJGvJXqr4FIIsQ3CfwQkYVoMCV9E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4533 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Abhinandan Gujjar > -----Original Message----- > From: Naga Harish K, S V > Sent: Monday, December 19, 2022 11:03 AM > To: jerinj@marvell.com; Carrillo, Erik G ; Guj= jar, > Abhinandan S > Cc: dev@dpdk.org; Jayatheerthan, Jay > Subject: [PATCH v3 3/4] eventdev/crypto: change eventdev reconfig logic >=20 > When rte_event_crypto_adapter_create() is used for creating adapter > instance, eventdev is reconfigured with additional > ``rte_event_dev_config::nb_event_ports`` parameter. >=20 > This eventdev reconfig logic is enhanced to increment the > ``rte_event_dev_config::nb_single_link_event_port_queues`` > parameter if the adapter event port config is of type > ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. >=20 > With this change the application is no longer need to configure the event= dev > with ``rte_event_dev_config::nb_single_link_event_port_queues`` > parameter required for crypto adapter when the adapter is created using > above mentioned api. >=20 > Signed-off-by: Naga Harish K S V > --- > v2: > * fix build error in documentation > v3: > * update doxygen > --- > --- > doc/guides/prog_guide/event_crypto_adapter.rst | 16 ++++++++++++++++ > lib/eventdev/rte_event_crypto_adapter.c | 3 +++ > lib/eventdev/rte_event_crypto_adapter.h | 13 +++++++++++++ > 3 files changed, 32 insertions(+) >=20 > diff --git a/doc/guides/prog_guide/event_crypto_adapter.rst > b/doc/guides/prog_guide/event_crypto_adapter.rst > index 554df7e358..7e5dc294f2 100644 > --- a/doc/guides/prog_guide/event_crypto_adapter.rst > +++ b/doc/guides/prog_guide/event_crypto_adapter.rst > @@ -159,6 +159,22 @@ which it enqueues events towards the crypto > adapter using > nb_events); > } >=20 > +Event device configuration for service based adapter > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + > +When rte_event_crypto_adapter_create() is used for creating adapter > +instance, eventdev is reconfigured with additional > +``rte_event_dev_config::nb_event_ports`` parameter. > +This eventdev reconfig logic also increment the > +``rte_event_dev_config::nb_single_link_event_port_queues`` > +parameter if the adapter event port config is of type > +``RTE_EVENT_PORT_CFG_SINGLE_LINK``. > + > +So the application is no longer need to configure the event device with > +``rte_event_dev_config::nb_event_ports`` and > +``rte_event_dev_config::nb_single_link_event_port_queues`` > +parameters required for crypto adapter when the adapter is created > +using above mentioned api. >=20 > Querying adapter capabilities > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > diff --git a/lib/eventdev/rte_event_crypto_adapter.c > b/lib/eventdev/rte_event_crypto_adapter.c > index 3c585d7b0d..5620a36dd3 100644 > --- a/lib/eventdev/rte_event_crypto_adapter.c > +++ b/lib/eventdev/rte_event_crypto_adapter.c > @@ -287,6 +287,9 @@ eca_default_config_cb(uint8_t id, uint8_t dev_id, > rte_event_dev_stop(dev_id); > port_id =3D dev_conf.nb_event_ports; > dev_conf.nb_event_ports +=3D 1; > + if (port_conf->event_port_cfg & > RTE_EVENT_PORT_CFG_SINGLE_LINK) > + dev_conf.nb_single_link_event_port_queues +=3D 1; > + > ret =3D rte_event_dev_configure(dev_id, &dev_conf); > if (ret) { > RTE_EDEV_LOG_ERR("failed to configure event dev %u\n", > dev_id); diff --git a/lib/eventdev/rte_event_crypto_adapter.h > b/lib/eventdev/rte_event_crypto_adapter.h > index 83d154a6ce..3994e32bba 100644 > --- a/lib/eventdev/rte_event_crypto_adapter.h > +++ b/lib/eventdev/rte_event_crypto_adapter.h > @@ -414,6 +414,19 @@ rte_event_crypto_adapter_create_ext(uint8_t id, > uint8_t dev_id, > * control in configuration of the service, it should use the > * rte_event_crypto_adapter_create_ext() version. > * > + * When this API is used for creating adapter instance, eventdev is > + * reconfigured with additional > + ``rte_event_dev_config::nb_event_ports`` > + * parameter during service initialization. This eventdev reconfig > + logic also > + * increment the > + ``rte_event_dev_config::nb_single_link_event_port_queues`` > + * parameter if the adapter event port config is of type > + * ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. > + * > + * So the application is no longer need to account for > + * ``rte_event_dev_config::nb_event_ports`` and > + * ``rte_event_dev_config::nb_single_link_event_port_queues`` > + * parameters required for crypto adapter in eventdev configure when > + * the adapter is created with this api. > + * > * @param id > * Adapter identifier. > * > -- > 2.25.1