From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9AD3742B15; Wed, 17 May 2023 06:53:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3741A40EE1; Wed, 17 May 2023 06:53:32 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 4EE3A40223 for ; Wed, 17 May 2023 06:53:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684299210; x=1715835210; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gIp23hgfRexDUcKBYGMvKlgXEXREfkG/Mlxy5KUEfME=; b=lfO8EwLzMfPRWcARhMIkNdqbje5DBa4M9gqzlCatbkLfty8OCdANZMT2 h0KVD3uPsToE+hvS0Rli5NtrBwl5KhaDpWCNKhgtwU8T422/0MUFZIm4G 4dF1zeiUxTzwaBHhXlM6ofEfUbpON04jWQ1k9gzmOhemoWmw1ppVyDGDR i6Xd4oeh03MI4iNGpmHQg8LiPdNDS8/IHwXFY3wvVVGURQoccWm5fVtLB 3aodJ/SRCYNQGVawc0RTV2vj32JCGteg+EZAhY2ewHfG6elQi1iaB/6SB T9y/8Mf8b54XWCWSwte/JEJ/A1vNFvr5yXFi7zAj9NlKgFkmGIxMlF/r0 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10712"; a="350500472" X-IronPort-AV: E=Sophos;i="5.99,281,1677571200"; d="scan'208";a="350500472" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2023 21:53:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10712"; a="771330294" X-IronPort-AV: E=Sophos;i="5.99,281,1677571200"; d="scan'208";a="771330294" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 16 May 2023 21:53:29 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 16 May 2023 21:53:29 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 16 May 2023 21:53:29 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 16 May 2023 21:53:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bddSvYHz8uqc5KlirsX6B96fD2NxxkDzY05eK4jmCU+7GLWMc+m9iGWHbJBtHiPgUNQkwn99V9nhq8nl6QpsyrOgLNJI0kH4ovTO+55hlq9RNLXBvE+xAbeIfxGzS4FPJvPAaFWoki4dQIA0H86hY+3wzxRH/77iLYb+ABI5ucfT6YKsSurGTY9EdBAH+QG+NnYYHSPLbuR92gE5S0ukGpBjXqahmm9IhWDmSr9UBLiiqRO5uZbcDgtTvaMM4b1YlTjBQ9H/J1QWFz1zaRcYNrqn6S9f1aiJ40ZBpnIW12bBg3jLfdQdesY8DSSBD2wDkpj9Ky0HVHFrV6DyFVyqcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TIq+Z6N90Sh7W0zvOu1leMC3r+72hZH8Scdocp9t2Ig=; b=OWOr5IcWhUxfu3voPNmdYKCWgCFrBTJFJMMhGOgCFy8IhIdNs0EtsbePNN6FDDbugHmGM01NXAiGLw/31aqYz9ajs6q/M8p2krbX2hQXJSIvQhZszGbKUgccKT9e77XiocO7P1PGukMyDDFulrLsjfdgP9D5/jcrckYC/6P5bX0XzXXQ04fy8d9hYffoGnhYlRgL0VvXAaWUTVqWgT2TMpHnzsK4JF+X/tbaYkV81mZ2YL5K3zk41PnZPjXJF7Ev1Anc28Y0cu+UIb5FmvtldvQrBhHQIVHO3L9tRyXxvYHyOZkQxseDpq4JF7vxJpejsH2d+1PK76jGO7mTTKF66g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5832.namprd11.prod.outlook.com (2603:10b6:510:141::7) by SJ0PR11MB6672.namprd11.prod.outlook.com (2603:10b6:a03:44c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.22; Wed, 17 May 2023 04:53:27 +0000 Received: from PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::1b71:aae5:3d48:1eb3]) by PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::1b71:aae5:3d48:1eb3%5]) with mapi id 15.20.6387.029; Wed, 17 May 2023 04:53:27 +0000 From: "Gujjar, Abhinandan S" To: "Kundapura, Ganapati" , "jerinj@marvell.com" , "dev@dpdk.org" CC: "Naga Harish K, S V" , "Jayatheerthan, Jay" Subject: RE: [PATCH v1] eventdev/crypto: refactor circular buffer size Thread-Topic: [PATCH v1] eventdev/crypto: refactor circular buffer size Thread-Index: AQHZcdZ04JAflBR4ikax0Ub+w0UC5K9eEwRw Date: Wed, 17 May 2023 04:53:27 +0000 Message-ID: References: <20230418091616.1388517-1-ganapati.kundapura@intel.com> In-Reply-To: <20230418091616.1388517-1-ganapati.kundapura@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5832:EE_|SJ0PR11MB6672:EE_ x-ms-office365-filtering-correlation-id: 2ffc9580-3ea9-4965-21fd-08db5692a719 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: P5TNn4tnA3IveuZVyZfVxKOtCAl9lFECwvjGfslWh6Y+r2Jk6ohxK/6870GtKiU3XNvubRlUSdNgdGx5NWc3JoJu8cmILT3D04nxRSemh2BexNv8hNl7DVT2fx7AMWoxXYd7GMS9IdhHhjjeF65lvIyN2A8FIGYDiYf6DuSkgeku+2lWsRK3uf2QgqUQI8AkPPZD59WS7n4NlNXMlS/7k2Blfk8ngQOAwtTyF5x7o2Os59be267qGvFW+HfYtmVHS2mU5QqdNIyUqzHS2XEOi5TFQrucAn+jNXFcWOsbfeKwg/GbMxXc2BZhNjc4SxcolE6g2cr9whmD1FG09nsE2L1qduO5tnRmQMriJG9mnoA2YJa6gWZW34FTTXXCDAGyeaPyCCGGnp5yI7i8i2vjepPUyfKCq6CqEjrdn4ZGnbMKS9SkUUlXO5/z8zf1MNKKGgCbDOJ6N4PoWogF0cJc9jBFLlsfN2YCGY5QEH8q/m1RE4ekRIAX8lggSPfI+9KCNG6zx227XNsBEuSAQeSaeFcARyNRMIeGQl3UEEfplYoN9vJB1s3FhsyCHTAvBeLDOxjQ3DxJ9HgEq5edGopt4NpiWPqPVRM4PGOart2jNfE7FhbvNDRQY4HPDHAkahJC x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5832.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(346002)(396003)(136003)(376002)(366004)(451199021)(186003)(55016003)(122000001)(33656002)(86362001)(6506007)(38100700002)(110136005)(7696005)(54906003)(9686003)(71200400001)(8676002)(66556008)(82960400001)(52536014)(5660300002)(2906002)(41300700001)(26005)(66476007)(76116006)(64756008)(66946007)(8936002)(66446008)(38070700005)(4326008)(55236004)(316002)(478600001)(53546011)(107886003)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VRIu6aOCsOO8EzG4+YgvRpPIw73bd7yJNIfXOuod1NazN+NFR4TGySEIy1K5?= =?us-ascii?Q?89e3YGnZq5yF0AiqqN7FEY+QABkOPn1VBCzl15wSC7bxZdshybBNc2VB/98b?= =?us-ascii?Q?m3V3ParTCmDPLef6ptor7A7/bqbAuFNVg7InexM7SfB25Ci5NF55Oy+kZ5Lh?= =?us-ascii?Q?Nf48DOZG4fhoTzlz75M6JYTpyQKd7PofwbXM2gok1V4gC4DiMV+pwo0EDFcN?= =?us-ascii?Q?+fWvYCUMiobZ+gIaH+BrFzj7XcMMnGluQ9TQRb2l4QiO0gxS2WfQEdfNuZde?= =?us-ascii?Q?06yOFKd0KLVWzDGd4FMmka+gxmqeW8pP1MXAe855EcyUeiO7Hny4lVh9DrCa?= =?us-ascii?Q?8ijcMfWTm0Qj69e4J14DgCFZO9DW1od5kT/FXvfwhH91s8MyyYqXkzr046VD?= =?us-ascii?Q?s4bmnphuS0q0bjojRPvzhxZzkrcpQh9/xTtJ6TftcKm7NIGYX1SN8HYepElU?= =?us-ascii?Q?TxwEADnhR9xy2DPXs2pfbKzE5Jfu8G9h3KP9wUlPLKADEXFQZ+O/8BWMfYrg?= =?us-ascii?Q?7abu/v7iPYdrilFidLYVYEHDwri7019BVRArEUlXPcF/PrgnI5N8CHRqO7dW?= =?us-ascii?Q?vDp4g8rnjFVGFlULXhnAPtSrDN0U1p60o8V6Ff3Wg/y+EwDlgF693NfFnrLy?= =?us-ascii?Q?WgqRfD7BTtTeEiFyV1px40CCspPVSC9gd+2SH/PpddO4gyrksxWrrujOTVsl?= =?us-ascii?Q?ORUicyg6aIRt0rLE8L1a2YiF2x/oWcDL/n0T/dZQFwuw2tiqhZcaMPQFHt3H?= =?us-ascii?Q?m6O3VeG0iY1CfcZ4Hh0WpQCEq/SM0RHsMTNpQhyLgx28oV32F0RKvg3fHLUU?= =?us-ascii?Q?B72Uk7IwN0Yb56nOt0qij/PEo8PxGb5QUrWoiVBUqXr+a2lo4HeUWGx2+VV6?= =?us-ascii?Q?zuvpAkfg3lFFP7+K5ohUoiEYyNA4Yx5dCRoEtyQZyC+7dTC2ZdPrr51a2tlj?= =?us-ascii?Q?kCU+7EfYCNzYIk6C9p8D+yrX/TbE4OySbzNYSFGQMwYOymx7QxYI4rl3u+ts?= =?us-ascii?Q?1YqUulWDLsDmxwlRttk9TK3UJvI9KQzURW94ysMjqx3cMM6SnbsiG4AKwSQe?= =?us-ascii?Q?f05MjmfVcqfErXKXNW6VJu1B4sYBoPDpOsfZHj7avOe+tVZ2P1gThYfeFUKX?= =?us-ascii?Q?Q2DxyS2pdcoBjIXQbs5KVhM5J6N9WqYkK94Hf88pKkgp9mJCRS28zkyg4ojf?= =?us-ascii?Q?AFLDCFwNCtUGXYZTFn7hfwZgnNzf6VwQxRWWU8XrTNH19nqIAZlX+vnnWQeX?= =?us-ascii?Q?pjq7UKrQnTxycGfVAx654aWVHZR7rqihZHPhODem4giZDfdUrMUd2i2qfFnb?= =?us-ascii?Q?hEtZD/wrXW8KXvlDvl/RyvOoSRvKMljhvUFz8U6HTbJicI4E9oLdBgmfh4Bx?= =?us-ascii?Q?59NH4V6u2OpMTt5pRE6KqPE2DXF8mjHwfxVqnJlVH8zQpqDD7Dj0fDid74CR?= =?us-ascii?Q?EJQsgfay1FGYrf2eXQGRkIhZf3PSlJCktjzUW5xXWw4NQnfxhq5hBhJQB7cL?= =?us-ascii?Q?hnz3DvX3a0B4rYoyXip8y+nlSDoqGvveDg5C2RsjFKzz8FDcrMKZGnsBU73S?= =?us-ascii?Q?ekbiUhN78B+XaYN0NnXAigyioxwisxNsBAZVXgqQ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5832.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ffc9580-3ea9-4965-21fd-08db5692a719 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2023 04:53:27.1176 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: E4xbLQ1jM6K9Nge6XgPwISzXhKOyh6Mv3Wz6Vd8gHUFgNWdcooiQUf9WJBniJtBlJmtHeugaQwlstZokVpZR3MPeufV5e5NuVgVID70AlVc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6672 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Kundapura, Ganapati > Sent: Tuesday, April 18, 2023 2:46 PM > To: jerinj@marvell.com; Gujjar, Abhinandan S > ; dev@dpdk.org > Cc: Naga Harish K, S V ; Jayatheerthan, Jay > > Subject: [PATCH v1] eventdev/crypto: refactor circular buffer size >=20 > In case of CRYPTO_ADAPTER_OPS_BUFFER_SZ is modified, > eca_circular_buffer_space_for_batch() also needs to be updated to check > maximum number of crypto ops can be accommodated in circular buffer > when CPM becomes busy. >=20 > Defined MAX_OPS_IN_BUFFER which contains size for batch of dequeued > events and redefined CRYPTO_ADAPTER_OPS_BUFFER_SZ in terms of > MAX_OPS_IN_BUFFER. >=20 > This patch makes eca_circular_buffer_space_for_batch() independent of > circular buffer changes. >=20 > Signed-off-by: Ganapati Kundapura Acked-by: Abhinandan Gujjar >=20 > diff --git a/lib/eventdev/rte_event_crypto_adapter.c > b/lib/eventdev/rte_event_crypto_adapter.c > index f6c1e53..52a28e5 100644 > --- a/lib/eventdev/rte_event_crypto_adapter.c > +++ b/lib/eventdev/rte_event_crypto_adapter.c > @@ -25,7 +25,14 @@ > #define CRYPTO_ADAPTER_MEM_NAME_LEN 32 > #define CRYPTO_ADAPTER_MAX_EV_ENQ_RETRIES 100 >=20 > -#define CRYPTO_ADAPTER_OPS_BUFFER_SZ (BATCH_SIZE + BATCH_SIZE) > +/* MAX_OPS_IN_BUFFER contains size for batch of dequeued events */ > +#define MAX_OPS_IN_BUFFER BATCH_SIZE > + > +/* CRYPTO_ADAPTER_OPS_BUFFER_SZ to accommodate > MAX_OPS_IN_BUFFER + > + * additional space for one batch > + */ > +#define CRYPTO_ADAPTER_OPS_BUFFER_SZ (MAX_OPS_IN_BUFFER + > BATCH_SIZE) > + > #define CRYPTO_ADAPTER_BUFFER_SZ 1024 >=20 > /* Flush an instance's enqueue buffers every > CRYPTO_ENQ_FLUSH_THRESHOLD @@ -188,7 +195,8 @@ > eca_circular_buffer_batch_ready(struct crypto_ops_circular_buffer *bufp) > static inline bool eca_circular_buffer_space_for_batch(struct > crypto_ops_circular_buffer *bufp) { > - return (bufp->size - bufp->count) >=3D BATCH_SIZE; > + /* circular buffer can have atmost MAX_OPS_IN_BUFFER */ > + return (bufp->size - bufp->count) >=3D MAX_OPS_IN_BUFFER; > } >=20 > static inline void > -- > 2.6.4