From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB04E430DA; Wed, 23 Aug 2023 06:34:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B161740A79; Wed, 23 Aug 2023 06:34:12 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id C163D406BA for ; Wed, 23 Aug 2023 06:34:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692765250; x=1724301250; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=pM7kPsH2DHydEuDHupa9XnVUaGUt/L1lWsRwjkyBbP4=; b=JOFq7X4FAtVY4nxXZtIrheO+CsdGS13Xn3El7pk47r8pJetqTazwrmWr 3+hHopJE8/i+g3umwyTCkyIA4U5YyGT23/KVBAOV4n4UsZ9fNmfwSjhRa X6exmauFuGTxHg/Z6QEZ1NffV5F8W4ZkWokEtttR2O9tgoKwS4l1+kt1f G8ZumXfl5ZhUgKq7iNlWAdk+ZLFGmqZckvqn/0nJEMYUmbRjc9lDrD/jL +sRLQu/SDlH26bSPPLa8xzCqXzZfKGUER+LDTAxHW0T3H8G1x1cRhV4oQ XG8gs19h86uh/1qcuwF6cJBu6cXxCfgldrchVyOT69CXPnp6rONikR5e7 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10810"; a="364244230" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="364244230" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2023 21:34:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10810"; a="736518412" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="736518412" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga002.jf.intel.com with ESMTP; 22 Aug 2023 21:33:52 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 22 Aug 2023 21:33:52 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 22 Aug 2023 21:33:52 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 22 Aug 2023 21:33:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WNxMSJGV9oerV46BE/R1WtFlX51XRdMBV5MB6nhahLUI4habFaIBxkGbsjPtdKPKSknANLjvACuLkstjWNMYTDKYPFKveEiLg6IzDGzepf7P/hfzl0Ihlzpm+OuNOrtt1AW+Cs355zpKHM6Rr3X0KtTmR3/CzLe9QcNWqbzctHhoE2eklntJnE+oRO5UAje96rFBVlq3Y1XYyJKVqNTSQZiEm0C5i42Di2FdAwARyhLDMxfkEo9REr20BMzHYXIsbPWnL8RBNep2Z0tDHYayjK7AvU94GUYRQ041cG00jX6zNO4f5rs+RicqXVBAJyr/Pto3DopJOEnghWYefGnnMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vxDi6DzmhSs3bZrweSJFjmFT7IFubr/ntVn51yZItGs=; b=jsezuilGzaL9j749DeM/ny59+xU8w1eBMDi3EFfHI/RA1ezT61ZibMuO7Z30HjCGVW49CLXT3giAOnfUQ+57DuAiCja9GachJtZz8Ot40r5BCpoimKV8DC1YQv5w3lIRyphvQavZNFzbI4NM+DuEHsqS6PD+EXz0uWJWVyu3Q4UG3mU7jG5ae2YHcRCh0GomUogd/jYwcx+coGdAkG2OHyS4M9jpQ4ACVyQpC2eTkkcyH832oL0s9lR7ZRLUmEH3tW+m5A2R+N3Bs5esUwdoisEF6BtJdhDpRRUh0CEV2L7LNlokS5ktDoJlC5z8L0HDQTdrXHD0hX9IMz8GsJ09RA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5832.namprd11.prod.outlook.com (2603:10b6:510:141::7) by PH0PR11MB5660.namprd11.prod.outlook.com (2603:10b6:510:d5::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Wed, 23 Aug 2023 04:33:49 +0000 Received: from PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::765e:559b:400b:cc5c]) by PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::765e:559b:400b:cc5c%7]) with mapi id 15.20.6699.022; Wed, 23 Aug 2023 04:33:49 +0000 From: "Gujjar, Abhinandan S" To: Aakash Sasidharan CC: "jerinj@marvell.com" , "sthotton@marvell.com" , "anoobj@marvell.com" , "dev@dpdk.org" Subject: RE: [PATCH 2/3] test/event_crypto_adapter: skip unsupported test Thread-Topic: [PATCH 2/3] test/event_crypto_adapter: skip unsupported test Thread-Index: AQHZ1Pr24nnV9adBD0KOj0q/T9jP2q/3S4fA Date: Wed, 23 Aug 2023 04:33:49 +0000 Message-ID: References: <20230822131649.3509986-1-asasidharan@marvell.com> <20230822131649.3509986-2-asasidharan@marvell.com> In-Reply-To: <20230822131649.3509986-2-asasidharan@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5832:EE_|PH0PR11MB5660:EE_ x-ms-office365-filtering-correlation-id: 403b7f11-c8c7-405e-7c18-08dba39225b2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sjs37cKwH8tAgyxlmFIOdz8Sk4QPYHocBrH1pTzMyIwmDsraRfloZMsVDoaNMCsA9mA28+wvwJvs2WValeSHQ34DbgU1itctUsKXJ6A/Jc8wy44RziQbZ0xB5BEJ+/ZuaIjW702nIX4dNhtWVi5onqcc7pCb5ILOd85M2nMLiSxrp0nulxHsWLuH6ew/vUUEgWjxPCc1OeESuF+x0XV4zhr2NSybIdB8BpSWvu3WUoi/I75ZS/0uoykuQbXtw/Ng9E5FkQyv1MlXhNlJ20KoMTFPQLH68vQuu3ruMlia52Xmc97t66d6jVrre6zbu+41fOdkMC4gULHvfAD12ooA9+YslxVKH9m2A5s0BotwNJl/qya+tzutSzISFZaE7mSTpxJ2/rsSyHI1G8lv7CRe7Y+30EbStPVihILnu8gTX3wz30ijKxJCPwIL3KS/i1otO871IFBX469/tNngxewL+Ei+7kx404lMDlL5VKOc75MlMvTU3Aclzb46YoePn/Wh3VDIz04LCA+llk51q9+s+cgTrfU7DZ1Xx5HIH9S5kkl2QLXjNbCib+JOTEHupHqq3BJ1fAQuLz2hsDh9TXAGkU7E9PQCdlFByf6hFi2cDknbw3uokHE1x6TxaYtOZVNZ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5832.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(346002)(39860400002)(376002)(136003)(396003)(451199024)(186009)(1800799009)(83380400001)(2906002)(6506007)(53546011)(38100700002)(5660300002)(33656002)(52536014)(86362001)(7696005)(8676002)(9686003)(8936002)(4326008)(66946007)(316002)(6916009)(66476007)(66446008)(66556008)(38070700005)(76116006)(64756008)(54906003)(82960400001)(478600001)(122000001)(71200400001)(55016003)(41300700001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fXIsBC/fFABIsjm/cEvC2amQp9jwtQadgcgaW6vEQZoKP+75rvtgFk8zndzB?= =?us-ascii?Q?XlEQnEesFDy9JZAj8yFZMWeq97Janp0RgHZ7F3la5PjHeiLC2HleFDDgXVdl?= =?us-ascii?Q?YNEtnmLXMsq4dMTFIyncOFiF0TJmfclPgWqng4oQA71Bv2a/U5sOqR3wsr6G?= =?us-ascii?Q?mMQZrSzvIj5b2HEfG4V9sgt7Ci5Us/gsX+fBX3EHNb6bQzUO4xFgh2AgIOzL?= =?us-ascii?Q?jbPCsXEjrP/0bcaQRuM+1DqiAi8138466jDCUBLbrdaVmpnIf6nSWNdxZ6Be?= =?us-ascii?Q?ie3M+c6D3q0bORhJwYxyftuG/0HYMn+sXIq5cfBnCbq9BmGbQ3LQnSbMAfQK?= =?us-ascii?Q?KDfFQzeMHXqz6JeqeVgI2qDgvh2go9chCbTRXM5CL9S55oAscwbzCNK+NwSf?= =?us-ascii?Q?ue0GX71tGP3EP/8q/MKUDgmE9Hkw2AK8HV2i0RcoymoE0r2TJSf+1J29U6JK?= =?us-ascii?Q?LTYWY4YcKB2dbkStSFTrReNGQkSp0jnwmEkA1T1bZ6BTahR6iBhl0I1sWN6e?= =?us-ascii?Q?WYJ45bM8vseWIbvZu2FTTgo5V1RUBPQmaODR/tzMJ2zf0a2fyoOsQbD1McEH?= =?us-ascii?Q?fczcehmTCyq38BIIVVeL8vfca6qV6OSq5rhyDu5PaNmzFowGxirQF10Mb4lI?= =?us-ascii?Q?CGpQVPdTjzxQte4/15MAKX/UlVMZwY9tu5LldHCzwP61qgYF8+eD9Q/sB46E?= =?us-ascii?Q?7tnWPUptNtIQssnc9fKHUBadeSaOxMEUhsVhoXsxbk0u5Ydrh84clhcWxAHC?= =?us-ascii?Q?yYqHUnSDxQyarI/zcyuc8OKWeMY7hiPNOLvplREyqn+drWKUizFHBnMAbPte?= =?us-ascii?Q?YAD+N5pdB4B5l3TKExGKSdGkoa+oDRmGCz5pYnsk8xp3LnlEMaZTEtsdM80u?= =?us-ascii?Q?Qq9jZETNMRXk6im+7cZWU2Ic5Tgck80oj8tEtG3Z84gm5phcWOeA9s8hnWdl?= =?us-ascii?Q?5QdtWPokfbg4o4LQ2z+AWHSZYeLfWz+h1RDKOR9wJIA98TuVhCJJg/rH/MBG?= =?us-ascii?Q?32X+iuNkn63iI4ZrFU9YwlSrjLaWzbulxEl9PCsaah3U3TWMykrEsqp7zVH8?= =?us-ascii?Q?nvA08wJo1yLSW19pa7TBUzfdi3hjbtGcf8SRdm4WXqxILRvP7aeoFfC1FN9B?= =?us-ascii?Q?Itk+J00kJqdSnenN63JrgWccj+W1KyqblfCQdpy9pqk2XaIqNizycPKLBvH8?= =?us-ascii?Q?44yD+halmqFJ6ISH6aRXO/KVlY+zBnx1Uv99FrLpqHXvKkUw2YnRSnfH4RDj?= =?us-ascii?Q?K3MtcvwwMAvaPPGvfHgp/2hd0AuwuIt2Kouh5pfa8p2GZLOckQTfKKTwjaqu?= =?us-ascii?Q?YnD8S5aG/qLkV8hWa8OaAmFp6ZMxDf74SS23FybrkBJGt3ptLlJC7pCmZ/sw?= =?us-ascii?Q?dTvYKP4+QyfmxmdvvQzCaB7r48R86NQPNNblRvG2Jtk5RlvnbJ3vx/yWusPA?= =?us-ascii?Q?hxg2Zdid3h/BcdquVrHtSu7NLXSa7cH+MR/B5xC4Ro5nsmLbDnfbshRRrUyh?= =?us-ascii?Q?1dCOLfCy+hH1nDakwkxe0qg9z9uqmRLXw5h5QrdNfTYn4DY5kaB/yj1QMQKK?= =?us-ascii?Q?sWHXsL2mVEm99T/GfLE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5832.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 403b7f11-c8c7-405e-7c18-08dba39225b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2023 04:33:49.5551 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: X6agDsXdyZbZOqIsRga++dTHvq6z5hILLNgwQdnA1/X3RIFgv2VLjhmaupujwg2wSY9/ckKO45FwC/Ct/U8faPHeZ9JApA+Q34zSGS1hW3k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5660 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Aakash Sasidharan > Sent: Tuesday, August 22, 2023 6:47 PM > To: Gujjar, Abhinandan S > Cc: jerinj@marvell.com; sthotton@marvell.com; anoobj@marvell.com; > dev@dpdk.org; asasidharan@marvell.com > Subject: [PATCH 2/3] test/event_crypto_adapter: skip unsupported test >=20 > Skip the test if rte_event_crypto_adapter_caps_get() > returns -ENOTSUP. >=20 > Signed-off-by: Aakash Sasidharan > --- > app/test/test_event_crypto_adapter.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) >=20 > diff --git a/app/test/test_event_crypto_adapter.c > b/app/test/test_event_crypto_adapter.c > index 24f66be69f..00b20fa443 100644 > --- a/app/test/test_event_crypto_adapter.c > +++ b/app/test/test_event_crypto_adapter.c > @@ -284,6 +284,9 @@ test_crypto_adapter_params(void) > }; >=20 > err =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, > &cap); > + if (err =3D=3D -ENOTSUP) > + return TEST_SKIPPED; > + > TEST_ASSERT_SUCCESS(err, "Failed to get adapter capabilities\n"); >=20 > if (cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) { @@ > -1252,8 +1255,13 @@ test_crypto_adapter_create(void) > .enqueue_depth =3D 8, > .new_event_threshold =3D 1200, > }; > + uint32_t cap; > int ret; >=20 > + ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, > &cap); > + if (ret =3D=3D -ENOTSUP) > + return ret; > + rte_event_crypto_adapter_caps_get() is basic thing to check what is support= ed or not. Not sure, purpose of this patch. Did you come across a case whether existin= g test was not working? If so, please mention that in the patch commit. > /* Create adapter with default port creation callback */ > ret =3D rte_event_crypto_adapter_create(TEST_ADAPTER_ID, > evdev, > @@ -1274,6 +1282,9 @@ test_crypto_adapter_qp_add_del(void) > int ret; >=20 > ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, > &cap); > + if (ret =3D=3D -ENOTSUP) > + return TEST_SKIPPED; > + > TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); >=20 > if (cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) { @@ > -1309,6 +1320,9 @@ configure_event_crypto_adapter(enum > rte_event_crypto_adapter_mode mode) > int ret; >=20 > ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, > &cap); > + if (ret =3D=3D -ENOTSUP) > + return ret; > + > TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); >=20 > /* Skip mode and capability mismatch check for SW eventdev */ @@ > -1475,6 +1489,9 @@ crypto_adapter_teardown(void) { > int ret; >=20 > + if (!crypto_adapter_setup_done) > + return; > + > ret =3D rte_event_crypto_adapter_stop(TEST_ADAPTER_ID); > if (ret < 0) > RTE_LOG(ERR, USER1, "Failed to stop adapter!"); > -- > 2.25.1