From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F035A00C3; Wed, 7 Dec 2022 08:04:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4A005410FB; Wed, 7 Dec 2022 08:04:19 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 6D5AB410D7 for ; Wed, 7 Dec 2022 08:04:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670396657; x=1701932657; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=3EOUeVFZICCNyARGNT7LkUvIit7LjudrTd6rf80rejk=; b=RcZpQct6dc58STajctLAwpG3EGxEy8G5ofyELt9F8Y1lym2xf1oMvkiR aXZNNvFxsEBuGYqV0EwH6kBQ4MS1HHSAHHuLOpYgIwDM9glJI5N3itMXJ HSeFxdjbwbuOYRMrgamnHzK/qF6oDL4ymRyvI8Dc9L5gClvKc2LeLZar+ XNT5/vciasQ++kQoy6FCsVprgweoU1X6PwO7BPPItFglIfnOOXF2nrjd0 4MMaNr5DXrXlLIa34MPfXASO/2etJXv/S9vzZu8wb08HiYyOgiL0i/UGr 4GmF4uMKypM4y9VmiM5PZlNCc/FtI8dLFtWNREFX+AA0HgMuHVkJNjgko g==; X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="315535972" X-IronPort-AV: E=Sophos;i="5.96,223,1665471600"; d="scan'208";a="315535972" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2022 23:04:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="752973395" X-IronPort-AV: E=Sophos;i="5.96,223,1665471600"; d="scan'208";a="752973395" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga002.fm.intel.com with ESMTP; 06 Dec 2022 23:04:15 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 6 Dec 2022 23:04:14 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 6 Dec 2022 23:04:14 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 6 Dec 2022 23:04:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C/xytyzQybKCi61JvtCVBgZIDJNDxsLy8Mp9PSvKTlASMiAphDwSsxRPGSScfrixEVayxrJ4OGC3gd3Ky75YKx7IbjN75nCIRvQXMX3Mlkk/T1AnCRdgxZi7gTf3u0DZetqTv7FiIf1aLSTBCjAfn/PO85bCJsDPrJm1n+W8E50L65AjVMr7i98+jvQ6Bo8Zjcaa4zvH3NMDI12fO57kvqu5UlO4wgNxDooR7cWFrTQYkK7+egM00Zwj4Fp72cojrlOLdepkr8zfVX8Y9SAS2Eg3LU8oZIf8f/vc9y8d1RgSgaxthaDr8Wr/2TxUhDw3cZ3KopEuywxo3KvX6iJiKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aGF1KG3BDUzcnfY4z0HY/2JV101DDp7wmN575P1ewyE=; b=PX5X722ewappANJsPMapN2/kYJHNrR86sbdsZ+7jgvPvLuy4It8l1ZrqZqoH9BylPewzY4LLASyBFmZqiwsYIfRQBh4ZWFomgnXx0Zgkc8xE6X/loNrVYlgb/aYxVQ3FR1pgyrwAEg/2ZzDISRmAqR2/8NddvEhfJZOO8DPLZZLZECp2TP/LlzSbFF6+80ZI6sHcUfT9cxkveXKLk2fyfMyNHueuiqJdjHPV0I2FB5w7jssz15NXX9XI4lMJWayq6U0zknmljiQN/Q+3Xah8aULdwCgZoe+mP+uvMJqBivw9CGwMYET3AImpS9h3UFD4V9qx7LMsoQBl/tggp1+/8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5832.namprd11.prod.outlook.com (2603:10b6:510:141::7) by CY8PR11MB6818.namprd11.prod.outlook.com (2603:10b6:930:62::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Wed, 7 Dec 2022 07:04:13 +0000 Received: from PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::ef44:2061:3d86:6b21]) by PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::ef44:2061:3d86:6b21%9]) with mapi id 15.20.5880.014; Wed, 7 Dec 2022 07:04:13 +0000 From: "Gujjar, Abhinandan S" To: "Kundapura, Ganapati" , "dev@dpdk.org" , "jerinj@marvell.com" , "Naga Harish K, S V" CC: "Jayatheerthan, Jay" , "vfialko@marvell.com" Subject: RE: [PATCH v3 4/5] eventdev/crypto: fix overflow in circular buffer Thread-Topic: [PATCH v3 4/5] eventdev/crypto: fix overflow in circular buffer Thread-Index: AQHZCggchf513ViQEESvus0i2pyg6K5iACSg Date: Wed, 7 Dec 2022 07:04:13 +0000 Message-ID: References: <20221201064652.1885734-1-ganapati.kundapura@intel.com> <20221207064945.1665368-1-ganapati.kundapura@intel.com> <20221207064945.1665368-4-ganapati.kundapura@intel.com> In-Reply-To: <20221207064945.1665368-4-ganapati.kundapura@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5832:EE_|CY8PR11MB6818:EE_ x-ms-office365-filtering-correlation-id: ed967835-c374-439b-a674-08dad8213f23 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ezv6sjyRSYJoGt2e5RebgMJIIsLLT71pfaQzuxFjDdzXNF137sU4v1B7qu2Qa5ZQptutgMOaATbm5msNfQq9+DE7J94099vP1CACX0Ja8rzma206zs7O83L5e1pwzPMQk7VmV19pvy3ipFxqwB3OLkxpdFRGsAZuH9g7Zw5vYKLdjIvvi0hQGUzV6OsuDPCoVRB1N7NIfBWcajoROIPIUBDnyAFlLLj9FavP01NVT/50gM/VFlb2/STzo7ta2gKT3AdV8gQgJ3vgRK5AH6rYD2+927uZAUQcfUh6G4BP5bi26CUCUVF6W+Cr2L5NyeBYMGDZad6xF9ZTIuRbUDaPI0WafiqafkNKGD/YRX7KkU3X/WY3a0pS9UKDsjfRRgZ1twZjfZc/2sLZAS4EVJmw8SF8JRF26GuAIzRb7b/NPrzhewpqAh6AtiZ58ywPoo0BzQwQovwKeSAQa0trGIGzYsLZ575Z1Vco6Il10WhzxkYqzgv+MeEn38FaFg7QqrHVbDAyT/cRqO/CLDAtz+5fF6x5qmmpP6bQmFtsK/NOTxCIwscW9hEHdW/EyhxqafXhhxw/n9+oMnzSaarXgGExp4av/ilJk1hmJbJ6xkM4/rqB8VuRIzB8X1MjVZFsigw0wR8wkp18lB/sova2/Gf3ndznTaep2S3lnJf2nngXAqjOy9nubP5RnqF8ltUgrJgZNywPR82zmDKr/KWV+CSBzw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5832.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(39860400002)(346002)(396003)(376002)(366004)(451199015)(54906003)(86362001)(8936002)(41300700001)(2906002)(33656002)(4326008)(5660300002)(38070700005)(38100700002)(83380400001)(71200400001)(122000001)(478600001)(66556008)(66946007)(316002)(6636002)(66446008)(110136005)(82960400001)(76116006)(52536014)(8676002)(53546011)(55016003)(55236004)(6506007)(9686003)(186003)(66476007)(7696005)(64756008)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?poWSNojDVG5wR46z5reVLsCnlTmu6pAQteUpO1pCzvjlIkQFmtNSqLrlRocj?= =?us-ascii?Q?8+9mnxAMZFvstcMMcWxeHA0a8c6OjWRehKuDYwS6bbodySXxqaPB7tF55NJ3?= =?us-ascii?Q?m9ZqVCs38Li0GTR/Tr6q3n8CMKaemYTyy21BAVQvP14KNLO21QzhlcR7VbmW?= =?us-ascii?Q?x93lem4Qo14dJItU6bRyjkXa1ygNyVyjmVf/5xvs6/37fJezaA/E0s+CYc7W?= =?us-ascii?Q?zEPtYaOm8NW2+Yvg6MV3xx5u81bXvgiju/BVY0m+fMSWsKx4VfalU6A6TIzd?= =?us-ascii?Q?G+0Pb6MfNj/A8lXFyI1Hx7W+utC0XZ0WUxvtjq3wEkPQR0DVdeOO+w4Ybu5c?= =?us-ascii?Q?YKI/DsNyTQsQQUc3BWRjxJc3Q2xEFs5IMRhp7UBPd+A8Ql90MvrqueQTErd2?= =?us-ascii?Q?E3J0pkwtixv2la4m8ahmM9PWI4sgCUTT/UTkWqMu9nRzj3aNr5VZfBcthNRz?= =?us-ascii?Q?Y/SlWf6/eRWbpyZttf+na9UyC3eCYPI7E5D3fom18SiylYt12teJjKby7eUE?= =?us-ascii?Q?FwCaVm/otanffcR3ov4EJQU9VYxOBcgrMhA93I+a04vpaP8vo+sWxACR3Nso?= =?us-ascii?Q?QszoGWWGrrSP79yM7QZA365mN06www3Tvg033hFrpoVDHLrtpHP/BlCef/Rg?= =?us-ascii?Q?Q6NKt/t6qK1wiREq0n/5sP8cUEcxp6BZvwe9ZGs6cPawd4UPy6b/Y3H94sM0?= =?us-ascii?Q?O2G0lUHH6OvJi9QcgRIPROOWBHXJJsLAdievabUafYWIqLVQvIlAbUhpWNSD?= =?us-ascii?Q?T2dmAi/LkN7rcDl8dLkacTqSQ+h4fSM/I3Dstq1mOq4R1l0HhTwrab745XHD?= =?us-ascii?Q?GFTzz0OKJyosmcLCUVzl2yPEEfqnZbHadV9GORH0mUxTzCqoRPfOpQojXZNg?= =?us-ascii?Q?mpz5uQHUslYz3NiQ8vbJ5YPCjjVUAKb26IZqz0UEKjZNu4e6238YWFFlqRa7?= =?us-ascii?Q?8xvwe0nXHcdHH1nBGKlK3D1QT0MZcAmw88azdtbPCoTIH0NEQWeS2/3W6cei?= =?us-ascii?Q?pZAJF2zYHntGYHTS9eqvuwmlaA5MrEOxyrKlAWwtoOJOoscB2tpyn0BTotEw?= =?us-ascii?Q?4jJ92I8seU0nIzBCoz4AltXQscxyoF0zfb1cCGt/8tU74Fyoe76b01MVVjsQ?= =?us-ascii?Q?TBEiKISOM45L46/QizhdAg+y3CaXHvfv/ydPjHMrmn9sfVTTWmn6a7/qJu2v?= =?us-ascii?Q?w5ko9hXg0sjDGECfUqChdN/uKtIiivnXop9Crk02gTf8K2sHwl3KwgqZOv42?= =?us-ascii?Q?lU0SqdGaFkLElyNb1BpBRnE4PcNEnff83e53t74KjmGYeuNbWBJthkj0pgvP?= =?us-ascii?Q?Vg1rt9xRxlU5edbFapt+o6BlmoVImkfT80jVftaJlbCRCKaoruSxh8gzXvx/?= =?us-ascii?Q?sKh3uth4xeV/fv33bs6/pi5YPsvoy25W9JUkQSo6DnZNweEODPG+CrSyFsLM?= =?us-ascii?Q?xrmPNS5m8xWzY7OMjTM3Ydwb1nC2aNGVzNPDKnu86aqNuWzZM1LvIbwQVjwC?= =?us-ascii?Q?IG1HbTtC3CWLnC7P0c9M1snh8GUVWrvo1VJj52sZvt6hNI/58dzdGR2LUwjb?= =?us-ascii?Q?O1mY6RR477Tswe1cgHcruCTiqdgc/h4fitxenUvnEVIUolwLjyLc5LaKuhu3?= =?us-ascii?Q?CQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5832.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed967835-c374-439b-a674-08dad8213f23 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2022 07:04:13.1011 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ri9Kyz0DtjrDQLXxM5TGk/TqCI5ggbgk3GygyzEW0WLMtScf0bWdMUcHk6BKUH81yW3P9blbAjB/OQaPEiG1dgPE29bgfNcaQiu2suHqJv8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6818 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Abhinandan Gujjar > -----Original Message----- > From: Kundapura, Ganapati > Sent: Wednesday, December 7, 2022 12:20 PM > To: dev@dpdk.org; jerinj@marvell.com; Naga Harish K, S V > ; Gujjar, Abhinandan S > > Cc: Jayatheerthan, Jay ; vfialko@marvell.com > Subject: [PATCH v3 4/5] eventdev/crypto: fix overflow in circular buffer >=20 > In case of crypto enqueue failures, even though backpressure flag is set = to > stop further dequeue from eventdev, the current logic does not stop > dequeueing events for max_nb events. >=20 > This is fixed by checking the backpressure just before dequeuing events f= rom > event device. >=20 > Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation") >=20 > Signed-off-by: Ganapati Kundapura > --- > v3: > * Updated commit message >=20 > v2: > * Updated subject line in commit message >=20 > diff --git a/lib/eventdev/rte_event_crypto_adapter.c > b/lib/eventdev/rte_event_crypto_adapter.c > index c08984b..31b8255 100644 > --- a/lib/eventdev/rte_event_crypto_adapter.c > +++ b/lib/eventdev/rte_event_crypto_adapter.c > @@ -573,14 +573,15 @@ eca_crypto_adapter_enq_run(struct > event_crypto_adapter *adapter, > if (adapter->mode =3D=3D RTE_EVENT_CRYPTO_ADAPTER_OP_NEW) > return 0; >=20 > - if (unlikely(adapter->stop_enq_to_cryptodev)) { > - nb_enqueued +=3D eca_crypto_enq_flush(adapter); > + for (nb_enq =3D 0; nb_enq < max_enq; nb_enq +=3D n) { >=20 > - if (unlikely(adapter->stop_enq_to_cryptodev)) > - goto skip_event_dequeue_burst; > - } > + if (unlikely(adapter->stop_enq_to_cryptodev)) { > + nb_enqueued +=3D eca_crypto_enq_flush(adapter); > + > + if (unlikely(adapter->stop_enq_to_cryptodev)) > + break; > + } >=20 > - for (nb_enq =3D 0; nb_enq < max_enq; nb_enq +=3D n) { > stats->event_poll_count++; > n =3D rte_event_dequeue_burst(event_dev_id, > event_port_id, ev, BATCH_SIZE, 0); > @@ -591,8 +592,6 @@ eca_crypto_adapter_enq_run(struct > event_crypto_adapter *adapter, > nb_enqueued +=3D eca_enq_to_cryptodev(adapter, ev, n); > } >=20 > -skip_event_dequeue_burst: > - > if ((++adapter->transmit_loop_count & > (CRYPTO_ENQ_FLUSH_THRESHOLD - 1)) =3D=3D 0) { > nb_enqueued +=3D eca_crypto_enq_flush(adapter); > -- > 2.6.4