From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F36E430E2; Wed, 23 Aug 2023 10:37:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 14AF2410F1; Wed, 23 Aug 2023 10:37:21 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 26EDA40ED6 for ; Wed, 23 Aug 2023 10:37:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692779839; x=1724315839; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=TBNuF/QX5cY4Ks7FD3m6NJ9vqO07rY5hXzbSpKYpqPY=; b=a7AbjC3ziaY83KShGLoji2Z86ui4vZIsfZ4AzhefWvf3Xgcs/GEwcfd3 tk/cEb5CYjh5/evdxf1Z6dILI7zhvamwtFHZQAr1PX5RkrcoeHlNiTA7a AUZuC1E1/c5IkvZEhETuBT1Ue4ZMFJVe5Izu1FHAQTpisN/3icoVfdnDR e72ad86MbZ99PNPNYn0cXeiHO7/bASrO55+Egta60NB0o0gfXQ3P9z6mi 3u5LlS59GxoQv+k4DmxZfC0Qf2t/QPdqsvfMi/IPw8NRsl9lf7EVQKbQ3 uO3TUe85TcvhEMIaIacyO3ZDcyGF+A9VxIK2UjJfgGimJ5NOvxLIQwnnz Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10810"; a="374079299" X-IronPort-AV: E=Sophos;i="6.01,195,1684825200"; d="scan'208";a="374079299" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2023 01:37:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10810"; a="806605563" X-IronPort-AV: E=Sophos;i="6.01,195,1684825200"; d="scan'208";a="806605563" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP; 23 Aug 2023 01:37:15 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 23 Aug 2023 01:37:14 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 23 Aug 2023 01:37:14 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 23 Aug 2023 01:37:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q6Sl20CjCOheekNpKa/o2lhjGTkW9grVEiHadcc4c1sgHqDhhNRWLvHACmY3VU/ERjxAAn2/9Enpi+KIUmIQxCeLRWiqXLCi1XrJn8aAMolTIav63ZwhFEncw4rOOcmJwf0Uxh01csn6IOm9/6yAhKW5OUoUbItl3v5TWqjrdLixTfxNqQYsKHfkQ1RTVpCyaecS0s4aELmOk4JM/iVDVH1VfAQI58kz0PnbDYJBiw1FfQF1kAEb1IrR9+xqGgo/w+68HTorETC29PjbXZhcsXPnbcSac3CFXm1WSCsIosvkLCDaRvZTZ6+YaIJkHa/D5pcpOWr2TgnuOi/PEyuoJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KhE+HAbfMTAJbZOgm8777TzGmmogbZv7FfHOLlZXvGI=; b=cTCp+YN+alnVm1hVPuq5UxLc/eBc6CqlQt8ZEbAO5jyl9Pr1gK2Qu0BPQmlWiC1x+SJE0hnKTSeP55Noy5kWok0oRWTiBk1hivUrMdTA+rFhwt3Xel0xsqIjQKy9OpsY7q+0XdX9WZTeDyGLgjC5GLxGo9Y/8EgMF087SFyJLUWhW0NWBhHAOjXuO13q04/FVtiy8Odf4ddAZdlPQQBLtueGZJ1H/ty3cWLIpP6kZkfJLUUA80EtW2VmrxKpMvJR7aZYgw7w/77VgkDB0o+KvLAzwaDl6Vm4v0b3MEbhrX5e6c+ssuJlbQ4kE1PXDtWvX25y7ZAaz0zT2L7mMiTbiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5832.namprd11.prod.outlook.com (2603:10b6:510:141::7) by PH0PR11MB5080.namprd11.prod.outlook.com (2603:10b6:510:3f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.26; Wed, 23 Aug 2023 08:37:10 +0000 Received: from PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::765e:559b:400b:cc5c]) by PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::765e:559b:400b:cc5c%7]) with mapi id 15.20.6699.022; Wed, 23 Aug 2023 08:37:10 +0000 From: "Gujjar, Abhinandan S" To: Aakash Sasidharan CC: Jerin Jacob Kollanukkaran , Shijith Thotton , Anoob Joseph , "dev@dpdk.org" Subject: RE: [PATCH 2/3] test/event_crypto_adapter: skip unsupported test Thread-Topic: [PATCH 2/3] test/event_crypto_adapter: skip unsupported test Thread-Index: AQHZ1Pr24nnV9adBD0KOj0q/T9jP2q/3S4fAgAA2+ICAAA07gA== Date: Wed, 23 Aug 2023 08:37:10 +0000 Message-ID: References: <20230822131649.3509986-1-asasidharan@marvell.com> <20230822131649.3509986-2-asasidharan@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5832:EE_|PH0PR11MB5080:EE_ x-ms-office365-filtering-correlation-id: e480aa63-9917-4ffe-bf86-08dba3b424ae x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DT1Vv+8Z+8ymyLmJWSwIQUNmQoyYjZOnBrz0wIdWVK/2GqAZVWKgnKkOsrVObYdZmCd54FjMR/ZHiWk8O6+b/Y3K6HZagW7sPBGt1Kz0ByXymgRL6prfqyhXvStDnZjDSzXJkjjGb4jceUo7N9W8174aKLPd5BEGLB0Z8RtNi71l9OH+8YogPtICxFZBRW9RCdiuBZxsa++sS4lNPK4oGYKGl8TKHu73loGaMzot3GL/6NVcAOnLxzMBd4a+20/Lde4EYbNI5XBgMdmi1ESQTwbynFwrAFh25n0A7s6AsGOE3dq5uf/QEx98EMoOnPjl0iCuVp9+7OWxprT1eldqibsPY6VhpA3CplSaoG+ObwoYTWVDHJrDJz+jpI2AeHq54jpr9QEBB52TA9DGOTKwjKR8VjVklAw4YhGTFidU3CeM6BAWdtzFXV6ffztXIS8ObLFAbBXu7gi33+ROxJL4u0KRIQUtBP66lgOVh8oxMoQ9FGVqP2EmC8PSnC2xTNVX+WnCRiTGFIKpWUz1Zo04cJXqN9Bk0Eoe2AM3ztwDPIHES2oivnuk4S2Oe9l2B9KVisjq4F6cYU0IY2Prls/9B5Lu4EMfiQ8HiHM2f52tCRmDLzqYpP/j9ZieRu989WTC x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5832.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(396003)(136003)(376002)(39860400002)(366004)(186009)(451199024)(1800799009)(6506007)(7696005)(52536014)(6916009)(316002)(53546011)(4326008)(8676002)(8936002)(54906003)(64756008)(66476007)(66556008)(66946007)(66446008)(76116006)(55016003)(9686003)(41300700001)(5660300002)(71200400001)(478600001)(83380400001)(86362001)(82960400001)(2906002)(33656002)(38100700002)(38070700005)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nebRJDkgQpDP4zTRZOxspC6mETSqPlgBHm5sNAPA2XQO40B9atJO0WTW//3S?= =?us-ascii?Q?d0UPS/Sd5lv9kFbgrZ4GKVv+2/5xA7f2Qs0QU4hM6bL74rpfTQ9Y/r4WNdzA?= =?us-ascii?Q?pGbNY0o7MeQhKWcXNcdPPrDeg5Gg9qeDFBdM+VYPZMeY15C6S4G6E07OYAcS?= =?us-ascii?Q?5fD1E7asQ/t5n5gaG2ClOHBy37zH4ozYGYdGQdrzK48qHm8tb6F+ntUb/TdS?= =?us-ascii?Q?nHwDAeEYDGZvXplGZQKv3Q70NmTZoe1PkXzzFjoMZ4hdw1CXKfo+G6EuWGyW?= =?us-ascii?Q?hdXikWuDTi5zp13vCck6u3u/sf1LMfBYkBMEsKjWdgF9Fg+mbWsmaU4mCNYY?= =?us-ascii?Q?IjB+Mn6gMT8ii3Mj4zkhyCBKZe3pcqEtD3aNWmm56jSs2VeX1EcXLbZXVZI4?= =?us-ascii?Q?7yQ5RZ1QmnQZLAHeasj69Z8HjWgeNwD/bWK6La96RLEYX4t0tuZX4Ody9ZKz?= =?us-ascii?Q?Hzbul9MY8P9cbkXOCf5LNPKtExbRSPyMqY0JaLW7BcOza2ps0ShMTZq/SRno?= =?us-ascii?Q?asMLJx31DL1YFXXmA7T/WHxSLHltO+FAx/uAzapJ4MyqgEkosdtLz5EpzTCF?= =?us-ascii?Q?nUymA3cxwbYQubikjjtB/uTzKe8UwRGQG2qFLk+XZO/7874yRlEhDjy5p71r?= =?us-ascii?Q?JR5svE2uLei3J8cYajzJLuIu/rrtvYrnli5MM/SFvli4Mzi5Mg6euJRi60Aa?= =?us-ascii?Q?WqhGAhTTs730S5ymbVmqcgDsIYZzsAukFnKoSh7T+6I+k7349Y8Nq8u32rz8?= =?us-ascii?Q?8aRfEMsvpLiaimvwbh9wwu4OF1Eh1nkaGm+2cqtuooI/1INfofmurL2eiH8S?= =?us-ascii?Q?wuIrdH6EjHiar9fh6a+W4jZVrgfSECQUVyRr2THS4yD8gPJKAAkGGQ0QYVsQ?= =?us-ascii?Q?IonGRpkEoMhQknBLMaGsvt4fxetiWY8OjRjOrmczyZMB3J6uIYQmMhAF5H3e?= =?us-ascii?Q?6b1M8vh0extWDGIstg3MHLc5E8Jc2SahHzucuN4mVoUAmwG9EEaZcB5cGANY?= =?us-ascii?Q?EMOIHVU618ahQZAd7yhX4tVDxE4+7O3b6hohPlcZto5b+WDcejoRAXE3LQyU?= =?us-ascii?Q?6JJNbUNMfpJw/iryfaUI8MfdATJ3Sqc1KwuvZEKdQX31z2H4z1OcAC4HWOgh?= =?us-ascii?Q?QAbiAk3wBSRjdDMTT91anFTEqkeoaMPfwhpBFSEJAeraJr6cft4qAqs/393p?= =?us-ascii?Q?83IYksh2/44yZaT6kWssr8TmRYKWtVG0miYpWvNpO4L++LXk1q+QoGPt1Rmr?= =?us-ascii?Q?bIIisrkNR3JqynJuYQpO3CGOdD7CEPUqIjP/L0gWYY7nOhmQ2cr6fe2chBR+?= =?us-ascii?Q?ExnpdjibzInva3ntS4j/zV6Y3Aagzaqwk3vVax8PcdmLkLJniQI9E30mNTAS?= =?us-ascii?Q?IZPPWBGAkbxygJ0nZsLhMCxbIVjGWe4atMLJYtgUhbg3ESXTo6rGpx7ubN1O?= =?us-ascii?Q?YOFmgPHoAnyjVG25yw9SuwgNKUJjc1WGHDZ/vpGCO0jo+qU3jlRRCCgbV/MM?= =?us-ascii?Q?sp7x/bMrgHINxyHgf2es4SPEIYq2lV8u45ouuyI67RObnt4QAz/5eDWSRyZ4?= =?us-ascii?Q?WhTnDnAeVJYa9FLeqcE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5832.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e480aa63-9917-4ffe-bf86-08dba3b424ae X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2023 08:37:10.7358 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zqmjbKycHg5cnVg4gX5ur+aj+6kwTqfoymK4KwNjUklwocE2tojiaKNFGHCOwLcJB2Zai5gHfzrBOXRGaQsiquucrtW417FrpLVvsIJMfdM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5080 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Aakash Sasidharan > Sent: Wednesday, August 23, 2023 1:19 PM > To: Gujjar, Abhinandan S > Cc: Jerin Jacob Kollanukkaran ; Shijith Thotton > ; Anoob Joseph ; > dev@dpdk.org > Subject: RE: [PATCH 2/3] test/event_crypto_adapter: skip unsupported test >=20 > Hi Abhinandan, >=20 > Please see inline. >=20 > > -----Original Message----- > > From: Gujjar, Abhinandan S > > Sent: Wednesday, August 23, 2023 10:04 AM > > To: Aakash Sasidharan > > Cc: Jerin Jacob Kollanukkaran ; Shijith Thotton > > ; Anoob Joseph ; > > dev@dpdk.org > > Subject: [EXT] RE: [PATCH 2/3] test/event_crypto_adapter: skip > > unsupported test > > > > External Email > > > > ---------------------------------------------------------------------- > > > > > > > -----Original Message----- > > > From: Aakash Sasidharan > > > Sent: Tuesday, August 22, 2023 6:47 PM > > > To: Gujjar, Abhinandan S > > > Cc: jerinj@marvell.com; sthotton@marvell.com; anoobj@marvell.com; > > > dev@dpdk.org; asasidharan@marvell.com > > > Subject: [PATCH 2/3] test/event_crypto_adapter: skip unsupported > > > test > > > > > > Skip the test if rte_event_crypto_adapter_caps_get() > > > returns -ENOTSUP. > > > > > > Signed-off-by: Aakash Sasidharan > > > --- > > > app/test/test_event_crypto_adapter.c | 17 +++++++++++++++++ > > > 1 file changed, 17 insertions(+) > > > > > > diff --git a/app/test/test_event_crypto_adapter.c > > > b/app/test/test_event_crypto_adapter.c > > > index 24f66be69f..00b20fa443 100644 > > > --- a/app/test/test_event_crypto_adapter.c > > > +++ b/app/test/test_event_crypto_adapter.c > > > @@ -284,6 +284,9 @@ test_crypto_adapter_params(void) > > > }; > > > > > > err =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, > > &cap); > > > + if (err =3D=3D -ENOTSUP) > > > + return TEST_SKIPPED; > > > + > > > TEST_ASSERT_SUCCESS(err, "Failed to get adapter capabilities\n"); > > > > > > if (cap & > > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) { > > @@ > > > -1252,8 +1255,13 @@ test_crypto_adapter_create(void) > > > .enqueue_depth =3D 8, > > > .new_event_threshold =3D 1200, > > > }; > > > + uint32_t cap; > > > int ret; > > > > > > + ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, > > > &cap); > > > + if (ret =3D=3D -ENOTSUP) > > > + return ret; > > > + > > rte_event_crypto_adapter_caps_get() is basic thing to check what is > > supported or not. > > Not sure, purpose of this patch. Did you come across a case whether > > existing test was not working? > > If so, please mention that in the patch commit. > > > [Aakash] This is required for event_cnxk because it can support crypto > adapter only with crypto_cnxk and not with other cryptodevs. Ok. Acked-by: Abhinandan Gujjar >=20 > > > /* Create adapter with default port creation callback */ > > > ret =3D rte_event_crypto_adapter_create(TEST_ADAPTER_ID, > > > evdev, > > > @@ -1274,6 +1282,9 @@ test_crypto_adapter_qp_add_del(void) > > > int ret; > > > > > > ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, > > &cap); > > > + if (ret =3D=3D -ENOTSUP) > > > + return TEST_SKIPPED; > > > + > > > TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); > > > > > > if (cap & > > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) { > > @@ > > > -1309,6 +1320,9 @@ configure_event_crypto_adapter(enum > > > rte_event_crypto_adapter_mode mode) > > > int ret; > > > > > > ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, > > &cap); > > > + if (ret =3D=3D -ENOTSUP) > > > + return ret; > > > + > > > TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); > > > > > > /* Skip mode and capability mismatch check for SW eventdev */ @@ > > > -1475,6 +1489,9 @@ crypto_adapter_teardown(void) { > > > int ret; > > > > > > + if (!crypto_adapter_setup_done) > > > + return; > > > + > > > ret =3D rte_event_crypto_adapter_stop(TEST_ADAPTER_ID); > > > if (ret < 0) > > > RTE_LOG(ERR, USER1, "Failed to stop adapter!"); > > > -- > > > 2.25.1