From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3427141E37; Thu, 9 Mar 2023 04:03:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C99E641151; Thu, 9 Mar 2023 04:03:52 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 10D7A4113D for ; Thu, 9 Mar 2023 04:03:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678331031; x=1709867031; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Lqz7KoUtYwDv3b2dCZdtVnBJa/YhENyOkoBSEx1ABCs=; b=U8fcoeuyTMCJZBL7Pxj0AP3/k5ebPfL86TxB8NIVQierhtNpiHc7FNhk 1VEqM/kaHMwU0csJmw2Pg0EltJDbEhdShXz9CamWRXnbNVTTcUsJpkzZa N2tn6M/Ece/KWx5JjXxZ1trV+FKdjkYf1059B3ePU2uLFZFchM1MVJgR8 YItlDWrUYj6A0j9AIuskPhAP5mHl21GjEHim1ypAhWEfdHqkB3V0PpSEX PVCH8pgEERut/Ck0r5zszsEouNMp7flcXulsv8M4WVNWyDXVAnDnW+AMu UHHCFC0Y3AQch1ZbvJrG/xFYCCm02gIJ2VC/RuOBdPNXwngesrnM+8g1Q g==; X-IronPort-AV: E=McAfee;i="6500,9779,10643"; a="363975330" X-IronPort-AV: E=Sophos;i="5.98,245,1673942400"; d="scan'208";a="363975330" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2023 19:03:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10643"; a="766259710" X-IronPort-AV: E=Sophos;i="5.98,245,1673942400"; d="scan'208";a="766259710" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by FMSMGA003.fm.intel.com with ESMTP; 08 Mar 2023 19:03:29 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 8 Mar 2023 19:03:28 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 8 Mar 2023 19:03:28 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 8 Mar 2023 19:03:28 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Wed, 8 Mar 2023 19:03:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AAJly1o4/F57NDH8Mc1+oTD4d2GHbAauAhM7iuteTGXSEgWIRB06WnnzqDHYEK5blmSz9sqBnR2RwCy3OK2XfFJTykw36ICvBYKYNG+pOG4lAJd7cD0CLbZi8KhqPBVTVITGk4rdAXvZboKmFORNCsg8+qSDKb/xzQdTMjJPu7xv1KzSAaTQjsbNALjHJ8e1wacMlvs/4l1xiL3NbIqExJ4Q4vccGtZ3gpqoPSTSG7oxo6fdb0rMnieaeKSHXL8aXw2otTERemXvfsuWBWxY4HsWPOg39dXp2ToX0rt7mYx20A8lbr4CH1gGZBjJW6ZmjHeNHe5xCUUQZwY26HJ7og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SOm+m7/0xTetV7238IOTUUnDiOlOEYNy07rIGD6cjaM=; b=EJPvM3aa6JbXlW/wWhnt7iyro4pVSnb+vve8SvWm5iZgOvpZGmVXaF62BuSJFiKCQJGSGhH0spF93jejO+i/M2kAmiHQDGk3byxbQeJ+h2Isu3pO+bUAl6+yz00sPSm2VipTwsLkl7e2scMmdPSUbdqa4K09WxDwYfEW6DuXr8rDf89ZAfW05tcDqlj8kZut2B4+u2gobFnXU+QU/2GoG1uj4nheAUuEFNoLo0yp1sj2Hk664mU+VyLBOO80JgN1DW6T2gqBD7/3KUfeHFcB1J9WCLcKQpfxhrk7R/ZW2LWwNSO76psaDVxtZW7vH3BvUrONJlCfvPPAOZejcEG22Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5877.namprd11.prod.outlook.com (2603:10b6:510:141::12) by CYYPR11MB8305.namprd11.prod.outlook.com (2603:10b6:930:c1::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.29; Thu, 9 Mar 2023 03:03:26 +0000 Received: from PH0PR11MB5877.namprd11.prod.outlook.com ([fe80::73e:9f2f:1bef:8263]) by PH0PR11MB5877.namprd11.prod.outlook.com ([fe80::73e:9f2f:1bef:8263%9]) with mapi id 15.20.6178.019; Thu, 9 Mar 2023 03:03:26 +0000 From: "Liu, Mingxia" To: Stephen Hemminger CC: "dev@dpdk.org" , "Xing, Beilei" , "Zhang, Yuying" Subject: RE: [PATCH] net/cpfl: fix a compiler issue about virtchnl opcode Thread-Topic: [PATCH] net/cpfl: fix a compiler issue about virtchnl opcode Thread-Index: AQHZUi0wlF8phgK0wUKxq4dWodtOfq7xvQOAgAAF0NA= Date: Thu, 9 Mar 2023 03:03:25 +0000 Message-ID: References: <20230309103142.276726-1-mingxia.liu@intel.com> <20230308184143.32a8a6d0@hermes.local> In-Reply-To: <20230308184143.32a8a6d0@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5877:EE_|CYYPR11MB8305:EE_ x-ms-office365-filtering-correlation-id: 21f9ecfe-14ad-4d76-2c7b-08db204ad9f6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ral/V9WP+V9aNL2cdUzfshlnBV53vbHL0mI/fkioqSPsROBRnRIKkh3eeUjnr/gp1Ni89UdUTXPjZtAn3DWQOgRJ3zE2wbaYrUQFiz6y9a/mb8etkK8e4BT5I0C4YdPuilh3/ZNSAsiHBPSPISAFnkFpZr0bmwW5nsZEqNpE2yivBToyR8pkhkVF1+uk8clr04RzFTRt339hKaWV/kP+tgHr6mSt+whwuXoOc54Wheh1VO57dRRHBPc1h8CdS3qb/d/6E0976QY83wkDB0I/+YvTyxQ4/2ERBVF/y+oExVrTlcwuybbqkRp4uvTPFOKZWIOu4uvnROF/bCI1Nz4jt24ulIT5rPqfuhW0op77yomHWU1Ojq/lwJ8i5hwgcBP1WzOsFEUep359oHDlwx9pdtYTXBNICcb3O6sOyeGr3le1rLTa1bGGB3myKLx/qj00w996ZUtEI79N/UGlAlqHeXgd88mCAgFIhkZiE67cP4qBDozeXmlvpUsj2oC3dCcZN2O/uGWGyo1jKNkKBS4xcf7/+gSB4rRpqlgtcMkTy+cyVcxwLrWf25bvyGtfVwC0yg8xhAJEiC9/dfgBJQGybSuUq8faiHm23PRl6bxis35J7svcSYrnJQ+4p5xohSHJadvFKKTHz9Huv5udctXCiVr251vU/Anto+JXBCKv18lXSeRT6b8quudTeW0FJkcq+H5yVZXDJFZoiuPJspcxzA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5877.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(396003)(39860400002)(366004)(346002)(376002)(451199018)(6506007)(316002)(4744005)(2906002)(38100700002)(26005)(86362001)(82960400001)(76116006)(107886003)(6916009)(4326008)(8676002)(66556008)(64756008)(66476007)(66446008)(66946007)(52536014)(478600001)(33656002)(8936002)(122000001)(71200400001)(7696005)(5660300002)(41300700001)(55016003)(53546011)(186003)(83380400001)(9686003)(38070700005)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RxVPH0dOpaI0uCbMrAB91yXqlEqwMEagCBQzN8MWn0gje8JHm84DDOolsflw?= =?us-ascii?Q?64UwY6+aduL0cDMt0LXR01DZ5tFSoeNmgEyyDPA2GO4T0xseUIVdu7KwPDkS?= =?us-ascii?Q?kHb+o0ggg11/Kzy8TQYwIfqjQt8okHcPCpvnwp3vYI8fivre4rPcULecCLic?= =?us-ascii?Q?DxdpYgLDMAVYAeVhZRMbDmb/4JE14evqipFu0rXc2q+MVSM3nyKKOQdPPVxW?= =?us-ascii?Q?e4cHDQJTGPaick1hFsAPaspt12NeYdgIi6c/WugGogq5sdtkRLb+DlIUXRtc?= =?us-ascii?Q?qHFwCjRrcz3oPBvBAMY8lNBxcFsO+aTjMxZzzrTaJWEZwnYFKEg4OfnwYOrY?= =?us-ascii?Q?fwuJkQFfn/DFexwg9CmlvF2JRJbshuGAlEIdB+ZHZFecL4QXGZm8SvEotPtb?= =?us-ascii?Q?AM1fCuVsRD5RmG2K13aI9SsK7Cr4B2ROONwmm6CKQnIgl/i8AcfKgkzLlNGR?= =?us-ascii?Q?riR4aE/dfv8NifCWuxfhy9NdiiZ/eziV104OMNG8iFZQA6+T6GfOb2kTS2ar?= =?us-ascii?Q?tgYBgelZgUWiEFXFQTH9MgPHZFqKyLtbtLVQfOgdqaPmbCaIzHncP/+4qlW4?= =?us-ascii?Q?tNqLlkbynI0QjKHlhjYuDLgRSHYStVyJLq8A086wgBmze8g9riWK2b4GrAgr?= =?us-ascii?Q?p6jFuOsqIM+vp+EMXN1RDO28mEZTitoHY35/UJbX3AZPceewyZOTsut2OrqY?= =?us-ascii?Q?cynVI1umuH1Jsbz0SaUqeuHJV2tRvIZIm09U8GMoJdAi9XaiHpEbSQpIElgs?= =?us-ascii?Q?3V+dr2rywwx1utxb2FgdrS0BAn5qg2XrXDsNB9RrtnQ7ml1IWHc35vslZYQ1?= =?us-ascii?Q?1pM9hmjNhy5asfaZ1ZEUIANJ+qLGXcMYPV+W7kJeAxfXzr+g+8jJHbyZgNX2?= =?us-ascii?Q?Vlbr2cns7Jz5GI9rZ8FQfwX9sIBGlUaByC3Nk8A5wHrU6ATDKWnnC6MfWG3A?= =?us-ascii?Q?wKPQ+1ZWxpLBLRj7E4hYeLG7QRQKpC6VR06yc1lTwPSctnK+bwoHvKHgfxTZ?= =?us-ascii?Q?Gy/Gwga6y9gZ51m/r2N7yds30SpZAu8C5K2ZlEUikWQq+Ih+t3wYTkyVlJbY?= =?us-ascii?Q?LQLxTH20UPh8slqf12KfiDMtp+P3sAAdYsrbsKG/TZlHTDa+heu1RF+0NKWR?= =?us-ascii?Q?tAdSHhuGHuKKGj4+gIaYz8t1Cpz1RLMyLMAnd2n4S76NQWGYXCTXSqGGgA4E?= =?us-ascii?Q?EluxH9RpIN2xdrDMSBsmu98SIk39sy1+zt+P9D+RbIfs0qGD0PIar9LUkoal?= =?us-ascii?Q?lEtguBFx9z7R8pDawQIEFzK2eUjnz8/eVrhGbpjNdqXkzcMqCQn//qcBAWBO?= =?us-ascii?Q?WB7blA+H7jpDkUaY6jfJ//xZj+IvyT7zqWr7+gKCtWc7cS3K3HMUHtkYfy//?= =?us-ascii?Q?VGKu9BYgl65TAZC/PVxa6thsfGxelvbl4L+BEnPd4wCdSkFYHOl0uYvE2pJ+?= =?us-ascii?Q?w++kmlDqzNqdZVZmGtGNETjtHjAh+ODTA3IPotLAWgpQVKufMeSnybIEe4Bw?= =?us-ascii?Q?j3LgDeJAhKZFtNrvmFVzjaHhvP5Xdwn1NagQCUhthFgDB37PjD7C+xVqr71h?= =?us-ascii?Q?zkOgAEbwRwWDQNYYdmKbOgNOqTd+FWO61G15TGDd?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5877.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21f9ecfe-14ad-4d76-2c7b-08db204ad9f6 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2023 03:03:25.8890 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BBRmWP8BE5P6dJGeFmVXbIv+6ApQoLucLKLz5ON0fOBbj2vDpxwCyvE0FG1tLM8t3DK9+uFjByXs/Sv6ctyOhw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR11MB8305 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Thursday, March 9, 2023 10:42 AM > To: Liu, Mingxia > Cc: dev@dpdk.org; Xing, Beilei ; Zhang, Yuying > > Subject: Re: [PATCH] net/cpfl: fix a compiler issue about virtchnl opcode >=20 > On Thu, 9 Mar 2023 10:31:42 +0000 > Mingxia Liu wrote: >=20 > > iff --git a/drivers/net/idpf/idpf_ethdev.c > > b/drivers/net/idpf/idpf_ethdev.c index db58157ba3..59883af8a8 100644 > > --- a/drivers/net/idpf/idpf_ethdev.c > > +++ b/drivers/net/idpf/idpf_ethdev.c > > @@ -1058,8 +1058,8 @@ idpf_handle_virtchnl_msg(struct idpf_adapter_ext > *adapter_ex) > > struct idpf_ctlq_msg ctlq_msg; > > enum idpf_mbx_opc mbx_op; > > struct idpf_vport *vport; > > - enum virtchnl_ops vc_op; > > uint16_t pending =3D 1; > > + enum virtchnl_ops vc_op; > > int ret; > > > > while (pending) { >=20 >=20 > Why does order of declarations matter here? > Compilers are free to reorder this. [Liu, Mingxia] Unused changes, v2 was sent.