DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] net/idpf: refine dev_link_update function
@ 2023-06-26 11:14 Mingxia Liu
  2023-06-30  8:27 ` Zhang, Qi Z
  2023-06-30 18:55 ` [PATCH v2] " Mingxia Liu
  0 siblings, 2 replies; 8+ messages in thread
From: Mingxia Liu @ 2023-06-26 11:14 UTC (permalink / raw)
  To: dev; +Cc: jingjing.wu, beilei.xing, Mingxia Liu

This patch refines idpf_dev_link_update callback function according to
CPFL PMD basic code.

Signed-off-by: Mingxia Liu <mingxia.liu@intel.com>
---
 drivers/net/idpf/idpf_ethdev.c | 63 ++++++++++++++++------------------
 1 file changed, 30 insertions(+), 33 deletions(-)

diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c
index fb59655555..bfdac92b95 100644
--- a/drivers/net/idpf/idpf_ethdev.c
+++ b/drivers/net/idpf/idpf_ethdev.c
@@ -30,6 +30,23 @@ static const char * const idpf_valid_args[] = {
 	NULL
 };
 
+uint32_t idpf_supported_speeds[] = {
+	RTE_ETH_SPEED_NUM_NONE,
+	RTE_ETH_SPEED_NUM_10M,
+	RTE_ETH_SPEED_NUM_100M,
+	RTE_ETH_SPEED_NUM_1G,
+	RTE_ETH_SPEED_NUM_2_5G,
+	RTE_ETH_SPEED_NUM_5G,
+	RTE_ETH_SPEED_NUM_10G,
+	RTE_ETH_SPEED_NUM_20G,
+	RTE_ETH_SPEED_NUM_25G,
+	RTE_ETH_SPEED_NUM_40G,
+	RTE_ETH_SPEED_NUM_50G,
+	RTE_ETH_SPEED_NUM_56G,
+	RTE_ETH_SPEED_NUM_100G,
+	RTE_ETH_SPEED_NUM_200G
+};
+
 static const uint64_t idpf_map_hena_rss[] = {
 	[IDPF_HASH_NONF_UNICAST_IPV4_UDP] =
 			RTE_ETH_RSS_NONFRAG_IPV4_UDP,
@@ -110,42 +127,22 @@ idpf_dev_link_update(struct rte_eth_dev *dev,
 {
 	struct idpf_vport *vport = dev->data->dev_private;
 	struct rte_eth_link new_link;
+	unsigned int i;
 
 	memset(&new_link, 0, sizeof(new_link));
 
-	switch (vport->link_speed) {
-	case RTE_ETH_SPEED_NUM_10M:
-		new_link.link_speed = RTE_ETH_SPEED_NUM_10M;
-		break;
-	case RTE_ETH_SPEED_NUM_100M:
-		new_link.link_speed = RTE_ETH_SPEED_NUM_100M;
-		break;
-	case RTE_ETH_SPEED_NUM_1G:
-		new_link.link_speed = RTE_ETH_SPEED_NUM_1G;
-		break;
-	case RTE_ETH_SPEED_NUM_10G:
-		new_link.link_speed = RTE_ETH_SPEED_NUM_10G;
-		break;
-	case RTE_ETH_SPEED_NUM_20G:
-		new_link.link_speed = RTE_ETH_SPEED_NUM_20G;
-		break;
-	case RTE_ETH_SPEED_NUM_25G:
-		new_link.link_speed = RTE_ETH_SPEED_NUM_25G;
-		break;
-	case RTE_ETH_SPEED_NUM_40G:
-		new_link.link_speed = RTE_ETH_SPEED_NUM_40G;
-		break;
-	case RTE_ETH_SPEED_NUM_50G:
-		new_link.link_speed = RTE_ETH_SPEED_NUM_50G;
-		break;
-	case RTE_ETH_SPEED_NUM_100G:
-		new_link.link_speed = RTE_ETH_SPEED_NUM_100G;
-		break;
-	case RTE_ETH_SPEED_NUM_200G:
-		new_link.link_speed = RTE_ETH_SPEED_NUM_200G;
-		break;
-	default:
-		new_link.link_speed = RTE_ETH_SPEED_NUM_NONE;
+	for (i = 0; i < RTE_DIM(idpf_supported_speeds); i++) {
+		if (vport->link_speed == idpf_supported_speeds[i]) {
+			new_link.link_speed = vport->link_speed;
+			break;
+		}
+	}
+
+	if (i == RTE_DIM(idpf_supported_speeds)) {
+		if (vport->link_up)
+			new_link.link_speed = RTE_ETH_SPEED_NUM_UNKNOWN;
+		else
+			new_link.link_speed = RTE_ETH_SPEED_NUM_NONE;
 	}
 
 	new_link.link_duplex = RTE_ETH_LINK_FULL_DUPLEX;
-- 
2.34.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2023-07-03  6:51 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-26 11:14 [PATCH] net/idpf: refine dev_link_update function Mingxia Liu
2023-06-30  8:27 ` Zhang, Qi Z
2023-06-30 10:46   ` Liu, Mingxia
2023-06-30 18:55 ` [PATCH v2] " Mingxia Liu
2023-07-03  2:21   ` Zhang, Qi Z
2023-07-03  3:17     ` Liu, Mingxia
2023-07-03 11:22   ` [PATCH v3] " Mingxia Liu
2023-07-03  6:51     ` Zhang, Qi Z

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).