From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8FA4542502; Tue, 5 Sep 2023 10:30:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7282F40270; Tue, 5 Sep 2023 10:30:47 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 95AA64026A for ; Tue, 5 Sep 2023 10:30:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693902645; x=1725438645; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=iod2clDCMLH0Sq9PcDaCRl57K8uFJiuBX92uauqYVng=; b=kaHpBJe1nqSb8U4Zmd1asn4Oe0DSD8Qf9rC+w8ptjWtkaV/cre9TuOlm 76W04/iSHG0PQ+ofiZjOszonARNySJh0LmxXA3U7BT1ok/5PHda4sUPdM 5EL7bJdXK7KPABaiQ4H/sGHJ4o0RVicVpslzQ4EaxcHRt+RGmRnr0g11q ykwWIeWu4llmDsC3K8LOAr+CFCBknqhlZzBZz/HICFg8uFv87ie0hMJoO 0eP/jqj+DKBdYn1jhzcJv0M0E9GjhGmmSey8Db60GViL92zksm/qxFNVP bSBKBhZj6OZK6MOm7Rq9TOkrcCGq8dQ1rq7EqdGlf9CtGOP7OsIXDM8OI w==; X-IronPort-AV: E=McAfee;i="6600,9927,10823"; a="407726576" X-IronPort-AV: E=Sophos;i="6.02,228,1688454000"; d="scan'208";a="407726576" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2023 01:30:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10823"; a="770261208" X-IronPort-AV: E=Sophos;i="6.02,228,1688454000"; d="scan'208";a="770261208" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Sep 2023 01:30:38 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 5 Sep 2023 01:30:38 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 5 Sep 2023 01:30:38 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.46) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 5 Sep 2023 01:30:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L7o7iAu4r28h9+vDYDZR1RJgRR6VyGDeWnFPCXiiK1+37BnMRnNf3kaF3pkTNOPIiYIBlmFdDAMsXaccJIq+t4Egobqtpqygu6iu6kYiFf3gNCELYhXzvMGn4vK0JHXyShcPasNHDsw0xnUQizrW0MWtjl0l0o5qYEdeBOPdJsqS6JE95pDn8JSeEUyvBPfl9gj20TOPmPrfj5zzkSeCK9rh+hz9rPUyR8E+XYtlqnWQhOAAtnTSRxcDm7clZw0CAbJrfjm8lj/Q8LHRvhPHwfvG1532gO1eqPs+R9Yj60COYn1NIcQUKR3VMLN3VMQA03B/wv6QNvJz+QyevoiAug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=veolRyIxUSW8q0ZIMHlQGYY/bSXkNGRP0RJ9e+f+pMU=; b=jJiI3JY7ui3c+PxtPszyI17gjavbi17jUiEITg/G+fcASb8oM06kd5mKzZAni0N8X/i4GGjKQUzStnHCn+Y2emBVWbCztTFm/uSwncX52kkcmXeG33a3BcphLVnu/h3Gi0l0Kvsa2sOkmhCt8CALy4FdSgun/3hVRe4+PVx36lurQMF5ee9l/wE01gzcC/SYnM7x/VHcCZXiULoth4MxB+8tk7L1q6oUxs4mBD1SDopOjZXkiTf5ohC47LS6mD1zBnKjWgekGgSAIKbJ+GNqf4i8pVH4RkCIKgSdzI9WXPB9BLXy9yfu+6xJra4/AheRWrW3B5nk1s/mJ77HfP1lYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5877.namprd11.prod.outlook.com (2603:10b6:510:141::12) by CO1PR11MB4819.namprd11.prod.outlook.com (2603:10b6:303:91::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.33; Tue, 5 Sep 2023 08:30:35 +0000 Received: from PH0PR11MB5877.namprd11.prod.outlook.com ([fe80::95b7:4291:8e30:e19f]) by PH0PR11MB5877.namprd11.prod.outlook.com ([fe80::95b7:4291:8e30:e19f%5]) with mapi id 15.20.6745.030; Tue, 5 Sep 2023 08:30:35 +0000 From: "Liu, Mingxia" To: "Xing, Beilei" , "Wu, Jingjing" CC: "dev@dpdk.org" , "Zhang, Qi Z" Subject: RE: [PATCH v2 07/12] net/cpfl: create port representor Thread-Topic: [PATCH v2 07/12] net/cpfl: create port representor Thread-Index: AQHZ0A1tXnobzLE3iUGkeeCj4fWkL7AMAg2w Date: Tue, 5 Sep 2023 08:30:34 +0000 Message-ID: References: <20230809155134.539287-1-beilei.xing@intel.com> <20230816150541.144532-1-beilei.xing@intel.com> <20230816150541.144532-8-beilei.xing@intel.com> In-Reply-To: <20230816150541.144532-8-beilei.xing@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5877:EE_|CO1PR11MB4819:EE_ x-ms-office365-filtering-correlation-id: 9f13c032-aa01-4eea-fffb-08dbadea6017 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TC8kr4HKAuBqNmwynroLgo82BF55aS6KtAOjkvGf9L4jHTz16MweUAiexE0eUyE/44wvZ541hV5IzTSLSQba6ycEYodGmX1NZzIxJW217fdrbSqewzYD3wDthnZhftvtat3QDBA2cctv/G5bh0rZgD9vOfOzJ2dpFRlaS34CISDWPVsmbSyTRLcMOsrmXIQVcMqUbEzVs9RjShp4RedmK4tOqeHn75mho7ksosDxMRhZWQbfrcX5P8Znzu2ku170+nZ25i6TygHDit84I0snSKO67VoiHaruDKlzm8K1xwUnAxDysqAsI6l3QqYDD5IQl52Wu1+aCbBRqHDXoF8pPTGujJDyNQpYsZLBCUqgZn78zSqj92eU9K3xtlrDZwvb1H3ecbGRUBvSMEr9sxlEb7/oCfp5PpLqaHRnKSHShoI0OUL0Oz5EpGQc4bLit7Xv7LVenhQJDfu2mGy19ZFgf6GkZwOju0H19vtSRVOmnpUyeGRJJSTepLPtzfroaWvngAtFk6dTIaR9/dsVhaX2/klR1wcSV2GiifkoItufshh1bwlXRYKY4ZlpVb2HyP+QC3CbEZowRRgdmojYbh3x9UxZKcBuWu/SbyDLu/aZnyChHLFzmC9O25AW1OHe+R6g x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5877.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(136003)(39860400002)(396003)(376002)(346002)(451199024)(1800799009)(186009)(8936002)(5660300002)(110136005)(316002)(54906003)(6636002)(66446008)(66476007)(66556008)(2906002)(64756008)(66946007)(76116006)(4326008)(8676002)(52536014)(41300700001)(6506007)(7696005)(55016003)(107886003)(26005)(53546011)(9686003)(38100700002)(122000001)(82960400001)(71200400001)(478600001)(38070700005)(83380400001)(33656002)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?um3MxgVxQhD/VTTLK1VRffDYS+VXtLHjqZ5FBbnU+tnmo3bppmFH35RYGr8O?= =?us-ascii?Q?zKRTJZiy/ZZAYE811xJdDCV/gwaAqwsg0gETUXaxaurPsMoS3dr7jgEtiCkW?= =?us-ascii?Q?aeCjsFVQJAPnTfJp8xDYhvdEpMMiZgQjk96rHlizKmDmFBBqbruHuCEzab30?= =?us-ascii?Q?HuYoJOdbPSQlEafMMomA/hQbhyZIjhb2YCy8d63wOmX1/U7Fduaw0BCpsPKK?= =?us-ascii?Q?ZkdIXTF1eAMy4bZleQw56cCqMsqwJxnVIh+pjxs2yT8xejYomHJS6L1ef/5N?= =?us-ascii?Q?XKPyh9CZM3ucsqSCBAWX5RJ0BRGXQCrzlih/L+Ja94D70Kc8HjbRsetrHgBv?= =?us-ascii?Q?UzA1e0c6ACcLawsocrXDBNehLe28dGIEl+56g3ENGov21iJzdQ0yS8l0g2+h?= =?us-ascii?Q?MOh9Opp/huL+iL3ak2s/BFnoA/8aArDQr7dwlF2mFkECJLG1lMoxzTI53AuH?= =?us-ascii?Q?PqQJGNYlhciGtLhoO2qIr9v+Ah4fnA1ctPI0L3EsQIYCjAOMeMSTMgj7QlaW?= =?us-ascii?Q?l1j9rcHYK9DcC36ye8QRU6C+XpaNGqEBJSEm+1l4SzrxzbmQoqXRJ6JJEbA5?= =?us-ascii?Q?Z7N4sS/l6epJtj6462Lg6Ky0rArIxWj8Ds1aiILlBb7j4leLhWMIDxctlwgP?= =?us-ascii?Q?wA2NSKjdM9VqliXso0BuZD31ei8mp5Tgt47+IdOgHVwA+n7LFNSziY7zmXE9?= =?us-ascii?Q?y0J+qRVQR/FRGzS0cf4DMW4wbrbkefZXq6V79QTuy2+SYYBK8tWQCoy3wR+S?= =?us-ascii?Q?v+qvjj8Natn0ujKwzbFmkRlDkchxic4VkpJ3Yumym4sFyewzBcc8pWuDgBi4?= =?us-ascii?Q?GdekFXjnlz72uPHl1aQCUi4SDC764BUN+LUoJqSlq4TTS98s1kAmx3JsJrCp?= =?us-ascii?Q?TJQwJBNfMz+ccyV4T0S2EVgjr53U3q/knh0SXuxJm478S+fiHHMXs6ryvGj0?= =?us-ascii?Q?T5RS95F+qMgKozrodS5dW+hGolLsynTnch6Sqa8ArQ5pB7reZwpJs5gvq+e8?= =?us-ascii?Q?8bGy+QMAYTqOrr9s5FsFGCumPVrV4p9qcPt4s/dsmx3gW5i9OlEjW12y8gy2?= =?us-ascii?Q?UskxRoyJSRuf9yl/8QHOsmR8KwFLRE25rPar51jCbFwsvq+nHkhHF9+bIweP?= =?us-ascii?Q?uAjntlYxAi9dqjHiyP/IxXGDovwS3Ob+9Tg2/Kow9JdilPPHqWn4PtPwvepI?= =?us-ascii?Q?ZCyiLtYtr2p/hPtFyit4ff0CpYq4yC4MaCSxC4LZDQZPV60JqZlq2TysL6/8?= =?us-ascii?Q?vKuhlYUn6yFtcDxptkAsGK9gz4UMGjuZA//G5hXnMM7AKWjC86BahlU7EWKj?= =?us-ascii?Q?AYrPSIih5gTcWY8aQEBbQGTjxl93qcDWYHEE5d1CRhCW+D9fEllGF7dVc2NS?= =?us-ascii?Q?Zl6XTlb3Ih3uzM4E7B3qsobcD5mFWa/B10A6MIxjoghFoHTXw7MDXY5lVibt?= =?us-ascii?Q?3zQB7iw3O5ST5KxxVijc0HGF9NoQdplKXYkXwyzyEhG6PBa4DnatFG6x3IkQ?= =?us-ascii?Q?/+eQ02Hm+sUiUGkBxUHPtf7QXsXRvLSmE2Fop9mqr/vBQEPOYwdYaDJxf1QE?= =?us-ascii?Q?90I9Jv51sh3oyW4zfIAQX/QgCSh/OjguFeQ6bWG/?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5877.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f13c032-aa01-4eea-fffb-08dbadea6017 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2023 08:30:34.8604 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +31gKmoc0cCFVoyyuLDcwCp2r2mNR03QLvHMO+kb0G8jQ5eu+684hjV+QZ8WpdQPHhVnTKpRg4G8OnRpJVq2gw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4819 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Xing, Beilei > Sent: Wednesday, August 16, 2023 11:06 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Liu, Mingxia ; Xing, Beilei > ; Zhang, Qi Z > Subject: [PATCH v2 07/12] net/cpfl: create port representor >=20 > From: Beilei Xing >=20 > Track representor request in a whitelist. > Representor will only be created for active vport. >=20 > Signed-off-by: Jingjing Wu > Signed-off-by: Qi Zhang > Signed-off-by: Beilei Xing > --- > drivers/net/cpfl/cpfl_ethdev.c | 107 ++++--- > drivers/net/cpfl/cpfl_ethdev.h | 34 +++ > drivers/net/cpfl/cpfl_representor.c | 448 ++++++++++++++++++++++++++++ > drivers/net/cpfl/cpfl_representor.h | 26 ++ > drivers/net/cpfl/meson.build | 1 + > 5 files changed, 573 insertions(+), 43 deletions(-) create mode 100644 > drivers/net/cpfl/cpfl_representor.c > create mode 100644 drivers/net/cpfl/cpfl_representor.h >=20 > +static int > +cpfl_repr_init(struct rte_eth_dev *eth_dev, void *init_param) { > + struct cpfl_repr *repr =3D CPFL_DEV_TO_REPR(eth_dev); > + struct cpfl_repr_param *param =3D init_param; > + struct cpfl_adapter_ext *adapter =3D param->adapter; > + > + repr->repr_id =3D param->repr_id; > + repr->vport_info =3D param->vport_info; > + repr->itf.type =3D CPFL_ITF_TYPE_REPRESENTOR; > + repr->itf.adapter =3D adapter; > + repr->itf.data =3D eth_dev->data; > + > + eth_dev->dev_ops =3D &cpfl_repr_dev_ops; > + > + eth_dev->data->dev_flags |=3D RTE_ETH_DEV_REPRESENTOR; > + /* bit[15:14] type > + * bit[13] xeon/acc > + * bit[12] apf/cpf > + * bit[11:0] vf > + */ > + eth_dev->data->representor_id =3D > + (uint16_t)(repr->repr_id.type << 14 | > + repr->repr_id.host_id << 13 | > + repr->repr_id.pf_id << 12 | > + repr->repr_id.vf_id); > + [Liu, Mingxia] how about use the macro variable ? #define CPFL_REPRESENTOR_ID(type, host_id, pf_id, vf_id)\ ((((type) & 0x3) << 14) + (((host_id) & 0x1) << 13) + (((pf_id) & 0x1) <<= 12) + ((vf_id) & 0xfff)) > + > +static bool > +match_repr_with_vport(const struct cpfl_repr_id *repr_id, > + struct cpchnl2_vport_info *info) { > + int func_id; > + > + if (repr_id->type =3D=3D RTE_ETH_REPRESENTOR_PF && > + info->func_type =3D=3D 0) { > + func_id =3D cpfl_func_id_get(repr_id->host_id, repr_id->pf_id); > + if (func_id < 0) > + return false; > + else > + return true; > + } else if (repr_id->type =3D=3D RTE_ETH_REPRESENTOR_VF && > + info->func_type =3D=3D 1) { [Liu, Mingxia] For good readability, func_type value 0 and 1 are better to = be replaced by macro variables.