From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C92643BF0; Tue, 27 Feb 2024 10:59:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 191824027D; Tue, 27 Feb 2024 10:59:43 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id 1409D40150 for ; Tue, 27 Feb 2024 10:59:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709027982; x=1740563982; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=sG6AEToQgJ9v6+4PI9EBxASerSYLu6RKHn2ApEwxH+U=; b=SfBopsw3YnNB1S12rriGPNH9ICpK74ZYobhPwseR57ALVUG3OGMapotC eFoWL/zkLsrm4XFyy+aAKQQK99gOsCynWnPPfGwj/AwJv7jgqcqKkU0dI BIxnnfu7Ddjs9+KxPAI7ofAl5ncQcUDRfkHanQqAOL3/Q7xaZUkOp2/L5 dDdMJJzWdsOAcYbhBsTCz+ZD5p50JQ57Dv20Rtg/HG8UBS59fc+8S7dgQ R08EEqx4ofZA7CdrQoDbDWQ04g4OTlThrYkNn+UdenyZYt7MKM2+k3U0z 0TOFQG14gSrvuAbmvF+qWpp0nfz8xux70nIoxCeoczryiZUwH5UmlpRyM w==; X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="13911044" X-IronPort-AV: E=Sophos;i="6.06,187,1705392000"; d="scan'208";a="13911044" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 01:59:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,187,1705392000"; d="scan'208";a="6946451" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 27 Feb 2024 01:59:41 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 27 Feb 2024 01:59:39 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 27 Feb 2024 01:59:39 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 27 Feb 2024 01:59:39 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 27 Feb 2024 01:59:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JRmi7jS/KNnOu1p1dMz7saFPE4PaonXLBLmzsXBxZFkz92pxwiDCOKWdjecAvn8YrJGuU3spdo9uw6VlCf0JB1tL8KrjYr1SSXvTA/MTef3isUabtv9eoHOon40CLR/gyUAIo/QZ6sckEFbzWSQgJuYc6gJWNY2/MCFy92ooqBYt6kCVal1/BscVl0oyHyX6RwBDa/SnmmCUEWXivxB5jXYxx4DE7i1CRIYkunkQPd4u9Iv/HShdiC+YpctlliEMcioo9dMNABQsHVctdVMoib22+2tBPR9m5o0OmXPMRpFpDSBf36qzvKZ/ohwUlnH5Mmhe+HpW8ERgtAv5kxyycA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NGJFrz0DPb2eRbwxLBufmwnaA1Kv5wqlnNgUJDmz5X4=; b=SHw3ASL3yNk0M/7x6dwKH5/P/6bDWCwURPwsKvdMyYw0DAs7f6vM9QXi/16wTnIFkp/uK3MZOmRfeckWbRDio5MdznEHoDS23HY0hDqcUXJ/QRJ+J8XGbM3I1Ynm+0Jzc1Z3d1S0c8YKIGAQCYLvZBnUnXJvQ/FVdMkggcB6LitmCSWcPT9g8VYICYtcWP4mqD2SBseq5ET30xjCh+DMLOsJwm4szqOOp4Uy2dxlW5QJotaXE0LwvimShfzVi4EEHJNcV7tRH9tGiXN9MkAsQgEO5gZxi3AcLNJuJ0CFyR6GyNM2rWlwqQNwI90gusutnt3EpCy+YRrh6zug6AWdfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5877.namprd11.prod.outlook.com (2603:10b6:510:141::12) by SN7PR11MB7540.namprd11.prod.outlook.com (2603:10b6:806:340::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.39; Tue, 27 Feb 2024 09:59:37 +0000 Received: from PH0PR11MB5877.namprd11.prod.outlook.com ([fe80::80ac:3dca:c153:f006]) by PH0PR11MB5877.namprd11.prod.outlook.com ([fe80::80ac:3dca:c153:f006%4]) with mapi id 15.20.7339.024; Tue, 27 Feb 2024 09:59:37 +0000 From: "Pattan, Reshma" To: Stephen Hemminger , "dev@dpdk.org" Subject: RE: [PATCH 2/2] app/pdump: handle SIGTERM and SIGHUP Thread-Topic: [PATCH 2/2] app/pdump: handle SIGTERM and SIGHUP Thread-Index: AQHaaPWpSlWnpI9+Q0uRGCwrw4yZqrEd8vUw Date: Tue, 27 Feb 2024 09:59:37 +0000 Message-ID: References: <20240226205143.66702-1-stephen@networkplumber.org> <20240226205143.66702-3-stephen@networkplumber.org> In-Reply-To: <20240226205143.66702-3-stephen@networkplumber.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5877:EE_|SN7PR11MB7540:EE_ x-ms-office365-filtering-correlation-id: 2eb8961d-2a03-436f-dadb-08dc377aceb6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hMUfKKA3mh3CpFrSEuOsnW49ch3N91kLkgg87IFb/13I3khB/gx5ptjBc+DzHggTxe9onOQPhwi5gRLPHOXgjLAs9xNifBHpScK5t7ImCP7oE4/C3T2g1SeuwqReccHv2yJ9HuKZIEfU8nII53EwC4vH81qpbptACaRHMfLZCk8L8HjMs4K4HmKpClb0/EcJhEElf8Nt19Mv1FNAXaZsrs0TKngnsoCUVL2JLDjPOPZsEHwOupzDhNXDjO3YahMcsF2fxBX46q3DMjQnpp2lwpfqNyG+w8Tl+iSVbkPPA3q83lmRnDrMQDsjgaEJ7wiVzYiZCXLPDZVD/ANkcUGtOeRUlnLADVx3mnPLj7WyXEY4Y5sQseRtr772Q4KpOKuyjFomvdSv/8ZWvf6m+ucgsJ3zRXFGIo7pltRGuXT/azfN2Rit/lC6N0I6HQqlOD1xXa4liIciABYva6wnDQ6Ugp5ebX2mZkrzUchwKqmvROFwzNBvckKqdwpC+3ZCIX8WeSO4ESgSQS66BC22uw7LKJkToQLp6RrA4tLMj/73SmyXIrLGIEKO/59ONpOPXDsGzHrYzs4hYe7HnzdiFGwqSlNwUXq28FN5Qxoq7L+nLdcBv8+41W3LmeCB3XClj/fBQbjCDzIYkNUad6mrd5JK5FnEul1WHG73mXOSpj1Ih8ob1gZm5GS2BvpMy0E1y9Qau6PqHAXKBNGNPFg8ofFHH4qaxEYHYn+pjkuJ8JtbISQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5877.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ILYryfkr/rW5ERrjmtksNP/0dYwrGOugb58cu4HAcDgRcpye96kpzehdpAIc?= =?us-ascii?Q?sw+YWnpAkDk4cXCUoQ3X000rxTyT9US7WR/klvcYC5ML+YumyoVQhZMS49iJ?= =?us-ascii?Q?wZYUvgmdn25kOkMD1CDQyVlRS57ndT7JELIbjZ3iQDsWOxXR/9doxPFioN3A?= =?us-ascii?Q?zF/NJ1Okm7435JMvxS9cIy+l9tlcpD6lZnTBIwx2tUFg8yXwnUPAFH1TsJj8?= =?us-ascii?Q?V6bnpYwt7Yjc7H6KxYK+ATak9UjIIWZdNoe+KjzmxF0S/k2j2Y5G8WzlDJ7R?= =?us-ascii?Q?iiCH63w0NxRvG2OSm+G252VBQ9gxV1ttuqNYsE46n3GXLbYdKyktaUzsZMyC?= =?us-ascii?Q?osJDlVOABczhxnh79zOOMWMjLwDkmswI09m+kB2/kg7ta6spBIgkFY4x770E?= =?us-ascii?Q?fBVZFfEOQkw5mp/evLpwT2U5GMrMfPGcljU6ipd7CpUYFVDtoDycxiwRv5fM?= =?us-ascii?Q?2iC+kP7YGMvwanaUZXExhZriDp5nmGoUnCCIc4kW1WFC+FU1lpJVuQKcaZY3?= =?us-ascii?Q?kiGC69e9S1O/6ueDyTML66HlEL3Uf4+ZvbfmNT3gbxwYA7u1cTHxNiuaS36l?= =?us-ascii?Q?oAH0we3NJTw6DM05w/EPzaCi9xSCPjXNTFsmUH0V32dBGPNRfmVIKD8jjbb5?= =?us-ascii?Q?zj3SScNkt4vb1JhXRfYHW6/zJFUpZ8o/geaeVM/7Gdtrxyw2CGQy1xyuAJaC?= =?us-ascii?Q?PYfO7rANBoRtnvyCd3GvaS06maxIMw408KHEiiMPs7jOSsJyokvStH4mt7rA?= =?us-ascii?Q?AyLJ6umPQopDfEdDX5Pw3hF9/8GJl1fnPe+jP5PMIOGDBL9cJ2Jnv7STaftV?= =?us-ascii?Q?skDqohyFrSvY8FsWLoNuTc9zlu5TSju7DO1Nq/4gJUp4mQ6XBntHnFXUu3Th?= =?us-ascii?Q?kfOYwC3pn64xVsIWZkCRTu+xKtFVjBqm8JnITfbRjCu70Yku+JAnEBopWyPI?= =?us-ascii?Q?+XIx5WkrfF6rFvIIDptMy9NX9/ixmQGidl15n7D/urE1KnQoAodHJsRTqRgs?= =?us-ascii?Q?MmZdpcr+wvUSeeRvCEZ2hFRBO4Mwxyz1DIqe53bG01NwSF/STL/3CVFk3jia?= =?us-ascii?Q?Th+5gWyQIRXjjDxfsI7hLMY4Fv/tbBxb9U+NwWMIeekXf/5SBtoPa0OHuLr3?= =?us-ascii?Q?5jhgAOUW0FtWyw9ts0Wm9GsNf8SUsgIrvYOK7qKedETJjZdFBO69EmSkzlts?= =?us-ascii?Q?/srDVyZ4Pu6ZJPFZpAc2Phsy/hH20YxuYeCwPeZH3I4YGh+Ks7mQ3IGw+QYT?= =?us-ascii?Q?rtwGw74MfAJGv60MlVUSuv+ME//iiAxx2W4vA7exXQkDnHMAimG5g0vqgQcO?= =?us-ascii?Q?SHPfIdy+cyLbrA08RUHaZ2FQc5CKZVmcS0Qx0AQSFJmbN3aVJ//AtQQVtKq4?= =?us-ascii?Q?HVjgJvbBbi/Fg3WdaumOOtSKcSYMlxc2hSaS+bBUxGYpl/zg1YJgQ5zsRvWT?= =?us-ascii?Q?27dUdt9USm1anskdr4mnLmLKGWUqb8ApboSyd3gqHXAfsgecHITTq+gL1fBF?= =?us-ascii?Q?I1cjozcUorAFxBfiHS8nvDd0Bg8ZVk0pPg8nQAw751OkeMD5YRgANbDQ4BTL?= =?us-ascii?Q?Vp8mAT5bfvvY8HwJXmwJDDoxJ+J4lEiwuCXgteqv?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5877.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2eb8961d-2a03-436f-dadb-08dc377aceb6 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2024 09:59:37.3295 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rxdB4bycnzMrJM3j6B5wQxPBblVRFojOJQ+6zzh3wXn1t4XTME023fwS+GONtDQ9fOLWmFnsZCo+iqbzwma8AA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7540 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > + sigaction(SIGHUP, NULL, &origaction); =20 Why do we need this ? Can't be this direct sigaction(SIGHUP, &action, NULL= ) without a below if code?=20 Can you please explain how this works.=20 > + if (origaction.sa_handler =3D=3D SIG_DFL) > + sigaction(SIGHUP, &action, NULL); >=20 Other changes looks ok to me. Regards, Reshma