From: Dariusz Sosnowski <dsosnowski@nvidia.com>
To: Chaoyong He <chaoyong.he@corigine.com>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Ori Kam <orika@nvidia.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "techboard@dpdk.org" <techboard@dpdk.org>
Subject: RE: Deprecated packet modification flow actions
Date: Fri, 15 Mar 2024 09:24:18 +0000 [thread overview]
Message-ID: <PH0PR12MB8800338C1EA958718EDD460AA4282@PH0PR12MB8800.namprd12.prod.outlook.com> (raw)
In-Reply-To: <SJ0PR13MB554585ECD639E30DA659CA399E242@SJ0PR13MB5545.namprd13.prod.outlook.com>
> NFP plans support RTE_FLOW_ACTION_TYPE_MODIFY_FIELD flow action in
> 24.07 or 24.11.
> For remove of legacy flow, does there also correspond patches in OVS project?
I am not familiar with any patches to OVS. Thanks for raising this.
For the record, in latest commit on main branch in OVS (commit fa0dfa18d534) I see that the following modify actions are used:
RTE_FLOW_ACTION_TYPE_SET_MAC_SRC
RTE_FLOW_ACTION_TYPE_SET_MAC_DST
RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC
RTE_FLOW_ACTION_TYPE_SET_IPV4_DST
RTE_FLOW_ACTION_TYPE_SET_TTL
RTE_FLOW_ACTION_TYPE_SET_TP_SRC
RTE_FLOW_ACTION_TYPE_SET_TP_DST
RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC
RTE_FLOW_ACTION_TYPE_SET_IPV6_DST
We'd need to sync with OVS developers, but I assume we cannot just remove these without providing a proper replacement, so the functionality is not broken.
I think that, once there's an agreement on the timeline of implementing MODIFY_FIELD in PMDs, we'd need to work
with OVS to migrate it to MODIFY_FIELD. After OVS uses MODIFY_FIELD actions, deprecated actions could be safely removed from OVS and DPDK.
What do you all think?
Also, this opens a question about other upstream projects using deprecated actions. Do you know if there are other projects besides OVS?
Best regards,
Dariusz Sosnowski
next prev parent reply other threads:[~2024-03-15 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 16:17 Dariusz Sosnowski
2024-03-11 1:42 ` Chaoyong He
2024-03-15 9:24 ` Dariusz Sosnowski [this message]
2024-03-15 13:34 ` Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR12MB8800338C1EA958718EDD460AA4282@PH0PR12MB8800.namprd12.prod.outlook.com \
--to=dsosnowski@nvidia.com \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=orika@nvidia.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=somnath.kotur@broadcom.com \
--cc=techboard@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).