From: Dariusz Sosnowski <dsosnowski@nvidia.com>
To: Alexander Kozyrev <akozyrev@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
Raslan Darawsheh <rasland@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Matan Azrad <matan@nvidia.com>, Bing Zhao <bingz@nvidia.com>,
Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>
Subject: RE: [PATCH] app/testpmd: add postpone option to async flow destroy
Date: Thu, 18 Jul 2024 12:05:38 +0000 [thread overview]
Message-ID: <PH0PR12MB880079C5DBABEF3923D71CFEA4AC2@PH0PR12MB8800.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20240717141954.3770657-1-akozyrev@nvidia.com>
> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@nvidia.com>
> Sent: Wednesday, July 17, 2024 16:20
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Dariusz
> Sosnowski <dsosnowski@nvidia.com>; Bing Zhao <bingz@nvidia.com>; Ori Kam
> <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>
> Subject: [PATCH] app/testpmd: add postpone option to async flow destroy
>
> The potpone option is not available in the async flow destroy CLI.
Typo: s/potpone/postpone/
> Only flow creation can be postponed in the testpmd application.
> Insert this option into the async flow destroy CLI before the rule ID.
>
> Fixes: ecdc927b99 ("app/testpmd: add async flow create/destroy operations")
Could you please add Cc: stable@dpdk.org?
It's better that we keep this tag in git log. It helps LTS maintainers with backports.
>
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
> ---
> app/test-pmd/cmdline_flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index
> a76b44bf39..fb6a552863 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -3703,7 +3703,7 @@ static const struct token token_list[] = {
> [QUEUE_DESTROY] = {
> .name = "destroy",
> .help = "destroy a flow rule",
> - .next = NEXT(NEXT_ENTRY(QUEUE_DESTROY_ID),
> + .next = NEXT(NEXT_ENTRY(QUEUE_DESTROY_POSTPONE),
> NEXT_ENTRY(COMMON_QUEUE_ID)),
> .args = ARGS(ARGS_ENTRY(struct buffer, queue)),
> .call = parse_qo_destroy,
> --
> 2.18.2
Best regards,
Dariusz Sosnowski
next prev parent reply other threads:[~2024-07-18 12:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 14:19 Alexander Kozyrev
2024-07-18 12:05 ` Dariusz Sosnowski [this message]
2024-07-22 0:01 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR12MB880079C5DBABEF3923D71CFEA4AC2@PH0PR12MB8800.namprd12.prod.outlook.com \
--to=dsosnowski@nvidia.com \
--cc=akozyrev@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).