From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F13A74553B; Mon, 1 Jul 2024 20:07:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF8B54060F; Mon, 1 Jul 2024 20:07:17 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2041.outbound.protection.outlook.com [40.107.220.41]) by mails.dpdk.org (Postfix) with ESMTP id A1CDD400EF for ; Mon, 1 Jul 2024 20:07:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iMsRYYQuvvgbeBE8mVlh4RQT2sReACVuBNrisr1g8Xqxat0LCO6OT5SoaeQ0JY19zKZuLsf12AczV815pIlkUNIvSeCioIELIYF5uimiyug+hGseyWH1NIQb2lSRdWoZ500Zj3aeNHOrXNNp4kroRJ8GWf8iQ4goXgHkmq92f8HCjU3n2VH5JJeubipSt8VDvbngneJ8CBLn8sSJNALJ4+SX4GfqZ8vJYknyaDNWoToy0XigFdy7Iz/wSDjp7b8LswlY67L0m5x+N7HxUQO5Y+K6ttpq027L8r0BAaMCx9+62i07pGP7COr6N3eRorgXLZn2BSVOLEKUml5lRqhYQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0ONRzwSD43xGiCXLGcks2YK+F+/YGGIj0P8rGuq9bo4=; b=d2rb1foCQzisRb6pSVBgBpanzsnK9K0dR3If/q2tQDRG9D6o4xJPzO/c9IkT6Fwz3FPpsnuYBG8Acg95nUG226KcvoqX997aFYATHPXUmOEL+vCQb3+9yzf5nkB8WWzzaykT5OLfP1jFVTxPKS+QKETrm0zGmZXcZ+LkkeTcNgjjktJUgqI4wioipK1pOzlFt6uqr3UphQZT0z/RpY0Y2SZaE5Or3yLar888zUCuhj3rqR3XknX0QS4EpuI9HXwLvRmLUeNU1eUooNze8iiVoXrea6204yuoEn6cDfOqnKwnDc+wWt0GS7mb+MwHaPLh4hP6bxdLwwvf/oJL+pk0+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ONRzwSD43xGiCXLGcks2YK+F+/YGGIj0P8rGuq9bo4=; b=GALFxSAS/N7MWWG8UD2Z+QtsGvEmVAMqzpRgssGT0TORZGspQaV95uCPEXSf9UffT8tGs1hf+rVAoL3PJNTnNT9KkP+hfbsnv6zxPa5fI7uyS2KxRLW29+EtoAbXsyVRSbPv1g0VizsrOrFyyfEbPQkaqKZT3Caj6BRBn97ntvFyrWYEcPAnnikvhmDT1xXuTDDOVqXm5x7IHYpMS0m8aNbYJKpkOVzeKKp4XeuGzJjSq9taMPTjZrWarZFqvcWNr295s2RajhK1crh8F0mJ2EODiL8BV+5+fg60aBygCklMScfaZqnvdGWeE4zR4i7hwjHsgrU7mASTf/wUfW+LOg== Received: from PH0PR12MB8800.namprd12.prod.outlook.com (2603:10b6:510:26f::12) by MN2PR12MB4343.namprd12.prod.outlook.com (2603:10b6:208:26f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.32; Mon, 1 Jul 2024 18:07:13 +0000 Received: from PH0PR12MB8800.namprd12.prod.outlook.com ([fe80::bdb6:e12f:18b6:2b77]) by PH0PR12MB8800.namprd12.prod.outlook.com ([fe80::bdb6:e12f:18b6:2b77%7]) with mapi id 15.20.7719.029; Mon, 1 Jul 2024 18:07:13 +0000 From: Dariusz Sosnowski To: Mahmoud Maatuq , Slava Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad , Maayan Kashani CC: "dev@dpdk.org" Subject: RE: [PATCH v2] net/mlx5: fix memleak for resource object Thread-Topic: [PATCH v2] net/mlx5: fix memleak for resource object Thread-Index: AQHaxm6nIpJLryz2e06oBs8rzpDvPbHiK/Kw Date: Mon, 1 Jul 2024 18:07:13 +0000 Message-ID: References: <20240623103539.1690600-1-mahmoudmatook.mm@gmail.com> <20240624194151.1788790-1-mahmoudmatook.mm@gmail.com> In-Reply-To: <20240624194151.1788790-1-mahmoudmatook.mm@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR12MB8800:EE_|MN2PR12MB4343:EE_ x-ms-office365-filtering-correlation-id: 0190b656-fdda-4aec-45bf-08dc99f8a21f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?5WRAiPDNd57tKqkarlEZpKr3g5XI4ZiXjDw4mYdvSbIXmqncsrg+r4rZ+tss?= =?us-ascii?Q?1IHILJP5JmujMlOWZtXbHGfvRR3PAHCjulYKfCw88Jygz8C5lIOTHBWBllKN?= =?us-ascii?Q?NSGRAuz9hz8zQbgAAzLtcybKop35E02ULFZ0H9SdAfTfYUQAqm7jvfqJvJrI?= =?us-ascii?Q?z7V58lfPxel/C2cU1x9khkoCbSfyc4T/1iZjjG5lgEWmjKrlKYW5HB/8nIPm?= =?us-ascii?Q?aS+TTFKJ4uF7m5/yH/+xTiOdtACkeBH7ttqQB1CC4IK4W7ZjLtTwuYJm9WDW?= =?us-ascii?Q?oQuDKWEf4CPYgHuAHdbV+5GiQwAVboLGIhVSq2KAP8A+t8Jqc70GSh811VlT?= =?us-ascii?Q?lwtSacXkxe/wrMudX/cggXl45snLjpygnvNq6uyG8Tgw3IEFota5drp+y1fi?= =?us-ascii?Q?SyzP6bUenpqv6mOLV87SQ8auEYs7T7dSR7EFB1QjE3dSc3cX4FUD4Z+AejYo?= =?us-ascii?Q?p6bCYg/m+gaZutkLmurc0SxHta6LAekmcdBOg9waA48kv0WSmnIleZOvtA1T?= =?us-ascii?Q?rwP4Mara6HvCZgLB2YJW3DEkgl9KLsAaz5jSHMJDBBVP+xJnyFBBygHmxnEb?= =?us-ascii?Q?tutForpAAP8cdOzwuSfVLrLMRAGMrosftKLIyTkq2CXfFEtPa7AUggc9DZ4+?= =?us-ascii?Q?mEo1D/p1JqsPo/qA9ICq4HnBHj+AHBUHkalnKfnYcx/l1x+ImmR7EojWJzpR?= =?us-ascii?Q?uJEdrgF0tMZBaOimM9KFyfJ3UeUMKFvJRVXMOkuDl/jEkb4ADfJbKDT+KO+w?= =?us-ascii?Q?uVkMwqCv7iVNzSkf/D2AQbKAyBwf16WeE1otsmDnu+QDVdeOCz2V6VdLK36L?= =?us-ascii?Q?V0OFNQ52tC73MVbp0qasOBWiFFwFwIE2HRlE5Dkf0VSh/0agSarUoTKK3X51?= =?us-ascii?Q?kQ4KeZvk6CFzi+DLVUPeHK8hUXLl0WaXVi67yUO5RygNCraJdkPVFMYKyQG5?= =?us-ascii?Q?KgP5e5ZqMYWlIDSg8/m0iaHNxR2I32kCzAILK1enBosBTWAwe3OFKqDVUq99?= =?us-ascii?Q?uekj82mJMIze0OdEpPLsH6LK5/o1IWBfiOe2CeW7fM67ZrCou/bvOdRkNegC?= =?us-ascii?Q?nLTSffCPJ9PDO5QD600aSYSE6chW0c8emvryvuqr6r5vCu1CYVZIj9MWC6Xu?= =?us-ascii?Q?G9yC5d/PBY5f18A7ewFCDEbKjuaYsbiAW6U6wtSbSYOuxqfiq8DZLAHh/FLl?= =?us-ascii?Q?Kp41byU8MKJSjFb/dVhLtgoWAb6AjwdgKRgnf8nkEkL7KL6J2DR/womt+Bvt?= =?us-ascii?Q?O1mSpq7EUPU4sXHbdOmPD8gOBtoNMZGCuZrt2sguQKD8Mn/gStW+JZvY5ykT?= =?us-ascii?Q?5cQ1qCRCRPSfz8AS9uz90FLHksMvGt/YklZw4nxis7eFGFO/zoU28czi6ilw?= =?us-ascii?Q?HMvjzPUepeNd/TPbv67UkbgOO70BXj6DcnY7H1AScq+53NJLxA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR12MB8800.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?K//isuGIDSa4Jcw/Lc3TTQrX6zv340ZZ3Fnt8hXuNU9T2UKmoBPmk6ZtHWjw?= =?us-ascii?Q?XbwP22EbW20qTm8yzWu3rqNVSfnMzSoHoygz5frCQT/+cee2yy1D1BL/XJmw?= =?us-ascii?Q?Nq9gCEbqL5njaiMOb5h3Yd7iNJBp7KACOHtGystv0lVVm56FBo6en5OvSXx6?= =?us-ascii?Q?igUCggDPbMR2iHOWOOnOug6zM7uOYWOmGCWe69KcMyNPjraPO6yC5oEkyRr5?= =?us-ascii?Q?oMjSbpvzSHMLdKLxPWXPjGLt7je+Xrw6FXIN/bsPnKXGP/pohNl7pyF39Uvb?= =?us-ascii?Q?57sZX1eWEq1cgS8oGyl9bvsUEMBVpxZqpJu80sqrfIiQs6ofL8QD2HIXZB7x?= =?us-ascii?Q?xt3RdhVmJGsEsYbEv9QeRLC16s8pKkMzJAov7varsuOGoyzCDQuS4Shv2s1h?= =?us-ascii?Q?gawzQWLv60z6ytfRvG6AwlrWQoFeLUZugZc2xa5aTpbK3LbRlpVNvDu/H6nD?= =?us-ascii?Q?8InblRyfGWOz+4F4xNWMVI4XZVrK/rtVKEoMYBCgcteoTKmeGEvk7Mmy/DP+?= =?us-ascii?Q?iO00U0dfluTLkkzsoZFjZYvwxqsrIO0h9OCXqR6cRSfnkfDkbxHentlv3oK8?= =?us-ascii?Q?6VZjzh874vJVICRCliYKus+2Legq2v8QtrNgYY8Xqpc8HRGDnTtmNUIwWLHT?= =?us-ascii?Q?+r1xGOJYDheUSOFowDnyGaIqpTQrLQN6ZovV4tdEbkzaqC0vOGvIavgWHJ3j?= =?us-ascii?Q?sg+97iCmOamdIZp7mQFV98a+XbGxFLipf0vBQLFFJCONBJYaF1om5HDHjLEt?= =?us-ascii?Q?W0/sIo52v3qSW7J4gQvpmaOXoQITkV9yCBiq1rsd6FkAuj5dMipiwxuM+j3S?= =?us-ascii?Q?xXVwnAkj53anFQl+QzAqawOH5ptd6EEMQMy9pDp6e4sW/LKCzZDyASmwjslN?= =?us-ascii?Q?lUFiZLKOPklhRjB9aeazcAB7EuQ6Fe2yx5YIIE3p3pc9HoccfBf3H1Du3eVm?= =?us-ascii?Q?hrAXIxbUB2KlnJLofgCq9moX38GZXHIVjxi6XQUKr3qCeclL1lu0XBH25jrV?= =?us-ascii?Q?ZZQPZMFFOnjoh9kqFd05X/2FctY07yUyVvmb/VrNp53dFKlSDmwK+X50xyJX?= =?us-ascii?Q?iOacn7WUdpM6vbqSmpN5L9zl+oeMYCyIPiP+KeKUy3eum6tBVdK2KW6JGF4y?= =?us-ascii?Q?fbcOqAWO9b+iDcNZSZLEy1KtRK+XeDg2EmcSUo6wuiJ3oXupzli4SNb1V/p8?= =?us-ascii?Q?CqBWkAo1ot8qY6G3zf/1FcfYB2MCb4RhWxD2PQhBnLkxYaC3OTljg2x2wb9i?= =?us-ascii?Q?cWvQ5Wbdvwj9DeogR9Hbt1YW+Z1NYjoaLVkiMJGHtH6Nt/iOgvAg5rv3fmaY?= =?us-ascii?Q?fdsS9fTa2ImVLLO3f3lPCMyvDpSOGp5l7mT+bHVTqeAuSdylZHDYXYHj4mLR?= =?us-ascii?Q?TxRC3CtJxLQzT4hJ+D/svFsFPNUmXCjI4SIIQ6jG7TJJkE30ffgwiiappZHU?= =?us-ascii?Q?ySCq75SbP0j4O2//W4Zmmmm9pOhHIfmzN8vjFQS/8H4crCSQYQhcY1WnFB8X?= =?us-ascii?Q?gZilxMlKMYXHcbwFIe1z7QmnX+y126wFYSFWG+yYboDY88m4jMyMsKitdKcZ?= =?us-ascii?Q?b9AxrXHuqMh/5KNkN2Ki6ro4fCavaz+dcvQMP6da?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB8800.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0190b656-fdda-4aec-45bf-08dc99f8a21f X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2024 18:07:13.0301 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ie+8h9Q0Qa8DbWecfM1CpFUbLxoSdfsKROsT15sPSK7U5C8XcDZM3XN32lAlwYGQX5tzWCE559Y/4BNHGz7c3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4343 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Sorry for the delayed review. Just two small comments. > -----Original Message----- > From: Mahmoud Maatuq > Sent: Monday, June 24, 2024 21:42 > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Suanming Mou ; Matan Azrad > ; Maayan Kashani > Cc: dev@dpdk.org; Mahmoud Maatuq > Subject: [PATCH v2] net/mlx5: fix memleak for resource object=20 I think for clarity what resource was leaking, a better title would be: net/mlx5: fix matcher object memory leak >=20 > this makes sure that the allocated resource object is freed for all branc= hes that > return NULL Typo: s/this/This/ Also, s/allocated resource object/allocated matcher object/ Also, please add a period at the end of the sentence. > Coverity issue: 426424 > Fixes: 27d171b88031 ("net/mlx5: abstract flow action and enable reconfigu= re") > Cc: mkashani@nvidia.com >=20 > Signed-off-by: Mahmoud Maatuq > --- > drivers/net/mlx5/mlx5_flow_dv.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow= _dv.c > index d46beffd4c..8a0d58cb05 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -12010,9 +12010,12 @@ flow_matcher_create_cb(void *tool_ctx, void > *cb_ctx) > items =3D *((const struct rte_flow_item **)(ctx->data2)); > resource->matcher_object =3D mlx5dr_bwc_matcher_create > (resource->group->tbl, resource->priority= , items); > - if (!(resource->matcher_object)) > + if (!resource->matcher_object) { > + mlx5_free(resource); > return NULL; > + } > #else > + mlx5_free(resource); > return NULL; > #endif > } > -- > 2.43.0 Best regards, Dariusz Sosnowski