From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 123CE44156; Tue, 4 Jun 2024 18:41:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F2F6E40A6D; Tue, 4 Jun 2024 18:41:04 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2079.outbound.protection.outlook.com [40.107.94.79]) by mails.dpdk.org (Postfix) with ESMTP id E9B9B4026E for ; Tue, 4 Jun 2024 18:41:02 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lH01IfQ/nEO5HRhXa3a9991+usTZhGHpr0ueoZEg1yOAr40C8UeA3YjYSNhgb8pvSAf5Y5P2w0h6kWBu9xtNKFhfwgk2dicXffsMDDzMmoBolsMhklfkD5mRwrwz4HAFtNlCDRlr/doJS0vubz0Et43805EozAH8hYwV4Yk2IrCJ6C4UG/mh6bqGOspiMvRZjZHUmF0udVt6IORCzVI3csvA5NJo/alQz/4lfdORjnoOy5Ra4nGesjZXCBaEhaLhoCXV/O22GK3CvSPQfTlexmNvdLSLPXkVzDRoRZC3cy9b3Fv8jiCR+U6uvkboZTbRTiwTbyqTekoIaeyqVerlGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5KiWw39ZRxqRL+EG/US4RZ6KJIiTXOCwE/u/AMX67io=; b=YcX0cQOkkrs0sg0v7qfdLIvphawGDQXXWn/No/hMqf4iLSJyJeq75Ls6UQ0rsbDfdxxCrMNqYHg8jCX7eYEVpXXSXk+IRKOJHGznSzowpUC9dmT89jvYCcu7/kJF0Y3qGM51iVJlIp1+FnMklUiwcQ6xk13dDrYLMoPg02jAcocJOG0MPQbVLi3T9uEuse4omnUp4a3rGJlIOlLzOeD+UyOZHGEaWySJR2+fJrxaMBFzNCmGmuieaZ5bvF99ZjWtdYhoGJX8YdKdXIKTz/LCbTt+KYBPvqzZFBf/bRuVweMwqGqWGSPSK7/cFa8pL2EO3dztvQZMjNDUaOXa5nrtnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5KiWw39ZRxqRL+EG/US4RZ6KJIiTXOCwE/u/AMX67io=; b=iZX2rUCGApg2g1VmXdr2qxgCksw8KTLaWB/WlGej2E118n8o5qJfa4mKW57aowPnGAFpPSO7c6mCTDbiR+uTzaeBrw6nn6PCC3cWtLZKZfgNWUll5wGXKhmjCkxNVfNFDGFX54d40YOVtxr3HNFUe7Vb2p67+b5qqI0HYpZwpsKT/MydX57dSRbEg5sZTyVRHvkolMz5i0jSt3JdrCcbX3CL0Q5DCBcraP/J3RnqGkPa9taJdP7UU4K7A1w0KjlPMvARyW01r0iaPwwGaIAVxEqGehEPKYHJHJvrtoOiNxDiM9cPuONqCMewZlgJNzB11CNRZlj4bU9FOz1zktMX2w== Received: from PH0PR12MB8800.namprd12.prod.outlook.com (2603:10b6:510:26f::12) by CYYPR12MB9013.namprd12.prod.outlook.com (2603:10b6:930:c2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.25; Tue, 4 Jun 2024 16:41:00 +0000 Received: from PH0PR12MB8800.namprd12.prod.outlook.com ([fe80::bdb6:e12f:18b6:2b77]) by PH0PR12MB8800.namprd12.prod.outlook.com ([fe80::bdb6:e12f:18b6:2b77%6]) with mapi id 15.20.7633.021; Tue, 4 Jun 2024 16:40:59 +0000 From: Dariusz Sosnowski To: rongwei liu , "NBU-Contact-Thomas Monjalon (EXTERNAL)" CC: "dev@dpdk.org" , Matan Azrad , Slava Ovsiienko , Ori Kam , Suanming Mou , Aman Singh , Yuying Zhang , Ferruh Yigit , Andrew Rybchenko Subject: RE: [PATCH v4 2/3] ethdev: add VXLAN last reserved field Thread-Topic: [PATCH v4 2/3] ethdev: add VXLAN last reserved field Thread-Index: AQHatnw+//CSgY1HCU2SJu4W6Q+IzLG3s94AgAAX84CAAAEBoA== Date: Tue, 4 Jun 2024 16:40:59 +0000 Message-ID: References: <14937324.O6BkTfRZtg@thomas> <20240604123840.432044-1-rongweil@nvidia.com> <20240604123840.432044-3-rongweil@nvidia.com> <6180616.2l3rmUXbR5@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR12MB8800:EE_|CYYPR12MB9013:EE_ x-ms-office365-filtering-correlation-id: ab816e0d-5bc4-4697-22d8-08dc84b51d50 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|366007|1800799015|376005|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?S8EZX1LUbGGubh8BdDoMAo1UDmuzu1ao35FPQ7jdoRsOHsaHpO9ot5Mk5HvA?= =?us-ascii?Q?uEQ0dbC0XZk1iELuJTsN9levCymOmqJzGRC6xgF5QZ+A8xDgWmDDkT8pYm5b?= =?us-ascii?Q?L3Xqh7V5HtaqmCh2kRwG5+OuQnBwAFE1F12nx2WLe3q6eihHPEvkdmGfiQ77?= =?us-ascii?Q?NGzBiJfzOxqumpHw7YOzU8wAj7idpIHP0imiZcMGhXGaeUVHisrLaQvJs9n9?= =?us-ascii?Q?id9X8gbS9iM/HTO4baxXX/upKq9pq3/zZsIAv0lCX3hO/2GTnxYoeiQec0cz?= =?us-ascii?Q?SMZjLHxUoVHo7ltkl9q/3uqOaMyaEyOdygroESmgKemgdViezQVLgCGYr6aL?= =?us-ascii?Q?TFuTcknrmMAwvvhDEGPcKkeB9l2bqa5DURcWPC5Jfw6x9fo+kA5thFppRgzh?= =?us-ascii?Q?GM00gCte74n3G/6MAdgGHxzdczXYHrQgkSxZ3OTH3+dbar5PiyVLLbelAMVo?= =?us-ascii?Q?kEu/VEkg2dTb5CPdIyxRvB8H+6M9F0OnLsYh9DGNx2W5VX+kaX6MMa4nPUmV?= =?us-ascii?Q?gWDjvqSvRZS6wOf3wZTIM04/lcvxAWveBLcavYD8knx2YCH1uoblHhbs4SwK?= =?us-ascii?Q?g0keLKufS5RF0jY4gMYprY4j4ahqPEhWrLUH0+zVZ8zuQmgeeDOfKTVoB9bc?= =?us-ascii?Q?cPvnikCDpecA7MsbO57nqWAWyP87Y5Ictnl4hcEHmg+ljxtpEDgVYMyecVg2?= =?us-ascii?Q?H3S/niCXTajCkh2aKEa1/k/72gwygSgWzyHrU2/aTOSbhyRJ7V4l7fczC+em?= =?us-ascii?Q?ztGogvJSDVx4t8O9mxX5LHxxvWWhdKIetl+G70vwvI0SWARO98ZIETs7MHYh?= =?us-ascii?Q?p6rOJ+yEDaPkZzxsloy9rOYnIchhBQasj4Gy3yhwe7vZPkVkvU0zyIoGC1R3?= =?us-ascii?Q?qviK5lCgmOZYDL17z6ZYsUgTZ3RrVCV9+5MLsx2yl1T6NRNq7tb6rf1iMPup?= =?us-ascii?Q?Wit4/pJAgHJ5sqEbUoQFKm/OUigcR26Mz0C91t8oRSHMyc74UEEC/hxlwvfj?= =?us-ascii?Q?kcsmqwUb5HZaOJmFO1LMds/TtwABDrttr3SWFI8ntQyJdn+GOZKj6gcp6qvD?= =?us-ascii?Q?JgdP9hog9XNwHkbxfJ0kVWlYVj7JeA5z0+vxa/uL8p8Rzf83G43v2u85SlgQ?= =?us-ascii?Q?uCdABAxilCYXl8WQy8kK0upuQkoKlwF/G+lFKU96CMNmvS40uK2pnoZaBmiO?= =?us-ascii?Q?t6zAqVH6i6ZeaMpfB/VKsmkDXJotwYWI2gznQwShcY9lTAUXmhm4jfEk41fD?= =?us-ascii?Q?Qh/38P9YopfaHVmZSpEu21fXZf4HMbf5j9uCmdP5qq6NmhC+8mnoy6OsJzw6?= =?us-ascii?Q?Ew9oRmai2Zj9exmXqb/ozgG+otFLgx6PVR8Gq6EfmhxFLCkwRSqv8Ic1kFYm?= =?us-ascii?Q?hsAfnOM=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR12MB8800.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7H3FN9juM1LUDz1a46SL+3aIB0llDa5ApafJ/YBwpqUM0dVdKlp5DPbQqjtI?= =?us-ascii?Q?0+Wfa6l0g3GuI0e8UCE1MtZe73hrvEU2c66IIof56dhmNrTn/JC11eGCfqFY?= =?us-ascii?Q?oVTRuyhHGZ2EPPsuuwbjpGXrrq+RdzWTG8SnYGvTI/2Jgj0aWHJklbr7vDAj?= =?us-ascii?Q?+kP1HZZ75mIvWERFkuBBm9R7aLqxvePlKPGIf8woL/HQQStg/8pDEJqmKlNr?= =?us-ascii?Q?Gy3CwtCx44ynDejSmpJ44He5GI5WjWf1WbPs/rJFheQjEkRDYcihudrO5K7P?= =?us-ascii?Q?+Puv+tMmt9zC3TJalDE/mFeTJ5nD+7u8apFMT/IEuWT385aWGCtS1swiqcIl?= =?us-ascii?Q?XO+JDZyQDp8xvFuPrSKVTL6bQJ7TM76ocHUPud5yPZLT48UvudSJ0LRuZ14w?= =?us-ascii?Q?ny+wJJnsQI0I1iuhxfPTk/E42Rm3fmhgfgF2s1f1YmMMgpS7+t5R1ICxSUid?= =?us-ascii?Q?6aaQSBBuk9wMdXhKjKe68qv5g6LZEq70b1ToRWReqLf+sqzOTUq7aemKNuCF?= =?us-ascii?Q?MbTLQDZoe6TzEaUr3U+7Zd+EfGugs0p25CkNzdWfP1KtCPYYw4rDaMO+MfTk?= =?us-ascii?Q?wdLci+CEyn6TO7tsi+fb1o0mH4f/DsJfzvKOzGluou090VZ2Qu2HdE0KP/OA?= =?us-ascii?Q?FhNwDyP0uosj3j8c2Vn2tkKP+/4KQRg0Dzdecon7sClU7ILCI4TOzYZzwvFp?= =?us-ascii?Q?ijxA9f9w+eSegz+GQB0mbPuktHofRmMhVmC3GfDrN3gsI3dvdeXnTczRM97O?= =?us-ascii?Q?jyIcfl16w721/UFGU4+IPjr9rumhTxW8ZJZH4muTwfrJRBV6gkIPCWI2etA8?= =?us-ascii?Q?PfgSfK67WiSb0JOSwZ0cfXAZ71mEmKIboSaEsRv0Yl6KgXEwBNzMeK/k219m?= =?us-ascii?Q?Q6R9YHi25pdjg4eMH/VNUnudIT6dBAqG7u/Y41hHSwhdiLghF6gWEiUe8rTm?= =?us-ascii?Q?svmihrMKaAPZ1mGuklQFgK4WWVkMsXdsmdRzQ06VOjRtmWF+4D1dDUAXsCj0?= =?us-ascii?Q?zl0NRy0yYBTVDegRboEYbmxSQ5lKIW8TxXJfSGZuqeTAueMWzTvECzxDI2MY?= =?us-ascii?Q?n921XvcAeeA+dfJeJNMiT60ogsvaSpI5tMkA94b9K1kvGmASOIgrGurnnoel?= =?us-ascii?Q?1WP0iFygNecW5IgGUqHdkdo6S61RWmTRjks0PulYwAnIRCVTk8/cVB5B3fOD?= =?us-ascii?Q?VKfG7nzvD0+22rIkozGiD4vEnBObf/k0ZgrYX2e0/wpd6uAGZXe8xYILFQAb?= =?us-ascii?Q?FPok4HvjiHRK4XKVrWMakdZkfXflWtQU+sroZTquO9qHV4GKeuXAFMHq2JVC?= =?us-ascii?Q?bVh7nnwOLSXwi3YdGV+b0QNImhE2+ElxrT5lyYMOdLBrlhlIuRfxMsgr9Pqu?= =?us-ascii?Q?8SPbJeMt6F5lpSas6hlvlJAMpUkpifePPYsCP2JbRzbbkVcUfoiukzGH7Wv7?= =?us-ascii?Q?S88EYpqV7UsdrDJX8/2Cd/Jnc+dvtbAvl2RrcmLmYYCh3BKNiw51FPOyBfLQ?= =?us-ascii?Q?HSN17YLEBghrU1sNyEdlqgXsZmo2Zk2pY1A7dEDUMhUXmavN/G0XHeqoNIeL?= =?us-ascii?Q?uCli7cQ8SM2t7sVvFGcbxwJsNHxcZyCbt8nt/h1R?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB8800.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab816e0d-5bc4-4697-22d8-08dc84b51d50 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jun 2024 16:40:59.4878 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1r4+pJXwTVuV2sEqojJM34L/cyTrb+kuCDhJebP55mvESChiY5dIQHeTy1InP1nfwqdYqFO9Q7LYgifR9Vi/lw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB9013 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > 04/06/2024 14:38, Rongwei Liu: > > > --- a/app/test-pmd/cmdline_flow.c > > > +++ b/app/test-pmd/cmdline_flow.c > > > @@ -1006,6 +1006,7 @@ static const char *const flow_field_ids[] =3D { > > > "ipv6_flow_label", "ipv6_traffic_class", > > > "esp_spi", "esp_seq_num", "esp_proto", > > > "random", > > > + "vxlan_last_rsvd", > > > NULL > > > }; > > > > How vxlan_last_rsvd is linked to RTE_FLOW_FIELD_VXLAN_RSVD1 in testpmd? > > Just because it is the same order? Yes, it's because of the order. We should refactor this to use array designators. > > > --- a/lib/ethdev/rte_flow.h > > > +++ b/lib/ethdev/rte_flow.h > > > @@ -2428,6 +2428,7 @@ enum rte_flow_field_id { > > > RTE_FLOW_FIELD_ESP_SEQ_NUM, /**< ESP Sequence Number. */ > > > RTE_FLOW_FIELD_ESP_PROTO, /**< ESP next protocol value. *= / > > > RTE_FLOW_FIELD_RANDOM, /**< Random value. */ > > > + RTE_FLOW_FIELD_VXLAN_RSVD1, /**< VXLAN last reserved byte. = */ > > > }; > > > > I think we should use the same naming as in testpmd. > > What about RTE_FLOW_FIELD_VXLAN_LAST_RSVD? > To be honest, no strong objection per my personal thought. Considering t= he API "vxlan_hdr" names this field as "uint8_t rsvd1", maybe RTE_FLOW_FIEL= D_VXLAN_RSVD1 will be clearer for user as 1 vs 1 mapping? +1 on using RSVD1 so it matches rte_vxlan_hdr definition. In this patch, "vxlan_last_rsvd" is used in testpmd, so it matches existing= "last_rsvd" field in VXLAN item. If we choose to use "rsvd1", we should probably rename all other instances = of "last_rsvd" to match. Best regards, Dariusz Sosnowski