From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0915A034C; Wed, 21 Sep 2022 09:42:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF8BE40697; Wed, 21 Sep 2022 09:42:13 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2101.outbound.protection.outlook.com [40.107.243.101]) by mails.dpdk.org (Postfix) with ESMTP id 069364014F for ; Wed, 21 Sep 2022 09:42:12 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dUorgWUnWS/nlbYkAjwftUD6wiRco6l4q4hUXS2+3bHd6PqJbsh3NnMuAdWHR63j4v1bgW/q9f2DlI8KEHXvIACWuXKuHMGgZcZIEoG1nqTrWtyMzxyvYp75cgrV4Ov5pixobCOr6qqfaEWsLU6QwbtsG1fzq4z3iYZnCYSIc31MLyfRa9AZxJpfbJlhRxrAM4VMYfyIgaUKcgO6zD9p9TvlbxapFNe/yK5pqoJfO4Tr+U0hifFIENWrchMTsnsKQMDJvByREufFL90FDl+8stF7/5cu6FxCd3JqpIXIBCugpc/RNcqGZRL7GCTrs5C3PQBSiWILEOERBd7/D8kg6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hXsUMTmv4lxmDPrMo4xKHX5/qQQF88n9izlWBfpwcGw=; b=XF89JD0ZvdTGOipfFVSX4RxFf/ow/Z0T79jy6vCboU8sfH2nbuXblB8rjk7pIjuXu42FsBlCXRmvXmRiTnOe8r/UrRsOk/DtolxAQto5R1XOOSQVSqV+GzdCSF+YhEJnXaLpEcpkvx9b2g5IuMdn0asxKjRhuEdlAhaaEM5SkaCZK6UIOxq3I1964jLSlFT5cpumFb+/osovVDwySR/y0QqUOyCNXq4Ou9JUNUaY0U5aYxU4wmJAlOZqCvyXLNbFlFVG1yRa+4iFtxvThDiPdgh8wZptu7Q30qVQ27u0dH6t2aHASVxaF3wpb7PFftufFfooKaOWqktqGrsogKtD9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hXsUMTmv4lxmDPrMo4xKHX5/qQQF88n9izlWBfpwcGw=; b=A0QnRKdpjzjw0rTWlBWDup0b0OmGGV3j/f4ZFXFEHvJRT58zKUeFv/uMtlBnGMPfetOQOpxJg8V+bkDx1kBiFwXnsjGiaDzkDAfNfySMCGXol2bS6y0bU36Wedvj9v4H9rMHwScUv8c2J2OE6uoUqbwixAmcvmydxxaV46bVQwQ= Received: from PH0PR13MB5568.namprd13.prod.outlook.com (2603:10b6:510:12b::16) by MW5PR13MB5606.namprd13.prod.outlook.com (2603:10b6:303:195::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14; Wed, 21 Sep 2022 07:42:08 +0000 Received: from PH0PR13MB5568.namprd13.prod.outlook.com ([fe80::21a8:2a67:d4fb:bb3d]) by PH0PR13MB5568.namprd13.prod.outlook.com ([fe80::21a8:2a67:d4fb:bb3d%7]) with mapi id 15.20.5612.005; Wed, 21 Sep 2022 07:42:07 +0000 From: Chaoyong He To: Thomas Monjalon , Ferruh Yigit , "dev@dpdk.org" CC: oss-drivers , Niklas Soderlund , Jerin Jacob Kollanukkaran , Andrew Rybchenko , David Marchand Subject: RE: [PATCH v9 07/12] net/nfp: add flower ctrl VNIC related logics Thread-Topic: [PATCH v9 07/12] net/nfp: add flower ctrl VNIC related logics Thread-Index: AQHYyPA1X2aT4W9QJUa0JygNySXyyK3ocIGAgACzyRCAAGGrgIAAAmpg Date: Wed, 21 Sep 2022 07:42:07 +0000 Message-ID: References: <1663238669-12244-1-git-send-email-chaoyong.he@corigine.com> <30e1463b-22c6-cd26-acf3-c38c05ea477b@xilinx.com> <2126161.Icojqenx9y@thomas> In-Reply-To: <2126161.Icojqenx9y@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR13MB5568:EE_|MW5PR13MB5606:EE_ x-ms-office365-filtering-correlation-id: 6ad6946b-8b39-4382-5639-08da9ba4c92d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0IMmPYDTAOeCKKjpuUafm8PLDpb3rmrTum9/vZYyMyWJZhRI98Jch71qWShdO83MBkvHnwv5LlOqrlnzyBQjHRshcfyDosQdhnQtkws793SACvs/86GbF7XMncOWIobQtfDtyoOHGr0pAHEKJdPQqcsiHRMtiFpR1x3VBFKCG7mlYDelanQasvds9HAqsE3uL+21QzH6WdS6HSraEjhWbrCptUfqdf9paF7pygIA67uWNeMjZtX5vEEHGpT2nQJ26wDV5WwsnxQWSG4UNbQW1BmBMgQzk4+jI1ns4+HUPIC1tutdNzDVWyGfdCqiaXiJ4I5TelkFLIExqpQra4upZZoTbNsIbkGWJpjrF1/L9NHbDTWgaUoxMTLJ4486nzz7JXxK6Kef/JPZEZcYg92J9K6p7wq9n6nP06iKsXURfDvB5xuufsnMqnvlkZKYZ5qgSy184od8hEXhllNvIptr1laGYWml7keQWWm6ERhN3k2XdLbfLpFBGWzfpUYOK0BF5DBaN1IwfCqnrBOymH5tFbmL7fYoUfaMxdh5eFdyQjxTgSoU5BKYh44DVZ04t+HvOMTgf0+SUzV2Php/EGVNzAuHTwUktSj26Jl7OypnQ4kKnMMfzZx9hgMnx8gKyFh6gWEMuT3XMDWa+omlRBlkpIQwscBBC9/orEB2gOPH0+l4ECpSapNzGvnlY0d6+lV0YVMKl1fn1Mz6I+3im1mWbMpJBuzSuPZYoEYo/6S+7t+Z3B5UZUdlYJ7rpCAEDP0OK+iI4YWHCqfwBTikaArxJA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR13MB5568.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39840400004)(396003)(136003)(366004)(376002)(346002)(451199015)(83380400001)(2906002)(316002)(54906003)(110136005)(66556008)(44832011)(5660300002)(52536014)(4326008)(76116006)(66946007)(33656002)(66476007)(66446008)(64756008)(478600001)(71200400001)(86362001)(41300700001)(8936002)(6506007)(7696005)(53546011)(9686003)(26005)(186003)(8676002)(38070700005)(38100700002)(55016003)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?rNco7X1ULyru0VlXJSvp1AleGFJXlkWjzojVMU/Fg+jbiNobUM6OAXNo9q?= =?iso-8859-1?Q?VPrH8aHROFq2/H9ppsba1PW+35f8ZKJtYxZrXNTqPgLgyGC4ilRpH3BENO?= =?iso-8859-1?Q?h9G4LnWMzGAqyN82otkfrwVRJWCwLTlEIKVDQ3/oV70Ad1MUKL/C62BG8/?= =?iso-8859-1?Q?eELDFiJcOkZQa3+KB34kJrifu6j8sAdInVtqzi3X4uw8YTfQlDjoskWOdU?= =?iso-8859-1?Q?cEJQBj4ZoLOXk2Wz5eidJYcFm5fdi6Er6FpVgdTcjSBawSSSFVE/iR3xQm?= =?iso-8859-1?Q?3abZHN4MBDKuSpmLEE1HmpGETkwxEwS+8f2ne2u1pQvU9/p59lc52UqaPN?= =?iso-8859-1?Q?tyRjNM5BzPwJqNmB8yHv3CMLrfXcPWhGeFouw4Fw5VzGQqkL4bHIkMVfYn?= =?iso-8859-1?Q?yr3q3ImnxumENYplmbyMwg14mfC98hbAGJdB0ecWrZZPrTewLA0J5ucDRJ?= =?iso-8859-1?Q?SCdTk8dNZkuyXnoL9mgvDdr22L1FAhhrtNk/TbsvBjdCmlZzAMX6cUYRZn?= =?iso-8859-1?Q?LmiEFe5ntvovj5cAX2HEElbRHP4rBC2cpYPaUYWhfUOEnOofSiEAOrVkrf?= =?iso-8859-1?Q?E6UZ6W1+82G6dUbCCQqwEMvP658PwVOMcH4klk07FNwrwPC6Z6JKVFxKZV?= =?iso-8859-1?Q?t8tPJochae8XDLaCEUJJFOaRbwNi9WIqDzBIA7ottx7e+HyPWPbTL7x1G+?= =?iso-8859-1?Q?HCYmc1Tm5BlPatJwZkWpA0AT81UiUf1bLPLtckOfLMz8B57gKKJ1WsGli6?= =?iso-8859-1?Q?FXs1ouWJoLzNfVHFU7gfEPrCCjLH8LmmjUtyQb/YWNDFtP8xL21HrExp9h?= =?iso-8859-1?Q?V5WAKiBVRDniZcZbBKg66fI/eUQVOHgrWndM6xpWuVBN36wixlTkQT5g6L?= =?iso-8859-1?Q?A+9ic65MNZdy2dZVTouoRhnEHYP8afiTcL4bn1k3KmvlpFC64JxvBngEcq?= =?iso-8859-1?Q?awP+64JVmCS/zHAehSKUDlgeC3Z+YuU2KBVWcJaQ71q7EMvFi+BOtxUfrj?= =?iso-8859-1?Q?grCp2yv66Io9kzbzE6fOIgA9J1kE7iX/t+Ff6csOs+RrZUGtHCSvQUI/R7?= =?iso-8859-1?Q?BewZO5dELyehiiDodlt2uzM/rE/ahIoWM98g7nZtK34VB9W2KnVIl+Y1ad?= =?iso-8859-1?Q?GkYu2MVQ6F6QZKOovX/qoHiRTXZgqu0Y5J/p7qh5AKsr6PB4i0cN0i78f+?= =?iso-8859-1?Q?SCI5hkHivZSX22aoSdMOdEKRoS/7pl09+Ikrm7dhflvbin8uRimsO0G1Yv?= =?iso-8859-1?Q?dRMgMuFMjTe5vy6/yvJ/RfPcC37EkZj5o1r6hvXaHrRNKrsBNHbqqF+fPo?= =?iso-8859-1?Q?TnLnA3UjjqLutV5lE0k+ftedQtTghQEMBkpZOdGCYi+hAhxvMbLweNKxIH?= =?iso-8859-1?Q?VVGUA/5v9HFIKYFuY5hgxefsfBYw8KwEpczohjl7I/ddPIQB1mepv4Ns9W?= =?iso-8859-1?Q?x52KsZcBrI/aWVdqMsdH2erHpELV31dWxcjddevqd2lo0UycetAss6vs2g?= =?iso-8859-1?Q?wrQiWTUqP1REoeYa3fRA6qjd9n/3dJbxz4bBxYU2TwUnEc5iQZTrjoohnq?= =?iso-8859-1?Q?DPAsukXBrXDpNMH0X8Tp/0NMUVMRlg3WjxHSXimhqhGlAL4KST1n9w38Hz?= =?iso-8859-1?Q?ZuJ2rts30Ii7r51T8vz/1tG6JU4kZicLjG?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB5568.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ad6946b-8b39-4382-5639-08da9ba4c92d X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2022 07:42:07.7855 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yHXkVu6Vj1E5wwusvyRYIe95F5HzIDCQBO/gdOb3XJzpg3NPVmrfSwfPd5o24mGqld55UWOruzLoTcE4naLO4n/TqvEkWwwNiJBB3AECyyk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR13MB5606 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > 21/09/2022 04:02, Chaoyong He: > > > On 9/15/2022 11:44 AM, Chaoyong He wrote: > > > > Adds the setup/start logic for the ctrl vNIC. This vNIC is used by > > > > the PMD and flower firmware application as a communication channel > > > between > > > > driver and firmware. In the case of OVS it is also used to > > > > communicate flow statistics from hardware to the driver. > > > > > > > > A rte_eth device is not exposed to DPDK for this vNIC as it is > > > > strictly used internally by flower logic. > > > > > > > > > > Hi Chaoyong, > > > > > > Similar comment with previous versions, interface is created using > > > regular 'rte_eth_dev_allocate()' API, I think interface will be > > > visible to application, I can't understand the need of creating an in= terface > for control. >=20 > You didn't reply to this. > Why the control port should be exposed to the application? > We recommend not using ethdev for this. >=20 Actually, in the v1--v5 of this patch series, we did create a control port = which is not in the rte_eth_devices[] array, so it won't exposed to the application. >=20 > > > What is the communication method between driver and FW? > > > Since one of the following patches (09/12) introduces Rx/Tx for ctrl > > > interface, is device interface is control packets (similar to network= data > packets)? > > > > > > > Basically, the 'control message' is exist in the form of normal data pa= ckets. > > > > When we use the flower firmware application, there exist two types of > > packets for now, and they are identified only from the prepend meta-dat= a. > > > > Bit 3 3 2 2 2 2 2 2 2 2 2 2 1 1 1 1 1 1 1 1 1 1 0 0 0 0 0 0 0 0 0 0 > > -----\ 1 0 9 8 7 6 5 4 3 2 1 0 9 8 7 6 5 4 3 2 1 0 9 8 7 6 5 4 3 2 1 0 > > Word +---------------+---------------+---------------+---------------+ > > 0 | type | type | type | type | > > > > +---------------+---------------+---------------+---------------+ > > The 'control message' packets are processed by the ctrl vNIC. > > The 'normal' packets are processed by the pf vNIC. > > > > The communication method between driver and firmware is decided by > the > > designment of hardware and firmware. > > > > The kernel driver also has the same ctrl vNIC and pf vNIC ethdev and th= e > usage is same. > > > > > > Because of the add of ctrl vNIC, a new PCItoCPPBar is needed. > > > > Modify the related logics. > > > > > > > > Signed-off-by: Chaoyong He > > > > Reviewed-by: Niklas S=F6derlund >=20 >=20