* [PATCH] doc: deprecate graph data structures
@ 2024-02-21 16:13 pbhagavatula
2024-03-19 3:22 ` Jerin Jacob
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: pbhagavatula @ 2024-02-21 16:13 UTC (permalink / raw)
To: jerinj, ndabilpuram, kirankumark, zhirun.yan; +Cc: dev, Pavan Nikhilesh
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Deprecate rte_node, rte_node_register and rte_graph_cluster_node_stats
structures as will be extended to include node specific error counters
and error description.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
doc/guides/rel_notes/deprecation.rst | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 10630ba255..b3dfd06ed6 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -142,3 +142,8 @@ Deprecation Notices
will be deprecated and subsequently removed in DPDK 24.11 release.
Before this, the new port library API (functions rte_swx_port_*)
will gradually transition from experimental to stable status.
+
+* graph: The graph library data structures will be modified to
+ support node specific errors, the structures ``rte_node``,
+ ``rte_node_register`` and ``rte_graph_cluster_node_stats`` will be
+ extended to include node error counters and error description.
--
2.25.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] doc: deprecate graph data structures
2024-02-21 16:13 [PATCH] doc: deprecate graph data structures pbhagavatula
@ 2024-03-19 3:22 ` Jerin Jacob
2024-03-19 15:50 ` Stephen Hemminger
2024-03-19 5:21 ` Nithin Dabilpuram
2024-07-31 12:22 ` Thomas Monjalon
2 siblings, 1 reply; 8+ messages in thread
From: Jerin Jacob @ 2024-03-19 3:22 UTC (permalink / raw)
To: pbhagavatula; +Cc: jerinj, ndabilpuram, kirankumark, zhirun.yan, dev
On Wed, Feb 21, 2024 at 9:43 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Deprecate rte_node, rte_node_register and rte_graph_cluster_node_stats
> structures as will be extended to include node specific error counters
> and error description.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Implementation patches for 24.11 at
https://patches.dpdk.org/project/dpdk/list/?series=31181.
The deprecation notice looks good to me.
Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 10630ba255..b3dfd06ed6 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -142,3 +142,8 @@ Deprecation Notices
> will be deprecated and subsequently removed in DPDK 24.11 release.
> Before this, the new port library API (functions rte_swx_port_*)
> will gradually transition from experimental to stable status.
> +
> +* graph: The graph library data structures will be modified to
> + support node specific errors, the structures ``rte_node``,
> + ``rte_node_register`` and ``rte_graph_cluster_node_stats`` will be
> + extended to include node error counters and error description.
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] doc: deprecate graph data structures
2024-03-19 3:22 ` Jerin Jacob
@ 2024-03-19 15:50 ` Stephen Hemminger
2024-03-20 7:29 ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
0 siblings, 1 reply; 8+ messages in thread
From: Stephen Hemminger @ 2024-03-19 15:50 UTC (permalink / raw)
To: Jerin Jacob
Cc: pbhagavatula, jerinj, ndabilpuram, kirankumark, zhirun.yan, dev
On Tue, 19 Mar 2024 08:52:13 +0530
Jerin Jacob <jerinjacobk@gmail.com> wrote:
> On Wed, Feb 21, 2024 at 9:43 PM <pbhagavatula@marvell.com> wrote:
> >
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Deprecate rte_node, rte_node_register and rte_graph_cluster_node_stats
> > structures as will be extended to include node specific error counters
> > and error description.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Implementation patches for 24.11 at
> https://patches.dpdk.org/project/dpdk/list/?series=31181.
> The deprecation notice looks good to me.
>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
Can more of the internals be private to the library to avoid future changes.
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [EXTERNAL] Re: [PATCH] doc: deprecate graph data structures
2024-03-19 15:50 ` Stephen Hemminger
@ 2024-03-20 7:29 ` Pavan Nikhilesh Bhagavatula
0 siblings, 0 replies; 8+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2024-03-20 7:29 UTC (permalink / raw)
To: Stephen Hemminger, Jerin Jacob
Cc: Jerin Jacob, Nithin Kumar Dabilpuram, Kiran Kumar Kokkilagadda,
zhirun.yan, dev
> On Tue, 19 Mar 2024 08:52:13 +0530
> Jerin Jacob <jerinjacobk@gmail.com> wrote:
>
> > On Wed, Feb 21, 2024 at 9:43 PM <pbhagavatula@marvell.com> wrote:
> > >
> > > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > >
> > > Deprecate rte_node, rte_node_register and rte_graph_cluster_node_stats
> > > structures as will be extended to include node specific error counters
> > > and error description.
> > >
> > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Implementation patches for 24.11 at
> > https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__patches.dpdk.org_project_dpdk_list_-3Fseries-
> 3D31181&d=DwIFaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=E3SgYMjtKCMVsB-
> fmvgGV3o-g_fjLhk5Pupi9ijohpc&m=UWUO-
> vO43HDzAb_QlsOvuvJsc8rbmtFAcsB6Hgzhjaumo01L-
> tlXha8dw_qPzxMO&s=FKKIPKTNhxdMKJf9M4Gma8F4783JsEFR512A7hfeQp
> g&e= .
> > The deprecation notice looks good to me.
> >
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
>
> Can more of the internals be private to the library to avoid future changes.
These structures are all used in fastpath i.e., inline functions so, unfortunately
cant be made private.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] doc: deprecate graph data structures
2024-02-21 16:13 [PATCH] doc: deprecate graph data structures pbhagavatula
2024-03-19 3:22 ` Jerin Jacob
@ 2024-03-19 5:21 ` Nithin Dabilpuram
2024-03-20 3:07 ` Yan, Zhirun
2024-07-31 12:22 ` Thomas Monjalon
2 siblings, 1 reply; 8+ messages in thread
From: Nithin Dabilpuram @ 2024-03-19 5:21 UTC (permalink / raw)
To: pbhagavatula; +Cc: jerinj, ndabilpuram, kirankumark, zhirun.yan, dev
Acked-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
On Wed, Feb 21, 2024 at 9:50 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Deprecate rte_node, rte_node_register and rte_graph_cluster_node_stats
> structures as will be extended to include node specific error counters
> and error description.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 10630ba255..b3dfd06ed6 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -142,3 +142,8 @@ Deprecation Notices
> will be deprecated and subsequently removed in DPDK 24.11 release.
> Before this, the new port library API (functions rte_swx_port_*)
> will gradually transition from experimental to stable status.
> +
> +* graph: The graph library data structures will be modified to
> + support node specific errors, the structures ``rte_node``,
> + ``rte_node_register`` and ``rte_graph_cluster_node_stats`` will be
> + extended to include node error counters and error description.
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] doc: deprecate graph data structures
2024-03-19 5:21 ` Nithin Dabilpuram
@ 2024-03-20 3:07 ` Yan, Zhirun
2024-07-18 12:36 ` Pavan Nikhilesh Bhagavatula
0 siblings, 1 reply; 8+ messages in thread
From: Yan, Zhirun @ 2024-03-20 3:07 UTC (permalink / raw)
To: Nithin Dabilpuram, pbhagavatula; +Cc: jerinj, ndabilpuram, kirankumark, dev
Acked-by: Zhirun Yan <zhirun.yan@intel.com>
> -----Original Message-----
> From: Nithin Dabilpuram <nithind1988@gmail.com>
> Sent: Tuesday, March 19, 2024 1:21 PM
> To: pbhagavatula@marvell.com
> Cc: jerinj@marvell.com; ndabilpuram@marvell.com; kirankumark@marvell.com;
> Yan, Zhirun <zhirun.yan@intel.com>; dev@dpdk.org
> Subject: Re: [PATCH] doc: deprecate graph data structures
>
> Acked-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
>
> On Wed, Feb 21, 2024 at 9:50 PM <pbhagavatula@marvell.com> wrote:
> >
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Deprecate rte_node, rte_node_register and rte_graph_cluster_node_stats
> > structures as will be extended to include node specific error counters
> > and error description.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > ---
> > doc/guides/rel_notes/deprecation.rst | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index 10630ba255..b3dfd06ed6 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -142,3 +142,8 @@ Deprecation Notices
> > will be deprecated and subsequently removed in DPDK 24.11 release.
> > Before this, the new port library API (functions rte_swx_port_*)
> > will gradually transition from experimental to stable status.
> > +
> > +* graph: The graph library data structures will be modified to
> > + support node specific errors, the structures ``rte_node``,
> > + ``rte_node_register`` and ``rte_graph_cluster_node_stats`` will be
> > + extended to include node error counters and error description.
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] doc: deprecate graph data structures
2024-03-20 3:07 ` Yan, Zhirun
@ 2024-07-18 12:36 ` Pavan Nikhilesh Bhagavatula
0 siblings, 0 replies; 8+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2024-07-18 12:36 UTC (permalink / raw)
To: Yan, Zhirun, Nithin Dabilpuram, Thomas Monjalon
Cc: Jerin Jacob, Nithin Kumar Dabilpuram, Kiran Kumar Kokkilagadda, dev
Thomas,
Ping can this deprecation notice be merged
> Acked-by: Zhirun Yan <zhirun.yan@intel.com>
>
> > -----Original Message-----
> > From: Nithin Dabilpuram <nithind1988@gmail.com>
> > Sent: Tuesday, March 19, 2024 1:21 PM
> > To: pbhagavatula@marvell.com
> > Cc: jerinj@marvell.com; ndabilpuram@marvell.com;
> kirankumark@marvell.com;
> > Yan, Zhirun <zhirun.yan@intel.com>; dev@dpdk.org
> > Subject: Re: [PATCH] doc: deprecate graph data structures
> >
> > Acked-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> >
> > On Wed, Feb 21, 2024 at 9:50 PM <pbhagavatula@marvell.com> wrote:
> > >
> > > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > >
> > > Deprecate rte_node, rte_node_register and rte_graph_cluster_node_stats
> > > structures as will be extended to include node specific error counters
> > > and error description.
> > >
> > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > > ---
> > > doc/guides/rel_notes/deprecation.rst | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/doc/guides/rel_notes/deprecation.rst
> > > b/doc/guides/rel_notes/deprecation.rst
> > > index 10630ba255..b3dfd06ed6 100644
> > > --- a/doc/guides/rel_notes/deprecation.rst
> > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > @@ -142,3 +142,8 @@ Deprecation Notices
> > > will be deprecated and subsequently removed in DPDK 24.11 release.
> > > Before this, the new port library API (functions rte_swx_port_*)
> > > will gradually transition from experimental to stable status.
> > > +
> > > +* graph: The graph library data structures will be modified to
> > > + support node specific errors, the structures ``rte_node``,
> > > + ``rte_node_register`` and ``rte_graph_cluster_node_stats`` will be
> > > + extended to include node error counters and error description.
> > > --
> > > 2.25.1
> > >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] doc: deprecate graph data structures
2024-02-21 16:13 [PATCH] doc: deprecate graph data structures pbhagavatula
2024-03-19 3:22 ` Jerin Jacob
2024-03-19 5:21 ` Nithin Dabilpuram
@ 2024-07-31 12:22 ` Thomas Monjalon
2 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2024-07-31 12:22 UTC (permalink / raw)
To: Pavan Nikhilesh; +Cc: jerinj, ndabilpuram, kirankumark, zhirun.yan, dev
21/02/2024 17:13, pbhagavatula@marvell.com:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Deprecate rte_node, rte_node_register and rte_graph_cluster_node_stats
> structures as will be extended to include node specific error counters
> and error description.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
Acked-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Acked-by: Zhirun Yan <zhirun.yan@intel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-07-31 12:28 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-21 16:13 [PATCH] doc: deprecate graph data structures pbhagavatula
2024-03-19 3:22 ` Jerin Jacob
2024-03-19 15:50 ` Stephen Hemminger
2024-03-20 7:29 ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2024-03-19 5:21 ` Nithin Dabilpuram
2024-03-20 3:07 ` Yan, Zhirun
2024-07-18 12:36 ` Pavan Nikhilesh Bhagavatula
2024-07-31 12:22 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).