RE: [EXTERNAL] Re: [PATCH v4 3/5] graph: add stats for node specific errors

[Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>]

> -----Original Message-----
> From: Robin Jarry <rjarry@redhat.com>
> Sent: Friday, October 11, 2024 3:24 PM
> To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Jerin Jacob
> <jerinj@marvell.com>; Nithin Kumar Dabilpuram
> <ndabilpuram@marvell.com>; Kiran Kumar Kokkilagadda
> <kirankumark@marvell.com>; zhirun.yan@intel.com; Zhirun Yan
> <yanzhirun_163@163.com>
> Cc: dev@dpdk.org
> Subject: [EXTERNAL] Re: [PATCH v4 3/5] graph: add stats for node specific
> errors
> 
> Hi Pavan, , Aug 16, 2024 at 17: 09: > From: Pavan Nikhilesh
> <pbhagavatula@ marvell. com> > > Add support for retrieving/printing stats
> for node specific > errors using rte_graph_cluster_stats_get(). > > Signed-off-
> by: Pavan
> 
> Hi Pavan,
> 
> , Aug 16, 2024 at 17:09:
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Add support for retrieving/printing stats for node specific
> > errors using rte_graph_cluster_stats_get().
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > ---
> 
> [snip]
> 
> > diff --git a/lib/graph/rte_graph.h b/lib/graph/rte_graph.h
> > index b28143d737..12b6461cf5 100644
> > --- a/lib/graph/rte_graph.h
> > +++ b/lib/graph/rte_graph.h
> > @@ -223,6 +223,10 @@ struct __rte_cache_aligned
> rte_graph_cluster_node_stats {
> >
> >  	uint64_t realloc_count; /**< Realloc count. */
> >
> > +	uint8_t node_error_cntrs;			   /**< Number of
> Node error counters. */
> > +	char (*node_error_desc)[RTE_NODE_ERROR_DESC_SIZE]; /**< Names
> of the Node error counters. */
> 
> Why do you need the parentheses here?
> 
> > +	uint64_t *node_error_count;			   /**< Total error
> count per each error. */
> 
> The node_ prefix is redundant here. Can you use something shorter?
> 
>    uint8_t errors_num; /**< Number of Node error counters. */
>    char (*errors_desc)[RTE_NODE_ERROR_DESC_SIZE];
>    uint64_t *errors_value;
> 

I will shrink them in the next version.

> Thanks!