From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEA3845B14; Fri, 11 Oct 2024 19:16:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A78A640A7D; Fri, 11 Oct 2024 19:16:03 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 71BD640A72 for ; Fri, 11 Oct 2024 19:16:02 +0200 (CEST) Received: from pps.filterd (m0431383.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49BBTRSb014696; Fri, 11 Oct 2024 10:15:55 -0700 Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2045.outbound.protection.outlook.com [104.47.74.45]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 4271b20ssy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Oct 2024 10:15:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ORiLmXay04Q1r60LST1zoWDCKvJ62TjJEqdMtvEqvcpp5uFA3FQhVSlg8Grnhu3It6AbbrwtUGAtAIzQRQV6LbTSXCkBZSpQq9oMWiZfH/v/KMABrflpJX4DZiWnTIxlow+KarQTcTEpKcX3eo90WfxXaxtz4/LLtM+vSkXqP9dBHeFeF72ajP007TLMo2EBD9E/jsR68Bvp1EHyRIGPMLx9PR6K5O2VB2Cw1Dmf7/yw5fwbYyDHvlVsUn1Am9t/bH6iPfboWupMsqCAGO2SFwTX+XhJDPFS7yoSx83H2+XcOraJpYPMmNppueFY8rugDsWxb5CP8B9P3t6aKKqZyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lTiwdF/lhvNzc504/PGdsFtrONhbufEB57wSEqykFYM=; b=kbnJ3rly/ERkFrZr8XOGl4Jsq5ZP5EhaPePmh0wCRAowp6DLOCz6gGHrxSzl4Lq5lN0YV8nsn8eXpvtCWwHnDepeOJLoFSkpO1SkO2hkgx1dj5PWmW2YwrzvN5evDopdCBYMaku/gNo08eKgw3ZGg+TjSibyrhK8NrdQ4NDKcumnCZdywkEEhntBcKRkQMHuMLhZzlf2mHcGabLMrUyemhnK0GMhCujQAU2mNl2dvlaoLkhHiQXIt7rHU4JTOoxtjo8WQsldq5rhSW+szbJU32pbrRbtPGDSsNLunereUq8AqGZCP0k/yYV36RsPLbqCJUkM4Mf0HbZiLGGlrGn9fQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lTiwdF/lhvNzc504/PGdsFtrONhbufEB57wSEqykFYM=; b=VgeSznVAYmuNJ0I96lpj36ypusY/nWI5mkKVIK8l1BRKApGIOq5EY8CeDLTaViUAxL7McXQ+SK1efkX01umDwft/KF7Vv+TUjuLckUCq7Gss4bp7K8agiBJfRCfx5sZklUKAJzSKGpM1iFN5poSkH2lgc5A+Jxc1Gu/cdurgsGQ= Received: from PH0PR18MB4086.namprd18.prod.outlook.com (2603:10b6:510:3::9) by SJ0PR18MB3993.namprd18.prod.outlook.com (2603:10b6:a03:2e5::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.21; Fri, 11 Oct 2024 17:15:49 +0000 Received: from PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::ed37:4ea0:6359:f717]) by PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::ed37:4ea0:6359:f717%5]) with mapi id 15.20.8048.020; Fri, 11 Oct 2024 17:15:49 +0000 From: Pavan Nikhilesh Bhagavatula To: Robin Jarry , Jerin Jacob , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , "zhirun.yan@intel.com" , Zhirun Yan CC: "dev@dpdk.org" Subject: RE: [EXTERNAL] Re: [PATCH v4 3/5] graph: add stats for node specific errors Thread-Topic: [EXTERNAL] Re: [PATCH v4 3/5] graph: add stats for node specific errors Thread-Index: AQHa7+5boNcBTiNGuUyfd1Pvuqwvs7KBpygAgAB7SgA= Date: Fri, 11 Oct 2024 17:15:48 +0000 Message-ID: References: <20240222122342.16375-1-pbhagavatula@marvell.com> <20240816150926.5789-1-pbhagavatula@marvell.com> <20240816150926.5789-3-pbhagavatula@marvell.com> In-Reply-To: Accept-Language: en-US, en-IN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB4086:EE_|SJ0PR18MB3993:EE_ x-ms-office365-filtering-correlation-id: 5bef1ad2-fa55-4505-5984-08dcea185a08 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: =?utf-8?B?SFlGUFBEaHpxcGFjU2FacUFmYWtoVjYyOGVyQ0VuVHBXeWMvMmJPRHhSZyt6?= =?utf-8?B?dnNGRVdZYmRKRm1US0dKTGFadmtpZThDVktVWkJvWDc3Yk5KYlBjcHJuUnda?= =?utf-8?B?VjhvNHhDSVkzZDhkMXFWUG93enN3azdxVExZbHUycVhnVGNBZnVPM2pTakNK?= =?utf-8?B?RnpDNnpzNTBkZnFja1ZOcU92WExESlNGQjlPR2J1Z3A0bm4zVEdBTHU0bmxP?= =?utf-8?B?aW1pZ2UvWFJWSFd0akUwRGRLUTlad3BqSjI4ajAwd2ZqTTBRaTBKUHM4NjUv?= =?utf-8?B?Z2w1Zm9QWGtPeCtwSnJkaHJlSTNtTHd1YlA3NzFpYWFTTXRha3BRS21haVk5?= =?utf-8?B?YmRrNGpFalpTVnU4SFFydmVRYUpRU0QzNVhwRk9iOUFMMDVYOGNxM2hPTUVa?= =?utf-8?B?WDcwMFFoZ1pBT1lWZDRvRTVlQ3E5eFRhTGVkZUlmaFQrdDV3M3BtQXg3VThV?= =?utf-8?B?cG5vT2ZBUXhHNTl3UkRiM0dsK2NYQThTT1h2VkpHdzhRd2RZb0xOeU1qL2Jv?= =?utf-8?B?K0ZTNGc0SlJ3dkI0MmhjUXJnWFpmbGpCY2cwc09FdVByeWpiRW9PTnl4RXQv?= =?utf-8?B?c0tpVFNxVGtZd3huT0ptQWgrVW5SaUxTNHNLYmxnWUVleUZpcFNzWk12RTdr?= =?utf-8?B?KzVvaWk2a3VPUUhBTU4zTGt1akFNY1N1Q3kvYTJHMVdlODZrSXZMOTUyYzZw?= =?utf-8?B?cVpZalJPVWpzS3hUNmdmeWRmMGpmZVhKRTBOeVU4dXRqRXhlK3BVNDVHcDJE?= =?utf-8?B?T1ZrQm5UK3VVQ1luV1htcStBSEltTEJDek5GQWwvWG15amZjZDlUUEFNVEJj?= =?utf-8?B?aVBRUUIxMTRqaHVxOEpwSDh6OXBONmRBZlVNaEFVc3JzQU1IVHNuSVhZQzIv?= =?utf-8?B?VG15dEplVUlxdHV6RDJBcVJQQlNBSnppbmlpMXFTejZtbHZXUFpXZEJCd0Mw?= =?utf-8?B?YXdnR1J3YXdaOFdaRTJUWk1raDJJMnV5WFBBK0FKVzFva09MaEE1YkdaOVIw?= =?utf-8?B?TXZUbkduOUE1RGRUaDVBVnljRmlmMFVtT2M5QWxLOGxJRjF0Mzh1ejNmOEtM?= =?utf-8?B?YW9RNW9GbFdWK3Q4ZisyeUFtRFMxcSsxSWo2a1dLNlliOWxLUGljSklYNkph?= =?utf-8?B?NGVMa1h2UkZUb0E3ZXpVSUcxMXZucjMzQlZuZFZxQjhPc0hXeTNZczQ1QU1v?= =?utf-8?B?ZXFtRXFxdFNPYU85b1lub3p5WGExVzF2MkZyTzVwOS9VcXhpeitHYnJTcWdt?= =?utf-8?B?MEVsSnZUdURLMk1RTEFKMzlZbW1PYkt6SllSWXlXR0MwRkF1eFN6NGRvWXBu?= =?utf-8?B?UjJDcmQ5dnpOQ1RHOFc3ZjAvVHFBSmtGOHo4UEZLSGV1N0hXVnB4Zk1od1Yz?= =?utf-8?B?dmZFOVlBcFBhUGtzc3h2Tmt4Ykg0bE1xQmRIby9nSlZ1TitONkxxcVBBUUYw?= =?utf-8?B?V2w4UWlVL3c5aTdmRDVJS3N4Umc2azRyNmFIZmlhL0dackF1T3FreXNjdHpH?= =?utf-8?B?QkZaR291TWxza0ZyY0hIbGtJQVl2Ni8zSGJrelBjZzdST1l5ZzQvMHBpQko4?= =?utf-8?B?T01IN2h4Y0EwVUpWY1VhenZLczR4UDRRNjdOcVVadGwrblhrYlErNzE3cVc3?= =?utf-8?B?aXRlQWtzV09LNlU2MkhmMjNDa1NTUFJmWHhackhyYmExNm8vbFBLdE4reTM4?= =?utf-8?B?V0ZvaFlTSWhCR0MyaVlZUkgwdFpmempVSjZjYnRadmltZUYzUitUaWNZMytm?= =?utf-8?Q?RZSA1OmqyksPGhvlNw=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4086.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QmJaWXh3VW1hNmROalJZaUJHUGw0ZnlkVEdPWXAxVHI4cC9oUE1QSVlsSi8v?= =?utf-8?B?anAwUW5OTGRsWmdNTFY0T0hsWmplaEIxb3BjYk1nMlJEb3BiMlVPWDlTZGdM?= =?utf-8?B?dERMMWpGN1RBNmdoY1B6VVE4Q2hhU1I4Mm5sVWEyS1M5SmxrN3N0UTRQQUxJ?= =?utf-8?B?MWlUVkl5MFFJWkQ0QjJKMENTRUpWeVBzUUFwVzd6TjJIU3A1elloOGQyTjJy?= =?utf-8?B?dExPaEJ6cjRlYktsb1ljbThBS2hWcXlrNVQraTRvWEx2NUhWcUp1L3hNSWho?= =?utf-8?B?MTBoRU05Y3JHRjBaZ3MwWmdabkVHNnFIOENITXVpTGgvL0JueUx3NUpCam1y?= =?utf-8?B?aFpSUjNpMk8vTnFHaXRjN0RVMGpxWkR4c1hhcCtkakc3ZXpwNWxwUmY2VGVK?= =?utf-8?B?d0F4Qi9HeEZvLzIwMTZtbjRabXRwZ2g0aE0wOUdJMW5KeVB4U05DL1U1eWhy?= =?utf-8?B?ODU5OHlvOU9UQWM1Zk1xVEpBVkpaSHpXbkIzUG90ckt4aWhsa0F5TGgyMGhq?= =?utf-8?B?UkFKUGZrbjg3SnNJNlQ5WnR2eGlnVjZsTkhQeTF5cCsxSndPdXBVblhZN3o1?= =?utf-8?B?WG85NkhxRFN6WFBIZVA4ZFYyMTF6elNVMEdjNGxxNGRJRkVpK0F2Zmw3cTI2?= =?utf-8?B?RkdQM3M0RlpnRG1PQ1VpK0hXVGlSNi9IcDJ6K3JjZzNCb2dZUzE1cDNWbm5N?= =?utf-8?B?TEgxcFg5QlRHSW9QUitnYXdKVzBlYmJsWDVYRUVIdFo2cTBJb2lZeW4zd3lj?= =?utf-8?B?bS9QeGhub2c5UmxwR0JjQTB4SWhNQWEzR1lyWlp2TjVaNXJCNFVsenVxM2Mx?= =?utf-8?B?Ni85bjJoUytrb0RNa0E0ZERCU1JBY1VsSXdlZTlYVmJpaGlwRUV6Y0J0SkFH?= =?utf-8?B?Zlkvcmp4YldjSnE4Nm5tZEdPREp1L2VOenNLVXNEeGQxZm52SlFwM3Q5RDVY?= =?utf-8?B?U0xZaWM2NXJkaitpRVVTaTNiRlI5RmpsNmd6OXhtbkdKUDZpN0FiZlBDVm1l?= =?utf-8?B?NW40RUt6aTYwZjB5dDhrYWdPdCs0T0NDZU1VVXpaZXhFa1c4WUFUc0hKMkZu?= =?utf-8?B?TUNUcmh2L1RBVDBvVmYrb3BtWVdkMjNGRCtNWmVJMFEvT3NkbHUwWmVzdWph?= =?utf-8?B?aHdKNlJHK3ZLaGRZbDFDdzY1UkJpTFc5ZG05bE9hUUIzQ0tGdCsyc3Jxdm5E?= =?utf-8?B?NFNvTDhtWjNzY0FZQVBuRHpvOHBFczFVRWhIVU50RE5XMm5XZG5HU3RlU2g4?= =?utf-8?B?bVp3TGhKM3p1Zmt1OFBGdE9NUlFMODZ5OTFtcmEyM0t6SnhYY0RnSGhxbTFo?= =?utf-8?B?bnpzSnR2TVh2cTd2Y3BYSnJGQXRxcEtTY3VweXlKRDdHcmorVGZqOGd4QVh3?= =?utf-8?B?bkNXTnVHNm9PTFpjSkNXb2F1blNKd3dORkl6QjdIdTJhV2NFK2pIeTU0Y2xM?= =?utf-8?B?MFhtYnBPUGZITEFERmxnS2dYdG53czc3b0Q5T2o3SGRDSDhuWUltRjAvODl0?= =?utf-8?B?d1R4ejJmMENqTUJoNXhTRHB3TWFWQWJJTjhNVlk3TUFSK3VBWmdsV1dWaVBH?= =?utf-8?B?emhYUnVVSHZVSTQ5QWZ0NHYwdW9hand5QlJ1eEFPWDdKYm1TcHF2WEk5VVUx?= =?utf-8?B?T3hZQmhDR0FBb1YvcXltbHpxaU8xTHhkdWx2RSt6d2NQc0FPbnZoYTNFam13?= =?utf-8?B?SFFaK2ZicEszR3hQcDVtYThLY01IM0hzVG9KbE9LRmRzZmx0aWFrejB2bW1O?= =?utf-8?B?VnVmQ05yVEl6b25CMmF2NDZzVWRHVWJvT0dHUHV0WWdIY213OHVFMGU4TUlX?= =?utf-8?B?bTFEc21zTHJNaXBEaFhiUWpTUFR6OXN2ZzQvNGNnV2hJejdlWW5MQkkxQWlH?= =?utf-8?B?RXNpdU1HaXZYTjY5ZnpXcVZ2YU5uQk5wbjlHbGRYTXU4elJ2RWw4Q3Vlbnhh?= =?utf-8?B?endxMkJkbkV1b1VHMmp6VmVtMncrSTZXYzZwbHV6QlhCVjJKbG1MdmlhQ0lr?= =?utf-8?B?RWZnYVhkWXFUZytPVDVmU1g3ZHBiZk9oWGg0aHE0d1RGSkc5WGM5Wm9uZFVJ?= =?utf-8?B?SXRTVDJmQ1dTcHJlY2NzaHBJOStGYnRzdmhNSVhWOUVWOC94Q3dNNWI4NUxr?= =?utf-8?Q?cCDxsrk4YcV+q1IfjPL6E0v5y?= MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4086.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5bef1ad2-fa55-4505-5984-08dcea185a08 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2024 17:15:49.0034 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Mfs0zRfbySBuSQfhp9PUxXYlsVesQtagUFvFpEA9IrWO/MbI85iYh066BEvvFld6KMxLBBfCOMGZopp8ruVPnwG3EycWU8xn0QVNKdcAc3A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB3993 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: ssbwA51Pg12O1rMzh5oI9UvdYqC81NBv X-Proofpoint-ORIG-GUID: ssbwA51Pg12O1rMzh5oI9UvdYqC81NBv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.687,Hydra:6.0.235,FMLib:17.0.607.475 definitions=2020-10-13_15,2020-10-13_02,2020-04-07_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Robin Jarry > Sent: Friday, October 11, 2024 3:24 PM > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > ; Nithin Kumar Dabilpuram > ; Kiran Kumar Kokkilagadda > ; zhirun.yan@intel.com; Zhirun Yan > > Cc: dev@dpdk.org > Subject: [EXTERNAL] Re: [PATCH v4 3/5] graph: add stats for node specific > errors >=20 > Hi Pavan, , Aug 16, 2024 at 17:=E2=80=8A09: > From: Pavan Nikhilesh > > > Add support for retrievi= ng/printing stats > for node specific > errors using rte_graph_cluster_stats_get(). > > Signe= d-off- > by: Pavan >=20 > Hi Pavan, >=20 > , Aug 16, 2024 at 17:09: > > From: Pavan Nikhilesh > > > > Add support for retrieving/printing stats for node specific > > errors using rte_graph_cluster_stats_get(). > > > > Signed-off-by: Pavan Nikhilesh > > --- >=20 > [snip] >=20 > > diff --git a/lib/graph/rte_graph.h b/lib/graph/rte_graph.h > > index b28143d737..12b6461cf5 100644 > > --- a/lib/graph/rte_graph.h > > +++ b/lib/graph/rte_graph.h > > @@ -223,6 +223,10 @@ struct __rte_cache_aligned > rte_graph_cluster_node_stats { > > > > uint64_t realloc_count; /**< Realloc count. */ > > > > + uint8_t node_error_cntrs; /**< Number of > Node error counters. */ > > + char (*node_error_desc)[RTE_NODE_ERROR_DESC_SIZE]; /**< Names > of the Node error counters. */ >=20 > Why do you need the parentheses here? >=20 > > + uint64_t *node_error_count; /**< Total error > count per each error. */ >=20 > The node_ prefix is redundant here. Can you use something shorter? >=20 > uint8_t errors_num; /**< Number of Node error counters. */ > char (*errors_desc)[RTE_NODE_ERROR_DESC_SIZE]; > uint64_t *errors_value; >=20 I will shrink them in the next version. > Thanks!