From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
"Ruifeng.Wang@arm.com" <Ruifeng.Wang@arm.com>,
"thomas@monjalon.net" <thomas@monjalon.net>
Subject: RE: [EXT] [PATCH 04/16] drivers/event: use previous value atomic fetch operations
Date: Mon, 13 Mar 2023 07:02:25 +0000 [thread overview]
Message-ID: <PH0PR18MB40862208579906B98E9F2355DEB99@PH0PR18MB4086.namprd18.prod.outlook.com> (raw)
In-Reply-To: <1678486530-20688-5-git-send-email-roretzla@linux.microsoft.com>
> -----Original Message-----
> From: Tyler Retzlaff <roretzla@linux.microsoft.com>
> Sent: Saturday, March 11, 2023 3:45 AM
> To: dev@dpdk.org
> Cc: Honnappa.Nagarahalli@arm.com; Ruifeng.Wang@arm.com;
> thomas@monjalon.net; Tyler Retzlaff <roretzla@linux.microsoft.com>
> Subject: [EXT] [PATCH 04/16] drivers/event: use previous value atomic fetch
> operations
>
> External Email
>
> ----------------------------------------------------------------------
> Use __atomic_fetch_{add,and,or,sub,xor} instead of
> __atomic_{add,and,or,sub,xor}_fetch adding the necessary code to
> allow consumption of the resulting value.
>
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
> drivers/event/cnxk/cnxk_tim_worker.h | 2 +-
> drivers/event/dsw/dsw_event.c | 4 ++--
> drivers/event/octeontx/timvf_worker.h | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/event/cnxk/cnxk_tim_worker.h
> b/drivers/event/cnxk/cnxk_tim_worker.h
> index a326d55..0bd66ec 100644
> --- a/drivers/event/cnxk/cnxk_tim_worker.h
> +++ b/drivers/event/cnxk/cnxk_tim_worker.h
> @@ -123,7 +123,7 @@
> const uint64_t v =
> ~(TIM_BUCKET_W1_M_NUM_ENTRIES <<
> TIM_BUCKET_W1_S_NUM_ENTRIES);
>
> - return __atomic_and_fetch(&bktp->w1, v, __ATOMIC_ACQ_REL);
> + return __atomic_fetch_and(&bktp->w1, v, __ATOMIC_ACQ_REL) &
> v;
> }
>
> static inline uint64_t
> diff --git a/drivers/event/dsw/dsw_event.c
> b/drivers/event/dsw/dsw_event.c
> index 9932caf..cbdc03f 100644
> --- a/drivers/event/dsw/dsw_event.c
> +++ b/drivers/event/dsw/dsw_event.c
> @@ -45,8 +45,8 @@
> * allocation.
> */
> new_total_on_loan =
> - __atomic_add_fetch(&dsw->credits_on_loan, acquired_credits,
> - __ATOMIC_RELAXED);
> + __atomic_fetch_add(&dsw->credits_on_loan, acquired_credits,
> + __ATOMIC_RELAXED) + acquired_credits;
>
> if (unlikely(new_total_on_loan > dsw->max_inflight)) {
> /* Some other port took the last credits */
> diff --git a/drivers/event/octeontx/timvf_worker.h
> b/drivers/event/octeontx/timvf_worker.h
> index 3f1e77f..aa729f8 100644
> --- a/drivers/event/octeontx/timvf_worker.h
> +++ b/drivers/event/octeontx/timvf_worker.h
> @@ -135,7 +135,7 @@
> {
> const uint64_t v = ~(TIM_BUCKET_W1_M_NUM_ENTRIES <<
> TIM_BUCKET_W1_S_NUM_ENTRIES);
> - return __atomic_and_fetch(&bktp->w1, v, __ATOMIC_ACQ_REL);
> + return __atomic_fetch_and(&bktp->w1, v, __ATOMIC_ACQ_REL) &
> v;
> }
>
> static inline struct tim_mem_entry *
> --
> 1.8.3.1
next prev parent reply other threads:[~2023-03-13 7:02 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 22:15 [PATCH 00/16] use __atomic operations returning new value Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 01/16] app/test: use previous value atomic fetch operations Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 02/16] common/cnxk: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 03/16] common/mlx5: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 04/16] drivers/event: " Tyler Retzlaff
2023-03-13 7:02 ` Pavan Nikhilesh Bhagavatula [this message]
2023-03-10 22:15 ` [PATCH 05/16] net/af_xdp: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 06/16] net/cnxk: " Tyler Retzlaff
2023-03-13 6:45 ` [EXT] " Nithin Kumar Dabilpuram
2023-03-10 22:15 ` [PATCH 07/16] net/cxgbe: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 08/16] net/iavf: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 09/16] net/mlx5: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 10/16] net/octeontx: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 11/16] raw/ifpga: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 12/16] bbdev: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 13/16] eal: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 14/16] ipsec: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 15/16] mbuf: " Tyler Retzlaff
2023-03-10 22:15 ` [PATCH 16/16] rcu: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 00/16] replace __atomic operations returning new value Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 01/16] app/test: use previous value atomic fetch operations Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 02/16] common/cnxk: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 03/16] common/mlx5: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 04/16] drivers/event: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 05/16] net/af_xdp: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 06/16] net/cnxk: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 07/16] net/cxgbe: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 08/16] net/iavf: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 09/16] net/mlx5: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 10/16] net/octeontx: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 11/16] raw/ifpga: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 12/16] bbdev: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 13/16] eal: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 14/16] ipsec: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 15/16] mbuf: " Tyler Retzlaff
2023-03-15 21:15 ` [PATCH v2 16/16] rcu: " Tyler Retzlaff
2023-03-16 10:03 ` [PATCH v2 00/16] replace __atomic operations returning new value Bruce Richardson
2023-03-16 15:25 ` Thomas Monjalon
2023-03-16 16:17 ` Tyler Retzlaff
2023-04-18 18:11 ` Tyler Retzlaff
2023-03-20 10:24 ` Ruifeng Wang
2023-03-20 19:00 ` [PATCH v3 " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 01/16] app/test: use previous value atomic fetch operations Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 02/16] common/cnxk: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 03/16] common/mlx5: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 04/16] drivers/event: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 05/16] net/af_xdp: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 06/16] net/cnxk: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 07/16] net/cxgbe: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 08/16] net/iavf: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 09/16] net/mlx5: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 10/16] net/octeontx: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 11/16] raw/ifpga: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 12/16] bbdev: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 13/16] eal: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 14/16] ipsec: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 15/16] mbuf: " Tyler Retzlaff
2023-03-20 19:00 ` [PATCH v3 16/16] rcu: " Tyler Retzlaff
2023-04-25 9:10 ` [PATCH v3 00/16] replace __atomic operations returning new value David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB40862208579906B98E9F2355DEB99@PH0PR18MB4086.namprd18.prod.outlook.com \
--to=pbhagavatula@marvell.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).