DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Jerin Jacob <jerinj@marvell.com>,
	Amit Prakash Shukla <amitprakashs@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1 1/3] app/test-eventdev: fix issues with clang 21.1.4
Date: Wed, 29 Oct 2025 06:25:33 +0000	[thread overview]
Message-ID: <PH0PR18MB40862DA7652261115B88195EDEFAA@PH0PR18MB4086.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20251028172324.3149379-1-jerinj@marvell.com>

>Fix the following error seen with clang 21.1.4
>
>app/test-eventdev/test_perf_common.c:1340:30: error: variable
>'event' is uninitialized when passed as a const pointer argument
>here [-Werror,-Wuninitialized-const-pointer]
>
>Fixes: b25a66c49e8d ("app/eventdev: add DMA adapter performance test")
>Cc: stable@dpdk.org
>
>Signed-off-by: Jerin Jacob <jerinj@marvell.com>

Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

>---
> app/test-eventdev/test_perf_common.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c
>index 2ad451e457..2bbc17ae96 100644
>--- a/app/test-eventdev/test_perf_common.c
>+++ b/app/test-eventdev/test_perf_common.c
>@@ -1335,13 +1335,14 @@ perf_event_dma_adapter_setup(struct test_perf *t, struct prod_data *p)
>                return -ENOTSUP;
>        }
>
>-       if (cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_VCHAN_EV_BIND)
>+       if (cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_VCHAN_EV_BIND) {
>+               event.queue_id = p->queue_id;
>                ret = rte_event_dma_adapter_vchan_add(TEST_PERF_DA_ID, p->da.dma_dev_id,
>                                                      p->da.vchan_id, &event);
>-       else
>+       } else {
>                ret = rte_event_dma_adapter_vchan_add(TEST_PERF_DA_ID, p->da.dma_dev_id,
>                                                      p->da.vchan_id, NULL);
>-
>+       }
>        return ret;
> }
>
>--
>2.51.2


  parent reply	other threads:[~2025-10-29  6:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-28 17:23 jerinj
2025-10-28 17:23 ` [dpdk-dev] [PATCH v1 2/3] net/iavf: " jerinj
2025-10-29 10:01   ` Medvedkin, Vladimir
2025-10-29 13:13   ` David Marchand
2025-10-28 17:23 ` [dpdk-dev] [PATCH v1 3/3] app/test: " jerinj
2025-10-29  5:02   ` Amit Prakash Shukla
2025-10-29 13:19   ` David Marchand
2025-10-29  6:25 ` Pavan Nikhilesh Bhagavatula [this message]
2025-10-29 13:11 ` [dpdk-dev] [PATCH v1 1/3] app/test-eventdev: " David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR18MB40862DA7652261115B88195EDEFAA@PH0PR18MB4086.namprd18.prod.outlook.com \
    --to=pbhagavatula@marvell.com \
    --cc=amitprakashs@marvell.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).