From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: "Morten Brørup" <mb@smartsharesystems.com>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"Stephen Hemminger" <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Chengwen Feng <fengchengwen@huawei.com>,
Kevin Laatz <kevin.laatz@intel.com>
Subject: Re: [PATCH] dmadev: replace zero length array
Date: Thu, 16 Oct 2025 09:50:43 +0000 [thread overview]
Message-ID: <PH0PR18MB4086321DB97D825FF9E44D86DEE9A@PH0PR18MB4086.namprd18.prod.outlook.com> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35F654D4@smartserver.smartshare.dk>
>> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
>> Sent: Thursday, 16 October 2025 10.15
>>
>> On Wed, Oct 15, 2025 at 11:59:46AM -0700, Stephen Hemminger wrote:
>> > Use of zero length arrays is Gcc extension.
>> > Found by zero_length_array.cocci.
>> >
>> > Fixes: 9674119fbf27 ("dmadev: add enqueue/dequeue operations")
>> > Cc: pbhagavatula@marvell.com
>> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>> > ---
>> > lib/dmadev/rte_dmadev.h | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h
>> > index 30e168825e..8ae9ee031b 100644
>> > --- a/lib/dmadev/rte_dmadev.h
>> > +++ b/lib/dmadev/rte_dmadev.h
>> > @@ -856,7 +856,7 @@ struct rte_dma_op {
>> > /** Number of destination segments. */
>> > uint16_t nb_dst;
>> > /** Source and destination segments. */
>> > - struct rte_dma_sge src_dst_seg[0];
>> > + struct rte_dma_sge src_dst_seg[];
>> > };
>> >
>> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>Acked-by: Morten Brørup <mb@smartsharesystems.com>
Thanks Stephan,
Acked-by: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
We should probably add this check to CI.
prev parent reply other threads:[~2025-10-16 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 18:59 Stephen Hemminger
2025-10-16 8:15 ` Bruce Richardson
2025-10-16 9:47 ` Morten Brørup
2025-10-16 9:50 ` Pavan Nikhilesh Bhagavatula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB4086321DB97D825FF9E44D86DEE9A@PH0PR18MB4086.namprd18.prod.outlook.com \
--to=pbhagavatula@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=kevin.laatz@intel.com \
--cc=mb@smartsharesystems.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).