From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3235FA0C45; Tue, 24 Aug 2021 07:17:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1B00340687; Tue, 24 Aug 2021 07:17:00 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id B20D54014D for ; Tue, 24 Aug 2021 07:16:58 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 17NLc64w007573; Mon, 23 Aug 2021 22:16:58 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2169.outbound.protection.outlook.com [104.47.55.169]) by mx0b-0016f401.pphosted.com with ESMTP id 3amkrk96ae-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Aug 2021 22:16:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iTBi9zkriEPnDE4n1gd3sOMSsVFgmGaNySb0QzABN3wR1xaGqS/+4VPPagStqTpB0UeL9KJU8TbfOH4UtcU2jZoQzhsssHah9EQLszaJOl1JCVj7IOURU7cDy7RNNbONTrYf5wyIgNRhrhSunOCrQVTeW5rONYQ6Pdan7TXO5a4GBOpoDGNtjuiRlDj9lXT8ila4+io1oRBzxtE8yjFP51SRuGof6pB8zwAGG4ugKSsjNTLHAu7opWZbHeIcH6zxPBDI02sgKpFBpeWz4Z4ajPzt8fqcn9Z9C3l2Cf19vYh40iUzFD9CCIutZftjUY3ysSHohbyUegaRWXVimgLaUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YSIikF7gad/HlB7VorIVrG1MSMA1xd87Va2uFlqKfsk=; b=mK2fXpe2tLDqzUEI0LDbyFSHGuxDRcpBdOWwFg2oj102Rjy2hg5eK065srl8oQNXxF1IKM/EBaLiAKu60MbYnZA7tYaBD2x2hn/O8u6RAU1lrGkn67KXfjlIy2Jg/JSXXdBUQ7myqH9Uk5PRwhbCciFiHSiYLRe6PfwchH0rEQr5/JB2Ii67JVbktfJW0IO7YL9Ck1m0H2rFZhpV61j4Ib74Hz58juS5NZGxKJw8dFlAjBgZt8SbPkitziVDEV/Bh1xlOdlY/gytPyFXPBlcCdJGpNNRzl2E+petkub4T69/V3dzJw0ttrIDSQMTzMXWucFTLq5ug4WB4Y9VvXmvQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YSIikF7gad/HlB7VorIVrG1MSMA1xd87Va2uFlqKfsk=; b=LnS1/Pq1bN7qMUYNLFP5MG+RewCK6PQlc1E5sljhr4cGk+CL1sEoK0DVZBddGuVqApLwIJ9dMpYaZtzgmlvngYes/YocccE0xSJfGQiwydMdIARQKVav19S81eyV+0hjwAy9Vd71rYW20TQqJDhvmYnkXtTOLmUaf59GM9C30kI= Received: from PH0PR18MB4086.namprd18.prod.outlook.com (2603:10b6:510:3::9) by PH0PR18MB3941.namprd18.prod.outlook.com (2603:10b6:510:22::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19; Tue, 24 Aug 2021 05:16:55 +0000 Received: from PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::d5ea:b9e5:cfbe:a41]) by PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::d5ea:b9e5:cfbe:a41%6]) with mapi id 15.20.4436.024; Tue, 24 Aug 2021 05:16:55 +0000 From: Pavan Nikhilesh Bhagavatula To: "Carrillo, Erik G" , Jerin Jacob Kollanukkaran CC: "Ananyev, Konstantin" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC 11/15] eventdev: reserve fields in timer object Thread-Index: AQHXmFbaoheo8+SNDEWO31/MSuEBsquBjjsAgACPVtA= Date: Tue, 24 Aug 2021 05:16:54 +0000 Message-ID: References: <20210823194020.1229-1-pbhagavatula@marvell.com> <20210823194020.1229-11-pbhagavatula@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bd78d77b-b4a3-4207-670f-08d966be63b3 x-ms-traffictypediagnostic: PH0PR18MB3941: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WHKDn6CohBbPdb2i5HKIEDUsrGCyPQZZuovzPFW60b7zBYpZuidv6JCOR5sBuwxIdl4JLTAWa+AgEoQHIiMIM3Ce3JFLyY8HcmJQca+yq4KbXldIm1mIrCr1fET7KcaNGDl7NNQj1ogxPNg+gkJF35suHRvm0uqgMlVRT3/jyX8AsyPHOEuKzWFgtjBew26Ydnsp//A3S65u7C6prVghmOgNh5NDUEA61JNnt+QOCOFINc9Cfe4C/l7Knh4CQ50UFAZabxqHwwHtqIE/kehrStMUmx7ThvvsM/rryGiE9149NXYy/BroxIfx1cpIAjqLC/KFF3pA6ZyKmZTM4N6NRq0OQSsXLf62Pp19KGEkBSzP+S4JiGfJC5M/HQfhvzdhd32L7/YB9QcMOro6IcmZP1Yzv7ZrTuK1D6uXBHhgh0fp1+Y9uNWFoI45aL8PMDmeLmeAwskxe4eKCKkHjFhOdYz3+hQ6/i2DI6FZTDIHiLiqMrrPj0WIfPMDSK77f/eo9iiwxfTQBzMd7cA14uY1BaKRJj+PIBkvNk/o+OqdD9pr4+Bw1q9C5xU4vuVAG+BBgKZrU0CLBgR7HxhrFoaND43DEOFq54BfiWJIWTRv/ntHPJgh2WRHylAtO3cFifc2iGPpLFktOwHSvSd+XNyCfhimoU30DnLKwEZ1vsCf70qbOeUgO2dNAdtIylW/0qQ2r0dqh/88SiaqgyJnN5YS0A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4086.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(346002)(136003)(366004)(396003)(71200400001)(122000001)(7696005)(110136005)(83380400001)(54906003)(86362001)(38100700002)(6506007)(53546011)(66946007)(5660300002)(64756008)(6636002)(52536014)(66476007)(8936002)(55016002)(8676002)(76116006)(33656002)(2906002)(4326008)(186003)(316002)(66446008)(9686003)(38070700005)(66556008)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?x4J2V0p9RRaOBDk5N48t/AXOAtinxyy8vVX4LVfpkfFZtlVsN0V5TH5ML2QZ?= =?us-ascii?Q?hI6JCFrjEj5ZG6YlM1MPl6eEaRFn8EOZpv5WfnBcxOKXyvRjRmM0nSg4jDTu?= =?us-ascii?Q?tZH/i2+Hw00ClQcnuzjdMjXsxJt/5MaU8pD1zUEhMRaJ2+MrQosXbd/XmCbv?= =?us-ascii?Q?iUmhzVEloLlp3BCDldD7q5Kk5ed00JLC13EpSmG+yrAUzmfVjJfL1gtnO6Ud?= =?us-ascii?Q?XJ6EeLiQnhqwTfpm/v4x0E9Cg5M1KEOWduMUEqO8dbDyUiPUzPzs5tlnEIdt?= =?us-ascii?Q?SBIPSLJdz0cNjUUIjwSmSkZgWjQcSoBEqgqjqp4RxhZUjfy5faZVj/GDd6p6?= =?us-ascii?Q?GXv/YF8F9xAL04PFbo0PBEEUPFq/FkWcLV/9MT/ZcXfwclY3dOiwOydkw26K?= =?us-ascii?Q?eBCThlhQGE858kGj7CSBMDJyEnni5eyw53TvfZ80iUrC/FzZ5VHfvxGDJ0jg?= =?us-ascii?Q?6ocqPBLTuZmYCIehxhURdUZYl4UjrN3YNH3Qr9WHLZigVs/YbGGT2s9Jsy1X?= =?us-ascii?Q?rlFTk5at146xdhPuhAVA/W7ejSN3yLk2n83x/Zl0+atNG3SMr3CDRJk8L2iF?= =?us-ascii?Q?jdEZ0ebuBpEkrfvyd2aM4iGOeRpXQo+bzAM4dy4tTikwLn1V76ujhK8gqXkN?= =?us-ascii?Q?tPX0bFC5LAQTWL3YIJp+zcP5YedwdoCLs0W4cHAivPIGAi0wqT2kpMFbg8dZ?= =?us-ascii?Q?lnp0S2DG/w+IGsMCp9n2DjdiM+5DGo8ur2z5DfZ0izr0U7IF4Rzr8tJKzoed?= =?us-ascii?Q?+ycGS3twejbXhI+jx0ntredMqB/HexkIQ7TpMUQRGWI0DHj/WuIrK3lHuuQ+?= =?us-ascii?Q?C0vXmX6yxA3PpQp+QjqQHfKUbAtdvfh9ygMjhWXuKaNvDPBN7VALGHk87T5Z?= =?us-ascii?Q?k5yukcs88pXcnvszdEOBosYjch73d2Ei+iNbpvmT9t9HFWG9ckaAD1j/TLFB?= =?us-ascii?Q?WQl9uJOLM/sAF8U2+pXeruyRSLB9uklF1Y1i4W0Yb2Fc8aRrGlFSubCMzrQj?= =?us-ascii?Q?uDgeONgqSTFPhP5rJ0/7ICOE2rGfWmcoCnCon31P6RCwB7jr+cd4XJahKL+9?= =?us-ascii?Q?T47RSK4mPysEW77KbEZNSyN6jfw7gTfuAuF0uM8LpeNkGUK7aYGbY+l1qLsl?= =?us-ascii?Q?EFQvLFyZIAC5MSseKbp0HPTYIUZsfcDWgKis2H7iAsT1oH55MWhwWRufFNX1?= =?us-ascii?Q?Uo1oLyM5CPRp7WUYnvcgYZEqzqb8s2epHMu6QQcosYw8Teg5cuP7VjsQU2AB?= =?us-ascii?Q?F+egw+q3ehPUrnMOFgfKB8H137n38U6RxCJjzx1Eh8R96Tk9zFHUhIxs4ju5?= =?us-ascii?Q?l2uf3ecvUiWshyj08UYmHuuHVRKP7Z+iBIFoq+aM6WsYBUNIfMSdNGfK+e9Z?= =?us-ascii?Q?Eqv60ZQEK/AbWhCpB1342HnujGQ+?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4086.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd78d77b-b4a3-4207-670f-08d966be63b3 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Aug 2021 05:16:55.0155 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OGHc05oItzD3umNg1f5iBEGg1Y4XjmphbpkynI3p/5Ps55K7L2uO44zuRurW7331i77wdUBJm6t6af0yXS1LbVX/lSQcn8nmKhoJaKDETOg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB3941 X-Proofpoint-GUID: AisAN0EHLAj6pSduC-9Jp6GjHpL3cAQC X-Proofpoint-ORIG-GUID: AisAN0EHLAj6pSduC-9Jp6GjHpL3cAQC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-08-24_01,2021-08-23_01,2020-04-07_01 Subject: Re: [dpdk-dev] [RFC 11/15] eventdev: reserve fields in timer object X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Erik, >Hi Pavan, > >One comment in-line: > >> -----Original Message----- >> From: pbhagavatula@marvell.com >> Sent: Monday, August 23, 2021 2:40 PM >> To: jerinj@marvell.com; Carrillo, Erik G >> Cc: Ananyev, Konstantin ; >dev@dpdk.org; >> Pavan Nikhilesh >> Subject: [dpdk-dev] [RFC 11/15] eventdev: reserve fields in timer >object >> >> From: Pavan Nikhilesh >> >> Reserve fields in rte_event_timer data structure to address future >use cases. >> Also, remove volatile from rte_event_timer. >> >> Signed-off-by: Pavan Nikhilesh >> --- >> lib/eventdev/rte_event_timer_adapter.h | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/lib/eventdev/rte_event_timer_adapter.h >> b/lib/eventdev/rte_event_timer_adapter.h >> index cad6d3b4c5..9499460a61 100644 >> --- a/lib/eventdev/rte_event_timer_adapter.h >> +++ b/lib/eventdev/rte_event_timer_adapter.h >> @@ -475,7 +475,7 @@ struct rte_event_timer { >> * - op: RTE_EVENT_OP_NEW >> * - event_type: RTE_EVENT_TYPE_TIMER >> */ >> - volatile enum rte_event_timer_state state; >> + enum rte_event_timer_state state; >> /**< State of the event timer. */ >> uint64_t timeout_ticks; >> /**< Expiry timer ticks expressed in number of >*timer_ticks_ns* >> from @@ -492,6 +492,8 @@ struct rte_event_timer { >> /**< Memory to store user specific metadata. >> * The event timer adapter implementation should not modify >this >> area. >> */ >> + uint64_t rsvd[2]; >> + /**< Reserved fields for future use. */ > >This placement puts rsvd after the user_meta field, which should be last >since it is a zero-length array. Am I missing something? My bad, I will fix it in next version. > >Thanks, >Erik Thanks, Pavan. > >> } __rte_cache_aligned; >> >> typedef uint16_t (*rte_event_timer_arm_burst_t)( >> -- >> 2.17.1