From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8904445B14; Fri, 11 Oct 2024 19:21:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 552CF40A87; Fri, 11 Oct 2024 19:21:13 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id D7F2D40A7D for ; Fri, 11 Oct 2024 19:21:11 +0200 (CEST) Received: from pps.filterd (m0431383.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49BBxP8J027239; Fri, 11 Oct 2024 10:21:08 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2176.outbound.protection.outlook.com [104.47.57.176]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 4271b20t88-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Oct 2024 10:21:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HBtw1FvmXK1BeXSLE+2X1SNkQDBNDFzYDRJVhjAfDAZ9nNo4BG2KqpTxZoeykDxsT07IAAJKBLNQ3p1BikBekF9AJdujmkvz/QmHPilCTMvrLJWergrT8nZPSeHEsYDJd5sEjrovEQEYQaJjWcVC3QkqiFek7ZPtbmuDs8hlJPE/PLuc9lvya4xvBAR23QWVuZhATtxnIp3QDbaK//szzWtbD9h0a8Sx4T4ZTssScxcHVA/08EIpUEvsPYftgc8ZD4jGCs9UTK9aDX3TsSkM9jYUIt1+IxpFsOY1IstAMRdArtaxgCgry393EpbytfHBLAv9gNf80hf17tY4Pw0bKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AgzkOEHn9eyRqnjCngxAmVnQW3597LFpi9WXYYPf5qU=; b=c23GxRXgsC+qfkwmZYK6Xw0k76PjKJYRoiMTni+fh+FfN7TPNFLZQ6Hw/doPYRdsJ9LxWbYY6pSJBHxs41Rh+0DQs4OyvdGeDn6mK3llEzNrg+PpyBlMU1Vr0wlgK8uzbMKa3KfDyE5ZsRsY5A3V9KOl4d8yXp9sC3m9a/t9Py0Tje/9iqa1h0V3Oo6vLHL4kjCjFAAk4W7fwtFjzcuD21d1ihkT9HnMyPXW/ix98lvwlCmycOlEAMfrZlfW2ey6CKUd8oeNyamqlePzbkFLhrIt5caOU0JNQjB8nZABIAdaH8lRNhw/pdn0RqGvWvKQ6rZQOgw9BXXWFLEL4VO4OA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AgzkOEHn9eyRqnjCngxAmVnQW3597LFpi9WXYYPf5qU=; b=WvMDNdv6SFSdewRXR37E4pxApf53Q1lSRwhCOueX7iIta41nC7OL0PqttA/BhajbcEmzOa9tu3HVEtB62jkNEHo9XsVT3fc5cVR5Scwa8scDDNvoIhI5qdHgfkQgA9et7cmuNhz4xxX6o3QprD8GrsbDzAIl8Jtk54EbBesf7QY= Received: from PH0PR18MB4086.namprd18.prod.outlook.com (2603:10b6:510:3::9) by PH0PR18MB3944.namprd18.prod.outlook.com (2603:10b6:510:27::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.20; Fri, 11 Oct 2024 17:21:05 +0000 Received: from PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::ed37:4ea0:6359:f717]) by PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::ed37:4ea0:6359:f717%5]) with mapi id 15.20.8048.020; Fri, 11 Oct 2024 17:21:05 +0000 From: Pavan Nikhilesh Bhagavatula To: Robin Jarry , Jerin Jacob , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , "zhirun.yan@intel.com" , Wathsala Vithanage , Bruce Richardson , Konstantin Ananyev CC: "dev@dpdk.org" Subject: RE: [EXTERNAL] Re: [PATCH v4 4/5] node: add error stats for ip4 lookup node Thread-Topic: [EXTERNAL] Re: [PATCH v4 4/5] node: add error stats for ip4 lookup node Thread-Index: AQHa7+5epFNhxjfUTkaZGJaKuw1mgrKBpaMAgAB8+EA= Date: Fri, 11 Oct 2024 17:21:05 +0000 Message-ID: References: <20240222122342.16375-1-pbhagavatula@marvell.com> <20240816150926.5789-1-pbhagavatula@marvell.com> <20240816150926.5789-4-pbhagavatula@marvell.com> In-Reply-To: Accept-Language: en-US, en-IN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB4086:EE_|PH0PR18MB3944:EE_ x-ms-office365-filtering-correlation-id: 77c469c7-6af0-4ead-fd17-08dcea1916cd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: =?utf-8?B?YWRkYzFvVzY1bzFDYmwyMDdmenB3bHZpL3FzY1piTW9DOWpFSUxUSGh6bXhY?= =?utf-8?B?ZHNOWUtTd1pEN1NkN1hSSXhNZDBXNGg5L0lONnF4UTFRMjBaVTd3U2pQNjJT?= =?utf-8?B?eWN1bmxFSDdvdmROSzVuZXp0SUNJNklOMlBZaytNOVcrRHVVUEhHbmJJTnB0?= =?utf-8?B?SjFTRUMyQlpqemFSMzRUbGRhTkxiQ3ZhWUZnOE0yS1NZVE92bWdlL2Fzbk9s?= =?utf-8?B?U1ZTVUhjUjZYMEtjd3NXakZxemxCcXl4TzdqYXNaeDV5aUhydWtnWkNmOTJa?= =?utf-8?B?VXBFSFo1MFpjREFyYktSTkttY2lzQVdDU0MrZGFvQjFHMnBVU1ptQzZhVnNC?= =?utf-8?B?aUhycXVYdDNENVkzdnloSlU5S3RxN2U4Y01Ob3hMMHZReW56WEJ0bTdlblc5?= =?utf-8?B?OGw1RUhEREVMbzBSNlk5a2YzSTQvUTdmSHl1Q3ptZHZUVVVObWpvTUI4TU01?= =?utf-8?B?cERRWGNrMFZkeEhJRFl0RUxQaVBLSksrcU9vUVYwUXk4Snl0aUx4cXl1dHA1?= =?utf-8?B?K1FDRlBKTmdxanF1OHJNR2dEUTY3ZUhtaWhZdXNsWjFKazZtMG56cFZoc1FB?= =?utf-8?B?a3U0cjJxaURpR2JXUmlENVpTR2FkZkpNN3Z1SjRNcW1GWHR2a3VBTjZUZTd2?= =?utf-8?B?Y2ZMdmlRVE5iZzU2U05lSURWT2cyRCtSYkRkanRhUEd2ZzE0T0E5eDhnWEx4?= =?utf-8?B?d0hWeEZQQkpaU1NiV1BLTGRrWWcxRXZhZUl6UWRkNll4SjBIeWx2TWpYUnhL?= =?utf-8?B?QUg5bFVvN3hXU3plTEI1bnBJbGwzTFd5R2FPNmRtbUllYzArVHlJR0NZVDdp?= =?utf-8?B?NFBndEE5M3l3OXYyVmJnNzcvTEtIY3pkN3lGVllFcUJPNjAzMmE1RE0xaXV6?= =?utf-8?B?YlIvU3EyZXhvNUNzb28xbDZaaUFkWDlsT3d2WVBhZGE0VGVUZ0FtdGZSd0g4?= =?utf-8?B?ekhUN2Q3RFNhR1BKS2wxL0JCSStqVDhtOEV2R2U3N1NjV3lTMVA3Y05OS3pk?= =?utf-8?B?Znd3Q1g3bkhEeDUxcWpCNzJpMitRVW1zdzNaemRjc1F3WURwUVJGVGdJbUhv?= =?utf-8?B?ZSs4OG1QY29rZmlkcmN4UEtTV0dNd0FnR2xhYXNMUFlDVFJXaFN6emlGMFRn?= =?utf-8?B?SFZ1dmtCNkVmRE1UR0taREFCT3pObHRGckxEMlJ0N3F6TDFncXFLbXUzQ0pz?= =?utf-8?B?ZklybzVseEFkWlo4VUx1UFViakdtQllsdm5VZ2tUSzllNDAybUowRm5YRDFl?= =?utf-8?B?d2huaTIvMnhhdjUzMWRxT0xXaWdSdU12aTQ4bUh3MDV1Tk5QMUYrVHZRbW9O?= =?utf-8?B?c2pObUhiaGQrSEdjZXdqVDkwdUFJTWdHZDVnSUdZdGNyQTFGWFByTzc0SWFQ?= =?utf-8?B?em9rV2NEOEh3bFZHOERUdkJaMG1ueUpka1dPSnZJV3dONisxUmMyZnZLc1JY?= =?utf-8?B?S1pybmJtY3VuS3NWdHVGMGN1YUQ2YUJ0N21kNFNiWDRrT2ZORW1wQ1RiUG9J?= =?utf-8?B?UmJ0VTFsY1Y0TUNMVWhlUXE0VWM2MmM3aW9NWkxFZ01FcGVwL01Lc2VVQlpY?= =?utf-8?B?S1NMbXRqaDRZaDB5SFlNSjZQRGpzZFozbjRMNXNDVWlhcStOZlVmS3doUDcy?= =?utf-8?B?SnM0Um5WNk5LUk9Pd0NDaVl6YUZXaUE0bThSU1lPYkpnVHlMOE1VT3RaL1ZM?= =?utf-8?B?UHd2Z24reS9tRGxhaGtZc3dIRU5SZzkyOGIyWjAwNVBtZDlNbnVOb2VBPT0=?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4086.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?N1JLS0RVMEhtNGxqQVlhY2cxeUNmNHpFU0VlSnk1N0ZjQ0pjSGhNN0oyUDFT?= =?utf-8?B?V05uTTJIcWI5clU2cXFXbWFtcWZPZC9vZlI5alZvLzVxSy9vUjVCN2tTWlF4?= =?utf-8?B?VURIaEhIVWY4ckVieG00WUNxdTZnTkxTeEltNlBMRTA3emFtY3JLeXRaUjRv?= =?utf-8?B?UHV1NjFhS25FNm5sRjBYN0NlTUQzVEJnR2Jib0VpaDF6OWJVZTBPbFJLaUpF?= =?utf-8?B?WVVKdDBiU3Nld2o0bG5QU3QxcHUzNE5GWlBreGFtYmh3R1VBZ2xpN3pjYk11?= =?utf-8?B?M2ZsQmVXNENFSnVGSVZWSlRNbTRSOU5XYTM1WTAyTHBteWxlcThkbXBkTlZK?= =?utf-8?B?UVd1WThweC8vV3pSZFJKKy91RG1lcWRYcU5VcWhHOWFsNW84elRvU0wvZlRH?= =?utf-8?B?eXZydE8yNjIrTHlPWnAyT3puOEJUL0x6d2h5aUJSS3VNYUk4bTViVlFaY1Ew?= =?utf-8?B?ZU5ISkJVVlYxNU4yZmVUN2NyWFlGT0lDQUFLNHF3ZFlJYlFYdFp2U0l1UFJL?= =?utf-8?B?VURZVVl4VW1zdUQvQ0p3ejFQZCs2YW5jS2V6SUgwQi9tMEF5UTRHbThSYkNS?= =?utf-8?B?VmUydWZRd3hzOW1jaTFlWnl4VzdPSlQ2b3RUd0xwNWJPK2s2TmtFVmRXQ0hq?= =?utf-8?B?Zy9LSW5rZEtOdm8xdStDcEhnQkV6bzIyREFvOE9ucnhpQngzRGgwK1AxbitE?= =?utf-8?B?RXJyZTBhRnNZV0lOaU8rZHZtbzJKWmJuZXRsYlJLQUIxVXFMcnFVeGZOcklC?= =?utf-8?B?TUFreGxYZXoxNFJZeFYrOEhPQ0kyQUVqdDZPUXJwYmpCbE4vUXpDMlQ3R0cy?= =?utf-8?B?TmVqaFFBZzRkT3FzYUpLaS9lK3RweGhOc2pUVFg0MjM3OUNKUzdKaHhmSmIx?= =?utf-8?B?bnp1TENWSFp0aklQNmx2R3lnam1PaUlCTU9sclovSmZXcGpnMWU1QytUcTNQ?= =?utf-8?B?WGxINUY4NE9kaWpxTHcwL081emdVaVZGTG56WDVZaFZjTDB6c0hBZlM3a2pH?= =?utf-8?B?bGlXN0RPOVM3MXluVXJmU3o0eXg0Mm5yUW84M3MvVTZOSVNLdGYvM2Noemdz?= =?utf-8?B?RGxPQnMrRS9PVG1TZnQ0R25oZU53ampLQUEvN05lNzdoRmNrOG52b05WZHZ2?= =?utf-8?B?d01ML0NuOGliOTAvR0xmS0gwQWNaaVdxS09FY1hscTNESkdGZmZvdG9qdHRY?= =?utf-8?B?WGpXWElFN0U2dGxtZ1lTN3ZYdVYzQW5GbnlwUmdWaFNwVXhPaFN0MkZmaGxo?= =?utf-8?B?R2E0MWpyanJ5bE9aTmt6UmNhTWZqYUNUWXNZc1FpVWxLRFFJTnJxbEZscXgw?= =?utf-8?B?VUdlcThSaUJDMnVucjV3SXRVQlh3bXZjNU1WL3BrbExmMGRGZnh1aFhCeDlC?= =?utf-8?B?N0RIMjJkNHo0UVVsT3FFZGNMcFZvVUJnMytWM0VLNjRHcThNbTJ1SkVTMXhr?= =?utf-8?B?UEFOWjRrZHE5cnlpOE9BK0JuMFlQQVgyRW5JK2xiQnFpK3hUZjhKWjIwMnF4?= =?utf-8?B?RVIzVXpsQ01mUThocGx6V3prYjFpa1g2dFJZWG5lRjhrcXNDTWl6M2pRSkgr?= =?utf-8?B?YkhCZHBlMTc3a1U4UStKZk54UmtRRm1rRDBYZXRWdy94U3ZqM1ZtKzJ1ZEtl?= =?utf-8?B?TGh2RXFKaDlBTmNjZlJyRWRzaVMzVTY2bUowMk9ScnNBK1JEYmNnb3ZzMzFJ?= =?utf-8?B?T1lMQkpMZXkxaUtKblhtQWhBM1FwSHJ4NUU3T203Nm40VnRBYUxsZDlaNzl3?= =?utf-8?B?cC9UeE9SMDN4cE9QZWh5b1R1ajF1bEQ5UlNSQXI3RW0vZDdLOWdQWEl5c2p6?= =?utf-8?B?VkREcWsrSjVGb3VwQXBQN0Qxa1FTbncyaFl3TTJoa0wrZ2hIeWlORm5VVHlH?= =?utf-8?B?aXNtOHBHRkRqaDg5clV6UXFCRVJyWTRhUzlSV211ZHJ3WEpmc2xuQjNQOHZ0?= =?utf-8?B?TDhzK05UNHBlY2JGdEVtYW4xWXM4K09zeGdnQkI5Ykthay93NlQ5b05SQmxp?= =?utf-8?B?anZWdE9wQThoQTNGbTExS0t2aFRLdGgzYUNGWTVLZ3JGbnV3ZUNCdnMxa3J3?= =?utf-8?B?NlRpd3IzU2I2RS9mZDZCbjAzWms4S3duR21xbUEvVkczNU5KVWpKaGJhWVgx?= =?utf-8?Q?iY4E2MY3YDNe2XqIEa+VUQ95S?= MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4086.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77c469c7-6af0-4ead-fd17-08dcea1916cd X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2024 17:21:05.6837 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PecGCKWMjaH9Q8FfDi6ShA7k2XZpVQLgWhQ2PO+HMf5+izgF32s7Vgwj4Fmz9/1k4OPVj1e8b4yQPATHWip6g7engCPILn4+Ugfi3MJS0vw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB3944 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 76pw04dhsOO-TaZUzhAYIlWWyQbfTE5j X-Proofpoint-ORIG-GUID: 76pw04dhsOO-TaZUzhAYIlWWyQbfTE5j X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.687,Hydra:6.0.235,FMLib:17.0.607.475 definitions=2020-10-13_15,2020-10-13_02,2020-04-07_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Robin Jarry > Sent: Friday, October 11, 2024 3:19 PM > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > ; Nithin Kumar Dabilpuram > ; Kiran Kumar Kokkilagadda > ; zhirun.yan@intel.com; Wathsala Vithanage > ; Bruce Richardson > ; Konstantin Ananyev > > Cc: dev@dpdk.org > Subject: [EXTERNAL] Re: [PATCH v4 4/5] node: add error stats for ip4 look= up > node >=20 > Hi Pavan, , Aug 16, 2024 at 17:=E2=80=8A09: > From: Pavan Nikhilesh > > > Add error counters for i= p4 LPM lookup > failures in > ip4_lookup node. > > Signed-off-by: Pavan Nikhilesh > >=20 > Hi Pavan, >=20 > , Aug 16, 2024 at 17:09: > > From: Pavan Nikhilesh > > > > Add error counters for ip4 LPM lookup failures in > > ip4_lookup node. > > > > Signed-off-by: Pavan Nikhilesh >=20 > [snip] >=20 > > diff --git a/lib/node/node_private.h b/lib/node/node_private.h > > index 1de7306792..36b2a733db 100644 > > --- a/lib/node/node_private.h > > +++ b/lib/node/node_private.h > > @@ -12,6 +12,8 @@ > > #include > > #include > > > > +#include > > + > > extern int rte_node_logtype; > > #define RTE_LOGTYPE_NODE rte_node_logtype > > > > @@ -88,4 +90,10 @@ node_mbuf_priv2(struct rte_mbuf *m) > > return (struct node_mbuf_priv2 *)rte_mbuf_to_priv(m); > > } > > > > +#define NODE_INCREMENT_ERROR_ID(node, id, cond, cnt) > \ > > + { = \ > > + if (unlikely(rte_graph_has_stats_feature() && (cond))) > \ > > + ((uint64_t *)RTE_PTR_ADD(node, node->err_off))[id] > +=3D (cnt); \ > > + } >=20 > This is private API which is not usable with out-of-tree nodes. Could > you expose a way to increment a given error stat that does not involve > a hacky macro? >=20 > How about something like this in rte_graph_worker_common.h: >=20 I would prefer nodes having their own error increment implementation, leave= s room=20 for optimization rather than forcing all the nodes to use a single implemen= tation. Some nodes might also be able to use SIMD to increment error count at once. Also, I really hate doing=20 if (error) rte_node_increment_error() The macro really looks really clean atleast for inbuild nodes.=20 We can still have this additional inline function as a utility function. I will leave it upto the maintainers to decide. > static inline void > rte_node_increment_error(struct rte_node *node, uint16_t err_id, uint64_t > value) > { > #ifdef RTE_LIBRTE_GRAPH_STATS > uint64_t *errors =3D RTE_PTR_ADD(node, node->err_off); > errors[err_id] +=3D value; > #else > RTE_SET_USED(node); > RTE_SET_USED(err_id); > RTE_SET_USED(value); > #endif > } >=20 > NB: do *not* include a condition in that function. The decision whether > to increment an error stat or not should remain in the nodes.