From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B1B0A0C45; Tue, 21 Sep 2021 22:32:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D1C814003F; Tue, 21 Sep 2021 22:32:19 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 0AEAC4003C for ; Tue, 21 Sep 2021 22:32:17 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18LGtjPL002692; Tue, 21 Sep 2021 13:32:17 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2174.outbound.protection.outlook.com [104.47.57.174]) by mx0b-0016f401.pphosted.com with ESMTP id 3b7384m1y7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Sep 2021 13:32:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eJUZ25ysR5UkDOtwtCWqR0GQc7zRpBrAqOT3R8Ehw2p4aVT0bj+JkwXzjWADyYayz9ZgskG9tZfBg7M2UtVdrkV9fMTfU3GLYdhkDa8uTzhJqLahqJ0oXgVPeWSKEPHgLiOmlFdZxymXmgLwUCvE7HnlSI7g4S8tuUK7cdMPmJu9fbxzte6EQPVmqzp4/jhl+uEafxumR6GG0SLUvNxe5gcGPRUhMhjngsB5oZXt9HCvSvKoMC6zgDgyce49nEWuqcKGY1yryVURNcVpev3Udp1eS6ZspcSr8uc5ogygufE+fjyLbQVQWdltQIFCyU7McTK8NhkHu+BvLiC/J5fNEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=AXNiIDbH2eJwbLBetBo/YZep3iPWXWrhrxcUtARuZCc=; b=n5fPL4T3sukqk3zyDNsCfd0nmjj7AJpxq7CuVDmj2abC8LoGKuwm6BNHcZ92oSLxIzn8yfcy55gRgj7Ycots9xcl++AXgxz4U7pkJzi1lOaRg0nWU9SCvBBLy+ST5dGNgzeqtZQeD578E7iuIIArzK/JyD0dvkIuw6nV1biS8Zf6lixIY3sa44WBGdY22XrSVeUyXFrRJ0mXBQS7UT1awCQPsd3X4fhDUbIMXOtCc7OSwHNIhxzPtQrLAWt2XcwlZW1e53SOHMrJmynQzZCs2IV8ft9G5Y3TZQ+9dXa4mfVlbK5e6pdjOJJUF9j5+8WA0+U0+DDTR/MGXp7jdvxjkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AXNiIDbH2eJwbLBetBo/YZep3iPWXWrhrxcUtARuZCc=; b=Bp4exflrFju6j0ZEiRvv0LM4pf6F8GwK9/Xh0yKM6kr2PkWH9mVaiaD5iGDJzyagO+6tc9U+VaJ8NhEKWxjaUZYgbC39uIAWQHjR30Bd0QUowCdbworIi6pu+AjUgR8l/L50myt1+EuXSwlJ8ldgv+RZ5bBYU8uM0CsIJe3oU6U= Received: from PH0PR18MB4086.namprd18.prod.outlook.com (2603:10b6:510:3::9) by PH0PR18MB3847.namprd18.prod.outlook.com (2603:10b6:510:28::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Tue, 21 Sep 2021 20:32:14 +0000 Received: from PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::94d1:2b0c:115f:5a75]) by PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::94d1:2b0c:115f:5a75%7]) with mapi id 15.20.4523.018; Tue, 21 Sep 2021 20:32:14 +0000 From: Pavan Nikhilesh Bhagavatula To: Naga Harish K S V , Jerin Jacob Kollanukkaran , "jay.jayatheerthan@intel.com" CC: "dev@dpdk.org" Thread-Topic: [EXT] [dpdk-dev] [PATCH v2 3/5] eventdev/rx_adapter:add per queue event buffer configure support Thread-Index: AQHXrsooKMY7XsOT0kyZMJlaEnlYYKuu8bpA Date: Tue, 21 Sep 2021 20:32:14 +0000 Message-ID: References: <20210918131140.3543317-1-s.v.naga.harish.k@intel.com> <20210921092146.1778421-1-s.v.naga.harish.k@intel.com> <20210921092146.1778421-3-s.v.naga.harish.k@intel.com> In-Reply-To: <20210921092146.1778421-3-s.v.naga.harish.k@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 23e9417f-f0a2-4794-b226-08d97d3ee5cb x-ms-traffictypediagnostic: PH0PR18MB3847: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SZdhG3FpGY0xIt8wdbi1I2E/QuTANYeXJj2PS5+2iRT+MVm4bR+3sJClRotXBMuw/aj47R4U6cSOOtQ/et4wiPkJb5f6umwWu5CPR3ytlFAJI0ecgEr0coTLDMOenUd3Yafry02ljagsLNZgevE25scJoUMn15mF/gBrhmKmcVQk/B7BqAJsI/Mwd23G9bBWLaVQe2WVsB9uKS7lVSda54R0zF3EZQGgaRlgbZOnan5JfZNulMbgl6GMjJoe9ExbzuyxujSnqqXHF8QshPzaS2RU+3oBBbzVkozgyk/8mJYlz0c5vsgE3Z8/Dj6Q+pxNZhIBgabJvqYAtdbwq4EZXmMWqx/DHvNDpXh1KVkyAHRds4qvu8V+L+tXtXa4nrZ2M8J9evtCAn7SuTGGzLeSEybD+LoOQBRU5vJVShYbTAvYLmKuajbfRfRZvMvhYff/lJfkj9iNkHBJ/BkM3XR2yiC269A+ZyIMJabaZcgBfR6Vjq99eRtcCZxjWak96O3wp93s3f1wFLMYcgbemA9LZlaQK3Y6Nsex3NAyyWoVFpKi33K+VExqLtR2CFmk+D4qLSC3IklDDO+7KScZENvZdrDn4tHJ65SHx1gB0wCi5C5la14rpbk53uNU3rAGbiP5Fpeg9f2JUwtiKPZYM5doZdjt9RgsK2xr9tdxjG6JXeyp6gYFt1rf+5Aj5Rpfn4Ull3DOebtCbT5WHOLR27PNPg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4086.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(2906002)(66446008)(8936002)(52536014)(76116006)(316002)(66946007)(110136005)(122000001)(55016002)(66476007)(66556008)(5660300002)(64756008)(4326008)(86362001)(9686003)(8676002)(33656002)(186003)(38100700002)(508600001)(71200400001)(7696005)(83380400001)(38070700005)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9pNUFRiL6ZT9ukmQwrPVY7WaqzHssVAGv63w2oALIXmCkmsXHcKLjpCJeS6M?= =?us-ascii?Q?AZD/h26+ruqhku8oGnSBduKAyJYx84u849KBJQSi5cqr0RacO+TeVfM8DCs6?= =?us-ascii?Q?uKY7ENnar1FNsifjEq4No+oN6VGOPQqWIfa3J3HusDk0M/DrCeiZ0txWEhZZ?= =?us-ascii?Q?Nv2VOUtsdznhWOIDBuaM7nMO5vFoQN8LWYyvhLdQA9XJXfXvDBoZa5d61IFq?= =?us-ascii?Q?2BfYxGchqJ4yUBWQ7Ad3n+J5JktfB9zyK2h2lj+1UK7p0zyxCkzCvndN3SCu?= =?us-ascii?Q?YS0idNWtEw6+JJkDocHnAJGNOS5kGK/mhNonfN9LIiXM+rU413uWmuDxn3wH?= =?us-ascii?Q?MOAa0jokZA+I/HnwynnqgF4Eo4JyXoh5mfcuRD0pfvlktQq1Lw3VDZr8b5Zv?= =?us-ascii?Q?zSTR2KclAHeByoKB98MCL7XIims7hFUvTHeYCn5bHaqWnRltAxdnzL2/kL4w?= =?us-ascii?Q?sXLEN2i/j4Lr1FG3Wnkq8vuGaAYLMIY1i8MUqjVDyrCZd8lYiBiHomPGT98a?= =?us-ascii?Q?i80GfGwf8m9xWA22oIIfaKyLsORMq4bEUbljLV0QIeZfm2jHuxnCPwJ5HjXB?= =?us-ascii?Q?N0HIf6Y+8IbZseiNFCjphIQZTuAXGe1WXXOLH+UCT8vmVPA6bpsISRK6Uh+2?= =?us-ascii?Q?+7Exf778Ju2bbqKQ9P+6J0WfO3Z/3aj/xA+XTCx2EJtY4osdWgss7PI5qEwn?= =?us-ascii?Q?5QCtsl4Lsh6LM5EHLjlnXguCBrFQrB8AwukEpHGaHydoIzljUkPh1/oXaHXa?= =?us-ascii?Q?Wuaf7Tp+UwK+fkBy+sHStWgS4BzYxcBornP329jd22A8yPmkhoj0rbPq3vow?= =?us-ascii?Q?7X4/1Nn25cFIESKrLZ8BFQ5dmsh7X/fY2Qt+G1S4dd3X4mUUo9tAb5EfQIof?= =?us-ascii?Q?azZ9iPnJZlo6NZd+wo2vTWb2dBEYF6DHU5F7iwk2Cuubt5v+zUtnhYteHPdy?= =?us-ascii?Q?2PIiP8LJJExsTYPuCne7N1AVZAaTvqkyoMioTEhuB8Sa0TyP7jbPscNYNKXc?= =?us-ascii?Q?oN1VaGqIYZcJINoWfx43pbtpjYXzEuLp5yc6Rl2J3kMLIeffhbCtjWk1Eix+?= =?us-ascii?Q?3C2Sgd/tpynBau4oT1CR3nrQXpHNeseTPL9dRkZ+yZGCQN1n6khT0I3aj1hh?= =?us-ascii?Q?3HkifvcyAgY4nqF8kTe8En03d0ndMe478HAkKcyq07BKEe6qOj0v14H3JNGc?= =?us-ascii?Q?qZkofYPgN39+b2wtVOq9YtVlrrKhi9nbrugIQNFalp4LLCHLcxaLWdj+2ezg?= =?us-ascii?Q?Lv0S8Hcl3HEu2uS98g/I0PJvDNi1AYFcpAzXeMF0uLzOTpAxa2TbGl9EelkV?= =?us-ascii?Q?5Y99HT6wsc4Situ/NoXZvHmOMKKUFwNACav3Pli60tT7uxzuuT9DJdXlHGxb?= =?us-ascii?Q?mNl43X++8mnAttNvdHBevVZm0ofH?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4086.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23e9417f-f0a2-4794-b226-08d97d3ee5cb X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2021 20:32:14.5028 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DTModd6Mv7+puwDa+2PRXJD0gYfbSAYmmrrjIkic5QyAbWhngTANgToU2xf8MqyUwYAYqzidw9fWL5URdLqzh2o9ls41FP6AlI5aOF8kG4E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB3847 X-Proofpoint-GUID: 0Sr8nsBhtugFBXON403U838-41qCzQk0 X-Proofpoint-ORIG-GUID: 0Sr8nsBhtugFBXON403U838-41qCzQk0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-21_06,2021-09-20_01,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] [PATCH v2 3/5] eventdev/rx_adapter:add per queue event buffer configure support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: dev On Behalf Of Naga Harish K S V >Sent: Tuesday, September 21, 2021 2:52 PM >To: Jerin Jacob Kollanukkaran ; >jay.jayatheerthan@intel.com >Cc: dev@dpdk.org >Subject: [EXT] [dpdk-dev] [PATCH v2 3/5] eventdev/rx_adapter:add per >queue event buffer configure support > >External Email > >---------------------------------------------------------------------- >To configure per queue event buffer size, applications sets >``rte_event_eth_rx_adapter_params::use_queue_event_buf`` flag >as true and is passed to >``rte_event_eth_rx_adapter_create_with_params`` >api. > >The per queue event buffer size is populated in >``rte_event_eth_rx_adapter_queue_conf::event_buf_size`` and >passed >to ``rte_event_eth_rx_adapter_queue_add`` api. > >Signed-off-by: Naga Harish K S V >--- > .../prog_guide/event_ethernet_rx_adapter.rst | 19 ++++++++++++--- >---- > lib/eventdev/rte_event_eth_rx_adapter.h | 4 ++++ > 2 files changed, 16 insertions(+), 7 deletions(-) > >diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst >b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst >index dd753613bd..333e6f8192 100644 >--- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst >+++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst >@@ -62,12 +62,14 @@ service function and needs to create an event >port for it. The callback is > expected to fill the ``struct rte_event_eth_rx_adapter_conf structure`` > passed to it. > >-If the application desires to control the event buffer size, it can use t= he >-``rte_event_eth_rx_adapter_create_with_params()`` api. The event >buffer size is >-specified using ``struct >rte_event_eth_rx_adapter_params::event_buf_size``. >-The function is passed the event device to be associated with the >adapter >-and port configuration for the adapter to setup an event port if the >-adapter needs to use a service function. >+If the application desires to control the event buffer size at adapter >level, >+it can use the ``rte_event_eth_rx_adapter_create_with_params()`` >api. The event >+buffer size is specified using ``struct >rte_event_eth_rx_adapter_params:: >+event_buf_size``. To configure the event buffer size at queue level, >the boolean >+flag ``struct >rte_event_eth_rx_adapter_params::use_queue_event_buf`` need to >be >+set to true. The function is passed the event device to be associated >with >+the adapter and port configuration for the adapter to setup an event >port >+if the adapter needs to use a service function. > > Adding Rx Queues to the Adapter Instance > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >@@ -79,7 +81,9 @@ parameter. Event information for packets from this >Rx queue is encoded in the > ``ev`` field of ``struct rte_event_eth_rx_adapter_queue_conf``. The > servicing_weight member of the struct >rte_event_eth_rx_adapter_queue_conf > is the relative polling frequency of the Rx queue and is applicable when >the >-adapter uses a service core function. >+adapter uses a service core function. The applications can configure >queue >+event buffer size in ``struct >rte_event_eth_rx_adapter_queue_conf::event_buf_size`` >+parameter. > > .. code-block:: c > >@@ -90,6 +94,7 @@ adapter uses a service core function. > queue_config.rx_queue_flags =3D 0; > queue_config.ev =3D ev; > queue_config.servicing_weight =3D 1; >+ queue_config.event_buf_size =3D 1024; Wasn't this set to 6 * BURST_SIZE in the previous patch? > > err =3D rte_event_eth_rx_adapter_queue_add(id, > eth_dev_id, >diff --git a/lib/eventdev/rte_event_eth_rx_adapter.h >b/lib/eventdev/rte_event_eth_rx_adapter.h >index a7881097b4..b9f0563244 100644 >--- a/lib/eventdev/rte_event_eth_rx_adapter.h >+++ b/lib/eventdev/rte_event_eth_rx_adapter.h >@@ -199,6 +199,8 @@ struct rte_event_eth_rx_adapter_queue_conf { > * Valid when >RTE_EVENT_ETH_RX_ADAPTER_QUEUE_EVENT_VECTOR flag is set in > * @see >rte_event_eth_rx_adapter_queue_conf::rx_queue_flags. > */ >+ uint16_t event_buf_size; >+ /**< event buffer size for this queue */ > }; > > /** >@@ -265,6 +267,8 @@ struct rte_event_eth_rx_adapter_params { > /**< size of event buffer for the adapter. > * the size is aligned to BATCH_SIZE and added (2 * BATCH_SIZE) > */ >+ bool use_queue_event_buf; >+ /**< flag to indicate that event buffer is separate for each >queue */ > }; > > /** >-- >2.25.1