From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CED4F43902; Fri, 19 Jan 2024 20:39:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E486402AD; Fri, 19 Jan 2024 20:39:17 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 62F814029F; Fri, 19 Jan 2024 20:39:15 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40JG7vKi009056; Fri, 19 Jan 2024 11:39:11 -0800 Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2041.outbound.protection.outlook.com [104.47.66.41]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3vpvex7g7m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 Jan 2024 11:39:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JPCH2n+eRE5Hk62Cd9GtKvfnVsl5dU9IuFJYmIsxcQZKVnxzXgX7SWBdsRydXzUiitiSUEjwWgVaDL+1Je9pSE9TjHbIx/pUVQPlIhjszt3BW+wrhf1IJRuqIwF/Dto08t8vDl4pEj/LE+X/SfLp1+uluxTb8c9xk+xHO0DqQrl6cn34kzvzTnMyn1V/Ukt2O+O+HGQZ++6W0omGkhnmdrA3fE5IJ9hvFwLoJgUfobkqix1mEPTQYpZWL95UHWDqsgyNVX4cs+UpMVpSBPClBSFaKxlNisFnicb+feW3z3jZTppoNhS/5ckkwlCBK/1dajvr60SOTLitUAicQBg0Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lNOdMjmTocwEL0ww/TiGFHB++EscI5j8z20Z+2vTAu0=; b=ZRby8oCCaKpJLv/CTZf83k4f73gRVyyMAwSfoTu97VdAypOgMXXU5lINqQwwUWYkUqjtCopbRpfHpFENlwuCssKwkvGMOqFgfBksPebiA858rpm6sFm4TDyFzMrF+Aw4w//V1CS92XU9Y39C4vxMRxozni0t4BDLgc8LsPKelx9HwQ9wfe/7eyuMytdNJFKoOYht9voOCYHIZ+HT/zXqt1CgXQZhOSAI2H2FCKVhWCgW5w9A37EzLwWNlsE6KxphEN0qvNhKwhCfs6vsLMUm2Reuui1Q5BsYkHVmtPMjxw+rZod50132m7nCZ+minAPp8qjd0u0dJ2gNZPnmh/7P8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lNOdMjmTocwEL0ww/TiGFHB++EscI5j8z20Z+2vTAu0=; b=IERiOGiO7P0MyvLfzfj2okItLuSH2HnPQesz1UTjffBJ3Urd8mEPoPHvAamDtP0hlMnI/9ITgM+KDXkHrTM5S5NbTkMCry2G10Dqn3klQMWuDcJWVGO8qveLx5PIn7KkTqZcO8m3k+2z2+cV79GDWgW0T6wtyhnnCWAtH3qaFus= Received: from PH0PR18MB4086.namprd18.prod.outlook.com (2603:10b6:510:3::9) by CH0PR18MB4275.namprd18.prod.outlook.com (2603:10b6:610:ba::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.24; Fri, 19 Jan 2024 19:39:09 +0000 Received: from PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::fa99:f25f:fa5b:de66]) by PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::fa99:f25f:fa5b:de66%3]) with mapi id 15.20.7228.009; Fri, 19 Jan 2024 19:39:08 +0000 From: Pavan Nikhilesh Bhagavatula To: Joyce Kong , Stephen Hemminger CC: "thomas@monjalon.net" , Ruifeng Wang , "bruce.richardson@intel.com" , "dev@dpdk.org" , nd , "stable@dpdk.org" , Jerin Jacob Subject: RE: [PATCH v4 1/2] config: correct cpu instruction set for cross build Thread-Topic: [PATCH v4 1/2] config: correct cpu instruction set for cross build Thread-Index: AQHaKYF655rkGKmWCkGHbwvgb2aO87DhyrSw Date: Fri, 19 Jan 2024 19:39:08 +0000 Message-ID: References: <20230822074743.3243015-1-joyce.kong@arm.com> <20231205035259.3516625-1-joyce.kong@arm.com> <20231205035259.3516625-2-joyce.kong@arm.com> <20231207144111.7b9405fd@hermes.local> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB4086:EE_|CH0PR18MB4275:EE_ x-ms-office365-filtering-correlation-id: 95490b1b-3f9b-4483-a428-08dc19264e03 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zeMk8YxPkN2W8+grT23vv8AP8H1U551TOgSduyQlHNEr1tJIqrFXwmUuM7y/7eXOR9y9gAL4pQVUvAJxHQR2H912JduYoP2SLZ86fsN88sBzi6lqS9DVwnI1Nc08RH05+66IUwiMUo08VI4PJ9UEWb8CzD930mj8w9i4aUjMXa55ejKLpas0xkvb6nj1dlR5cuWAx2s1NRp30eBfXPRfKxcIu/H0+8UoYb9qbw+eEtNIAALzvmVHnCcMwaq6ib/V9XiXgNz7DfL5K2cnVilD73+iAWhLeLQJyNMpkRxeieZz1EotlZC+W8bxUtpThVGl9nP37yPmZ2cXecAH+Jwvh6vZ1kUJHdqOyUN5aQdPSerObdNxwnIgT4aZEP2GN0JdJyKZe2Ygw97h4L2KOSKOzFByzXbn+h493BNLInUp+fy94YA2FxApKb1khG76IOjeEcedcjblRblRf2UDWrVemjVHubn5XQhHxx3C7hY5hrYQ0llRT060PWfeNGWFeyo/c6d4OwoF8HmI7yiijNIO8LEseptxXSfJfiIfoXzG60lf6fddMGdcBQ2X8pxScR2KWxdR2ggo+eQrQV5uwJVk+CM/JQ83MoIoKSu6+/gEXvp+56gSIi6vO0vKRbBEgSN2bVGFfHbfWQVkELlBTohIz/qvSLHaOl79NOHgE5Ldxd0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4086.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(396003)(136003)(376002)(346002)(366004)(230173577357003)(230273577357003)(230922051799003)(451199024)(1800799012)(64100799003)(186009)(8676002)(8936002)(55016003)(316002)(110136005)(54906003)(52536014)(4326008)(66446008)(38100700002)(38070700009)(122000001)(33656002)(86362001)(64756008)(107886003)(83380400001)(7696005)(53546011)(9686003)(6506007)(71200400001)(478600001)(5660300002)(66946007)(76116006)(66476007)(66556008)(2906002)(26005)(41300700001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4R1QdiyGLbnZcwqGAQasT66buV1htiGN5sCSvONFJMlwUv/4cv5/5MP7Fi/W?= =?us-ascii?Q?MH0oYENqv0hXpK5A98QmO3LzeUPUlHSYqFOdNl5h3Tk3D1CkYAWr/n4B1x57?= =?us-ascii?Q?4iF7MP8aoaXUPB6ZaNx/3HUkOjZYxVGRzDtMYCjKzPFf0oTUe8dKLaZ98vb0?= =?us-ascii?Q?tqKAOjFipdFM+qgtRLWmnhHsT6S/kyiVqrViMOkev1pvUYE6Rv1zwxXMRYTV?= =?us-ascii?Q?qdBxeSN9RlDRyaSowPg1Eh+qrqsiCiy0JMVcrxkd+cie32scj1K30ZC9xnGZ?= =?us-ascii?Q?MwxxenMiKUouLkH2gsXV1EUVXxw1QM6+pBRIKJgZ9MXOeLDd29OlHkwkZtx1?= =?us-ascii?Q?/oR3rLRfYImZ8RhxrVE9v4KIJf1Ww43eyfIyICJ/sIM48WcSQI6dko78yS65?= =?us-ascii?Q?zzldqYNQTbxjJmYugXoyt9Hslnl+AqlmYrHtfbQb0oz59rYCBkjxPNCaZ/h2?= =?us-ascii?Q?Ipa4ju61bXpkAS1nNY5E2pFT8BU9l09PiskdYmcaaHA3CwNCTJQEnDllQvjo?= =?us-ascii?Q?pd0GJ+tM1IvwhXzXsUH4V0iLySVrJ1Ouc87lO8WpYUG1FQj+Tx4NBqCtNrPw?= =?us-ascii?Q?v8tleTWrY5hXMLBuuxNNn7995mcNS/KyEiMDDjgvJV6puSpffiDiXQb+8Z2e?= =?us-ascii?Q?eQwR4nZATzq+x7gKS3KoP0+H8rLduxB3+vmNS3MKPpjfj94zJyGsuUTy/2so?= =?us-ascii?Q?QhNcKSoy4mLcJkvMlCSn7PEFOHCZ82U354uz0kABNNO5Ye9Q/lo0ksnT0BZV?= =?us-ascii?Q?jDjPChSDuGbXteYXYisiIno5sHU/PiNWPQE+Z+2YgBIBz2End0R8k38fjEmc?= =?us-ascii?Q?b+BpDSBsoivuHshSvgQ8LMdMYkuJ4H4AGvh39IzZoZspgf9HMzxq0z/7BUGi?= =?us-ascii?Q?qzRb4f+Dq+bkfsytYLzV+Xry6UkoJXCqQivSlcvTkiwMY01KXOMkK6fj4maN?= =?us-ascii?Q?GMbuLgI/Nwzi+ZUev/6oI68zk7mp50oDWPjATZK2dxa87vi/rTbB9i3rSFJe?= =?us-ascii?Q?5GEOosZLOxak/yt2BBuX6AWE5uZeNrb7LH1UBirsviJwOvxBKP8/I5s0fPEB?= =?us-ascii?Q?CXkqTNuX3SGXiKHsD/M0itK+H0vKVy2DWmtBlIh1zWA74i+Pn927JNvAs5Q8?= =?us-ascii?Q?zyyxTQM4ptZLJSt8vA65F+0UdlF563X6RTCRlKQW7Xm8cbF685LpOx1x7qTP?= =?us-ascii?Q?ZJde+TtDG/euKyuOg9Hj2mZlsPXBK7Excoq/yP5UWE1CqZFw9kbZlu5uJQKE?= =?us-ascii?Q?4baU5GStOhK0VLpRCkQulz1rrGdMQB6Jl0iMPJnmw8nQ3qlS34H6UaWcGDi9?= =?us-ascii?Q?ySqcVEKawkZM/UHgzK540o5Vr29hpGh7A797LFEWvy7xV5TVKXxfj8P+dbDS?= =?us-ascii?Q?29EMeyxNDVtS584rCIFX5nls80qB28w3Os7t5phUSaeqa3WVaBRGJoGguGnt?= =?us-ascii?Q?F9qQLCNCTWGSggGB+5vGL+nb0Qiu83S7Y8jt8VRx1YUrVZkc8ZkFHrbDBRIJ?= =?us-ascii?Q?s5pvUCIUZUnXtF1nrkLD77Vz7TNj1j9+qbFPIuvu+8CanOWSxQoJtEzTDSiP?= =?us-ascii?Q?gReVpgCixRPl5ge2c467Pou8EoxcxNvRt+kQRiVm?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4086.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95490b1b-3f9b-4483-a428-08dc19264e03 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2024 19:39:08.7770 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ivJ9uilQdacSw7bJmFd6pyfu0HhSuJN115HignZJdfIYoMFymoDQbnXuc3pQqNShABZ2qd9datebjunkSFz6ShN2xbj4pPsTy0sXsyKPHa4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR18MB4275 X-Proofpoint-ORIG-GUID: e5UQl3Zx7Uh054mazfAc8XpVAZujIch4 X-Proofpoint-GUID: e5UQl3Zx7Uh054mazfAc8XpVAZujIch4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-19_12,2024-01-19_02,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Joyce Kong > Sent: Friday, December 8, 2023 8:21 AM > To: Stephen Hemminger > Cc: thomas@monjalon.net; Ruifeng Wang ; > bruce.richardson@intel.com; dev@dpdk.org; nd ; > stable@dpdk.org > Subject: [EXT] RE: [PATCH v4 1/2] config: correct cpu instruction set for= cross > build >=20 > External Email >=20 > ---------------------------------------------------------------------- > > -----Original Message----- > > From: Stephen Hemminger > > Sent: Friday, December 8, 2023 6:41 AM > > To: Joyce Kong > > Cc: thomas@monjalon.net; Ruifeng Wang ; > > bruce.richardson@intel.com; dev@dpdk.org; nd ; > > stable@dpdk.org > > Subject: Re: [PATCH v4 1/2] config: correct cpu instruction set for cro= ss > build > > > > On Tue, 5 Dec 2023 03:52:58 +0000 > > Joyce Kong wrote: > > > > > The platform value would be 'native' only when not cross build. > > > Move the operation about modifying cpu_instruction_set while platform > > > equals 'native' to the not cross build branch. > > > > > > Fixes: bf66003b51ec ("build: use platform for generic and native > > > builds") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Joyce Kong > > > Reviewed-by: Ruifeng Wang > > > > Looks right, what is the impact on existing users doing current cross b= uilds? >=20 > The original operation changes cpu_instruction_set to 'native' when both > 'platform =3D=3D native' and 'cpu_instruction_set =3D=3D auto'. > There was no impact on the existing users for current cross build, as the= cross > files set cpu field to a specific arch, such as 'armv8-a', and this didn'= t trigger > the modification for cpu_instruction_set. > However, if we want to use a common arch in cross files like 'auto', the > modification operation would override 'native' value to cpu_instruction_s= et > and b7676fcccab4 ("config: verify machine arch flag") would break the bui= ld > as it tries to test -march=3Dnative. >=20 > > > > Acked-by: Stephen Hemminger Tested-by: Pavan Nikhilesh