From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B20B2A0C45; Tue, 21 Sep 2021 22:28:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 34F134003F; Tue, 21 Sep 2021 22:28:06 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id B31C24003C for ; Tue, 21 Sep 2021 22:28:04 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18LGuHjq003471; Tue, 21 Sep 2021 13:28:03 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2174.outbound.protection.outlook.com [104.47.56.174]) by mx0b-0016f401.pphosted.com with ESMTP id 3b7384m1g5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Sep 2021 13:28:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D4CdgzOv9qm/fQjGtN+zCpxnAZA4SDZ1kQ6L03UV1IxUJBfHJGSgbAVphavMnrmkZwnqQVxYDzid4Mkeyz8ryKIw3X9lnZ92CTwOgQcU48oz/iAMQI7WC2osHSX1AkYxpoihGrhnGgreOknEGRdISSHbsuyxipsF4GnB+vDBV1UPj7ldE6jmmnmCiVhAfhS77wCo6cBeL2jbkbo0oT5ew0uMVUln+IwEzxkqoxxV18D3HD4VTVD8Y6d82yNQkjMBtdcYkJh68wGZxzYWQR0TGWomfPayFqD19d2P4UlIxuUI36A6CH08bR7o9wwVNHAhrWyOuITpUEl+L/j4JSJqoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qOGkxFEm9Bf2P6ohUKk841JiCywaxsoCs810E0IQwFE=; b=dZNWKcMr0/WSiGLCJxNAVR8yhYw0PQkzdwdmqvddty5erEcdzWZ/JMjBzErSgt5rg2azliiITb/V4/8nYkKXOJwPJuI45wcw0DQjh5/Lmnc2zoS0FddWh29ULGroQZtyALGJSplC33wdQlF0bT49t9izUO6a7N+mM0cx5Hs/5WX8wvsQ/Lzs242zh5WwQw4IsF4rLWox/RxfY5HlPsO4uaWrxwMSqakRZvEUL+NgWQI0ulHoWv7Xhxyep7P38uxDPIaT65K5ydw9u4VbIfhbeyRpagSdQYdFbxO7h7x57dRXmOQfJqYWOS+72W8gHiL9e0TzrGMeDfO+ER0EphMruw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qOGkxFEm9Bf2P6ohUKk841JiCywaxsoCs810E0IQwFE=; b=U0T6eDaFUGtuvGsWA4v99NxgCGCaiivB0VfYtZk0uHKTmY8LfIhNzTCS7m7xEkDEUod83lK1z7NT2YbFJO+MKzUPSCCGE24kAhdRbeGDSQWXwjVDhREncId98O1oAJJ0J313HKiXg2F4dFkAUMY11JSuUeh0JKMAjqbiHKTppYQ= Received: from PH0PR18MB4086.namprd18.prod.outlook.com (2603:10b6:510:3::9) by PH0PR18MB3941.namprd18.prod.outlook.com (2603:10b6:510:22::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Tue, 21 Sep 2021 20:28:00 +0000 Received: from PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::94d1:2b0c:115f:5a75]) by PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::94d1:2b0c:115f:5a75%7]) with mapi id 15.20.4523.018; Tue, 21 Sep 2021 20:28:00 +0000 From: Pavan Nikhilesh Bhagavatula To: Naga Harish K S V , Jerin Jacob Kollanukkaran , "jay.jayatheerthan@intel.com" CC: "dev@dpdk.org" Thread-Topic: [EXT] [dpdk-dev] [PATCH v2 2/5] test/event: add unit test for event buffer size config api Thread-Index: AQHXrs2F0K+m7nnhV0K/lZEkCb5N26uu7/2A Date: Tue, 21 Sep 2021 20:28:00 +0000 Message-ID: References: <20210918131140.3543317-1-s.v.naga.harish.k@intel.com> <20210921094559.1788022-1-s.v.naga.harish.k@intel.com> <20210921094559.1788022-2-s.v.naga.harish.k@intel.com> In-Reply-To: <20210921094559.1788022-2-s.v.naga.harish.k@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 89a27a13-9848-4975-5412-08d97d3e4e87 x-ms-traffictypediagnostic: PH0PR18MB3941: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1468; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IJQMcgKhF/mj8liDFmoi9XUj25tOS4TZvSb6h3t29cwxeEiwjE2GIH07OPLQnmfmy7kyV7+8Zi6p77NbONewa8EhJJ0moWgsXB7ReYr/XzQMDwGXwvoklkOX6be+noult4OMpn76I/IpKKiYSx1Kc34v25FGmOnbzVto5dHRpuITQvQSXIB7QGjfcLGUeXmbBQ5T6alcuIEY/gQKRLgeZWZcbst4/n1y4qFrSJuQ/zRsuBc+JgfOFeISNArl+39SnXLMF8+NCjk6AXUfY9D7fzVYVpXEByF/uur/3OGiONprGfR6oEThRHJ/FoWnPClm2aZUe7PCRjLGmjCz4wbrTOsRMfjlsgs8qrPdt41Ae+vQD3gukEwjm7l8GeM5ZLUyCnjkZPOc3Tzxtk2EkM+TTLpRbYHbwOZLK+t6ovMmEJe8Kr4hEMLi+MmJcWLCIC2hQix2Ozjc4pwbUZCNi/dwgjxPf0kY7WgWmHK/ROVyoG3uKIIVSbHw0Z3vQjcsCyFXvjd57m3OG9qOgYzLrFQWtMZmh6xgW331px0goak1wkw5e6769kMzh1VCNQhpn/XV1T5DQ6znTl7XeFmraH8bp8q9W6di0urvsSAReE5/x4NrZNqRPpmIp7kK83sNrXb/qrCXH+iSh54Zpd10A3thlnfZbanYBtY3Bu+f3S9F32xvkYB7EH8rG94jm8KqlCnfZadiWlRsrxfLkNfHOfVQJw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4086.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(5660300002)(2906002)(508600001)(186003)(122000001)(66556008)(9686003)(38100700002)(6506007)(64756008)(7696005)(66476007)(8936002)(71200400001)(110136005)(55016002)(33656002)(316002)(86362001)(66446008)(4326008)(76116006)(83380400001)(52536014)(8676002)(66946007)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yEcRDmbcgBRDlPLAslKRIpj/m0sVV0JHjCQgmPgE8pLMHbDhI2fuyMV7k4TQ?= =?us-ascii?Q?9F/ZoohKr4mpc/nFH/PTsfjRLk0lOdRP5/vgVAlTVcj0gAc2kUrUJld+m559?= =?us-ascii?Q?CXMBVCSK6Pv56CPfZc4AXhHlc6Wl8iVQrRvgOZ3J33vKeUOoKPl0hTtcAgnk?= =?us-ascii?Q?eKKd3thqlZNi4dwDqtHgbL8NlC3KYMuQdF60jQfnu7CiZ6Xm/sCuUapZe+l8?= =?us-ascii?Q?oTA1+U6BDpSFZ9lDmpmYQqzgpZzoqhHjybSjQHTtAQXWSpjHLcTeVf3bc1TS?= =?us-ascii?Q?njwcLXeA5W1fbzZEllIBFjzaV+9ih+dNwuHw2Co+Gdc72pYXOpQ+aXlNNVfU?= =?us-ascii?Q?asQEjBuE15a+DXl5HRAOwm7rvuLoed+DT111sPHyJ8DJEyCFXQe0w4WkaFDM?= =?us-ascii?Q?lm2RimE03PF3OPp2qbu+0KVcW1zrWsOtXQ7T9yQYmLUlsH40wngxjpxDKrsO?= =?us-ascii?Q?rHIvAieOR8hQQ+GPKe/astmDinxGa4uK6uhlq8mOXMhyHOxQnBUTMkbKahaC?= =?us-ascii?Q?uTXuf0Lq5axCecB2Nua8ijek739YvjDKw6iCjTsf2v0mCZwauR5JMT8ImMFS?= =?us-ascii?Q?Lf0+ez9yOW0nrsRw4ADmT0kewTtKX2f3dsQg6CE6Sbdn0EPjEoqLXRv8F6IR?= =?us-ascii?Q?AP8zRduiXW4DFz727nPa2zz7IY4l5wHZa5hOw37LB6UjmQLOSPWLb18En7Qo?= =?us-ascii?Q?vYBBQ9cltfOXJbgdZTYdm5STZvoUp18DP4plHf0vZsDYcjU9HpGuVJzS080p?= =?us-ascii?Q?e1oL1uz2j5r4QGa6SEV8SnuHvhfbqUxWN6AdnIPoNIbx+TOs1m0UgXq/AqFo?= =?us-ascii?Q?Zw+AtFgoOAi+OpFEk17o1XSQlROxRIIRMzxjC3QML42ArcP5rRtVv+i7xb3s?= =?us-ascii?Q?c0PMGQ94r83FejPtscLKoteKAFHwrVc7H+zasIIyB80WopVc+nFWZ0fTUDqm?= =?us-ascii?Q?2cYfUg4t28eCnbb4Lt+4MfyQbXvgoFjBoqXpjvDb7tNm/JHH8c+Utv6nA18r?= =?us-ascii?Q?uN171bAInxSIli49UQgFQ17oqqV1fxb+xGmrsFepI4OkJxpQIl7gyiPBVV7I?= =?us-ascii?Q?bQpx0o+5UxWmEXYSdiBAFZFns69fCiPzygcmH0YKxbXHdtwYL+GU+6PBUCdQ?= =?us-ascii?Q?2fQJvN5Alh82R0t8rsbBMgpRERzUMjK3T/Zqujc48Um0Qn6l4Gcjo9ciFGzR?= =?us-ascii?Q?awt1EEJzf3N0mp0b2bt++jqS9oxfr87OdFcKIBm8GloOK9xLGoTZVcH1L7fo?= =?us-ascii?Q?ml0/FpKGPgdsV/I2JJpAn2MAOpsXnXf/ctZNtSHQsUELvkmLhbFhsS44FGzI?= =?us-ascii?Q?AkZCwuTYesNNA8BvWQoZxhmLPDCmURAx29/wWwc45DVboTFFmP+5aehWXGmX?= =?us-ascii?Q?n5YmrYU3o2vhzAkSwzzESA/glTV6?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4086.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89a27a13-9848-4975-5412-08d97d3e4e87 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2021 20:28:00.6909 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NDnhUh3qGcv6wge45hYh5eIO7zBrJ34BrY0Ah9YjXOWBtje/yVVXgnxtkI4lyXSZ06w8cKtg8OTJgfujfqOcxfHgLfZ/P5EJoCReSM0vbEg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB3941 X-Proofpoint-GUID: mf8Lw-HmvoirYFIuHzi-NfcwBudLrG0H X-Proofpoint-ORIG-GUID: mf8Lw-HmvoirYFIuHzi-NfcwBudLrG0H X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-21_06,2021-09-20_01,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] [PATCH v2 2/5] test/event: add unit test for event buffer size config api X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >this patch adds unit test for >rte_event_eth_rx_adapter_create_with_params >api and validate all possible input combinations. > >Signed-off-by: Naga Harish K S V >--- > app/test/test_event_eth_rx_adapter.c | 53 >+++++++++++++++++++++++++--- > 1 file changed, 49 insertions(+), 4 deletions(-) > >diff --git a/app/test/test_event_eth_rx_adapter.c >b/app/test/test_event_eth_rx_adapter.c >index add4d8a678..3c0f0ad7cc 100644 >--- a/app/test/test_event_eth_rx_adapter.c >+++ b/app/test/test_event_eth_rx_adapter.c >@@ -428,6 +428,50 @@ adapter_create_free(void) > return TEST_SUCCESS; > } > >+static int >+adapter_create_free_v2(void) >+{ >+ int err; >+ >+ struct rte_event_port_conf rx_p_conf =3D { >+ .dequeue_depth =3D 8, >+ .enqueue_depth =3D 8, >+ .new_event_threshold =3D 1200, >+ }; >+ >+ struct rte_event_eth_rx_adapter_params rxa_params =3D { >+ .event_buf_size =3D 1024 >+ }; >+ >+ err =3D >rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID, >+ TEST_DEV_ID, NULL, NULL); >+ TEST_ASSERT(err =3D=3D -EINVAL, "Expected -EINVAL got %d", err); >+ >+ err =3D >rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID, >+ TEST_DEV_ID, &rx_p_conf, >&rxa_params); >+ TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err); >+ >+ err =3D >rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID, >+ TEST_DEV_ID, &rx_p_conf, >&rxa_params); >+ TEST_ASSERT(err =3D=3D -EEXIST, "Expected -EEXIST %d got %d", - >EEXIST, err); >+ >+ rxa_params.event_buf_size =3D 0; >+ err =3D >rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID, >+ TEST_DEV_ID, &rx_p_conf, >&rxa_params); >+ TEST_ASSERT(err =3D=3D -EINVAL, "Expected -EINVAL got %d", err); >+ >+ err =3D rte_event_eth_rx_adapter_free(TEST_INST_ID); >+ TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err); >+ >+ err =3D rte_event_eth_rx_adapter_free(TEST_INST_ID); >+ TEST_ASSERT(err =3D=3D -EINVAL, "Expected -EINVAL %d got %d", - >EINVAL, err); >+ >+ err =3D rte_event_eth_rx_adapter_free(1); >+ TEST_ASSERT(err =3D=3D -EINVAL, "Expected -EINVAL %d got %d", - >EINVAL, err); >+ >+ return TEST_SUCCESS; >+} >+ > static int > adapter_queue_add_del(void) > { >@@ -435,7 +479,7 @@ adapter_queue_add_del(void) > struct rte_event ev; > uint32_t cap; > >- struct rte_event_eth_rx_adapter_queue_conf queue_config; >+ struct rte_event_eth_rx_adapter_queue_conf queue_config =3D >{0}; > > err =3D rte_event_eth_rx_adapter_caps_get(TEST_DEV_ID, >TEST_ETHDEV_ID, > &cap); >@@ -523,7 +567,7 @@ adapter_multi_eth_add_del(void) > uint16_t port_index, port_index_base, drv_id =3D 0; > char driver_name[50]; > >- struct rte_event_eth_rx_adapter_queue_conf queue_config; >+ struct rte_event_eth_rx_adapter_queue_conf queue_config =3D >{0}; > > ev.queue_id =3D 0; > ev.sched_type =3D RTE_SCHED_TYPE_ATOMIC; >@@ -594,7 +638,7 @@ adapter_intr_queue_add_del(void) > struct rte_event ev; > uint32_t cap; > uint16_t eth_port; >- struct rte_event_eth_rx_adapter_queue_conf queue_config; >+ struct rte_event_eth_rx_adapter_queue_conf queue_config =3D >{0}; > > if (!default_params.rx_intr_port_inited) > return 0; >@@ -687,7 +731,7 @@ adapter_start_stop(void) > ev.sched_type =3D RTE_SCHED_TYPE_ATOMIC; > ev.priority =3D 0; > >- struct rte_event_eth_rx_adapter_queue_conf queue_config; >+ struct rte_event_eth_rx_adapter_queue_conf queue_config =3D >{0}; > > queue_config.rx_queue_flags =3D 0; > if (default_params.caps & >@@ -753,6 +797,7 @@ static struct unit_test_suite event_eth_rx_tests >=3D { > .teardown =3D testsuite_teardown, > .unit_test_cases =3D { > TEST_CASE_ST(NULL, NULL, adapter_create_free), >+ TEST_CASE_ST(NULL, NULL, adapter_create_free_v2), Please use a meaningful function name. In case of failure I don't thing "v2= " will gave any meaning > TEST_CASE_ST(adapter_create, adapter_free, > adapter_queue_add_del), > TEST_CASE_ST(adapter_create, adapter_free, >-- >2.25.1