From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A08043BE5; Mon, 26 Feb 2024 08:46:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6CB86402BA; Mon, 26 Feb 2024 08:46:14 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 13B0440144 for ; Mon, 26 Feb 2024 08:46:12 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41Q6jGDw005140; Sun, 25 Feb 2024 23:46:09 -0800 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2101.outbound.protection.outlook.com [104.47.58.101]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3wfgun43s2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 25 Feb 2024 23:46:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZGqZsy0jslT6PKA6H/1wCpY5FiYclB+JJ1ORBEz0UBdw1Sff31nWltWgte2c6CfrwTd8ocw0VfI1jV9bIpyDs3AgZS3hIgN21eVdgTPZSGPLo0s5RWw8p7f5beoAvdg5ne+NOqm8o5JPAV/QvFIS2B1C+PAa2J1N++npwCjkyEoDZOZZX/HOvTwQIVywa5g/Whtxp9leMV0DLIXsxYQs3z4x+BlOY37m004VGhKc6T4OyLkKdOWtxh5UNRQknMPya82WBKluCbLUijUeYhH1kVqrrR3SLGU9i6RYjBNKBUKpQrDAXpEkutQq0v2FxwEWZCqx5oAdaYlz/1INFPlOkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4V843i5hkmq/vf/0eRUgv+x2H1qCACCGtlsS/huYjjU=; b=VjZOWPeKJJdRUVQ1aXzvN/C3OIOa5f4aKOD4zZIZeTIWf1xXStZBllj5oqFodGlhTRQVlnmSLAQRpGD79D2M/tUWERud5x0/G4lbJBPZMJtOHNyxJU5PX2OlD1Na9HDXha5cMZ8/lPqVivJdqFUWEJ+pDi2SWVv5iDMH5ytfiqun8Ps0aRRun7rtgtw9zIoyoHqfpUmijfpqDlSp7XGTbdAkJAgXpococgUz5o9r166SCD7sf9DR54QJYeww3yGTnDzElzLaCU0URgHYBvc/n8obnRp+oiv+8YmwHMlCmk4PJzPWufQmBtamu+uDrO1SN1tkFbNR2rviJZhAiM80FA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4V843i5hkmq/vf/0eRUgv+x2H1qCACCGtlsS/huYjjU=; b=AYcuXyAhyY1tW9ETbzjuZnmtQybWJaIGnE3TdmnQP/NQwOFgVy8pKZb4Pg1MQCYo1GckcLKOnDjrFDeP0S7MBERcCDcHepq1bRgCrXcQTlWNRIVX7Vs8alrMAc/y1359pMQLNMfgxBsHb7PhZ8Kkz759QFZeNs+g5KxksrFNXTE= Received: from PH0PR18MB4086.namprd18.prod.outlook.com (2603:10b6:510:3::9) by MW5PR18MB5149.namprd18.prod.outlook.com (2603:10b6:303:1c7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.36; Mon, 26 Feb 2024 07:46:05 +0000 Received: from PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::baf5:a4b6:7776:10f4]) by PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::baf5:a4b6:7776:10f4%6]) with mapi id 15.20.7316.034; Mon, 26 Feb 2024 07:46:04 +0000 From: Pavan Nikhilesh Bhagavatula To: "Yan, Zhirun" , Jerin Jacob , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , Ruifeng Wang , "Richardson, Bruce" , Konstantin Ananyev CC: "dev@dpdk.org" Subject: RE: [24.11 PATCH v3 4/5] node: add error stats for ip4 lookup node Thread-Topic: [24.11 PATCH v3 4/5] node: add error stats for ip4 lookup node Thread-Index: AQHaZYoGqH+uEZsfe02q8raSfv9/uLEXhe8AgAS92xA= Date: Mon, 26 Feb 2024 07:46:03 +0000 Message-ID: References: <20240222053639.15057-1-pbhagavatula@marvell.com> <20240222122342.16375-1-pbhagavatula@marvell.com> <20240222122342.16375-4-pbhagavatula@marvell.com> In-Reply-To: Accept-Language: en-US, en-IN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB4086:EE_|MW5PR18MB5149:EE_ x-ms-office365-filtering-correlation-id: e5c44d8b-10eb-4728-209e-08dc369efc05 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sjAKYYCq/K3P9SKpi+sC3165DinYkMBEjfw2x4XOAofwSb2kVgJn/+oQZC1GovWBQ4Vz1CyXoohZ02x2eBs9exyRenbDOMlTEyamqNtmz3Vl5WrOmivh+rP0DQ7Q5WqWrIOTG/IFtWJ+T3NW94dDb9ekYWTDQAksH5W2w6XnxnNbC5nbtVctAdqLFguZv7wb2u+34h3qaFJjRbMgEEd16lceVO4UnFFnsjHt7+BtUeVu+PT4/+C8uiIYVrmAxrSlhV0bRizaBHW6XjbbaKCOeujj/6rSA+VRIvA/j2S/g3vXa4dplEhj2U5OzYuNjmEy5nPmiyQS4ejDcoQ1zOsKfeT34OCJS36uP+zZfqIt6sAsF/7Jc52KQXsDwLMkYxUXiZ/hCjRWWJ16JcfVcE+eVZ+KD4BAv66IzUM2xeokT3vu1n0dikz5khkRKW/8r7NDPnSxeedIJikPXcREkaAN6CPdL8JFby6GCsW3fbS4xd8h1nbLacq4PvI791Xo911Xdac7dYU/P+HcALuv1YDCqzd50nKEddorWK/0qYpAh+J0+vy/lE6PEwRtsBbwQE/zc46c4CJtbeO25jfm9MIIcITnR/8aueeDV5uA6XucNp/QvwxqEYPIpuQZqY07Rq7Jc4bS1eTVQm8KDJZqewTn3crQcMmvGoweYgm5K6XyL6AJgskHcD/JIAS5xd5iw1dmzzl3SADxufKmeKmx9Y3OEg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4086.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?x/8dO1z26YfyF60UikZT0knBTAuQO06RgiEFPQpg+IlbC0ix0CdT10i0BnOH?= =?us-ascii?Q?mPx6sr89SxtHaXTekX4YqcaXCYrX5cdPvM3VDwYjO2GKTcXwRkggWHx04Y2v?= =?us-ascii?Q?UaIUR7DgLTAXEVsJz3a7v6vWFJASRNfpl8/dbroqZJgohZi4IHvw9sLmR2tZ?= =?us-ascii?Q?FtVybk8C6uOifB0pwocl2O5beWhwjAWIOTwSzi/Fomnr+Fd58UJWXdXzgOqq?= =?us-ascii?Q?8mLUFcywlveI5Ssra99lYWnhoQ+kkpDn7af5SEfIlz9/lGEySyEftYwiXaTW?= =?us-ascii?Q?EhRqPGSYbjZsgW5MRbIChGVyf8RTiTYuh8QgZVoGp76nKNA+3cpC887MrMyq?= =?us-ascii?Q?0qSShTIOHYODdrIHwUNz1LW52Ux63tpDaeFNkEKKRfg+SaGmrotcLTyNYEBq?= =?us-ascii?Q?aqdFKkq3zfRW7n7gCTdANHmfebxanGMHERJ/FstfP5aOENEva9vBRichetUl?= =?us-ascii?Q?qG2kf4Y9A+DlaSXjhhleKqUzYZDQuSf0u4SztrcPE7ipvBPisB1LBizozsaq?= =?us-ascii?Q?foT7wvThwj40sNBYAGZutHz47A9VLO3J4PCO8qC+cbr32DdCZjhzQEBITBIq?= =?us-ascii?Q?gIfrkTAXhpH9vYdYORhLfkItkQO4EKdSvJ7CAkryEOMbLGX8uWBFkfgFshz/?= =?us-ascii?Q?o843gHZ0mpd4B/uQ1vnPtJxaFzsk7ydzi69dnZ08hSadmrLyGnslPwmRdVPz?= =?us-ascii?Q?BBxN3kBWx3KvHHGGHaNMI5ijtiWezWpDIrzok3Nt8/TSEq/yeLNVgHj6+cm7?= =?us-ascii?Q?qXi7DXe2TawIfW5mAcL5+8OIOYqsXCxWKhqOhlZ+3HK4gzoB7lPElbeIwq1K?= =?us-ascii?Q?H0pUxXyks9rrhcGB+dc0wakBiCTAmG+38Ph36hx9+iqrPEonjFf1AG64pLIk?= =?us-ascii?Q?kCf0RL2EQL1D2y7rNq+RktCCYqZOXDFMjLsbKknFwxAj9LuePqRUPYEKAdq1?= =?us-ascii?Q?lO3kHRQsViQcIeW/xpAURNWH8usnnMQ+Byz2+0YCJVHrmQV2/Bd4NU8/djAd?= =?us-ascii?Q?eFtzqJ4WdPPH9Msa3TfGvksGfuiJlFKjLHDQQv2FLeYkvvnmigf2biaM3Lxs?= =?us-ascii?Q?U1ZBiHEHjG9Ui0C5u7bI4QYQ+ENH9Fs2M2TPRl/BcjdIgG42Ha/3PlXarNSO?= =?us-ascii?Q?ksIEnnI/j9j15TRwVfT+cLzrNbv2OtdD38RmYXi5oMuOFgwFSfZNu+eXggme?= =?us-ascii?Q?0zmQdQUSE1jtC8qxntVRIqzEWvg2eAL3GLK6Uvy7HHabLQqeReoc/zv5iOvw?= =?us-ascii?Q?LdGZUkKXQHq1udB9ZIHapgsMYC7gtMhcdM6x1N4I4cz18YIB8GJ8ZVdBR8u3?= =?us-ascii?Q?3bI6JxYGCELZyPBZ+uY1YjiU3vBhycdI9/tKYQM7SGr0o3EdmPa8cEwreJF9?= =?us-ascii?Q?d/62vwmQHeSRlAs+zWhXu9A5HzD86Nh5U2r3ZoI0VCaFOPLh/yKaX4eo7P2x?= =?us-ascii?Q?m0h+hq+z+MfU359XyCbmWW6w/32nNt1eb9y0JbvK0/ymkPFWWpmXdr6+y0AD?= =?us-ascii?Q?gFwnVQS5qSBnHOFaTXtmMZn0OIAaLAKlfiQaf52kLq5ehZUNRyzN2KEzukqk?= =?us-ascii?Q?zrxEKUMVcAq0mrzM5BziZQsxsHJJKzoD7Llvng6/?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4086.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5c44d8b-10eb-4728-209e-08dc369efc05 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Feb 2024 07:46:04.0244 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zrmd6gRb57h9JX6iCUh0MbHkHbVlL6AcUZ+RwucgcGo2NFqcL2OUkMUMkr3adtFPV+B3q2ZFTSnNqqvRaiuFVTlrA3J0ujw2DPfciz87HY0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR18MB5149 X-Proofpoint-ORIG-GUID: B4QBhJFGjAlLZgtpkcu0IJv-S31USahn X-Proofpoint-GUID: B4QBhJFGjAlLZgtpkcu0IJv-S31USahn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-26_04,2024-02-23_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > -----Original Message----- > > From: pbhagavatula@marvell.com > > Sent: Thursday, February 22, 2024 8:24 PM > > To: jerinj@marvell.com; ndabilpuram@marvell.com; > kirankumark@marvell.com; > > Yan, Zhirun ; Pavan Nikhilesh > > ; Ruifeng Wang ; > > Richardson, Bruce ; Konstantin Ananyev > > > > Cc: dev@dpdk.org > > Subject: [24.11 PATCH v3 4/5] node: add error stats for ip4 lookup node > > > > From: Pavan Nikhilesh > > > > Add error counters for ip4 LPM lookup failures in ip4_lookup node. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > lib/node/ip4_lookup.c | 9 +++++++++ > > lib/node/ip4_lookup_neon.h | 5 +++++ > > lib/node/ip4_lookup_sse.h | 6 ++++++ > > lib/node/node_private.h | 8 ++++++++ > > 4 files changed, 28 insertions(+) > > > > diff --git a/lib/node/ip4_lookup.c b/lib/node/ip4_lookup.c index > > 18955971f6..5a7921db75 100644 > > --- a/lib/node/ip4_lookup.c > > +++ b/lib/node/ip4_lookup.c > > @@ -86,6 +86,7 @@ ip4_lookup_node_process_scalar(struct rte_graph > *graph, > > struct rte_node *node, > > rc =3D rte_lpm_lookup(lpm, rte_be_to_cpu_32(ipv4_hdr- > > >dst_addr), > > &next_hop); > > next_hop =3D (rc =3D=3D 0) ? next_hop : drop_nh; > > + NODE_INCREMENT_ERROR_ID(node, 0, (rc !=3D 0), 1); > > > > node_mbuf_priv1(mbuf, dyn)->nh =3D (uint16_t)next_hop; > > next_hop =3D next_hop >> 16; > > @@ -219,11 +220,19 @@ ip4_lookup_node_init(const struct rte_graph > *graph, > > struct rte_node *node) > > return 0; > > } > > > > +static struct rte_node_errors ip4_lookup_errors =3D { > > + .nb_errors =3D 1, > > + .err_desc =3D { > > + [0] =3D "ip4_lookup_error", >=20 > Here, if one node has a list of err_desc, should we add a table for count= ing? A more complex node can have a table of errors, the lookup node has only on= e type of failure i.e. lpm lookup failure. The id to increment can be selected by=20 NODE_INCREMENT_ERROR_ID(node, 0, (rc !=3D 0), 1); -> increments id 0 error NODE_INCREMENT_ERROR_ID(node, 1, (rc !=3D 0), 1); -> increments id 1 error > like: > err_type count > type_a 1 > type_b 2 > type_c 3 >=20 > or we can report the total number of failed pkts for one node only.