DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Harry van Haaren <harry.van.haaren@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] [PATCH] app/test-eventdev: fix terminal colour after control-c exit
Date: Mon, 18 Oct 2021 12:54:19 +0000	[thread overview]
Message-ID: <PH0PR18MB4086A7F6DEF5646D102F0427DEBC9@PH0PR18MB4086.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20211014095444.630505-1-harry.van.haaren@intel.com>

>Before this commit, a Control^C exit of the test-eventdev application
>would print the worker packet percentages, and leave the terminal with
>a green colour despite the colour reset being issued after the newline.
>By moving the colour reset command before the \n the issue is fixed.
>
>Fixes: 6b1a14a83a06 ("app/eventdev: add packet distribution logs")
>
>Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
>

Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

>---
>
>Given this is an aesthetic only fix, I feel its not worth backporting.
>Cc: pbhagavatula@marvell.com>
>
>---
> app/test-eventdev/test_perf_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/app/test-eventdev/test_perf_common.c b/app/test-
>eventdev/test_perf_common.c
>index e0d9f05ecd..a1b8dd72ee 100644
>--- a/app/test-eventdev/test_perf_common.c
>+++ b/app/test-eventdev/test_perf_common.c
>@@ -19,7 +19,7 @@ perf_test_result(struct evt_test *test, struct
>evt_options *opt)
> 		total += t->worker[i].processed_pkts;
> 	for (i = 0; i < t->nb_workers; i++)
> 		printf("Worker %d packets: "CLGRN"%"PRIx64"
>"CLNRM"percentage:"
>-				CLGRN" %3.2f\n"CLNRM, i,
>+				CLGRN" %3.2f"CLNRM"\n", i,
> 				t->worker[i].processed_pkts,
> 				(((double)t-
>>worker[i].processed_pkts)/total)
> 				* 100);
>--
>2.30.2


  reply	other threads:[~2021-10-18 12:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-14  9:54 [dpdk-dev] " Harry van Haaren
2021-10-18 12:54 ` Pavan Nikhilesh Bhagavatula [this message]
2021-10-20  7:47   ` [dpdk-dev] [EXT] " Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR18MB4086A7F6DEF5646D102F0427DEBC9@PH0PR18MB4086.namprd18.prod.outlook.com \
    --to=pbhagavatula@marvell.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).