From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCB8B43BE5; Mon, 26 Feb 2024 08:50:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 59AB4402BA; Mon, 26 Feb 2024 08:50:06 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id E8BD740144 for ; Mon, 26 Feb 2024 08:50:03 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41Q6jCKl007246; Sun, 25 Feb 2024 23:50:03 -0800 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2101.outbound.protection.outlook.com [104.47.58.101]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3wfepr4en6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 25 Feb 2024 23:50:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LBY3B1F6O8dynPL+KUu2ZesLuIdIvOa4K+nSdM5zqJ/ddeKCEVqZnJiydoFYklUH1JF5WM9lt63feSS7asqR+mQ+I/NBKE8nmza8PMvG/zO37RT+7Kyjl2TSfACTOo/cJESVD5ELcwJlh04xkZBFAcHWVk7s66DzOGbTQANsrjnPolVvr2NoEJsxmBDNU1fgzHb91DGI+aWcU6UP1+ZHepn/81suz0bhC3E1WWeLfa9c1Esj3ehb6uWZftBm+vJuQ4+Qgq3EH1eE2VFzHVX+IrZWvWl34Og/KTrKMrwMhalqbf57XUQPTH3ykyWyT/ZNCJTR2WZDOyaU3xt67fi5iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H1bVgHnDkpx2Zz0e9rhfxH7O4j3PaBqTMkv/Y2SjPI4=; b=Lvgh+UiNvyB006Eq/fSxCeKIgCXqjnOqzogubF8EOSnB1xYFOEIJ1PUGa7Z6YuobJL0V94HLowTuajZMwKaw6FFMhSkQZKfXnkkHPwPQGmQXmUGDaORksTphkS9wwkyb9ntSxJYRaqJwsiKtPNTNerv73q+80YBnB2qT7BxIF8K0HIFGFLg58gSEP5Lxr/AC1xDjZtdi3t+6AaUdVX/dCqH1yapuprq8hC1JN8W5ytXaeiBxZ80J3nDH9+oX+Qxais4NvkLm5/kRRlC0NNzNFt1jdvDikp1idSbyQm4WOt+i0LDspRRMCdYjLBpHdQeDH8XQ2lJYZQE9PeuNMDwxRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H1bVgHnDkpx2Zz0e9rhfxH7O4j3PaBqTMkv/Y2SjPI4=; b=HdTrGWNfQFk8MxKWMlSsA1k1vOSG14ksCU/3LMMVdi/SiQA5S2pTpXVJ3SYic6wGT07tsu6bDrbbonFPTO9Ox/5eJnIGbKg4MM3tPVTvjJpOrz+djObCc+AlNiAUgsjF4YNaBVNjkssQ32cc0w304rAScyOj4BFiszY3vju0AYk= Received: from PH0PR18MB4086.namprd18.prod.outlook.com (2603:10b6:510:3::9) by MW5PR18MB5149.namprd18.prod.outlook.com (2603:10b6:303:1c7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.36; Mon, 26 Feb 2024 07:49:59 +0000 Received: from PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::baf5:a4b6:7776:10f4]) by PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::baf5:a4b6:7776:10f4%6]) with mapi id 15.20.7316.034; Mon, 26 Feb 2024 07:49:59 +0000 From: Pavan Nikhilesh Bhagavatula To: "Yan, Zhirun" , Jerin Jacob , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda CC: "dev@dpdk.org" Subject: RE: [24.11 PATCH v3 1/5] graph: add support for node specific errors Thread-Topic: [24.11 PATCH v3 1/5] graph: add support for node specific errors Thread-Index: AQHaZYoHYAHF7gDF5UCCJBGOeZDuR7EXhH6AgATAPcA= Date: Mon, 26 Feb 2024 07:49:59 +0000 Message-ID: References: <20240222053639.15057-1-pbhagavatula@marvell.com> <20240222122342.16375-1-pbhagavatula@marvell.com> In-Reply-To: Accept-Language: en-US, en-IN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB4086:EE_|MW5PR18MB5149:EE_ x-ms-office365-filtering-correlation-id: 995f5d6d-f426-427e-c421-08dc369f8854 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EsaRgq4cDOR6sC7696N7Z4KxpiVny2H0GTPf4VeUS+kxUqFA79r69GrEMAS9vbBymdnMA2fHpgosQQ8kmQ9FYI3CsF2NfaETUp8Pxe0uVDNdcafdGCeRkn5uVi+kvH+pVArpMJL7lxF2R/x3vIjHfW9RhbsaAIm5bxXr5ztq7gS+u8gBBHlisDwW5beat1qbWp6AEiyklhW98XysYguDTYwJc8bx3RCjQGg7XgFeSxPEF5ZvTGnK+u6fKKgb2vU/cMFQ3mg8sDML6dTD3Hhbt+bPghhd1BxZuMsIqxu2UKDLW/KMgvM28xcDXtyovplOR6VIOUuy85MVGY/FNuvcytr2b8y2rGCO1CanmmLf9pnaprOAUyfPW6a4mrNQT3h5pZmmdpJhgr3FoENpq2hENP4F0sIplWzKSh4FsN4X9R0mOUczZ4uZywqaqkhLudYLvFhrKqI3g+vnzatW/bTjtgODlIbVswauXT68ygRg7+NNo9GBPHJIlJtaKhDie3xVOj8f26aZctHSzLET32f6PPfwRXQYMqmMc4Owo3Rf37JkJ09QWoUobIjC/qbaDwiOxlMmbifj4R2XwndQQEFTMWhYovwBrUSfqzdVnTCSTAQJWnKxcJJtDsF+63JoTgAH+1oRRgSQ3FSOkoC5Sy1M9NW2wy7v+D+cyo0oC3ZiG9y0ki00bOzxoobcuXc+GQckuIeZQ8/QJ3AigM/w3JyAWgCiWdrGzNejUAziGQ4GI6Q= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4086.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?63TvxGu9oxib1DBLtoturr+jutc6ONQ/6As48Z5E49FboZtuhEphIDD5NGVT?= =?us-ascii?Q?ZelNHNrakes4gtyZvcaqQezFlaZ5+bhNJbjmmFAi4DiL7g/QQtHx2ri3nRT6?= =?us-ascii?Q?HQlrqqRIv8SxJd+VykQ/PswAAyBVflLQ5NajYUOTAgXUrfbYdx6dIS6ERfFL?= =?us-ascii?Q?GHf3mcTl+zbhzlnZE5Owq24yaItMTtQTtHtHTgS5KK2JIOjKQxQ+1NJwgHYa?= =?us-ascii?Q?AX4BdC/UGvWSOYFmW2az+pGpK8JIytdwO1tkWJPi4AzTBHQeCKlBp6K8cyJl?= =?us-ascii?Q?Zi1+rQuNOpuW3YPLIGEl6ihEM4IHAW8qcXYdXgRfNmI9QdhozTh1uQZr/aOH?= =?us-ascii?Q?SKN92y0g3il+s8b/k0pzOS/S+TUb4qn1tGBX1Dbqh2ozuG4ggoYazAol/gHO?= =?us-ascii?Q?ITF5WXwPD6x87o8VXDLLr0i5AaSQwzBMQ6m9zOxR+aG+zJoI+X0JUkp8Z+w3?= =?us-ascii?Q?zCfF5yhbU1MdTvEKP23R3WeJk3lKfrRgUFeANrEFEAmiltIXJu0JOX0CHEIN?= =?us-ascii?Q?faUDQJ37MdZXUQQf6fk+nwhYWnhdFoaeVDbzzH5cGnpxKsBIx0Uqi7BajmoB?= =?us-ascii?Q?NLKWKmTUsqNKVeh4+w2pJQMsVKoCSNgpz+MiCU5EgZOEEgQvRJvDDT8LKeHe?= =?us-ascii?Q?WUoBmxvucmT4PEy3Y5gkA7cjSwTtaVbrxVpuVLNrfbobtlEVTW4cWgb9gmsJ?= =?us-ascii?Q?XliGuytpcAj5vYJHB0Ctcw/ls9sG+PSLFMDxBNr3Vci6U6+yH8EBh9CsXMPd?= =?us-ascii?Q?iY6biB6cwS7eA0TTay4OYO/qZwhlpHB3XZ/sIQg9qtsq4q3D+/ep9Kv0yegx?= =?us-ascii?Q?SUv/sPlqEJ+heeF+D7qhL8qFm4cC/LlPnW3AtA9N8A2HvdrXQJITz0xAkfQE?= =?us-ascii?Q?m+6yx0NAPXKiXFS/r2a5E1ORflFoF2Zisw6Er6C3bOXV4lV6HYT8nqNLjRdh?= =?us-ascii?Q?cSyBc7YO8pfttGh46Xl8/hqnTUirltwbiTlBNcSXMw0GyoXpjzlzxv90Eecp?= =?us-ascii?Q?LY5rNi/ScQi1ZVz6oPTBOx1FWRqARmtsKq0NTNr9WdCCl46fQSkftGyDY04Z?= =?us-ascii?Q?qUUqljehptydOQUYQJgp9LEp63DqycIVkzKLgUk5xBUf7h+FpQYTeT5/f3II?= =?us-ascii?Q?m9i+jyekYyY5Li3QRAahadmbs/IrVzsK6+3NBGWtTu2KKZL5SN44uJJLbhvN?= =?us-ascii?Q?A6y9sry95uN/UiEzW+NZwlEvBsOP0tTJ8C51kAr5UPVD/LbjnmR51nYUfan0?= =?us-ascii?Q?1bdM6lpqHNP+xARQcnzNyLEgq6Q7MLbbcX8gYcsDK7IkP3c8jBzEYVFajBPq?= =?us-ascii?Q?UFbYfgx/u8WfPUE0d94ngAggCJan2UU/SAolYnD0QuSMJuYBwFkQUPNo3OgM?= =?us-ascii?Q?QXgf5KYbXjPFeL3fhSqidlTGKt7cRYwjv1qx0UYkzC0NIn2ueQy+qOvzt1p2?= =?us-ascii?Q?zZN3AIBr9F+VnMj4SwzmkE/6MqZcu6uyXeBrAOP+d1RzwKRsFgVbvN4XfVHh?= =?us-ascii?Q?qWxORElm3TkYeVTK0fPmIHIO5EqB3XwLmImb9HwjYEd1OtncXP3vrvmQRrMY?= =?us-ascii?Q?WCRHAkYtB0QQDv2OWBjyNN2Ov6lle27jWBgu4UGy?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4086.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 995f5d6d-f426-427e-c421-08dc369f8854 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Feb 2024 07:49:59.4590 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OghCS9wyzXyj+EToNXMTdSLkEG8Ym446zYY2wLg54D8+w5Sii6TrL+bySXTT03WymIZyEt7DmxlCe5OMjNpbjRGFdbhTD0J0m1VzAGiBANk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR18MB5149 X-Proofpoint-ORIG-GUID: umHmMGzNhByVPdr5XXYZU_qBYmkxFWWS X-Proofpoint-GUID: umHmMGzNhByVPdr5XXYZU_qBYmkxFWWS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-26_04,2024-02-23_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > -----Original Message----- > > From: pbhagavatula@marvell.com > > Sent: Thursday, February 22, 2024 8:24 PM > > To: jerinj@marvell.com; ndabilpuram@marvell.com; > kirankumark@marvell.com; > > Yan, Zhirun > > Cc: dev@dpdk.org; Pavan Nikhilesh > > Subject: [24.11 PATCH v3 1/5] graph: add support for node specific erro= rs > > > > From: Pavan Nikhilesh > > > > Add ability for Nodes to advertise error counters > > during registration. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > v2 Changes: > > - Fix compilation. > > v3 Changes: > > - Resend as 1/5 didn't make it through. > > > > doc/guides/prog_guide/graph_lib.rst | 22 +- > > .../prog_guide/img/anatomy_of_a_node.svg | 329 +++++-- > > .../prog_guide/img/graph_mem_layout.svg | 921 +++++++++++++----- > > lib/graph/graph_private.h | 1 + > > lib/graph/node.c | 37 +- > > lib/graph/rte_graph.h | 7 + > > 6 files changed, 1016 insertions(+), 301 deletions(-) > > > > diff --git a/doc/guides/prog_guide/graph_lib.rst > > b/doc/guides/prog_guide/graph_lib.rst > > index ad09bdfe26..018900caea 100644 > > --- a/doc/guides/prog_guide/graph_lib.rst > > +++ b/doc/guides/prog_guide/graph_lib.rst > > @@ -21,6 +21,7 @@ Features of the Graph library are: > > - Nodes as plugins. > > - Support for out of tree nodes. > > - Inbuilt nodes for packet processing. > > +- Node specific error counts. > > - Multi-process support. > > - Low overhead graph walk and node enqueue. > > - Low overhead statistics collection infrastructure. > > @@ -124,6 +125,18 @@ Source nodes are static nodes created using > > ``RTE_NODE_REGISTER`` by passing > > While performing the graph walk, the ``process()`` function of all the= source > > nodes will be called first. So that these nodes can be used as input n= odes for > a > > graph. > > > > +nb_errors: > > +^^^^^^^^^^ > > + > > +The number of errors that this node can report. The ``err_desc[]`` sto= res the > > error > > +descriptions which will later be propagated to stats. > > + > > +err_desc[]: > > +^^^^^^^^^^^ > > + > > +The dynamic array to store the error descriptions that will be reporte= d by > this > > +node. >=20 > If there are no more detail infos reported by node, why not reuse the nod= e- > >name directly. >=20 The nodes can describe the errors they encounter in detail, and depending o= n how=20 complex the node is it can have multiple kinds of errors. > > + > > Node creation and registration > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > * Node implementer creates the node by implementing ops and attributes > of > > @@ -141,13 +154,13 @@ Link the Nodes to create the graph topology > > Topology after linking the nodes > > > > Once nodes are available to the program, Application or node public AP= I > > -functions can links them together to create a complex packet processin= g > graph. > > +functions can link them together to create a complex packet processing > graph. > > > > There are multiple different types of strategies to link the nodes. > > > > Method (a): > > ^^^^^^^^^^^ > > -Provide the ``next_nodes[]`` at the node registration time. See ``str= uct > > rte_node_register::nb_edges``. > > +Provide the ``next_nodes[]`` at the node registration time. See ``stru= ct > > rte_node_register::nb_edges``. >=20 > No need to change this line.