DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Christophe Fontaine <cfontain@redhat.com>,
	Jerin Jacob <jerinj@marvell.com>,
	Kiran Kumar Kokkilagadda <kirankumark@marvell.com>,
	Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
	Zhirun Yan <yanzhirun_163@163.com>,
	Robin Jarry <rjarry@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [EXTERNAL] [PATCH] graph: fix xstats description allocation
Date: Tue, 28 Oct 2025 10:16:26 +0000	[thread overview]
Message-ID: <PH0PR18MB4086C0C4F949EF9B456CC953DEFDA@PH0PR18MB4086.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20251028101333.14776-1-cfontain@redhat.com>

>Fix the extended stats name allocation size: instead of allocating
>RTE_NODE_XSTAT_DESC_SIZE (64 bytes), only "sizeof(RTE_NODE_XSTAT_DESC_SIZE)"
>were allocated for each xstat name.
>
>Fixes: 070db97e01 ("graph: support node xstats")
>Signed-off-by: Christophe Fontaine <cfontain@redhat.com>

Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

>---
> lib/graph/graph_stats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/lib/graph/graph_stats.c b/lib/graph/graph_stats.c
>index e0fc8fd25c..b87b5707f7 100644
>--- a/lib/graph/graph_stats.c
>+++ b/lib/graph/graph_stats.c
>@@ -302,7 +302,7 @@ stats_mem_populate(struct rte_graph_cluster_stats *stats,
>                                    graph_node->node->name, graph->name);
>
>                cluster->stat.xstat_desc = rte_zmalloc_socket(NULL,
>-                       sizeof(RTE_NODE_XSTAT_DESC_SIZE) * graph_node->node->xstats->nb_xstats,
>+                       RTE_NODE_XSTAT_DESC_SIZE * graph_node->node->xstats->nb_xstats,
>                        RTE_CACHE_LINE_SIZE, stats->socket_id);
>                if (cluster->stat.xstat_desc == NULL) {
>                        rte_free(cluster->stat.xstat_count);
>--
>2.51.0



  reply	other threads:[~2025-10-28 10:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-28 10:13 Christophe Fontaine
2025-10-28 10:16 ` Pavan Nikhilesh Bhagavatula [this message]
2025-10-28 11:09 ` [PATCH v2] " Christophe Fontaine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR18MB4086C0C4F949EF9B456CC953DEFDA@PH0PR18MB4086.namprd18.prod.outlook.com \
    --to=pbhagavatula@marvell.com \
    --cc=cfontain@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=kirankumark@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=rjarry@redhat.com \
    --cc=yanzhirun_163@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).