* [PATCH] graph: fix xstats description allocation
@ 2025-10-28 10:13 Christophe Fontaine
2025-10-28 10:16 ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2025-10-28 11:09 ` [PATCH v2] " Christophe Fontaine
0 siblings, 2 replies; 3+ messages in thread
From: Christophe Fontaine @ 2025-10-28 10:13 UTC (permalink / raw)
To: Jerin Jacob, Kiran Kumar K, Nithin Dabilpuram, Zhirun Yan,
Robin Jarry, Pavan Nikhilesh
Cc: dev, Christophe Fontaine
Fix the extended stats name allocation size: instead of allocating
RTE_NODE_XSTAT_DESC_SIZE (64 bytes), only "sizeof(RTE_NODE_XSTAT_DESC_SIZE)"
were allocated for each xstat name.
Fixes: 070db97e01 ("graph: support node xstats")
Signed-off-by: Christophe Fontaine <cfontain@redhat.com>
---
lib/graph/graph_stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/graph/graph_stats.c b/lib/graph/graph_stats.c
index e0fc8fd25c..b87b5707f7 100644
--- a/lib/graph/graph_stats.c
+++ b/lib/graph/graph_stats.c
@@ -302,7 +302,7 @@ stats_mem_populate(struct rte_graph_cluster_stats *stats,
graph_node->node->name, graph->name);
cluster->stat.xstat_desc = rte_zmalloc_socket(NULL,
- sizeof(RTE_NODE_XSTAT_DESC_SIZE) * graph_node->node->xstats->nb_xstats,
+ RTE_NODE_XSTAT_DESC_SIZE * graph_node->node->xstats->nb_xstats,
RTE_CACHE_LINE_SIZE, stats->socket_id);
if (cluster->stat.xstat_desc == NULL) {
rte_free(cluster->stat.xstat_count);
--
2.51.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [EXTERNAL] [PATCH] graph: fix xstats description allocation
2025-10-28 10:13 [PATCH] graph: fix xstats description allocation Christophe Fontaine
@ 2025-10-28 10:16 ` Pavan Nikhilesh Bhagavatula
2025-10-28 11:09 ` [PATCH v2] " Christophe Fontaine
1 sibling, 0 replies; 3+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2025-10-28 10:16 UTC (permalink / raw)
To: Christophe Fontaine, Jerin Jacob, Kiran Kumar Kokkilagadda,
Nithin Kumar Dabilpuram, Zhirun Yan, Robin Jarry
Cc: dev
>Fix the extended stats name allocation size: instead of allocating
>RTE_NODE_XSTAT_DESC_SIZE (64 bytes), only "sizeof(RTE_NODE_XSTAT_DESC_SIZE)"
>were allocated for each xstat name.
>
>Fixes: 070db97e01 ("graph: support node xstats")
>Signed-off-by: Christophe Fontaine <cfontain@redhat.com>
Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>---
> lib/graph/graph_stats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/lib/graph/graph_stats.c b/lib/graph/graph_stats.c
>index e0fc8fd25c..b87b5707f7 100644
>--- a/lib/graph/graph_stats.c
>+++ b/lib/graph/graph_stats.c
>@@ -302,7 +302,7 @@ stats_mem_populate(struct rte_graph_cluster_stats *stats,
> graph_node->node->name, graph->name);
>
> cluster->stat.xstat_desc = rte_zmalloc_socket(NULL,
>- sizeof(RTE_NODE_XSTAT_DESC_SIZE) * graph_node->node->xstats->nb_xstats,
>+ RTE_NODE_XSTAT_DESC_SIZE * graph_node->node->xstats->nb_xstats,
> RTE_CACHE_LINE_SIZE, stats->socket_id);
> if (cluster->stat.xstat_desc == NULL) {
> rte_free(cluster->stat.xstat_count);
>--
>2.51.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] graph: fix xstats description allocation
2025-10-28 10:13 [PATCH] graph: fix xstats description allocation Christophe Fontaine
2025-10-28 10:16 ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
@ 2025-10-28 11:09 ` Christophe Fontaine
1 sibling, 0 replies; 3+ messages in thread
From: Christophe Fontaine @ 2025-10-28 11:09 UTC (permalink / raw)
To: Jerin Jacob, Kiran Kumar K, Nithin Dabilpuram, Zhirun Yan,
Pavan Nikhilesh, Robin Jarry
Cc: dev, stable, Christophe Fontaine
Fix the extended stats name allocation size: instead of allocating
RTE_NODE_XSTAT_DESC_SIZE (64 bytes), only sizeof(RTE_NODE_XSTAT_DESC_SIZE)
were allocated for each xstat name.
Fixes: 070db97e017b ("graph: support node xstats")
Signed-off-by: Christophe Fontaine <cfontain@redhat.com>
Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
Notes:
v2: add acked-by
fix sha length
lib/graph/graph_stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/graph/graph_stats.c b/lib/graph/graph_stats.c
index e0fc8fd25c..b87b5707f7 100644
--- a/lib/graph/graph_stats.c
+++ b/lib/graph/graph_stats.c
@@ -302,7 +302,7 @@ stats_mem_populate(struct rte_graph_cluster_stats *stats,
graph_node->node->name, graph->name);
cluster->stat.xstat_desc = rte_zmalloc_socket(NULL,
- sizeof(RTE_NODE_XSTAT_DESC_SIZE) * graph_node->node->xstats->nb_xstats,
+ RTE_NODE_XSTAT_DESC_SIZE * graph_node->node->xstats->nb_xstats,
RTE_CACHE_LINE_SIZE, stats->socket_id);
if (cluster->stat.xstat_desc == NULL) {
rte_free(cluster->stat.xstat_count);
--
2.51.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-28 11:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-28 10:13 [PATCH] graph: fix xstats description allocation Christophe Fontaine
2025-10-28 10:16 ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2025-10-28 11:09 ` [PATCH v2] " Christophe Fontaine
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).