From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32E9E45C14; Wed, 30 Oct 2024 12:49:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B73D94028F; Wed, 30 Oct 2024 12:49:36 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 304EC40263 for ; Wed, 30 Oct 2024 12:49:35 +0100 (CET) Received: from pps.filterd (m0431383.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49UB9A7u015509; Wed, 30 Oct 2024 04:49:29 -0700 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2172.outbound.protection.outlook.com [104.47.59.172]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 42kdenruj3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Oct 2024 04:49:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mTK/N0a7pCcCriKsoloSXE+2IKwLqQ1RDOgUfWDs0PByAo+UNrrvrNJ8NCrfoPmyVSHx8dmeixiG3xzXKp+v07dZsUwSmzh8NYkfmedKdcuJtWtQ4hzxAsX2j5/7CAUwOj09A/Ok0v/QBKcqnOLccXNsTijcu0+zaavvekQ11N9z4ggkMRJWEH/jlgqEZLj+EmihO4uhjr1/xl3CS2LoFCD7hNZITi9/NwWbkGRIiK+VUZAs9vP8ir0Bta26cqa4W9BKOCVzNfmL0Esc/XBdruQo/rMnPvrT+UNu8UfebhrMiH8QTuo9oZApN9d9aO+jEb66B1IXJ4Ts2luViGr4pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jnprdh/BqROM9Uf1z5BXSl9OBllDORCP4CnbnLWPM8I=; b=KQPutZua/hgsHgT8cxo2LUK/Bo5aM0KOzTD6oFEQhHvydBNk/hMQ93t0HVikqvYICVwx3w1ZX1qZRgvEc3J0/KmPttinLAwL8lgpyR/Voco1UH2BTgP1j2jsJLJJ8xaRpcUaQlL6tQWuPEAOZ2arAJ2MGHMoMEM10qzwdScI819FHKhrw9U1H4/vccGwDvZ/OOAsD43ApfBsb58nM5G8eYG3q0XK2KhPGZXxJ54TJPG9j6Otf6aNEGLQQFRcpqz2pcWBDy+/emaREGK5Ezj7/W1OtECd8M7ae4e+CnQ3uzvyDoyOFIKjLSe9Km2xf++C8lZDzCExMrbf90g7ukkeMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jnprdh/BqROM9Uf1z5BXSl9OBllDORCP4CnbnLWPM8I=; b=Rg+OgGYxb0cEdc9MyuiwABLDRPvakplCxlADS4NHdSA5BiGBNsSHgEdrdOUO9sbMAVWuT4km0TVB79ZwaylqTCzD15MAKPzdxzhfMER+mF+zOTUppxfydaKZKZu0FDl5UH7AQI/w5mp+TGb9EtvOLZ/y8828JrNh6UvxJUBWJqQ= Received: from PH0PR18MB4086.namprd18.prod.outlook.com (2603:10b6:510:3::9) by CO1PR18MB4681.namprd18.prod.outlook.com (2603:10b6:303:e4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.32; Wed, 30 Oct 2024 11:49:25 +0000 Received: from PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::ed37:4ea0:6359:f717]) by PH0PR18MB4086.namprd18.prod.outlook.com ([fe80::ed37:4ea0:6359:f717%5]) with mapi id 15.20.8093.018; Wed, 30 Oct 2024 11:49:24 +0000 From: Pavan Nikhilesh Bhagavatula To: Vipin Varghese , "dev@dpdk.org" , "roretzla@linux.microsoft.com" , "bruce.richardson@intel.com" , "john.mcnamara@intel.com" , "dmitry.kozliuk@gmail.com" , Jerin Jacob CC: "ruifeng.wang@arm.com" , "mattias.ronnblom@ericsson.com" , "anatoly.burakov@intel.com" , "stephen@networkplumber.org" , "ferruh.yigit@amd.com" , "honnappa.nagarahalli@arm.com" , "wathsala.vithanage@arm.com" , "konstantin.ananyev@huawei.com" Subject: RE: [EXTERNAL] [RFC v3 3/3] examples: add lcore topology API calls Thread-Topic: [EXTERNAL] [RFC v3 3/3] examples: add lcore topology API calls Thread-Index: AQHbKo8eUGPDB8cmfkCa+OcEaubZLLKfLcZg Date: Wed, 30 Oct 2024 11:49:24 +0000 Message-ID: References: <20241030054133.520-1-vipin.varghese@amd.com> <20241030054133.520-4-vipin.varghese@amd.com> In-Reply-To: <20241030054133.520-4-vipin.varghese@amd.com> Accept-Language: en-US, en-IN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB4086:EE_|CO1PR18MB4681:EE_ x-ms-office365-filtering-correlation-id: 64797579-9014-404c-3e80-08dcf8d8e6d8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|7416014|376014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?YC+E/iCnX0MMXDAySgk4xtODsV8mSI+kfDspfmNJ9K2wQN4AA/qPeJUJdgMb?= =?us-ascii?Q?hlMslAJNOqoF0e+RYR/sbptUdmakLd6H0p08atZZJXG2yuQ+ePjnerxg2SuZ?= =?us-ascii?Q?2Ab5QLzgQL5qDnd7banl5gHf8hpzJhK91bbdRVZQ88VZ8lUa96Lm5mnwO0X7?= =?us-ascii?Q?/3pFUdAttCAjWacJlZIwk92QaquPhL6ak9ffX/7lhD2WVUgt+Vl3SFxMc+1T?= =?us-ascii?Q?tQkRiWLPEqbz/uJF9hkSlBQ7t2f3pTlP6SBD1eJYnfXOauFoOuoeiJJ7o3Vg?= =?us-ascii?Q?IGRKV7/8P+WnpxM3/j/QXZ4DL+Sp3SO2NXwlSfjvBMdZ+rmno6sUIe1kgdAw?= =?us-ascii?Q?kYrrdHa5Db1I/xOEKCxvoGHxrSxAcBsFU50/O3lG1JKrPrTuex5CzjJVO1bb?= =?us-ascii?Q?epDacmr4/kb/z/QSa34B/vZqB7BJfrCTyLLrkk7ttIUV1hqfWX/BHusjDCMN?= =?us-ascii?Q?EAXkBgec1O+Ok8RDB1immbUhg3ADaqWWG8UafsMSZx6DI+Q1NYelBTMhZqJ2?= =?us-ascii?Q?0ztG3TWtHV7kAvEEjN09ocx/eRsWgYO0f2C6DE4bxyxlTCkNDAGqkHWHBhYr?= =?us-ascii?Q?V6Lb/s1tKBTudrfBTW3xiuBjf+6JnwDJmlnVcIL3UbgKnZ06ZFKr0CDlPadd?= =?us-ascii?Q?MMkDsd6+ZUdW92BVgZCNC5e72u2FEM1LT8wQ9ZnrNmLQwozN2KtK7z3577o0?= =?us-ascii?Q?HdrJWF1kfri2/eWV9RwAVdq8p5LvAJrIn8MsrIrZzclRVViZ4ZcuMdjNcmRG?= =?us-ascii?Q?IoIIw2V6+EO6cguKODnyRsopEE0lfsYenrXilk3lCzvmfrOvgBgDbJQV4jUo?= =?us-ascii?Q?s1fGXzNBTr3eqbbJgDIpckKM/kkp+Km/pXxYGZzV2a8DPz/Q+GyYfrBRzPvh?= =?us-ascii?Q?e6N4uH+4H4J5mqzWL5eMZMib8VrKetuPWVRjK3zrZ8orff3NnWSthVUOVGKS?= =?us-ascii?Q?qE0JnzSMurIm5GJ4xjkhqHS7Imj3Q3V0uGojW+LOUlwC2nKbZlGXu53QfscU?= =?us-ascii?Q?35YtctCxdhvjRqzuVdqHYavVtDpZEuKHbVZIggGuTki9hgj9rfl4vYpk6mJ8?= =?us-ascii?Q?s3qm2LgOr3P4/bTNyQLKpU9t2QJRgIGagkv+wqVrvji5AIET5VBG6UGcj1pl?= =?us-ascii?Q?Lr+Si6OSHtCzHNQbeJs3VA8nGREH1FHaI6/kP2oZxGox83vNxwXBos+cAykg?= =?us-ascii?Q?IdatH9/37FlcMkPMJHziw3Ye++x+NgszRHa1FEPfx2DTZk03obF+OiDc3PSi?= =?us-ascii?Q?/Xi1F3/+vh3MZ+kHt+K1Y4xGy38quXQhpF+G7NUZ88hmAGFWYZ0/+crewWv7?= =?us-ascii?Q?cHLFCHeNIlEECvSYRj6WKRzqE3HpIEoZgczc1WSr13+tN/FIy1ZsVc7pUoqq?= =?us-ascii?Q?m4d9jn4=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4086.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(376014)(366016)(1800799024)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/jETEoFd6wgA1Nivmfug4rHdi4+zekg2OuE2U7ICg+p7EEvz+rxY9noGaVuR?= =?us-ascii?Q?j+1zzPxGMdr2jLfVF7M9+CtXFwvfIgfqTnt2dk3olbyUbkEyPDvydzX9cnLu?= =?us-ascii?Q?TLZ+OrBXZl5J+HAZXYj3uN2tL08M1ROLsPm5NwzohCP5pqTV8Yx+w0CekDck?= =?us-ascii?Q?3HAbUdH/4Cj51215tNVau1vh8o3f7mkcm1VVjoahdwWA4imtw0+cQFLI9oiN?= =?us-ascii?Q?agSAlX6ZKcQJ8q9dGR/GlHOaujA0qLJ9ZN273etIXam1GEmOPdcrl5C/aJCi?= =?us-ascii?Q?Cy8f1Z5XkuWRQ3fLzx2cpIzeCpQJfDkUfSgdj4Mgf50RgxLI3dGBMIuVFR4H?= =?us-ascii?Q?LWhpSRhYpWINWTPqr66yZM1vgCcu2DLioTJUk4fnw7Ug4vWglPnIMrOsqiKS?= =?us-ascii?Q?R+Wk9xfzfPOETISE4BH6oyMdbmBQ3FO3eJsZzHN3TscVBBZ3+pLocjISqtA0?= =?us-ascii?Q?qFwmc+xkq3gvzBuSHeNvft+ocHqZfcytFMA6k7Zw1rupGYsPXX7m23Zs7OG7?= =?us-ascii?Q?lu5SZArwvhkBGl0QC3r4kmttPaLDvO4CHyLPbaDWcBg6r5v3zEErQBqQtBYh?= =?us-ascii?Q?GDEQk4Z7DLvyvAfLc4BdPZkqAjohQYroo0Tn7fNzdr1BiadrKxUbkkExKYTO?= =?us-ascii?Q?/DK2uzMj2Qg8O6rGvXAIX3X+uk81zybmxpR+L+8ojGgwB5l/9u87dRIhwtid?= =?us-ascii?Q?rMhaay2tHK2Sqd1cjgEy+FVOxSOrVsjqsE8oQmU45GGJsNOTydQDHxgR3vxO?= =?us-ascii?Q?m/zmIrYMwBvzQky75cRsLD5CBxY2dWzZlWEzmKlrAZQY359MbpnMsiJIq/l6?= =?us-ascii?Q?KMMQnpQe70qiSMTbp+4LwHKMOM7/ATS0rn9RbMzEHgWTs4qlwZJoSGm2s5UC?= =?us-ascii?Q?21TOlQXyqRRWCSgiTrK/7DT7es2rc+ZB0i0SEElvTWCtED7YTN4oCOnL+e0D?= =?us-ascii?Q?UfWHiOMBZ3jw+OlPBLHeFUSiCcrsgees8TOeM6hSs1NSg00TrQClzsuK8k8p?= =?us-ascii?Q?d7cEIjMjrcibkebLUHTjf73M8lqIGW0rjQXLUt7mXCgs4wMd5suYgEhNJNoC?= =?us-ascii?Q?LOnoY2vModMyf3/JMAgAbemBMkZMhp0fnHPOQh1eGHc0I9kg8w5zXgRW0aPk?= =?us-ascii?Q?RmY6cKie7KBhhF7wtxNNlMQaldfpvKW21tWGUmTFs4hq23L4QxMa94qqSf3V?= =?us-ascii?Q?C3Pf+3Uv2Rx/vyien0wZVGwAemsqHrM4+EIWV0xc6ld22wNS+XnOScsFzFNB?= =?us-ascii?Q?EDS2Xyndf2ndkqu7bB7+satL1HN1NELa03pw01Rxc/CMJn3XcV1bwNUHrj1A?= =?us-ascii?Q?+gI/MDwROFvwyA9StNM5YAwp1tDMni1QMVOiN7Z/yflDpx/WHENrly4RHic3?= =?us-ascii?Q?2xkwAN+RYHb2hSAYOi/0w4w501jM1ORIzzlbu5gwTvd7DfCy8QMIeNBMFfDD?= =?us-ascii?Q?wKgM+qljZls0e4zskEqlYW68Kr7vzZEFbIVf4otxHd1cPdJBlXat7yibQ6S/?= =?us-ascii?Q?1jo7BUmqJTKwU4D5cj0xh08E+rbJTnz0U9SQWNyoigmj3o5bj9XcS1PYGhS1?= =?us-ascii?Q?n8j2WrKuuoo+TXeDFKt6CTsoT3aUsDTKHxEJIZNI?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4086.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64797579-9014-404c-3e80-08dcf8d8e6d8 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2024 11:49:24.9217 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tF7h00so+LAwdBIf3BE3z8aoBu0AdUuO8AMELU2/LETb5FJgZX4zEoMXT8tLNgKB37kkNKpd2HEIlmMH7GKZGFFHhG8xVRc4iZxvDeq8kuo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR18MB4681 X-Proofpoint-GUID: us8WBkvGETjh3kMRVLZ4X46XjXZSzapf X-Proofpoint-ORIG-GUID: us8WBkvGETjh3kMRVLZ4X46XjXZSzapf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.687,Hydra:6.0.235,FMLib:17.0.607.475 definitions=2020-10-13_15,2020-10-13_02,2020-04-07_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Enhance example code to allow topology based lcores API, while > retaining default behaviour. >=20 > - helloworld: allow lcoes to send hello to lcores in selected topology. > - l2fwd: allow use of IO lcores topology. > - skeleton: choose the lcore from IO topology which has more ports. >=20 > v3 changes: > - fix typo from SE_NO_TOPOLOGY to USE_NO_TOPOLOGY >=20 > Signed-off-by: Vipin Varghese > --- I see compilation failure on ARM platforms due to missing header include. ../examples/helloworld/main.c: In function 'parse_topology': ../examples/helloworld/main.c:83:13: error: implicit declaration of functio= n 'strtoul'; did you mean 'strtok'? [-Wimplicit-function-declaration] 83 | n =3D strtoul(q_arg, &end, 10); | ^~~~~~~ | strtok ../examples/helloworld/main.c:83:13: warning: nested extern declaration of = 'strtoul' [-Wnested-externs] ../examples/helloworld/main.c: In function 'helloworld_parse_args': ../examples/helloworld/main.c:115:42: error: 'EXIT_FAILURE' undeclared (fir= st use in this function) 115 | rte_exit(EXIT_FAILURE, "Invalid Top= ology selection\n"); | ^~~~~~~~~~~~ ../examples/helloworld/main.c:13:1: note: 'EXIT_FAILURE' is defined in head= er ''; this is probably fixable by adding '#include ' 12 | #include +++ |+#include 13 | #include ../examples/helloworld/main.c:115:42: note: each undeclared identifier is r= eported only once for each function it appears in 115 | rte_exit(EXIT_FAILURE, "Invalid Top= ology selection\n"); | ^~~~~~~~~~~~ ../examples/helloworld/main.c: In function 'main': ../examples/helloworld/main.c:153:26: error: 'EXIT_FAILURE' undeclared (fir= st use in this function) 153 | rte_exit(EXIT_FAILURE, "Invalid arguments\n"); | ^~~~~~~~~~~~ ../examples/helloworld/main.c:153:26: note: 'EXIT_FAILURE' is defined in he= ader ''; thi Below header include should fix it. diff --git a/examples/helloworld/main.c b/examples/helloworld/main.c index 9845c3775c3a..f49bd0108f74 100644 --- a/examples/helloworld/main.c +++ b/examples/helloworld/main.c @@ -3,6 +3,7 @@ */ =20 #include +#include #include #include #include