DPDK patches and discussions
 help / color / mirror / Atom feed
* Re: [dpdk-dev] [PATCH 21.11 v2 0/3] octeontx build only on 64-bit Linux
@ 2021-08-21 14:07 Pavan Nikhilesh Bhagavatula
  0 siblings, 0 replies; 3+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2021-08-21 14:07 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, Thomas Monjalon, Jerin Jacob Kollanukkaran

>On Thu, Mar 25, 2021 at 3:52 PM Thomas Monjalon
><thomas@monjalon.net> wrote:
>>
>> This is a reorg of the patches from Pavan.
>> It has been discussed that it should wait for DPDK 21.11
>> for ABI compatibility reason.
>>
>> Pavan Nikhilesh (3):
>>   net/thunderx: enable build only on 64-bit Linux
>>   common/octeontx: enable build only on 64-bit Linux
>>   common/octeontx2: enable build only on 64-bit Linux
>>
>>  drivers/common/octeontx/meson.build   |  6 ++++++
>>  drivers/common/octeontx2/meson.build  |  4 ++--
>>  drivers/compress/octeontx/meson.build |  6 ++++++
>>  drivers/crypto/octeontx/meson.build   |  7 +++++--
>>  drivers/event/octeontx/meson.build    |  6 ++++++
>>  drivers/event/octeontx2/meson.build   |  4 ++--
>>  drivers/mempool/octeontx/meson.build  |  5 +++--
>>  drivers/mempool/octeontx2/meson.build |  9 ++-------
>>  drivers/net/octeontx/meson.build      |  4 ++--
>>  drivers/net/octeontx2/meson.build     | 10 ++--------
>>  drivers/net/thunderx/meson.build      |  4 ++--
>>  drivers/raw/octeontx2_dma/meson.build | 10 ++++++----
>>  12 files changed, 44 insertions(+), 31 deletions(-)
>
>There were a couple of cleanups (indent etc..) and changes in meson
>files.
>This series does not apply cleanly on the main branch.
>Could you rebase it?

Ack l will rebase it.

>
>I noticed that the net/cnxk driver does not have this check, but it is
>disabled anyway since it depends on common/cnxk.
>Is it worth adding the check for consistency?

Sure I will add checks to cnxk driver family.

Thanks,
Pavan.

>
>
>--
>David Marchand


^ permalink raw reply	[flat|nested] 3+ messages in thread
* [dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on 64bit Linux
@ 2021-02-25 17:02 pbhagavatula
  2021-03-25 14:52 ` [dpdk-dev] [PATCH 21.11 v2 0/3] octeontx build only on 64-bit Linux Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: pbhagavatula @ 2021-02-25 17:02 UTC (permalink / raw)
  To: jerinj, Harman Kalra, Nithin Dabilpuram; +Cc: dev, Pavan Nikhilesh

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Due to Linux kernel dependency, only enable build for 64bit Linux.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 drivers/common/octeontx/meson.build  | 6 ++++++
 drivers/common/octeontx2/meson.build | 4 ++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/common/octeontx/meson.build b/drivers/common/octeontx/meson.build
index 203d1ef49..f29b58320 100644
--- a/drivers/common/octeontx/meson.build
+++ b/drivers/common/octeontx/meson.build
@@ -2,4 +2,10 @@
 # Copyright(c) 2018 Cavium, Inc
 #
 
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+	build = false
+	reason = 'only supported on 64-bit Linux'
+	subdir_done()
+endif
+
 sources = files('octeontx_mbox.c')
diff --git a/drivers/common/octeontx2/meson.build b/drivers/common/octeontx2/meson.build
index 84fb11524..3ae106792 100644
--- a/drivers/common/octeontx2/meson.build
+++ b/drivers/common/octeontx2/meson.build
@@ -2,9 +2,9 @@
 # Copyright(C) 2019 Marvell International Ltd.
 #
 
-if not dpdk_conf.get('RTE_ARCH_64')
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
 	build = false
-	reason = 'only supported on 64-bit'
+	reason = 'only supported on 64-bit Linux'
 	subdir_done()
 endif
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-21 14:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-21 14:07 [dpdk-dev] [PATCH 21.11 v2 0/3] octeontx build only on 64-bit Linux Pavan Nikhilesh Bhagavatula
  -- strict thread matches above, loose matches on Subject: below --
2021-02-25 17:02 [dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on 64bit Linux pbhagavatula
2021-03-25 14:52 ` [dpdk-dev] [PATCH 21.11 v2 0/3] octeontx build only on 64-bit Linux Thomas Monjalon
2021-08-17  8:46   ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).