From: Shijith Thotton <sthotton@marvell.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Wathsala Vithanage <wathsala.vithanage@arm.com>,
Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar Kokkilagadda <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>,
Harman Kalra <hkalra@marvell.com>
Subject: Re: [PATCH v2] common/cnxk: allow enabling IOVA field in mbuf
Date: Fri, 25 Oct 2024 10:12:39 +0000 [thread overview]
Message-ID: <PH0PR18MB4425466C7425DD49404099BBD94F2@PH0PR18MB4425.namprd18.prod.outlook.com> (raw)
In-Reply-To: <ZxttoW76gIDKp0XU@bricha3-mobl1.ger.corp.intel.com>
>On Fri, Oct 25, 2024 at 03: 20: 40PM +0530, Shijith Thotton wrote: > The value
>of RTE_IOVA_IN_MBUF has always been disabled on CNXK platforms, > as
>IOVA in the mbuf is unnecessary. This update changes that behavior to >
>respect the value
>
>On Fri, Oct 25, 2024 at 03:20:40PM +0530, Shijith Thotton wrote:
>> The value of RTE_IOVA_IN_MBUF has always been disabled on CNXK
>platforms,
>> as IOVA in the mbuf is unnecessary. This update changes that behavior to
>> respect the value set by the user. A warning message will be printed if
>> the build is configured to enable IOVA on the CNXK platform.
>>
>> Signed-off-by: Shijith Thotton <sthotton@marvell.com> --- v2: - Don't
>> override the default value of RTE_IOVA_IN_MBUF in CNXK platform. - Print
>> a warning message if IOVA in mbuf is enabled on CNXK platform.
>>
>> config/arm/meson.build | 8 ++------
>> drivers/common/cnxk/meson.build | 6 ++++++ 2 files changed, 8
>> insertions(+), 6 deletions(-)
>>
>I think you probably need some doc updates for this. The current doc (cnxk
>platform guide) says "Meson build option enable_iova_as_pa is disabled on
>CNXK platforms." This is no longer true. Instead, you probably need to put
>- in more than one place in the docs, I suggest - a note telling the user
>that the option should be disabled.
>
Thanks, will update the documentation.
next prev parent reply other threads:[~2024-10-25 10:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 11:06 [PATCH] " Shijith Thotton
2024-10-24 11:10 ` Jerin Jacob
2024-10-24 12:09 ` Bruce Richardson
2024-10-24 16:13 ` [EXTERNAL] " Shijith Thotton
2024-10-24 16:44 ` Bruce Richardson
2024-10-25 9:41 ` Shijith Thotton
2024-10-25 9:50 ` [PATCH v2] " Shijith Thotton
2024-10-25 10:06 ` Bruce Richardson
2024-10-25 10:12 ` Shijith Thotton [this message]
2024-10-25 11:51 ` [PATCH v3] " Shijith Thotton
2024-10-25 12:39 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB4425466C7425DD49404099BBD94F2@PH0PR18MB4425.namprd18.prod.outlook.com \
--to=sthotton@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=wathsala.vithanage@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).